Issues in SeoExtension.php (master) - Issues in master - sonata-project/SonataSeoBundle - Measure and Improve Code Quality continuously with Scrutinizer

Issues (20)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/Twig/Extension/SeoExtension.php (1 issue)

Labels

Unused Code 1

Severity

Minor 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

declare(strict_types=1);

/*
 * This file is part of the Sonata Project package.
 *
 * (c) Thomas Rabaix <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Sonata\SeoBundle\Twig\Extension;

use Sonata\SeoBundle\Seo\SeoPageInterface;
use Twig\Extension\AbstractExtension;
use Twig\TwigFunction;

final class SeoExtension extends AbstractExtension
{
    /**
     * @var SeoPageInterface
     */
    protected $page;

    /**
     * @var string
     */
    protected $encoding;

    /**
     * @param string $encoding
     */
    public function __construct(SeoPageInterface $page, $encoding)
    {
        $this->page = $page;
        $this->encoding = $encoding;
    }

    public function getFunctions()
    {
        return [
            new TwigFunction('sonata_seo_title', [$this, 'getTitle'], ['is_safe' => ['html']]),
            new TwigFunction('sonata_seo_metadatas', [$this, 'getMetadatas'], ['is_safe' => ['html']]),
            new TwigFunction('sonata_seo_html_attributes', [$this, 'getHtmlAttributes'], ['is_safe' => ['html']]),
            new TwigFunction('sonata_seo_head_attributes', [$this, 'getHeadAttributes'], ['is_safe' => ['html']]),
            new TwigFunction('sonata_seo_link_canonical', [$this, 'getLinkCanonical'], ['is_safe' => ['html']]),
            new TwigFunction('sonata_seo_lang_alternates', [$this, 'getLangAlternates'], ['is_safe' => ['html']]),
            new TwigFunction('sonata_seo_oembed_links', [$this, 'getOembedLinks'], ['is_safe' => ['html']]),
        ];
    }

    public function getName()
    {
        return 'sonata_seo';
    }

    /**
     * @return string
     */
    public function getTitle()
    {
        return sprintf('<title>%s</title>', strip_tags($this->page->getTitle()));
    }

    /**
     * @return string
     */
    public function getMetadatas()
    {
        $html = '';
        foreach ($this->page->getMetas() as $type => $metas) {
            foreach ((array) $metas as $name => $meta) {
                list($content, $extras) = $meta;
<?php

function returnThreeValues() {
    return array('a', 'b', 'c');
}

list($a, $b, $c) = returnThreeValues();

print $a . " - " . $c;

                if (!empty($content)) {
                    $html .= sprintf(
                        "<meta %s=\"%s\" content=\"%s\" />\n",
                        $type,
                        $this->normalize($name),
                        $this->normalize($content)
                    );
                } else {
                    $html .= sprintf(
                        "<meta %s=\"%s\" />\n",
                        $type,
                        $this->normalize($name)
                    );
                }
            }
        }

        return $html;
    }

    /**
     * @return string
     */
    public function getHtmlAttributes()
    {
        $attributes = '';
        foreach ($this->page->getHtmlAttributes() as $name => $value) {
            $attributes .= sprintf('%s="%s" ', $name, $value);
        }

        return rtrim($attributes);
    }

    /**
     * @return string
     */
    public function getHeadAttributes()
    {
        $attributes = '';
        foreach ($this->page->getHeadAttributes() as $name => $value) {
            $attributes .= sprintf('%s="%s" ', $name, $value);
        }

        return rtrim($attributes);
    }

    /**
     * @return string
     */
    public function getLinkCanonical()
    {
        if ($this->page->getLinkCanonical()) {
            return sprintf("<link rel=\"canonical\" href=\"%s\"/>\n", $this->page->getLinkCanonical());
        }
    }

    /**
     * @return string
     */
    public function getLangAlternates()
    {
        $html = '';
        foreach ($this->page->getLangAlternates() as $href => $hrefLang) {
            $html .= sprintf("<link rel=\"alternate\" href=\"%s\" hreflang=\"%s\"/>\n", $href, $hrefLang);
        }

        return $html;
    }

    /**
     * @return string
     */
    public function getOembedLinks()
    {
        $html = '';
        foreach ($this->page->getOEmbedLinks() as $title => $link) {
            $html .= sprintf("<link rel=\"alternate\" type=\"application/json+oembed\" href=\"%s\" title=\"%s\" />\n", $link, $title);
        }

        return $html;
    }

    /**
     * @param string $string
     *
     * @return mixed
     */
    private function normalize($string)
    {
        return htmlentities(strip_tags((string) $string), ENT_COMPAT, $this->encoding);
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			/*
6			* This file is part of the Sonata Project package.
7			*
8			* (c) Thomas Rabaix <[email protected]>
9			*
10			* For the full copyright and license information, please view the LICENSE
11			* file that was distributed with this source code.
12			*/
13
14			namespace Sonata\SeoBundle\Twig\Extension;
15
16			use Sonata\SeoBundle\Seo\SeoPageInterface;
17			use Twig\Extension\AbstractExtension;
18			use Twig\TwigFunction;
19
20			final class SeoExtension extends AbstractExtension
21			{
22			/**
23			* @var SeoPageInterface
24			*/
25			protected $page;
26
27			/**
28			* @var string
29			*/
30			protected $encoding;
31
32			/**
33			* @param string $encoding
34			*/
35			public function __construct(SeoPageInterface $page, $encoding)
36			{
37			$this->page = $page;
38			$this->encoding = $encoding;
39			}
40
41			public function getFunctions()
42			{
43			return [
44			new TwigFunction('sonata_seo_title', [$this, 'getTitle'], ['is_safe' => ['html']]),
45			new TwigFunction('sonata_seo_metadatas', [$this, 'getMetadatas'], ['is_safe' => ['html']]),
46			new TwigFunction('sonata_seo_html_attributes', [$this, 'getHtmlAttributes'], ['is_safe' => ['html']]),
47			new TwigFunction('sonata_seo_head_attributes', [$this, 'getHeadAttributes'], ['is_safe' => ['html']]),
48			new TwigFunction('sonata_seo_link_canonical', [$this, 'getLinkCanonical'], ['is_safe' => ['html']]),
49			new TwigFunction('sonata_seo_lang_alternates', [$this, 'getLangAlternates'], ['is_safe' => ['html']]),
50			new TwigFunction('sonata_seo_oembed_links', [$this, 'getOembedLinks'], ['is_safe' => ['html']]),
51			];
52			}
53
54			public function getName()
55			{
56			return 'sonata_seo';
57			}
58
59			/**
60			* @return string
61			*/
62			public function getTitle()
63			{
64			return sprintf('<title>%s</title>', strip_tags($this->page->getTitle()));
65			}
66
67			/**
68			* @return string
69			*/
70			public function getMetadatas()
71			{
72			$html = '';
73			foreach ($this->page->getMetas() as $type => $metas) {
74			foreach ((array) $metas as $name => $meta) {
75			list($content, $extras) = $meta;
			0 ignored issues – show Unused Code introduced 2015-12-02 16:59 UTC by Report Bug Copy Issue Report Show Similar Issues like this The assignment to `$extras` is unused. Consider omitting it like so `list($first,,$third)`. This checks looks for assignemnts to variables using the `list(...)` function, where not all assigned variables are subsequently used. Consider the following code example. <?php function returnThreeValues() { return array('a', 'b', 'c'); } list($a, $b, $c) = returnThreeValues(); print $a . " - " . $c; Only the variables `$a` and `$c` are used. There was no need to assign `$b`. Instead, the list call could have been. list($a,, $c) = returnThreeValues(); Loading history...
76
77			if (!empty($content)) {
78			$html .= sprintf(
79			"<meta %s=\"%s\" content=\"%s\" />\n",
80			$type,
81			$this->normalize($name),
82			$this->normalize($content)
83			);
84			} else {
85			$html .= sprintf(
86			"<meta %s=\"%s\" />\n",
87			$type,
88			$this->normalize($name)
89			);
90			}
91			}
92			}
93
94			return $html;
95			}
96
97			/**
98			* @return string
99			*/
100			public function getHtmlAttributes()
101			{
102			$attributes = '';
103			foreach ($this->page->getHtmlAttributes() as $name => $value) {
104			$attributes .= sprintf('%s="%s" ', $name, $value);
105			}
106
107			return rtrim($attributes);
108			}
109
110			/**
111			* @return string
112			*/
113			public function getHeadAttributes()
114			{
115			$attributes = '';
116			foreach ($this->page->getHeadAttributes() as $name => $value) {
117			$attributes .= sprintf('%s="%s" ', $name, $value);
118			}
119
120			return rtrim($attributes);
121			}
122
123			/**
124			* @return string
125			*/
126			public function getLinkCanonical()
127			{
128			if ($this->page->getLinkCanonical()) {
129			return sprintf("<link rel=\"canonical\" href=\"%s\"/>\n", $this->page->getLinkCanonical());
130			}
131			}
132
133			/**
134			* @return string
135			*/
136			public function getLangAlternates()
137			{
138			$html = '';
139			foreach ($this->page->getLangAlternates() as $href => $hrefLang) {
140			$html .= sprintf("<link rel=\"alternate\" href=\"%s\" hreflang=\"%s\"/>\n", $href, $hrefLang);
141			}
142
143			return $html;
144			}
145
146			/**
147			* @return string
148			*/
149			public function getOembedLinks()
150			{
151			$html = '';
152			foreach ($this->page->getOEmbedLinks() as $title => $link) {
153			$html .= sprintf("<link rel=\"alternate\" type=\"application/json+oembed\" href=\"%s\" title=\"%s\" />\n", $link, $title);
154			}
155
156			return $html;
157			}
158
159			/**
160			* @param string $string
161			*
162			* @return mixed
163			*/
164			private function normalize($string)
165			{
166			return htmlentities(strip_tags((string) $string), ENT_COMPAT, $this->encoding);
167			}
168			}
169

sonata-project / SonataSeoBundle

Issues (20)

Security Analysis no request data

src/Twig/Extension/SeoExtension.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like