SonataSeoExtension::fixConfiguration() - Code Metrics - Inspection of "Removed classes to compile method" - sonata-project/SonataSeoBundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — 2.x (#225)

by Jeroen

created 2017-10-09 18:45 UTC

SonataSeoExtension::fixConfiguration() F

↳ Parent: SonataSeoExtension

Complexity

Conditions	16
Paths	712

Size

Total Lines	46
Code Lines	28

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
c	0
b	0
f	0
dl	0
loc	46
rs	2.8984
cc	16
eloc	28
nc	712
nop	1

How to fix Complexity

<?php

/*
 * This file is part of the Sonata Project package.
 *
 * (c) Thomas Rabaix <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Sonata\SeoBundle\DependencyInjection;

use Symfony\Component\Config\FileLocator;
use Symfony\Component\DependencyInjection\ContainerBuilder;
use Symfony\Component\DependencyInjection\ContainerInterface;
use Symfony\Component\DependencyInjection\Definition;
use Symfony\Component\DependencyInjection\Loader;
use Symfony\Component\DependencyInjection\Reference;
use Symfony\Component\HttpKernel\DependencyInjection\Extension;

/**
 * This is the class that loads and manages your bundle configuration.
 */
class SonataSeoExtension extends Extension
{
    /**
     * {@inheritdoc}
     */
    public function load(array $configs, ContainerBuilder $container)
    {
        $configuration = new Configuration();
        $config = $this->processConfiguration($configuration, $configs);
        $config = $this->fixConfiguration($config);

        $bundles = $container->getParameter('kernel.bundles');

        $loader = new Loader\XmlFileLoader($container, new FileLocator(__DIR__.'/../Resources/config'));

        if (isset($bundles['SonataBlockBundle']) && isset($bundles['KnpMenuBundle'])) {
            $loader->load('blocks.xml');
        }

        $loader->load('event.xml');
        $loader->load('services.xml');

        $this->configureSeoPage($config['page'], $container);
        $this->configureSitemap($config['sitemap'], $container);

        $container->getDefinition('sonata.seo.twig.extension')
            ->replaceArgument(1, $config['encoding']);
    }

    /**
     * Configure the default seo page.
     *
     * @param array            $config
     * @param ContainerBuilder $container
     */
    protected function configureSeoPage(array $config, ContainerBuilder $container)
    {
        $definition = $container->getDefinition($config['default']);

        $definition->addMethodCall('setTitle', [$config['title']]);
        $definition->addMethodCall('setMetas', [$config['metas']]);
        $definition->addMethodCall('setHtmlAttributes', [$config['head']]);
        $definition->addMethodCall('setSeparator', [$config['separator']]);

        $container->setAlias('sonata.seo.page', $config['default']);
    }

    /**
     * Configure the sitemap source manager.
     *
     * @param array            $config
     * @param ContainerBuilder $container
     */
    protected function configureSitemap(array $config, ContainerBuilder $container)
    {
        $source = $container->getDefinition('sonata.seo.sitemap.manager');

        if (method_exists($source, 'setShared')) { // Symfony 2.8+
            $source->setShared(false);
        } else {
            // For Symfony <2.8 compatibility
            $source->setScope(ContainerInterface::SCOPE_PROTOTYPE);

        }

        foreach ($config['doctrine_orm'] as $pos => $sitemap) {
            // define the connectionIterator
            $connectionIteratorId = 'sonata.seo.source.doctrine_connection_iterator_'.$pos;

            $connectionIterator = new Definition('%sonata.seo.exporter.database_source_iterator.class%', [
                new Reference($sitemap['connection']),
                $sitemap['query'],
            ]);

            $connectionIterator->setPublic(false);
            $container->setDefinition($connectionIteratorId, $connectionIterator);

            // define the sitemap proxy iterator
            $sitemapIteratorId = 'sonata.seo.source.doctrine_sitemap_iterator_'.$pos;

            $sitemapIterator = new Definition('%sonata.seo.exporter.sitemap_source_iterator.class%', [
                new Reference($connectionIteratorId),
                new Reference('router'),
                $sitemap['route'],
                $sitemap['parameters'],
            ]);

            $sitemapIterator->setPublic(false);

            $container->setDefinition($sitemapIteratorId, $sitemapIterator);

            $source->addMethodCall('addSource', [$sitemap['group'], new Reference($sitemapIteratorId), $sitemap['types']]);
        }

        foreach ($config['services'] as $service) {
            $source->addMethodCall('addSource', [$service['group'], new Reference($service['id']), $service['types']]);
        }
    }

    /**
     * Fix the sitemap configuration.
     *
     * @param array $config
     *
     * @return array
     */
    protected function fixConfiguration(array $config)
    {
        foreach ($config['sitemap']['doctrine_orm'] as $pos => $sitemap) {
            $sitemap['group'] = isset($sitemap['group']) ? $sitemap['group'] : false;
            $sitemap['types'] = isset($sitemap['types']) ? $sitemap['types'] : [];
            $sitemap['connection'] = isset($sitemap['connection']) ? $sitemap['connection'] : 'doctrine.dbal.default_connection';
            $sitemap['route'] = isset($sitemap['route']) ? $sitemap['route'] : false;
            $sitemap['parameters'] = isset($sitemap['parameters']) ? $sitemap['parameters'] : false;
            $sitemap['query'] = isset($sitemap['query']) ? $sitemap['query'] : false;

            if ($sitemap['route'] === false) {
                throw new \RuntimeException('Route cannot be empty, please review the sonata_seo.sitemap configuration');
            }

            if ($sitemap['query'] === false) {
                throw new \RuntimeException('Query cannot be empty, please review the sonata_seo.sitemap configuration');
            }

            if ($sitemap['parameters'] === false) {
                throw new \RuntimeException('Route\'s parameters cannot be empty, please review the sonata_seo.sitemap configuration');
            }

            $config['sitemap']['doctrine_orm'][$pos] = $sitemap;
        }

        foreach ($config['sitemap']['services'] as $pos => $sitemap) {
            if (!is_array($sitemap)) {
                $sitemap = [
                    'group' => false,
                    'types' => [],
                    'id' => $sitemap,
                ];
            } else {
                $sitemap['group'] = isset($sitemap['group']) ? $sitemap['group'] : false;
                $sitemap['types'] = isset($sitemap['types']) ? $sitemap['types'] : [];

                if (!isset($sitemap['id'])) {
                    throw new \RuntimeException('Service id must to be defined, please review the sonata_seo.sitemap configuration');
                }
            }

            $config['sitemap']['services'][$pos] = $sitemap;
        }

        return $config;
    }
}


1			<?php
2
3			/*
4			* This file is part of the Sonata Project package.
5			*
6			* (c) Thomas Rabaix <[email protected]>
7			*
8			* For the full copyright and license information, please view the LICENSE
9			* file that was distributed with this source code.
10			*/
11
12			namespace Sonata\SeoBundle\DependencyInjection;
13
14			use Symfony\Component\Config\FileLocator;
15			use Symfony\Component\DependencyInjection\ContainerBuilder;
16			use Symfony\Component\DependencyInjection\ContainerInterface;
17			use Symfony\Component\DependencyInjection\Definition;
18			use Symfony\Component\DependencyInjection\Loader;
19			use Symfony\Component\DependencyInjection\Reference;
20			use Symfony\Component\HttpKernel\DependencyInjection\Extension;
21
22			/**
23			* This is the class that loads and manages your bundle configuration.
24			*/
25			class SonataSeoExtension extends Extension
26			{
27			/**
28			* {@inheritdoc}
29			*/
30			public function load(array $configs, ContainerBuilder $container)
31			{
32			$configuration = new Configuration();
33			$config = $this->processConfiguration($configuration, $configs);
34			$config = $this->fixConfiguration($config);
35
36			$bundles = $container->getParameter('kernel.bundles');
37
38			$loader = new Loader\XmlFileLoader($container, new FileLocator(__DIR__.'/../Resources/config'));
39
40			if (isset($bundles['SonataBlockBundle']) && isset($bundles['KnpMenuBundle'])) {
41			$loader->load('blocks.xml');
42			}
43
44			$loader->load('event.xml');
45			$loader->load('services.xml');
46
47			$this->configureSeoPage($config['page'], $container);
48			$this->configureSitemap($config['sitemap'], $container);
49
50			$container->getDefinition('sonata.seo.twig.extension')
51			->replaceArgument(1, $config['encoding']);
52			}
53
54			/**
55			* Configure the default seo page.
56			*
57			* @param array $config
58			* @param ContainerBuilder $container
59			*/
60			protected function configureSeoPage(array $config, ContainerBuilder $container)
61			{
62			$definition = $container->getDefinition($config['default']);
63
64			$definition->addMethodCall('setTitle', [$config['title']]);
65			$definition->addMethodCall('setMetas', [$config['metas']]);
66			$definition->addMethodCall('setHtmlAttributes', [$config['head']]);
67			$definition->addMethodCall('setSeparator', [$config['separator']]);
68
69			$container->setAlias('sonata.seo.page', $config['default']);
70			}
71
72			/**
73			* Configure the sitemap source manager.
74			*
75			* @param array $config
76			* @param ContainerBuilder $container
77			*/
78			protected function configureSitemap(array $config, ContainerBuilder $container)
79			{
80			$source = $container->getDefinition('sonata.seo.sitemap.manager');
81
82			if (method_exists($source, 'setShared')) { // Symfony 2.8+
83			$source->setShared(false);
84			} else {
85			// For Symfony <2.8 compatibility
86			$source->setScope(ContainerInterface::SCOPE_PROTOTYPE);
			0 ignored issues – show Bug introduced 2015-12-02 16:59 UTC by Report Bug Copy Issue Report The method `setScope()` does not seem to exist on `object<Symfony\Component...cyInjection\Definition>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
87			}
88
89			foreach ($config['doctrine_orm'] as $pos => $sitemap) {
90			// define the connectionIterator
91			$connectionIteratorId = 'sonata.seo.source.doctrine_connection_iterator_'.$pos;
92
93			$connectionIterator = new Definition('%sonata.seo.exporter.database_source_iterator.class%', [
94			new Reference($sitemap['connection']),
95			$sitemap['query'],
96			]);
97
98			$connectionIterator->setPublic(false);
99			$container->setDefinition($connectionIteratorId, $connectionIterator);
100
101			// define the sitemap proxy iterator
102			$sitemapIteratorId = 'sonata.seo.source.doctrine_sitemap_iterator_'.$pos;
103
104			$sitemapIterator = new Definition('%sonata.seo.exporter.sitemap_source_iterator.class%', [
105			new Reference($connectionIteratorId),
106			new Reference('router'),
107			$sitemap['route'],
108			$sitemap['parameters'],
109			]);
110
111			$sitemapIterator->setPublic(false);
112
113			$container->setDefinition($sitemapIteratorId, $sitemapIterator);
114
115			$source->addMethodCall('addSource', [$sitemap['group'], new Reference($sitemapIteratorId), $sitemap['types']]);
116			}
117
118			foreach ($config['services'] as $service) {
119			$source->addMethodCall('addSource', [$service['group'], new Reference($service['id']), $service['types']]);
120			}
121			}
122
123			/**
124			* Fix the sitemap configuration.
125			*
126			* @param array $config
127			*
128			* @return array
129			*/
130			protected function fixConfiguration(array $config)
131			{
132			foreach ($config['sitemap']['doctrine_orm'] as $pos => $sitemap) {
133			$sitemap['group'] = isset($sitemap['group']) ? $sitemap['group'] : false;
134			$sitemap['types'] = isset($sitemap['types']) ? $sitemap['types'] : [];
135			$sitemap['connection'] = isset($sitemap['connection']) ? $sitemap['connection'] : 'doctrine.dbal.default_connection';
136			$sitemap['route'] = isset($sitemap['route']) ? $sitemap['route'] : false;
137			$sitemap['parameters'] = isset($sitemap['parameters']) ? $sitemap['parameters'] : false;
138			$sitemap['query'] = isset($sitemap['query']) ? $sitemap['query'] : false;
139
140			if ($sitemap['route'] === false) {
141			throw new \RuntimeException('Route cannot be empty, please review the sonata_seo.sitemap configuration');
142			}
143
144			if ($sitemap['query'] === false) {
145			throw new \RuntimeException('Query cannot be empty, please review the sonata_seo.sitemap configuration');
146			}
147
148			if ($sitemap['parameters'] === false) {
149			throw new \RuntimeException('Route\'s parameters cannot be empty, please review the sonata_seo.sitemap configuration');
150			}
151
152			$config['sitemap']['doctrine_orm'][$pos] = $sitemap;
153			}
154
155			foreach ($config['sitemap']['services'] as $pos => $sitemap) {
156			if (!is_array($sitemap)) {
157			$sitemap = [
158			'group' => false,
159			'types' => [],
160			'id' => $sitemap,
161			];
162			} else {
163			$sitemap['group'] = isset($sitemap['group']) ? $sitemap['group'] : false;
164			$sitemap['types'] = isset($sitemap['types']) ? $sitemap['types'] : [];
165
166			if (!isset($sitemap['id'])) {
167			throw new \RuntimeException('Service id must to be defined, please review the sonata_seo.sitemap configuration');
168			}
169			}
170
171			$config['sitemap']['services'][$pos] = $sitemap;
172			}
173
174			return $config;
175			}
176			}
177

sonata-project / SonataSeoBundle

Pull Request — 2.x (#225)

SonataSeoExtension::fixConfiguration() F

Complexity

Size

Duplication

Importance

How to fix Complexity

Long Method

Duplication Side-by-Side

Filter issues like