ConfigurationListener::onKernelController() - Code Metrics - Inspection of "Enable configuration file for each bundle" - sonata-project/SonataSeoBundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#118)

unknown

created 2016-03-11 13:57 UTC

ConfigurationListener::onKernelController() C

↳ Parent: ConfigurationListener

Complexity

Conditions	10
Paths	21

Size

Total Lines	67
Code Lines	35

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	67
rs	6.1506
cc	10
eloc	35
nc	21
nop	1

How to fix Long Method Complexity

<?php

namespace Sonata\SeoBundle\EventListener;

use Symfony\Component\DependencyInjection\ContainerInterface;
use Symfony\Component\HttpKernel\Event\FilterControllerEvent;
use Symfony\Component\Yaml\Yaml;

class ConfigurationListener
{
    /** @var Sonata\SeoBundle\Seo\SeoPage $sonata */
    private $sonata;

    /** @var Symfony\Component\HttpKernel\Config\FileLocator $kernel */
    private $fileLocator;

    /** @var Symfony\Component\HttpKernel\Log\LoggerInterface $logger */
    private $logger;

    /**
     * __construct.
     *
     * @param Symfony\Component\HttpKernel\Config\FileLocator $fileLocator
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     */
    public function __construct(ContainerInterface $container)
    {
        $this->sonata = $container->get('sonata.seo.page');
        $this->logger = $container->get('logger');
        $this->fileLocator = $container->get('file_locator');
    }

    /**
     * onKernelController.
     *
     * @param Symfony\Component\HttpKernel\Event\FilterControllerEvent $event
     */
    public function onKernelController(FilterControllerEvent $event)
    {
        $controller = $event->getController();

        // $controller passed can be either a class or a Closure. This is not
        // usual in Symfony but it may happen. If it is a class, it comes in
        // array format
        if (!is_array($controller)) {
            return;
        }

        // Get the request with namespace and others information we need and
        // construct the bundle namespace
        $request = $this->getRequest($event);

        $namespace = array('_namespace', '_bundle');
        foreach ($namespace as $key => $value) {
            $namespace[$key] = $request->attributes->get($value);
        }

        array_unshift($namespace, '@');
        $namespace = implode('', $namespace);
        $namespace = array($namespace, 'Resources', 'config', 'sonata.yml');
        $namespace = implode('/', $namespace);

        // Get the configuration file from the configuration into the
        // corresponding bundle
        try {
            $path = $this->fileLocator->locate($namespace);
        } catch (\Exception $e) {
            // Nothing to do because there's no SEO file
            return;
        }

        try {
            $config = Yaml::parse($path);
        } catch (\Exception $e) {
            // Do nothing on error. Just log error
            $this->logger->err('An error occurred during SEO initialization');
            $this->logger->err($e->getMessage());

            return;
        }

        $controller = $request->attributes->get('_controller');
        $action = $request->attributes->get('_action');

        if (array_key_exists($controller, $config)) {
            $config = $config[$controller];

            if (array_key_exists($action, $config)) {
                $config = $config[$action];
                $title  = $this->getConfiguration($config, 'title');
                $metas  = $this->getConfiguration($config, 'metas');

                if (!empty($title)) {
                    $this->sonata->setTitle($title);
                }

                foreach ($metas as $key => $values) {
                    foreach ($values as $head => $value) {
                        $this->sonata->addMeta($key, $head, $value);
                    }
                }
            }
        }
    }

    /**
     * Return the configuration if exists.
     *
     * @param array  $config
     * @param string $key
     *
     * @return array
     */
    private function getConfiguration(array $config, $key)
    {
        if (array_key_exists($key, $config)) {
            return $config[$key];
        }

        return array();
    }

    /**
     * Return generated request.
     *
     * @param Symfony\Component\HttpKernel\Event\FilterControllerEvent $event
     *
     * @return Symfony\Component\HttpFoundation\Request;

     */
    private function getRequest(FilterControllerEvent $event)
    {
        $request = $event->getRequest();

        // Get the controller full namespace in order to get informations
        $controller = $request->attributes->get('_controller');
        $pattern = '/^(.*)\\\(.*Bundle)\\\Controller\\\(.*Controller)::(.*Action)$/';

        preg_match($pattern, $controller, $matches);
        $request->attributes->set('_namespace', $matches[1]);
        $request->attributes->set('_bundle', $matches[2]);
        $request->attributes->set('_controller', $matches[3]);
        $request->attributes->set('_action', $matches[4]);

        return $request;
    }
}


1			<?php
2
3			namespace Sonata\SeoBundle\EventListener;
4
5			use Symfony\Component\DependencyInjection\ContainerInterface;
6			use Symfony\Component\HttpKernel\Event\FilterControllerEvent;
7			use Symfony\Component\Yaml\Yaml;
8
9			class ConfigurationListener
10			{
11			/** @var Sonata\SeoBundle\Seo\SeoPage $sonata */
12			private $sonata;
13
14			/** @var Symfony\Component\HttpKernel\Config\FileLocator $kernel */
15			private $fileLocator;
16
17			/** @var Symfony\Component\HttpKernel\Log\LoggerInterface $logger */
18			private $logger;
19
20			/**
21			* __construct.
22			*
23			* @param Symfony\Component\HttpKernel\Config\FileLocator $fileLocator
			0 ignored issues – show Bug introduced 2016-03-11 13:59 UTC by Report Bug Copy Issue Report There is no parameter named `$fileLocator`. Was it maybe removed? This check looks for PHPDoc comments describing methods or function parameters that do not exist on the corresponding method or function. Consider the following example. The parameter `$italy` is not defined by the method `finale(...)`. /** * @param array $germany * @param array $island * @param array $italy */ function finale($germany, $island) { return "2:1"; } The most likely cause is that the parameter was removed, but the annotation was not. Loading history...
24			*/
25			public function __construct(ContainerInterface $container)
26			{
27			$this->sonata = $container->get('sonata.seo.page');
28			$this->logger = $container->get('logger');
29			$this->fileLocator = $container->get('file_locator');
30			}
31
32			/**
33			* onKernelController.
34			*
35			* @param Symfony\Component\HttpKernel\Event\FilterControllerEvent $event
36			*/
37			public function onKernelController(FilterControllerEvent $event)
38			{
39			$controller = $event->getController();
40
41			// $controller passed can be either a class or a Closure. This is not
42			// usual in Symfony but it may happen. If it is a class, it comes in
43			// array format
44			if (!is_array($controller)) {
45			return;
46			}
47
48			// Get the request with namespace and others information we need and
49			// construct the bundle namespace
50			$request = $this->getRequest($event);
51
52			$namespace = array('_namespace', '_bundle');
53			foreach ($namespace as $key => $value) {
54			$namespace[$key] = $request->attributes->get($value);
55			}
56
57			array_unshift($namespace, '@');
58			$namespace = implode('', $namespace);
59			$namespace = array($namespace, 'Resources', 'config', 'sonata.yml');
60			$namespace = implode('/', $namespace);
61
62			// Get the configuration file from the configuration into the
63			// corresponding bundle
64			try {
65			$path = $this->fileLocator->locate($namespace);
66			} catch (\Exception $e) {
67			// Nothing to do because there's no SEO file
68			return;
69			}
70
71			try {
72			$config = Yaml::parse($path);
73			} catch (\Exception $e) {
74			// Do nothing on error. Just log error
75			$this->logger->err('An error occurred during SEO initialization');
76			$this->logger->err($e->getMessage());
77
78			return;
79			}
80
81			$controller = $request->attributes->get('_controller');
82			$action = $request->attributes->get('_action');
83
84			if (array_key_exists($controller, $config)) {
85			$config = $config[$controller];
86
87			if (array_key_exists($action, $config)) {
88			$config = $config[$action];
89			$title = $this->getConfiguration($config, 'title');
90			$metas = $this->getConfiguration($config, 'metas');
91
92			if (!empty($title)) {
93			$this->sonata->setTitle($title);
94			}
95
96			foreach ($metas as $key => $values) {
97			foreach ($values as $head => $value) {
98			$this->sonata->addMeta($key, $head, $value);
99			}
100			}
101			}
102			}
103			}
104
105			/**
106			* Return the configuration if exists.
107			*
108			* @param array $config
109			* @param string $key
110			*
111			* @return array
112			*/
113			private function getConfiguration(array $config, $key)
114			{
115			if (array_key_exists($key, $config)) {
116			return $config[$key];
117			}
118
119			return array();
120			}
121
122			/**
123			* Return generated request.
124			*
125			* @param Symfony\Component\HttpKernel\Event\FilterControllerEvent $event
126			*
127			* @return Symfony\Component\HttpFoundation\Request;
			0 ignored issues – show Documentation introduced 2016-03-11 13:59 UTC by Report Bug Copy Issue Report The doc-type `Symfony\Component\HttpFoundation\Request;` could not be parsed: Expected "\|" or "end of type", but got ";" at position 40. (view supported doc-types) This check marks PHPDoc comments that could not be parsed by our parser. To see which comment annotations we can parse, please refer to our documentation on supported doc-types. Loading history...
128			*/
129			private function getRequest(FilterControllerEvent $event)
130			{
131			$request = $event->getRequest();
132
133			// Get the controller full namespace in order to get informations
134			$controller = $request->attributes->get('_controller');
135			$pattern = '/^(.)\\\(.Bundle)\\\Controller\\\(.Controller)::(.Action)$/';
136
137			preg_match($pattern, $controller, $matches);
138			$request->attributes->set('_namespace', $matches[1]);
139			$request->attributes->set('_bundle', $matches[2]);
140			$request->attributes->set('_controller', $matches[3]);
141			$request->attributes->set('_action', $matches[4]);
142
143			return $request;
144			}
145			}
146

sonata-project / SonataSeoBundle

Pull Request — master (#118)

ConfigurationListener::onKernelController() C

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

Duplication Side-by-Side

Filter issues like