Issues in FacebookLikeButtonBlockServiceTest.php - Fixed Issues - Inspection of "Fix wrong phpdoc" - sonata-project/SonataSeoBundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( cdef28...4d68a4 )

by Christian

created 2019-11-30 11:56 UTC

Social/FacebookLikeButtonBlockServiceTest.php (2 issues)

Labels

Documentation 2

Severity

Minor 2

Sylvain Deloux 2

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

declare(strict_types=1);

/*
 * This file is part of the Sonata Project package.
 *
 * (c) Thomas Rabaix <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Sonata\SeoBundle\Tests\Block\Social;

use Sonata\AdminBundle\Form\FormMapper;
use Sonata\BlockBundle\Block\BlockContext;
use Sonata\BlockBundle\Model\Block;
use Sonata\BlockBundle\Test\AbstractBlockServiceTestCase;
use Sonata\BlockBundle\Util\OptionsResolver;
use Sonata\SeoBundle\Block\Social\FacebookLikeButtonBlockService;

class FacebookLikeButtonBlockServiceTest extends AbstractBlockServiceTestCase
{
    public function testService(): void
    {
        $service = new FacebookLikeButtonBlockService(
            'sonata.block.service.facebook.like_button',
            $this->templating
        );

        $block = new Block();
        $block->setType('core.text');
        $block->setSettings([
            'url' => 'url_setting',
            'width' => 'width_setting',
            'show_faces' => 'show_faces_setting',
            'share' => 'share_setting',
            'layout' => 'layout_setting',
            'colorscheme' => 'colorscheme_setting',
            'action' => 'action_setting',
        ]);

        $optionResolver = new OptionsResolver();
        $service->setDefaultSettings($optionResolver);

        $blockContext = new BlockContext($block, $optionResolver->resolve($block->getSettings()));

        $formMapper = $this->createMock(FormMapper::class, [], [], '', false);
        $formMapper->expects($this->exactly(2))->method('add');

        $service->buildCreateForm($formMapper, $block);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $service->buildEditForm($formMapper, $block);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

        $service->execute($blockContext);

        $this->assertSame('url_setting', $this->templating->parameters['settings']['url']);
        $this->assertSame('width_setting', $this->templating->parameters['settings']['width']);
        $this->assertSame('show_faces_setting', $this->templating->parameters['settings']['show_faces']);
        $this->assertSame('share_setting', $this->templating->parameters['settings']['share']);
        $this->assertSame('layout_setting', $this->templating->parameters['settings']['layout']);
        $this->assertSame('colorscheme_setting', $this->templating->parameters['settings']['colorscheme']);
        $this->assertSame('action_setting', $this->templating->parameters['settings']['action']);
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			/*
6			* This file is part of the Sonata Project package.
7			*
8			* (c) Thomas Rabaix <[email protected]>
9			*
10			* For the full copyright and license information, please view the LICENSE
11			* file that was distributed with this source code.
12			*/
13
14			namespace Sonata\SeoBundle\Tests\Block\Social;
15
16			use Sonata\AdminBundle\Form\FormMapper;
17			use Sonata\BlockBundle\Block\BlockContext;
18			use Sonata\BlockBundle\Model\Block;
19			use Sonata\BlockBundle\Test\AbstractBlockServiceTestCase;
20			use Sonata\BlockBundle\Util\OptionsResolver;
21			use Sonata\SeoBundle\Block\Social\FacebookLikeButtonBlockService;
22
23			class FacebookLikeButtonBlockServiceTest extends AbstractBlockServiceTestCase
24			{
25			public function testService(): void
26			{
27			$service = new FacebookLikeButtonBlockService(
28			'sonata.block.service.facebook.like_button',
29			$this->templating
30			);
31
32			$block = new Block();
33			$block->setType('core.text');
34			$block->setSettings([
35			'url' => 'url_setting',
36			'width' => 'width_setting',
37			'show_faces' => 'show_faces_setting',
38			'share' => 'share_setting',
39			'layout' => 'layout_setting',
40			'colorscheme' => 'colorscheme_setting',
41			'action' => 'action_setting',
42			]);
43
44			$optionResolver = new OptionsResolver();
45			$service->setDefaultSettings($optionResolver);
46
47			$blockContext = new BlockContext($block, $optionResolver->resolve($block->getSettings()));
48
49			$formMapper = $this->createMock(FormMapper::class, [], [], '', false);
50			$formMapper->expects($this->exactly(2))->method('add');
51
52			$service->buildCreateForm($formMapper, $block);
			0 ignored issues – show Documentation introduced 2017-12-15 13:49 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$formMapper` is of type `object<PHPUnit\Framework\MockObject\MockObject>`, but the function expects a `object<Sonata\AdminBundle\Form\FormMapper>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
53			$service->buildEditForm($formMapper, $block);
			0 ignored issues – show Documentation introduced 2017-12-15 13:49 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$formMapper` is of type `object<PHPUnit\Framework\MockObject\MockObject>`, but the function expects a `object<Sonata\AdminBundle\Form\FormMapper>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
54
55			$service->execute($blockContext);
56
57			$this->assertSame('url_setting', $this->templating->parameters['settings']['url']);
58			$this->assertSame('width_setting', $this->templating->parameters['settings']['width']);
59			$this->assertSame('show_faces_setting', $this->templating->parameters['settings']['show_faces']);
60			$this->assertSame('share_setting', $this->templating->parameters['settings']['share']);
61			$this->assertSame('layout_setting', $this->templating->parameters['settings']['layout']);
62			$this->assertSame('colorscheme_setting', $this->templating->parameters['settings']['colorscheme']);
63			$this->assertSame('action_setting', $this->templating->parameters['settings']['action']);
64			}
65			}
66

sonata-project / SonataSeoBundle

Push — master ( cdef28...4d68a4 )

Social/FacebookLikeButtonBlockServiceTest.php (2 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like