AMQPBackendTest::testInitializeWithDeadLetterExchangeAndNoDeadLetterRoutingKey() - Code Metrics - Inspection of "Migrate to AMQP interop." - sonata-project/SonataNotificationBundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — 3.x (#276)

by Maksim

created 2017-11-14 11:41 UTC

testInitializeWithDeadLetterExchangeAndNoDeadLetterRoutingKey() A

↳ Parent: AMQPBackendTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	54
Code Lines	37

Duplication

Lines	0
Ratio	0 %

Importance

Changes	4
Bugs	2	Features	0

Metric	Value
c	4
b	2
f	0
dl	0
loc	54
rs	9.6716
cc	1
eloc	37
nc	1
nop	0

How to fix Long Method

<?php

/*
 * This file is part of the Sonata Project package.
 *
 * (c) Thomas Rabaix <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Sonata\NotificationBundle\Tests\Backend;

use Enqueue\AmqpLib\AmqpConnectionFactory;
use Interop\Amqp\AmqpBind;
use Interop\Amqp\AmqpConsumer;
use Interop\Amqp\AmqpContext;
use Interop\Amqp\AmqpQueue;
use Interop\Amqp\AmqpTopic;
use Interop\Amqp\Impl\AmqpBind as ImplAmqpBind;
use Interop\Amqp\Impl\AmqpQueue as ImplAmqpQueue;
use Interop\Amqp\Impl\AmqpTopic as ImplAmqpTopic;
use PhpAmqpLib\Channel\AMQPChannel;
use PHPUnit\Framework\TestCase;
use Sonata\NotificationBundle\Backend\AMQPBackend;
use Sonata\NotificationBundle\Backend\AMQPBackendDispatcher;
use Sonata\NotificationBundle\Iterator\AMQPMessageIterator;

class AMQPBackendTest extends TestCase
{
    const EXCHANGE = 'exchange';
    const QUEUE = 'foo';
    const KEY = 'message.type.foo';
    const DEAD_LETTER_EXCHANGE = 'dlx';
    const DEAD_LETTER_ROUTING_KEY = 'message.type.dl';
    const TTL = 60000;
    const PREFETCH_COUNT = 1;

    protected function setUp()
    {
        if (!class_exists(AmqpConnectionFactory::class)) {
            $this->markTestSkipped('enqueue/amqp-lib library is not installed');
        }
    }

    public function testInitializeWithNoDeadLetterExchangeAndNoDeadLetterRoutingKey()
    {
        /**
         * @var AMQPBackend
         * @var AmqpContext|\PHPUnit_Framework_MockObject_MockObject $contextMock
         */
        list($backend, $contextMock) = $this->getBackendAndContextMock();

        $queue = new ImplAmqpQueue(self::QUEUE);
        $topic = new ImplAmqpTopic(self::EXCHANGE);

        $contextMock->expects($this->once())

            ->method('createQueue')
            ->with($this->identicalTo(self::QUEUE))
            ->willReturn($queue);

        $contextMock->expects($this->once())

            ->method('declareQueue')
            ->with($this->identicalTo($queue))
            ->willReturnCallback(function (AmqpQueue $queue) {
                $this->assertTrue((bool) ($queue->getFlags() & AmqpQueue::FLAG_DURABLE));
                $this->assertSame([], $queue->getArguments());
            });

        $contextMock->expects($this->once())

            ->method('createTopic')
            ->with($this->identicalTo(self::EXCHANGE))
            ->willReturn($topic);

        $contextMock->expects($this->once())

            ->method('declareTopic')
            ->with($this->identicalTo($topic))
            ->willReturnCallback(function (AmqpTopic $topic) {
                $this->assertTrue((bool) ($topic->getFlags() & AmqpTopic::FLAG_DURABLE));
                $this->assertSame(AmqpTopic::TYPE_DIRECT, $topic->getType());
                $this->assertSame([], $topic->getArguments());
            });

        $contextMock->expects($this->once())

            ->method('bind')
            ->with($this->isInstanceOf(AmqpBind::class))
            ->willReturnCallback(function (ImplAmqpBind $bind) use ($queue, $topic) {
                $this->assertSame($queue, $bind->getTarget());
                $this->assertSame($topic, $bind->getSource());
                $this->assertSame(self::KEY, $bind->getRoutingKey());
            });

        $backend->initialize();
    }

    public function testInitializeWithDeadLetterExchangeAndNoDeadLetterRoutingKey()
    {
        /**
         * @var AMQPBackend
         * @var AmqpContext|\PHPUnit_Framework_MockObject_MockObject $contextMock
         */
        list($backend, $contextMock) = $this->getBackendAndContextMock(false, self::DEAD_LETTER_EXCHANGE);

        $queue = new ImplAmqpQueue(self::QUEUE);
        $topic = new ImplAmqpTopic(self::EXCHANGE);
        $deadLetterTopic = new ImplAmqpTopic(self::DEAD_LETTER_EXCHANGE);

        $contextMock->expects($this->at(0))

            ->method('createQueue')
            ->with($this->identicalTo(self::QUEUE))
            ->willReturn($queue);

        $contextMock->expects($this->at(1))

            ->method('declareQueue')
            ->with($this->identicalTo($queue))
            ->willReturnCallback(function (AmqpQueue $queue) {
                $this->assertTrue((bool) ($queue->getFlags() & AmqpQueue::FLAG_DURABLE));
                $this->assertSame(['x-dead-letter-exchange' => self::DEAD_LETTER_EXCHANGE], $queue->getArguments());
            });

        $contextMock->expects($this->at(2))

            ->method('createTopic')
            ->with($this->identicalTo(self::EXCHANGE))
            ->willReturn($topic);

        $contextMock->expects($this->at(3))

            ->method('declareTopic')
            ->with($this->identicalTo($topic));

        $contextMock->expects($this->at(4))

            ->method('bind')
            ->with($this->isInstanceOf(AmqpBind::class));

        $contextMock->expects($this->at(5))

            ->method('createTopic')
            ->with($this->identicalTo(self::DEAD_LETTER_EXCHANGE))
            ->willReturn($deadLetterTopic);

        $contextMock->expects($this->at(6))

            ->method('declareTopic')
            ->with($this->identicalTo($deadLetterTopic))
            ->willReturnCallback(function (AmqpTopic $topic) {
                $this->assertTrue((bool) ($topic->getFlags() & AmqpTopic::FLAG_DURABLE));
                $this->assertSame(AmqpTopic::TYPE_DIRECT, $topic->getType());
                $this->assertSame([], $topic->getArguments());
            });

        $backend->initialize();
    }

//
    public function testInitializeWithDeadLetterExchangeAndDeadLetterRoutingKey()
    {
        /**
         * @var AMQPBackend
         * @var AmqpContext|\PHPUnit_Framework_MockObject_MockObject $contextMock
         */
        list($backend, $contextMock) = $this->getBackendAndContextMock(false, self::DEAD_LETTER_EXCHANGE, self::DEAD_LETTER_ROUTING_KEY);

        $queue = new ImplAmqpQueue(self::QUEUE);
        $topic = new ImplAmqpTopic(self::EXCHANGE);
        $deadLetterTopic = new ImplAmqpTopic(self::DEAD_LETTER_EXCHANGE);
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

        $contextMock->expects($this->at(0))

            ->method('createQueue')
            ->with($this->identicalTo(self::QUEUE))
            ->willReturn($queue);

        $contextMock->expects($this->at(1))

            ->method('declareQueue')
            ->with($this->identicalTo($queue))
            ->willReturnCallback(function (AmqpQueue $queue) {
                $this->assertTrue((bool) ($queue->getFlags() & AmqpQueue::FLAG_DURABLE));
                $this->assertSame(
                    [
                        'x-dead-letter-exchange' => self::DEAD_LETTER_EXCHANGE,
                        'x-dead-letter-routing-key' => self::DEAD_LETTER_ROUTING_KEY,
                    ],
                    $queue->getArguments()
                );
            });

        $contextMock->expects($this->at(2))

            ->method('createTopic')
            ->with($this->identicalTo(self::EXCHANGE))
            ->willReturn($topic);

        $contextMock->expects($this->at(3))

            ->method('declareTopic')
            ->with($this->identicalTo($topic));

        $contextMock->expects($this->at(4))

            ->method('bind')
            ->with($this->isInstanceOf(AmqpBind::class));

        $backend->initialize();
    }

    public function testInitializeWithTTL()
    {
        /**
         * @var AMQPBackend
         * @var AmqpContext|\PHPUnit_Framework_MockObject_MockObject $contextMock
         */
        list($backend, $contextMock) = $this->getBackendAndContextMock(false, null, null, self::TTL);

        $queue = new ImplAmqpQueue(self::QUEUE);
        $topic = new ImplAmqpTopic(self::EXCHANGE);

        $contextMock->expects($this->once())

            ->method('createQueue')
            ->with($this->identicalTo(self::QUEUE))
            ->willReturn($queue);

        $contextMock->expects($this->once())

            ->method('declareQueue')
            ->with($this->identicalTo($queue))
            ->willReturnCallback(function (AmqpQueue $queue) {
                $this->assertTrue((bool) ($queue->getFlags() & AmqpQueue::FLAG_DURABLE));
                $this->assertSame(['x-message-ttl' => self::TTL], $queue->getArguments());
            });

        $contextMock->expects($this->once())

            ->method('createTopic')
            ->with($this->identicalTo(self::EXCHANGE))
            ->willReturn($topic);

        $contextMock->expects($this->once())

            ->method('declareTopic')
            ->with($this->identicalTo($topic));

        $contextMock->expects($this->once())

            ->method('bind')
            ->with($this->isInstanceOf(AmqpBind::class));

        $backend->initialize();
    }

    public function testGetIteratorWithNoPrefetchCount()
    {
        /**
         * @var AMQPBackend
         * @var AmqpContext|\PHPUnit_Framework_MockObject_MockObject $contextMock
         */
        list($backend, $contextMock) = $this->getBackendAndContextMock();

        $queue = new ImplAmqpQueue('aQueue');
        $consumerMock = $this->createMock(AmqpConsumer::class);
        $consumerMock->expects($this->once())
            ->method('getQueue')
            ->willReturn($queue);

        $contextMock->expects($this->never())

            ->method('setQos');

        $contextMock->expects($this->once())

            ->method('createQueue')
            ->willReturn($queue);

        $contextMock->expects($this->once())

            ->method('createConsumer')
            ->with($this->identicalTo($queue))
            ->willReturn($consumerMock);

        $iterator = $backend->getIterator();

        $this->assertInstanceOf(AMQPMessageIterator::class, $iterator);
    }

    public function testGetIteratorWithPrefetchCount()
    {
        /**
         * @var AMQPBackend
         * @var AmqpContext|\PHPUnit_Framework_MockObject_MockObject $contextMock
         */
        list($backend, $contextMock) = $this->getBackendAndContextMock(false, null, null, null, self::PREFETCH_COUNT);

        $queue = new ImplAmqpQueue('aQueue');
        $consumerMock = $this->createMock(AmqpConsumer::class);
        $consumerMock->expects($this->once())
            ->method('getQueue')
            ->willReturn($queue);

        $contextMock->expects($this->once())

            ->method('setQos')
            ->with($this->isNull(), $this->identicalTo(self::PREFETCH_COUNT), $this->isFalse());

        $contextMock->expects($this->once())

            ->method('createQueue')
            ->willReturn($queue);

        $contextMock->expects($this->once())

            ->method('createConsumer')
            ->with($this->identicalTo($queue))
            ->willReturn($consumerMock);

        $iterator = $backend->getIterator();

        $this->assertInstanceOf(AMQPMessageIterator::class, $iterator);
    }

    protected function getBackendAndContextMock($recover = false, $deadLetterExchange = null, $deadLetterRoutingKey = null, $ttl = null, $prefetchCount = null)
    {
        $backend = new AMQPBackend(
            self::EXCHANGE,
            self::QUEUE,
            $recover,
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            self::KEY,
            $deadLetterExchange,
            $deadLetterRoutingKey,
            $ttl,
            $prefetchCount
        );

        $settings = [
            'host' => 'foo',
            'port' => 'port',
            'user' => 'user',
            'pass' => 'pass',
            'vhost' => '/',
        ];

        $queues = [
            ['queue' => self::QUEUE, 'routing_key' => self::KEY],
        ];

        $contextMock = $this->getMockBuilder(AmqpContext::class)
            ->disableOriginalConstructor()
            ->getMock();

        $dispatcherMock = $this->getMockBuilder(AMQPBackendDispatcher::class)
            ->setConstructorArgs([$settings, $queues, 'default', [['type' => self::KEY, 'backend' => $backend]]])
            ->setMethods(['getContext', 'getChannel'])
            ->getMock();

        $dispatcherMock
            ->expects($this->any())
            ->method('getChannel')
            ->willReturn($this->createMock(AMQPChannel::class))
        ;

        $dispatcherMock->method('getContext')
            ->willReturn($contextMock);

        $backend->setDispatcher($dispatcherMock);

        return [$backend, $contextMock];
    }
}


1			<?php
2
3			/*
4			* This file is part of the Sonata Project package.
5			*
6			* (c) Thomas Rabaix <[email protected]>
7			*
8			* For the full copyright and license information, please view the LICENSE
9			* file that was distributed with this source code.
10			*/
11
12			namespace Sonata\NotificationBundle\Tests\Backend;
13
14			use Enqueue\AmqpLib\AmqpConnectionFactory;
15			use Interop\Amqp\AmqpBind;
16			use Interop\Amqp\AmqpConsumer;
17			use Interop\Amqp\AmqpContext;
18			use Interop\Amqp\AmqpQueue;
19			use Interop\Amqp\AmqpTopic;
20			use Interop\Amqp\Impl\AmqpBind as ImplAmqpBind;
21			use Interop\Amqp\Impl\AmqpQueue as ImplAmqpQueue;
22			use Interop\Amqp\Impl\AmqpTopic as ImplAmqpTopic;
23			use PhpAmqpLib\Channel\AMQPChannel;
24			use PHPUnit\Framework\TestCase;
25			use Sonata\NotificationBundle\Backend\AMQPBackend;
26			use Sonata\NotificationBundle\Backend\AMQPBackendDispatcher;
27			use Sonata\NotificationBundle\Iterator\AMQPMessageIterator;
28
29			class AMQPBackendTest extends TestCase
30			{
31			const EXCHANGE = 'exchange';
32			const QUEUE = 'foo';
33			const KEY = 'message.type.foo';
34			const DEAD_LETTER_EXCHANGE = 'dlx';
35			const DEAD_LETTER_ROUTING_KEY = 'message.type.dl';
36			const TTL = 60000;
37			const PREFETCH_COUNT = 1;
38
39			protected function setUp()
40			{

sonata-project / SonataNotificationBundle

Pull Request — 3.x (#276)

testInitializeWithDeadLetterExchangeAndNoDeadLetterRoutingKey() A

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like