Issues (54)

Security Analysis    not enabled

This project does not seem to handle request data directly as such no vulnerable execution paths were found.

  Cross-Site Scripting
Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.
  File Exposure
File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.
  File Manipulation
File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.
  Object Injection
Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.
  Code Injection
Code Injection enables an attacker to execute arbitrary code on the server.
  Response Splitting
Response Splitting can be used to send arbitrary responses.
  File Inclusion
File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.
  Command Injection
Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.
  SQL Injection
SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.
  XPath Injection
XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.
  LDAP Injection
LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.
  Header Injection
  Other Vulnerability
This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.
  Regex Injection
Regex Injection enables an attacker to execute arbitrary code in your PHP process.
  XML Injection
XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.
  Variable Injection
Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.
Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/Admin/CommentAdmin.php (2 issues)

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

1
<?php
2
3
declare(strict_types=1);
4
5
/*
6
 * This file is part of the Sonata Project package.
7
 *
8
 * (c) Thomas Rabaix <[email protected]>
9
 *
10
 * For the full copyright and license information, please view the LICENSE
11
 * file that was distributed with this source code.
12
 */
13
14
namespace Sonata\NewsBundle\Admin;
15
16
use Sonata\AdminBundle\Admin\AbstractAdmin;
17
use Sonata\AdminBundle\Datagrid\DatagridMapper;
18
use Sonata\AdminBundle\Datagrid\ListMapper;
19
use Sonata\AdminBundle\Form\FormMapper;
20
use Sonata\AdminBundle\Form\Type\ModelListType;
21
use Sonata\Doctrine\Model\ManagerInterface;
22
use Sonata\NewsBundle\Form\Type\CommentStatusType;
23
use Sonata\NewsBundle\Model\CommentManagerInterface;
24
use Symfony\Component\Form\Extension\Core\Type\TextType;
25
26
class CommentAdmin extends AbstractAdmin
27
{
28
    /**
29
     * @var CommentManagerInterface
30
     */
31
    protected $commentManager;
32
33
    public function getBatchActions()
34
    {
35
        $actions = parent::getBatchActions();
36
37
        $actions['enabled'] = [
38
            'label' => $this->getLabelTranslatorStrategy()->getLabel('enable', 'batch', 'comment'),
39
            'translation_domain' => $this->getTranslationDomain(),
40
            'ask_confirmation' => false,
41
        ];
42
43
        $actions['disabled'] = [
44
            'label' => $this->getLabelTranslatorStrategy()->getLabel('disable', 'batch', 'comment'),
45
            'translation_domain' => $this->getTranslationDomain(),
46
            'ask_confirmation' => false,
47
        ];
48
49
        return $actions;
50
    }
51
52
    public function postPersist($object): void
53
    {
54
        $this->updateCountsComment();
55
    }
56
57
    public function postRemove($object): void
58
    {
59
        $this->updateCountsComment();
60
    }
61
62
    public function postUpdate($object): void
63
    {
64
        $this->updateCountsComment();
65
    }
66
67
    public function setCommentManager(ManagerInterface $commentManager): void
68
    {
69
        if (!$commentManager instanceof CommentManagerInterface) {
70
            @trigger_error(
0 ignored issues
show
Security Best Practice introduced by
It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended.

If you suppress an error, we recommend checking for the error condition explicitly:

// For example instead of
@mkdir($dir);

// Better use
if (@mkdir($dir) === false) {
    throw new \RuntimeException('The directory '.$dir.' could not be created.');
}
Loading history...
71
                'Calling the '.__METHOD__.' method with a Sonata\Doctrine\Model\ManagerInterface is deprecated'
72
                .' since version 2.4 and will be removed in 3.0.'
73
                .' Use the new signature with a Sonata\NewsBundle\Model\CommentManagerInterface instead.',
74
                E_USER_DEPRECATED
75
            );
76
        }
77
78
        $this->commentManager = $commentManager;
0 ignored issues
show
Documentation Bug introduced by
$commentManager is of type object<Sonata\Doctrine\Model\ManagerInterface>, but the property $commentManager was declared to be of type object<Sonata\NewsBundle...ommentManagerInterface>. Are you sure that you always receive this specific sub-class here, or does it make sense to add an instanceof check?

Our type inference engine has found a suspicous assignment of a value to a property. This check raises an issue when a value that can be of a given class or a super-class is assigned to a property that is type hinted more strictly.

Either this assignment is in error or an instanceof check should be added for that assignment.

class Alien {}

class Dalek extends Alien {}

class Plot
{
    /** @var  Dalek */
    public $villain;
}

$alien = new Alien();
$plot = new Plot();
if ($alien instanceof Dalek) {
    $plot->villain = $alien;
}
Loading history...
79
    }
80
81
    protected function configureFormFields(FormMapper $formMapper): void
82
    {
83
        // define group zoning
84
        $formMapper
85
            ->with('group_comment', ['class' => 'col-md-6'])->end()
86
            ->with('group_general', ['class' => 'col-md-6'])->end()
87
        ;
88
89
        if (!$this->isChild()) {
90
            $formMapper
91
                ->with('group_general')
92
                    ->add('post', ModelListType::class)
93
                ->end()
94
            ;
95
        }
96
97
        $formMapper
98
            ->with('group_general')
99
                ->add('name')
100
                ->add('email')
101
                ->add('url', null, ['required' => false])
102
            ->end()
103
            ->with('group_comment')
104
                ->add('status', CommentStatusType::class, [
105
                    'expanded' => true,
106
                    'multiple' => false,
107
                ])
108
                ->add('message', null, ['attr' => ['rows' => 6]])
109
            ->end()
110
        ;
111
    }
112
113
    protected function configureDatagridFilters(DatagridMapper $datagridMapper): void
114
    {
115
        $datagridMapper
116
            ->add('name')
117
            ->add('email')
118
            ->add('message')
119
        ;
120
    }
121
122
    protected function configureListFields(ListMapper $listMapper): void
123
    {
124
        $listMapper
125
            ->addIdentifier('name')
126
            ->add('getStatusCode', TextType::class, ['label' => 'status_code', 'sortable' => 'status'])
127
        ;
128
129
        if (!$this->isChild()) {
130
            $listMapper->add('post');
131
        }
132
133
        $listMapper
134
            ->add('email')
135
            ->add('url')
136
            ->add('message');
137
    }
138
139
    /**
140
     * Update the count comment.
141
     */
142
    private function updateCountsComment(): void
143
    {
144
        $this->commentManager->updateCommentsCount();
145
    }
146
}
147