MonthlyPostArchiveAction::__invoke() - Code Metrics - Inspection of "Merge remote-tracking branch 'upstream/3.x' into m..." - sonata-project/SonataNewsBundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 37876c...34238f )

by Marko

created 2018-07-13 17:14 UTC

MonthlyPostArchiveAction::__invoke() A

↳ Parent: MonthlyPostArchiveAction

Complexity

Conditions	2
Paths	2

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
c	0
b	0
f	0
dl	0
loc	34
rs	9.376
cc	2
nc	2
nop	3

<?php

declare(strict_types=1);

/*
 * This file is part of the Sonata Project package.
 *
 * (c) Thomas Rabaix <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Sonata\NewsBundle\Action;

use Sonata\IntlBundle\Templating\Helper\DateTimeHelper;
use Sonata\NewsBundle\Model\BlogInterface;
use Sonata\NewsBundle\Model\PostManagerInterface;
use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\HttpFoundation\Response;
use Symfony\Component\Translation\TranslatorInterface;

final class MonthlyPostArchiveAction extends AbstractPostArchiveAction
{
    /**
     * @var DateTimeHelper
     */
    private $dateTimeHelper;

    public function __construct(
        BlogInterface $blog,
        PostManagerInterface $postManager,
        TranslatorInterface $translator,
        DateTimeHelper $dateTimeHelper
    ) {
        parent::__construct($blog, $postManager, $translator);

        $this->dateTimeHelper = $dateTimeHelper;
    }

    /**
     * @param string $year
     * @param string $month
     *
     * @return Response
     */
    public function __invoke(Request $request, $year, $month)
    {
        $date = $this->getPostManager()->getPublicationDateQueryParts(sprintf('%d-%d-%d', $year, $month, 1), 'month');

        if ($seoPage = $this->getSeoPage()) {
            $seoPage
                ->setTitle($this->trans('archive_month.meta_title', [
                    '%title%' => $this->getBlog()->getTitle(),
                    '%year%' => $year,
                    '%month%' => $this->dateTimeHelper->format($date, 'MMMM'),
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
                ]))
                ->addMeta('property', 'og:title', $this->trans('archive_month.meta_title', [
                    '%title%' => $this->getBlog()->getTitle(),
                    '%year%' => $year,
                    '%month%' => $this->dateTimeHelper->format($date, 'MMMM'),
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
                ]))
                ->addMeta('name', 'description', $this->trans('archive_month.meta_description', [
                    '%title%' => $this->getBlog()->getTitle(),
                    '%year%' => $year,
                    '%month%' => $this->dateTimeHelper->format($date, 'MMMM'),
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
                    '%description%' => $this->getBlog()->getDescription(),
                ]))
                ->addMeta('property', 'og:description', $this->trans('archive_month.meta_description', [
                    '%title%' => $this->getBlog()->getTitle(),
                    '%year%' => $year,
                    '%month%' => $this->dateTimeHelper->format($date, 'MMMM'),
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
                    '%description%' => $this->getBlog()->getDescription(),
                ]));
        }

        return $this->renderArchive($request, [
            'date' => $date,
        ], []);
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			/*
6			* This file is part of the Sonata Project package.
7			*
8			* (c) Thomas Rabaix <[email protected]>
9			*
10			* For the full copyright and license information, please view the LICENSE
11			* file that was distributed with this source code.
12			*/
13
14			namespace Sonata\NewsBundle\Action;
15
16			use Sonata\IntlBundle\Templating\Helper\DateTimeHelper;
17			use Sonata\NewsBundle\Model\BlogInterface;
18			use Sonata\NewsBundle\Model\PostManagerInterface;
19			use Symfony\Component\HttpFoundation\Request;
20			use Symfony\Component\HttpFoundation\Response;
21			use Symfony\Component\Translation\TranslatorInterface;
22
23			final class MonthlyPostArchiveAction extends AbstractPostArchiveAction
24			{
25			/**
26			* @var DateTimeHelper
27			*/
28			private $dateTimeHelper;
29
30			public function __construct(
31			BlogInterface $blog,
32			PostManagerInterface $postManager,
33			TranslatorInterface $translator,
34			DateTimeHelper $dateTimeHelper
35			) {
36			parent::__construct($blog, $postManager, $translator);
37
38			$this->dateTimeHelper = $dateTimeHelper;
39			}
40
41			/**
42			* @param string $year
43			* @param string $month
44			*
45			* @return Response
46			*/
47			public function __invoke(Request $request, $year, $month)
48			{
49			$date = $this->getPostManager()->getPublicationDateQueryParts(sprintf('%d-%d-%d', $year, $month, 1), 'month');
50
51			if ($seoPage = $this->getSeoPage()) {
52			$seoPage
53			->setTitle($this->trans('archive_month.meta_title', [
54			'%title%' => $this->getBlog()->getTitle(),
55			'%year%' => $year,
56			'%month%' => $this->dateTimeHelper->format($date, 'MMMM'),
			0 ignored issues – show Documentation introduced 2018-07-12 19:04 UTC by Report Bug Copy Issue Report `$date` is of type `array`, but the function expects a `object<DateTimeInterface>\|string\|integer`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
57			]))
58			->addMeta('property', 'og:title', $this->trans('archive_month.meta_title', [
59			'%title%' => $this->getBlog()->getTitle(),
60			'%year%' => $year,
61			'%month%' => $this->dateTimeHelper->format($date, 'MMMM'),
			0 ignored issues – show Documentation introduced 2018-07-12 19:04 UTC by Report Bug Copy Issue Report `$date` is of type `array`, but the function expects a `object<DateTimeInterface>\|string\|integer`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
62			]))
63			->addMeta('name', 'description', $this->trans('archive_month.meta_description', [
64			'%title%' => $this->getBlog()->getTitle(),
65			'%year%' => $year,
66			'%month%' => $this->dateTimeHelper->format($date, 'MMMM'),
			0 ignored issues – show Documentation introduced 2018-07-12 19:04 UTC by Report Bug Copy Issue Report `$date` is of type `array`, but the function expects a `object<DateTimeInterface>\|string\|integer`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
67			'%description%' => $this->getBlog()->getDescription(),
68			]))
69			->addMeta('property', 'og:description', $this->trans('archive_month.meta_description', [
70			'%title%' => $this->getBlog()->getTitle(),
71			'%year%' => $year,
72			'%month%' => $this->dateTimeHelper->format($date, 'MMMM'),
			0 ignored issues – show Documentation introduced 2018-07-12 19:04 UTC by Report Bug Copy Issue Report `$date` is of type `array`, but the function expects a `object<DateTimeInterface>\|string\|integer`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
73			'%description%' => $this->getBlog()->getDescription(),
74			]));
75			}
76
77			return $this->renderArchive($request, [
78			'date' => $date,
79			], []);
80			}
81			}
82

sonata-project / SonataNewsBundle

Push — master ( 37876c...34238f )

MonthlyPostArchiveAction::__invoke() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like