Issues in CommentTest.php - Fixed Issues - Inspection of "Merge 3.x into master" - sonata-project/SonataNewsBundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( c19266...47c0ad )

unknown

created 2019-09-13 00:00 UTC

tests/Model/CommentTest.php (1 issue)

Labels

Documentation 1

Severity

Minor 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

declare(strict_types=1);

/*
 * This file is part of the Sonata Project package.
 *
 * (c) Thomas Rabaix <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Sonata\NewsBundle\Tests\Model;

use PHPUnit\Framework\TestCase;
use Sonata\NewsBundle\Model\Comment;
use Sonata\NewsBundle\Model\PostInterface;

class ModelTest_Comment extends Comment
{
    public function getId(): void
    {
    }
}

class CommentTest extends TestCase
{
    public function testSettersGetters(): void
    {
        $date = new \DateTime();

        $comment = new ModelTest_Comment();
        $comment->setCreatedAt($date);
        $comment->setEmail('[email protected]');
        $comment->setMessage('My message');
        $comment->setName('My name');
        $comment->setPost($post = $this->createMock(PostInterface::class));
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $comment->setStatus(1);
        $comment->setUpdatedAt($date);
        $comment->setUrl('http://www.example.org');

        $this->assertSame($date, $comment->getCreatedAt());
        $this->assertSame('[email protected]', $comment->getEmail());
        $this->assertSame('My message', $comment->getMessage());
        $this->assertSame('My name', $comment->getName());
        $this->assertInstanceOf(PostInterface::class, $post);
        $this->assertSame($post, $comment->getPost());
        $this->assertSame(1, $comment->getStatus());
        $this->assertSame($date, $comment->getUpdatedAt());
        $this->assertSame('http://www.example.org', $comment->getUrl());
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			/*
6			* This file is part of the Sonata Project package.
7			*
8			* (c) Thomas Rabaix <[email protected]>
9			*
10			* For the full copyright and license information, please view the LICENSE
11			* file that was distributed with this source code.
12			*/
13
14			namespace Sonata\NewsBundle\Tests\Model;
15
16			use PHPUnit\Framework\TestCase;
17			use Sonata\NewsBundle\Model\Comment;
18			use Sonata\NewsBundle\Model\PostInterface;
19
20			class ModelTest_Comment extends Comment
21			{
22			public function getId(): void
23			{
24			}
25			}
26
27			class CommentTest extends TestCase
28			{
29			public function testSettersGetters(): void
30			{
31			$date = new \DateTime();
32
33			$comment = new ModelTest_Comment();
34			$comment->setCreatedAt($date);
35			$comment->setEmail('[email protected]');
36			$comment->setMessage('My message');
37			$comment->setName('My name');
38			$comment->setPost($post = $this->createMock(PostInterface::class));
			0 ignored issues – show Documentation introduced 2019-03-08 18:10 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$post = $this->createMoc...l\PostInterface::class)` is of type `object<PHPUnit\Framework\MockObject\MockObject>`, but the function expects a `object<Sonata\NewsBundle\Model\PostInterface>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
39			$comment->setStatus(1);
40			$comment->setUpdatedAt($date);
41			$comment->setUrl('http://www.example.org');
42
43			$this->assertSame($date, $comment->getCreatedAt());
44			$this->assertSame('[email protected]', $comment->getEmail());
45			$this->assertSame('My message', $comment->getMessage());
46			$this->assertSame('My name', $comment->getName());
47			$this->assertInstanceOf(PostInterface::class, $post);
48			$this->assertSame($post, $comment->getPost());
49			$this->assertSame(1, $comment->getStatus());
50			$this->assertSame($date, $comment->getUpdatedAt());
51			$this->assertSame('http://www.example.org', $comment->getUrl());
52			}
53			}
54

sonata-project / SonataNewsBundle

Push — master ( c19266...47c0ad )

tests/Model/CommentTest.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like