CommentAdmin::postUpdate() - Code Metrics - sonata-project/SonataNewsBundle - Measure and Improve Code Quality continuously with Scrutinizer

CommentAdmin::postUpdate() A
last analyzed 2020-08-28 02:03 UTC

↳ Parent: CommentAdmin

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	4
rs	10
c	0
b	0
f	0
cc	1
nc	1
nop	1

<?php

declare(strict_types=1);

/*
 * This file is part of the Sonata Project package.
 *
 * (c) Thomas Rabaix <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Sonata\NewsBundle\Admin;

use Sonata\AdminBundle\Admin\AbstractAdmin;
use Sonata\AdminBundle\Datagrid\DatagridMapper;
use Sonata\AdminBundle\Datagrid\ListMapper;
use Sonata\AdminBundle\Form\FormMapper;
use Sonata\AdminBundle\Form\Type\ModelListType;
use Sonata\Doctrine\Model\ManagerInterface;
use Sonata\NewsBundle\Form\Type\CommentStatusType;
use Sonata\NewsBundle\Model\CommentManagerInterface;
use Symfony\Component\Form\Extension\Core\Type\TextType;

class CommentAdmin extends AbstractAdmin
{
    /**
     * @var CommentManagerInterface
     */
    protected $commentManager;

    public function getBatchActions()
    {
        $actions = parent::getBatchActions();

        $actions['enabled'] = [
            'label' => $this->getLabelTranslatorStrategy()->getLabel('enable', 'batch', 'comment'),
            'translation_domain' => $this->getTranslationDomain(),
            'ask_confirmation' => false,
        ];

        $actions['disabled'] = [
            'label' => $this->getLabelTranslatorStrategy()->getLabel('disable', 'batch', 'comment'),
            'translation_domain' => $this->getTranslationDomain(),
            'ask_confirmation' => false,
        ];

        return $actions;
    }

    public function postPersist($object): void
    {
        $this->updateCountsComment();
    }

    public function postRemove($object): void
    {
        $this->updateCountsComment();
    }

    public function postUpdate($object): void
    {
        $this->updateCountsComment();
    }

    public function setCommentManager(ManagerInterface $commentManager): void
    {
        if (!$commentManager instanceof CommentManagerInterface) {
            @trigger_error(
// For example instead of
@mkdir($dir);

// Better use
if (@mkdir($dir) === false) {
    throw new \RuntimeException('The directory '.$dir.' could not be created.');
}
                'Calling the '.__METHOD__.' method with a Sonata\Doctrine\Model\ManagerInterface is deprecated'
                .' since version 2.4 and will be removed in 3.0.'
                .' Use the new signature with a Sonata\NewsBundle\Model\CommentManagerInterface instead.',
                E_USER_DEPRECATED
            );
        }

        $this->commentManager = $commentManager;
class Alien {}

class Dalek extends Alien {}

class Plot
{
    /** @var  Dalek */
    public $villain;
}

$alien = new Alien();
$plot = new Plot();
if ($alien instanceof Dalek) {
    $plot->villain = $alien;
}
    }

    protected function configureFormFields(FormMapper $formMapper): void
    {
        // define group zoning
        $formMapper
            ->with('group_comment', ['class' => 'col-md-6'])->end()
            ->with('group_general', ['class' => 'col-md-6'])->end()
        ;

        if (!$this->isChild()) {
            $formMapper
                ->with('group_general')
                    ->add('post', ModelListType::class)
                ->end()
            ;
        }

        $formMapper
            ->with('group_general')
                ->add('name')
                ->add('email')
                ->add('url', null, ['required' => false])
            ->end()
            ->with('group_comment')
                ->add('status', CommentStatusType::class, [
                    'expanded' => true,
                    'multiple' => false,
                ])
                ->add('message', null, ['attr' => ['rows' => 6]])
            ->end()
        ;
    }

    protected function configureDatagridFilters(DatagridMapper $datagridMapper): void
    {
        $datagridMapper
            ->add('name')
            ->add('email')
            ->add('message')
        ;
    }

    protected function configureListFields(ListMapper $listMapper): void
    {
        $listMapper
            ->addIdentifier('name')
            ->add('getStatusCode', TextType::class, ['label' => 'status_code', 'sortable' => 'status'])
        ;

        if (!$this->isChild()) {
            $listMapper->add('post');
        }

        $listMapper
            ->add('email')
            ->add('url')
            ->add('message');
    }

    /**
     * Update the count comment.
     */
    private function updateCountsComment(): void
    {
        $this->commentManager->updateCommentsCount();
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			/*
6			* This file is part of the Sonata Project package.
7			*
8			* (c) Thomas Rabaix <[email protected]>
9			*
10			* For the full copyright and license information, please view the LICENSE
11			* file that was distributed with this source code.
12			*/
13
14			namespace Sonata\NewsBundle\Admin;
15
16			use Sonata\AdminBundle\Admin\AbstractAdmin;
17			use Sonata\AdminBundle\Datagrid\DatagridMapper;
18			use Sonata\AdminBundle\Datagrid\ListMapper;
19			use Sonata\AdminBundle\Form\FormMapper;
20			use Sonata\AdminBundle\Form\Type\ModelListType;
21			use Sonata\Doctrine\Model\ManagerInterface;
22			use Sonata\NewsBundle\Form\Type\CommentStatusType;
23			use Sonata\NewsBundle\Model\CommentManagerInterface;
24			use Symfony\Component\Form\Extension\Core\Type\TextType;
25
26			class CommentAdmin extends AbstractAdmin
27			{
28			/**
29			* @var CommentManagerInterface
30			*/
31			protected $commentManager;
32
33			public function getBatchActions()
34			{
35			$actions = parent::getBatchActions();
36
37			$actions['enabled'] = [
38			'label' => $this->getLabelTranslatorStrategy()->getLabel('enable', 'batch', 'comment'),
39			'translation_domain' => $this->getTranslationDomain(),
40			'ask_confirmation' => false,
41			];
42
43			$actions['disabled'] = [
44			'label' => $this->getLabelTranslatorStrategy()->getLabel('disable', 'batch', 'comment'),
45			'translation_domain' => $this->getTranslationDomain(),
46			'ask_confirmation' => false,
47			];
48
49			return $actions;
50			}
51
52			public function postPersist($object): void
53			{
54			$this->updateCountsComment();
55			}
56
57			public function postRemove($object): void
58			{
59			$this->updateCountsComment();
60			}
61
62			public function postUpdate($object): void
63			{
64			$this->updateCountsComment();
65			}
66
67			public function setCommentManager(ManagerInterface $commentManager): void
68			{
69			if (!$commentManager instanceof CommentManagerInterface) {
70			@trigger_error(
			0 ignored issues – show Security Best Practice introduced 2015-11-23 07:52 UTC by Report Bug Copy Issue Report It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended. If you suppress an error, we recommend checking for the error condition explicitly: // For example instead of @mkdir($dir); // Better use if (@mkdir($dir) === false) { throw new \RuntimeException('The directory '.$dir.' could not be created.'); } Loading history...
71			'Calling the '.__METHOD__.' method with a Sonata\Doctrine\Model\ManagerInterface is deprecated'
72			.' since version 2.4 and will be removed in 3.0.'
73			.' Use the new signature with a Sonata\NewsBundle\Model\CommentManagerInterface instead.',
74			E_USER_DEPRECATED
75			);
76			}
77
78			$this->commentManager = $commentManager;
			0 ignored issues – show Documentation Bug introduced 2019-01-16 06:43 UTC by Report Bug Copy Issue Report `$commentManager` is of type `object<Sonata\Doctrine\Model\ManagerInterface>`, but the property `$commentManager` was declared to be of type `object<Sonata\NewsBundle...ommentManagerInterface>`. Are you sure that you always receive this specific sub-class here, or does it make sense to add an `instanceof` check? Our type inference engine has found a suspicous assignment of a value to a property. This check raises an issue when a value that can be of a given class or a super-class is assigned to a property that is type hinted more strictly. Either this assignment is in error or an instanceof check should be added for that assignment. class Alien {} class Dalek extends Alien {} class Plot { /** @var Dalek */ public $villain; } $alien = new Alien(); $plot = new Plot(); if ($alien instanceof Dalek) { $plot->villain = $alien; } Loading history...
79			}
80
81			protected function configureFormFields(FormMapper $formMapper): void
82			{
83			// define group zoning
84			$formMapper
85			->with('group_comment', ['class' => 'col-md-6'])->end()
86			->with('group_general', ['class' => 'col-md-6'])->end()
87			;
88
89			if (!$this->isChild()) {
90			$formMapper
91			->with('group_general')
92			->add('post', ModelListType::class)
93			->end()
94			;
95			}
96
97			$formMapper
98			->with('group_general')
99			->add('name')
100			->add('email')
101			->add('url', null, ['required' => false])
102			->end()
103			->with('group_comment')
104			->add('status', CommentStatusType::class, [
105			'expanded' => true,
106			'multiple' => false,
107			])
108			->add('message', null, ['attr' => ['rows' => 6]])
109			->end()
110			;
111			}
112
113			protected function configureDatagridFilters(DatagridMapper $datagridMapper): void
114			{
115			$datagridMapper
116			->add('name')
117			->add('email')
118			->add('message')
119			;
120			}
121
122			protected function configureListFields(ListMapper $listMapper): void
123			{
124			$listMapper
125			->addIdentifier('name')
126			->add('getStatusCode', TextType::class, ['label' => 'status_code', 'sortable' => 'status'])
127			;
128
129			if (!$this->isChild()) {
130			$listMapper->add('post');
131			}
132
133			$listMapper
134			->add('email')
135			->add('url')
136			->add('message');
137			}
138
139			/**
140			* Update the count comment.
141			*/
142			private function updateCountsComment(): void
143			{
144			$this->commentManager->updateCommentsCount();
145			}
146			}
147

sonata-project / SonataNewsBundle

CommentAdmin::postUpdate() A last analyzed 2020-08-28 02:03 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

CommentAdmin::postUpdate() A
last analyzed 2020-08-28 02:03 UTC