Sonata\NewsBundle\Action\CreateCommentFormAction

Complexity

Total Complexity

4

Size/Duplication

Total Lines	73
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	6

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	11	1
A	__invoke()	0	15	2
A	getCommentForm()	0	13	1

<?php

declare(strict_types=1);

/*
 * This file is part of the Sonata Project package.
 *
 * (c) Thomas Rabaix <thomas.rabaix@sonata-project.org>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Sonata\NewsBundle\Action;

use Sonata\NewsBundle\Form\Type\CommentType;
use Sonata\NewsBundle\Model\CommentManagerInterface;
use Sonata\NewsBundle\Model\PostInterface;
use Sonata\NewsBundle\Model\PostManagerInterface;
use Symfony\Bundle\FrameworkBundle\Controller\Controller;
use Symfony\Component\Form\FormFactoryInterface;
use Symfony\Component\Form\FormInterface;
use Symfony\Component\HttpFoundation\Response;
use Symfony\Component\Routing\RouterInterface;

final class CreateCommentFormAction extends Controller

The class Symfony\Bundle\FrameworkBundle\Controller\Controller has been deprecated with message: since Symfony 4.2, use "Symfony\Bundle\FrameworkBundle\Controller\AbstractController" instead.

{
    /**
     * @var RouterInterface
     */
    private $router;

    /**
     * @var PostManagerInterface
     */
    private $postManager;

    /**
     * @var CommentManagerInterface
     */
    private $commentManager;

    /**
     * @var FormFactoryInterface
     */
    private $formFactory;

    public function __construct(
        RouterInterface $router,
        PostManagerInterface $postManager,
        CommentManagerInterface $commentManager,
        FormFactoryInterface $formFactory
    ) {
        $this->router = $router;
        $this->postManager = $postManager;
        $this->commentManager = $commentManager;
        $this->formFactory = $formFactory;
    }

    /**
     * @param string $postId
     * @param bool   $form
     *
     * @return Response
     */
    public function __invoke($postId, $form = false)
    {
        if (!$form) {
            $post = $this->postManager->findOneBy([
                'id' => $postId,
            ]);

            $form = $this->getCommentForm($post);

It seems like $post defined by $this->postManager->findOneBy(array('id' => $postId)) on line 69 can also be of type null; however, Sonata\NewsBundle\Action\CreateCommentFormAction::getCommentForm() does only seem to accept object<Sonata\NewsBundle\Model\PostInterface>, maybe add an additional type check?

        }

        return $this->render('@SonataNews/Post/comment_form.html.twig', [
            'form' => $form->createView(),

It seems like $form is not always an object, but can also be of type boolean. Maybe add an additional type check?

            'post_id' => $postId,
        ]);
    }

    /**
     * @return FormInterface
     */
    private function getCommentForm(PostInterface $post)
    {
        $comment = $this->commentManager->create();
        $comment->setPost($post);
        $comment->setStatus($post->getCommentsDefaultStatus());

        return $this->formFactory->createNamed('comment', CommentType::class, $comment, [
            'action' => $this->router->generate('sonata_news_add_comment', [
                'id' => $post->getId(),
            ]),
            'method' => 'POST',
        ]);
    }
}