GalleryControllerTest::testDeleteGalleryMediaGalleryItemInvalidAction() - Code Metrics - Inspection of "Merge 3.x" - sonata-project/SonataMediaBundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#1175)

by Grégoire

created 2017-01-21 11:23 UTC

testDeleteGalleryMediaGalleryItemInvalidAction() B

↳ Parent: GalleryControllerTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	35
Code Lines	24

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
eloc	24
nc	1
nop	0
dl	0
loc	35
rs	8.8571
c	0
b	0
f	0

<?php

/*
 * This file is part of the Sonata Project package.
 *
 * (c) Thomas Rabaix <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Sonata\MediaBundle\Tests\Controller\Api;

use Doctrine\Common\Collections\ArrayCollection;
use Sonata\MediaBundle\Controller\Api\GalleryController;
use Sonata\MediaBundle\Model\GalleryItem;
use Symfony\Component\HttpFoundation\Request;

class GalleryTest extends GalleryItem
{
    private $id;

    public function __construct()
    {
        parent::__construct();
        $this->id = rand();
    }

    public function getId()
    {
        return $this->id;
    }
}

/**
 * @author Hugo Briand <[email protected]>
 */
class GalleryControllerTest extends \PHPUnit_Framework_TestCase

{
    public function testGetGalleriesAction()
    {
        $galleryManager = $this->getMock('Sonata\MediaBundle\Model\GalleryManagerInterface');

        $mediaManager = $this->getMock('Sonata\MediaBundle\Model\MediaManagerInterface');

        $formFactory = $this->getMock('Symfony\Component\Form\FormFactoryInterface');


        $galleryManager->expects($this->once())->method('getPager')->will($this->returnValue(array()));

        $gController = new GalleryController($galleryManager, $mediaManager, $formFactory, 'test');

        $paramFetcher = $this->getMockBuilder('FOS\RestBundle\Request\ParamFetcher')
            ->disableOriginalConstructor()
            ->getMock();
        $paramFetcher->expects($this->exactly(3))->method('get');
        $paramFetcher
            ->expects($this->once())
            ->method('all')
            ->will($this->returnValue(array(
                'page' => 1,
                'count' => 10,
                'orderBy' => array('id' => 'ASC'),
            )));

        $this->assertSame(array(), $gController->getGalleriesAction($paramFetcher));
    }

    public function testGetGalleryAction()
    {
        $galleryManager = $this->getMock('Sonata\MediaBundle\Model\GalleryManagerInterface');

        $mediaManager = $this->getMock('Sonata\MediaBundle\Model\MediaManagerInterface');

        $gallery = $this->getMock('Sonata\MediaBundle\Model\GalleryInterface');

        $formFactory = $this->getMock('Symfony\Component\Form\FormFactoryInterface');


        $galleryManager->expects($this->once())->method('findOneBy')->will($this->returnValue($gallery));

        $gController = new GalleryController($galleryManager, $mediaManager, $formFactory, 'test');

        $this->assertSame($gallery, $gController->getGalleryAction(1));
    }

    /**
     * @expectedException        \Symfony\Component\HttpKernel\Exception\NotFoundHttpException
     * @expectedExceptionMessage Gallery (42) not found
     */
    public function testGetGalleryNotFoundAction()
    {
        $galleryManager = $this->getMock('Sonata\MediaBundle\Model\GalleryManagerInterface');

        $mediaManager = $this->getMock('Sonata\MediaBundle\Model\MediaManagerInterface');


        $formFactory = $this->getMock('Symfony\Component\Form\FormFactoryInterface');


        $galleryManager->expects($this->once())->method('findOneBy');

        $gController = new GalleryController($galleryManager, $mediaManager, $formFactory, 'test');

        $gController->getGalleryAction(42);
    }

    public function testGetGalleryGalleryItemsAction()
    {
        $galleryManager = $this->getMock('Sonata\MediaBundle\Model\GalleryManagerInterface');

        $galleryItem = $this->getMock('Sonata\MediaBundle\Model\GalleryItemInterface');

        $gallery = $this->getMock('Sonata\MediaBundle\Model\GalleryInterface');

        $formFactory = $this->getMock('Symfony\Component\Form\FormFactoryInterface');


        $gallery->expects($this->once())->method('getGalleryItems')->will($this->returnValue(array($galleryItem)));

        $galleryManager->expects($this->once())->method('findOneBy')->will($this->returnValue($gallery));

        $mediaManager = $this->getMock('Sonata\MediaBundle\Model\MediaManagerInterface');


        $gController = new GalleryController($galleryManager, $mediaManager, $formFactory, 'test');

        $this->assertSame(array($galleryItem), $gController->getGalleryGalleryItemAction(1));
    }

    public function testGetGalleryMediaAction()
    {
        $media = $this->getMock('Sonata\MediaBundle\Model\MediaInterface');

        $formFactory = $this->getMock('Symfony\Component\Form\FormFactoryInterface');


        $galleryItem = $this->getMock('Sonata\MediaBundle\Model\GalleryItemInterface');

        $galleryItem->expects($this->once())->method('getMedia')->will($this->returnValue($media));

        $gallery = $this->getMock('Sonata\MediaBundle\Model\GalleryInterface');

        $gallery->expects($this->once())->method('getGalleryItems')->will($this->returnValue(array($galleryItem)));

        $galleryManager = $this->getMock('Sonata\MediaBundle\Model\GalleryManagerInterface');

        $galleryManager->expects($this->once())->method('findOneBy')->will($this->returnValue($gallery));

        $mediaManager = $this->getMock('Sonata\MediaBundle\Model\MediaManagerInterface');


        $gController = new GalleryController($galleryManager, $mediaManager, $formFactory, 'test');

        $this->assertSame(array($media), $gController->getGalleryMediasAction(1));
    }

    public function testPostGalleryMediaGalleryItemAction()
    {
        $media = $this->getMock('Sonata\MediaBundle\Model\MediaInterface');


        $media2 = $this->getMock('Sonata\MediaBundle\Model\MediaInterface');

        $media2->expects($this->any())->method('getId')->will($this->returnValue(1));

        $galleryItem = $this->getMock('Sonata\MediaBundle\Model\GalleryItemInterface');

        $galleryItem->expects($this->once())->method('getMedia')->will($this->returnValue($media2));

        $gallery = $this->getMock('Sonata\MediaBundle\Model\GalleryInterface');

        $gallery->expects($this->once())->method('getGalleryItems')->will($this->returnValue(array($galleryItem)));

        $galleryManager = $this->getMock('Sonata\MediaBundle\Model\GalleryManagerInterface');

        $galleryManager->expects($this->once())->method('findOneBy')->will($this->returnValue($gallery));

        $mediaManager = $this->getMock('Sonata\MediaBundle\Model\MediaManagerInterface');

        $mediaManager->expects($this->once())->method('findOneBy')->will($this->returnValue($media));

        $form = $this->getMockBuilder('Symfony\Component\Form\Form')->disableOriginalConstructor()->getMock();
        $form->expects($this->once())->method('handleRequest');
        $form->expects($this->once())->method('isValid')->will($this->returnValue(true));
        $form->expects($this->once())->method('getData')->will($this->returnValue($galleryItem));

        $formFactory = $this->getMock('Symfony\Component\Form\FormFactoryInterface');

        $formFactory->expects($this->once())->method('createNamed')->will($this->returnValue($form));

        $galleryController = new GalleryController(
            $galleryManager,
            $mediaManager,
            $formFactory,
            'Sonata\MediaBundle\Tests\Controller\Api\GalleryTest'
        );
        $view = $galleryController->postGalleryMediaGalleryItemAction(1, 2, new Request());

        $this->assertInstanceOf('FOS\RestBundle\View\View', $view);
        $this->assertSame(200, $view->getResponse()->getStatusCode(), 'Should return 200');
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
    }

    public function testPostGalleryMediaGalleryItemInvalidAction()
    {
        $media = $this->getMock('Sonata\MediaBundle\Model\MediaInterface');

        $media->expects($this->any())->method('getId')->will($this->returnValue(1));

        $galleryItem = $this->getMock('Sonata\MediaBundle\Model\GalleryItemInterface');

        $galleryItem->expects($this->once())->method('getMedia')->will($this->returnValue($media));

        $gallery = $this->getMock('Sonata\MediaBundle\Model\GalleryInterface');

        $gallery->expects($this->once())->method('getGalleryItems')->will($this->returnValue(array($galleryItem)));

        $galleryManager = $this->getMock('Sonata\MediaBundle\Model\GalleryManagerInterface');

        $galleryManager->expects($this->once())->method('findOneBy')->will($this->returnValue($gallery));

        $mediaManager = $this->getMock('Sonata\MediaBundle\Model\MediaManagerInterface');

        $mediaManager->expects($this->once())->method('findOneBy')->will($this->returnValue($media));

        $formFactory = $this->getMock('Symfony\Component\Form\FormFactoryInterface');


        $galleryController = new GalleryController(
            $galleryManager,
            $mediaManager,
            $formFactory,
            'Sonata\MediaBundle\Tests\Controller\Api\GalleryTest'
        );
        $view = $galleryController->postGalleryMediaGalleryItemAction(1, 1, new Request());

        $this->assertInstanceOf('FOS\RestBundle\View\View', $view);
        $this->assertSame(400, $view->getResponse()->getStatusCode(), 'Should return 400');
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
    }

    public function testPutGalleryMediaGalleryItemAction()
    {
        $media = $this->getMock('Sonata\MediaBundle\Model\MediaInterface');

        $media->expects($this->any())->method('getId')->will($this->returnValue(1));

        $galleryItem = $this->getMock('Sonata\MediaBundle\Model\GalleryItemInterface');

        $galleryItem->expects($this->once())->method('getMedia')->will($this->returnValue($media));

        $gallery = $this->getMock('Sonata\MediaBundle\Model\GalleryInterface');

        $gallery->expects($this->once())->method('getGalleryItems')->will($this->returnValue(array($galleryItem)));

        $galleryManager = $this->getMock('Sonata\MediaBundle\Model\GalleryManagerInterface');

        $galleryManager->expects($this->once())->method('findOneBy')->will($this->returnValue($gallery));

        $mediaManager = $this->getMock('Sonata\MediaBundle\Model\MediaManagerInterface');

        $mediaManager->expects($this->once())->method('findOneBy')->will($this->returnValue($media));

        $form = $this->getMockBuilder('Symfony\Component\Form\Form')->disableOriginalConstructor()->getMock();
        $form->expects($this->once())->method('handleRequest');
        $form->expects($this->once())->method('isValid')->will($this->returnValue(true));
        $form->expects($this->once())->method('getData')->will($this->returnValue($galleryItem));

        $formFactory = $this->getMock('Symfony\Component\Form\FormFactoryInterface');

        $formFactory->expects($this->once())->method('createNamed')->will($this->returnValue($form));

        $galleryController = new GalleryController(
            $galleryManager,
            $mediaManager,
            $formFactory,
            'Sonata\MediaBundle\Tests\Controller\Api\GalleryTest'
        );
        $view = $galleryController->putGalleryMediaGalleryItemAction(1, 1, new Request());

        $this->assertInstanceOf('FOS\RestBundle\View\View', $view);
        $this->assertSame(200, $view->getResponse()->getStatusCode(), 'Should return 200');

    }

    public function testPutGalleryMediaGalleryItemInvalidAction()
    {
        $media = $this->getMock('Sonata\MediaBundle\Model\MediaInterface');

        $media->expects($this->any())->method('getId')->will($this->returnValue(1));

        $galleryItem = $this->getMock('Sonata\MediaBundle\Model\GalleryItemInterface');

        $galleryItem->expects($this->once())->method('getMedia')->will($this->returnValue($media));

        $gallery = $this->getMock('Sonata\MediaBundle\Model\GalleryInterface');

        $gallery->expects($this->once())->method('getGalleryItems')->will($this->returnValue(array($galleryItem)));

        $galleryManager = $this->getMock('Sonata\MediaBundle\Model\GalleryManagerInterface');

        $galleryManager->expects($this->once())->method('findOneBy')->will($this->returnValue($gallery));

        $mediaManager = $this->getMock('Sonata\MediaBundle\Model\MediaManagerInterface');

        $mediaManager->expects($this->once())->method('findOneBy')->will($this->returnValue($media));

        $form = $this->getMockBuilder('Symfony\Component\Form\Form')->disableOriginalConstructor()->getMock();
        $form->expects($this->once())->method('handleRequest');
        $form->expects($this->once())->method('isValid')->will($this->returnValue(false));

        $formFactory = $this->getMock('Symfony\Component\Form\FormFactoryInterface');

        $formFactory->expects($this->once())->method('createNamed')->will($this->returnValue($form));

        $galleryController = new GalleryController(
            $galleryManager,
            $mediaManager,
            $formFactory,
            'Sonata\MediaBundle\Tests\Controller\Api\GalleryTest'
        );
        $view = $galleryController->putGalleryMediaGalleryItemAction(1, 1, new Request());

        $this->assertInstanceOf('Symfony\Component\Form\FormInterface', $view);
    }

    public function testDeleteGalleryMediaGalleryItemAction()
    {
        $media = $this->getMock('Sonata\MediaBundle\Model\MediaInterface');

        $media->expects($this->any())->method('getId')->will($this->returnValue(1));

        $galleryItem = $this->getMock('Sonata\MediaBundle\Model\GalleryItemInterface');

        $galleryItem->expects($this->once())->method('getMedia')->will($this->returnValue($media));

        $gallery = $this->getMock('Sonata\MediaBundle\Model\GalleryInterface');

        $gallery
            ->expects($this->any())
            ->method('getGalleryItems')
            ->will($this->returnValue(new ArrayCollection(array($galleryItem))));

        $galleryManager = $this->getMock('Sonata\MediaBundle\Model\GalleryManagerInterface');

        $galleryManager->expects($this->once())->method('findOneBy')->will($this->returnValue($gallery));

        $mediaManager = $this->getMock('Sonata\MediaBundle\Model\MediaManagerInterface');

        $mediaManager->expects($this->once())->method('findOneBy')->will($this->returnValue($media));

        $formFactory = $this->getMock('Symfony\Component\Form\FormFactoryInterface');


        $galleryController = new GalleryController(
            $galleryManager,
            $mediaManager,
            $formFactory,
            'Sonata\MediaBundle\Tests\Controller\Api\GalleryTest'
        );
        $view = $galleryController->deleteGalleryMediaGalleryItemAction(1, 1);

        $this->assertSame(array('deleted' => true), $view);
    }

    public function testDeleteGalleryMediaGalleryItemInvalidAction()
    {
        $media = $this->getMock('Sonata\MediaBundle\Model\MediaInterface');


        $media2 = $this->getMock('Sonata\MediaBundle\Model\MediaInterface');

        $media2->expects($this->any())->method('getId')->will($this->returnValue(2));

        $galleryItem = $this->getMock('Sonata\MediaBundle\Model\GalleryItemInterface');

        $galleryItem->expects($this->once())->method('getMedia')->will($this->returnValue($media2));

        $gallery = $this->getMock('Sonata\MediaBundle\Model\GalleryInterface');

        $gallery
            ->expects($this->any())
            ->method('getGalleryItems')
            ->will($this->returnValue(new ArrayCollection(array($galleryItem))));

        $galleryManager = $this->getMock('Sonata\MediaBundle\Model\GalleryManagerInterface');

        $galleryManager->expects($this->once())->method('findOneBy')->will($this->returnValue($gallery));

        $mediaManager = $this->getMock('Sonata\MediaBundle\Model\MediaManagerInterface');

        $mediaManager->expects($this->once())->method('findOneBy')->will($this->returnValue($media));

        $formFactory = $this->getMock('Symfony\Component\Form\FormFactoryInterface');


        $galleryController = new GalleryController(
            $galleryManager,
            $mediaManager,
            $formFactory,
            'Sonata\MediaBundle\Tests\Controller\Api\GalleryTest'
        );
        $view = $galleryController->deleteGalleryMediaGalleryItemAction(1, 1);

        $this->assertInstanceOf('FOS\RestBundle\View\View', $view);
        $this->assertSame(400, $view->getResponse()->getStatusCode(), 'Should return 400');
    }
}


Pull Request — master (#1175)

testDeleteGalleryMediaGalleryItemInvalidAction() B

Complexity

Size

Duplication

Importance

Available Fixes

Available Fixes

1			<?php
2
3			/*
4			* This file is part of the Sonata Project package.
5			*
6			* (c) Thomas Rabaix <[email protected]>
7			*
8			* For the full copyright and license information, please view the LICENSE
9			* file that was distributed with this source code.
10			*/
11
12			namespace Sonata\MediaBundle\Tests\Controller\Api;
13
14			use Doctrine\Common\Collections\ArrayCollection;
15			use Sonata\MediaBundle\Controller\Api\GalleryController;
16			use Sonata\MediaBundle\Model\GalleryItem;
17			use Symfony\Component\HttpFoundation\Request;
18
19			class GalleryTest extends GalleryItem
20			{
21			private $id;
22
23			public function __construct()
24			{
25			parent::__construct();
26			$this->id = rand();
27			}
28
29			public function getId()
30			{
31			return $this->id;
32			}
33			}
34
35			/**
36			* @author Hugo Briand <[email protected]>
37			*/
38			class GalleryControllerTest extends \PHPUnit_Framework_TestCase
			0 ignored issues – show Coding Style Compatibility introduced 2015-11-21 05:46 UTC by Report Bug Copy Issue Report PSR1 recommends that each class should be in its own file to aid autoloaders. Having each class in a dedicated file usually plays nice with PSR autoloaders and is therefore a well established practice. If you use other autoloaders, you might not want to follow this rule. Loading history...
39			{

sonata-project / SonataMediaBundle

Pull Request — master (#1175)

testDeleteGalleryMediaGalleryItemInvalidAction() B

Complexity

Size

Duplication

Importance

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like