| Conditions | 1 |
| Paths | 1 |
| Total Lines | 107 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 305 | private function addProvidersSection(ArrayNodeDefinition $node): void |
||
| 306 | { |
||
| 307 | $node |
||
| 308 | ->children() |
||
| 309 | ->arrayNode('providers') |
||
| 310 | ->addDefaultsIfNotSet() |
||
| 311 | ->children() |
||
| 312 | ->arrayNode('file') |
||
| 313 | ->addDefaultsIfNotSet() |
||
| 314 | ->children() |
||
| 315 | ->scalarNode('service')->defaultValue('sonata.media.provider.file')->end() |
||
| 316 | ->scalarNode('resizer')->defaultValue(false)->end() |
||
| 317 | ->scalarNode('filesystem')->defaultValue('sonata.media.filesystem.local')->end() |
||
| 318 | ->scalarNode('cdn')->defaultValue('sonata.media.cdn.server')->end() |
||
| 319 | ->scalarNode('generator')->defaultValue('sonata.media.generator.default')->end() |
||
| 320 | ->scalarNode('thumbnail')->defaultValue('sonata.media.thumbnail.format')->end() |
||
| 321 | ->arrayNode('allowed_extensions') |
||
| 322 | ->prototype('scalar')->end() |
||
| 323 | ->defaultValue([ |
||
| 324 | 'pdf', 'txt', 'rtf', |
||
| 325 | 'doc', 'docx', 'xls', 'xlsx', 'ppt', 'pptx', |
||
| 326 | 'odt', 'odg', 'odp', 'ods', 'odc', 'odf', 'odb', |
||
| 327 | 'csv', |
||
| 328 | 'xml', |
||
| 329 | ]) |
||
| 330 | ->end() |
||
| 331 | ->arrayNode('allowed_mime_types') |
||
| 332 | ->prototype('scalar')->end() |
||
| 333 | ->defaultValue([ |
||
| 334 | 'application/pdf', 'application/x-pdf', 'application/rtf', 'text/html', 'text/rtf', 'text/plain', |
||
| 335 | 'application/excel', 'application/msword', 'application/vnd.ms-excel', 'application/vnd.ms-powerpoint', |
||
| 336 | 'application/vnd.ms-powerpoint', 'application/vnd.oasis.opendocument.text', 'application/vnd.oasis.opendocument.graphics', 'application/vnd.oasis.opendocument.presentation', 'application/vnd.oasis.opendocument.spreadsheet', 'application/vnd.oasis.opendocument.chart', 'application/vnd.oasis.opendocument.formula', 'application/vnd.oasis.opendocument.database', 'application/vnd.oasis.opendocument.image', |
||
| 337 | 'text/comma-separated-values', |
||
| 338 | 'text/xml', 'application/xml', |
||
| 339 | 'application/zip', // seems to be used for xlsx document ... |
||
| 340 | ]) |
||
| 341 | ->end() |
||
| 342 | ->end() |
||
| 343 | ->end() |
||
| 344 | |||
| 345 | ->arrayNode('image') |
||
| 346 | ->addDefaultsIfNotSet() |
||
| 347 | ->children() |
||
| 348 | ->scalarNode('service')->defaultValue('sonata.media.provider.image')->end() |
||
| 349 | ->scalarNode('resizer')->defaultValue('sonata.media.resizer.default')->end() |
||
| 350 | ->scalarNode('filesystem')->defaultValue('sonata.media.filesystem.local')->end() |
||
| 351 | ->scalarNode('cdn')->defaultValue('sonata.media.cdn.server')->end() |
||
| 352 | ->scalarNode('generator')->defaultValue('sonata.media.generator.default')->end() |
||
| 353 | ->scalarNode('thumbnail')->defaultValue('sonata.media.thumbnail.format')->end() |
||
| 354 | ->scalarNode('adapter')->defaultValue('sonata.media.adapter.image.default')->end() |
||
| 355 | ->arrayNode('allowed_extensions') |
||
| 356 | ->prototype('scalar')->end() |
||
| 357 | ->defaultValue(['jpg', 'png', 'jpeg']) |
||
| 358 | ->end() |
||
| 359 | ->arrayNode('allowed_mime_types') |
||
| 360 | ->prototype('scalar')->end() |
||
| 361 | ->defaultValue([ |
||
| 362 | 'image/pjpeg', |
||
| 363 | 'image/jpeg', |
||
| 364 | 'image/png', |
||
| 365 | 'image/x-png', |
||
| 366 | ]) |
||
| 367 | ->end() |
||
| 368 | ->end() |
||
| 369 | ->end() |
||
| 370 | |||
| 371 | ->arrayNode('youtube') |
||
| 372 | ->addDefaultsIfNotSet() |
||
| 373 | ->children() |
||
| 374 | ->scalarNode('service')->defaultValue('sonata.media.provider.youtube')->end() |
||
| 375 | ->scalarNode('resizer')->defaultValue('sonata.media.resizer.default')->end() |
||
| 376 | ->scalarNode('filesystem')->defaultValue('sonata.media.filesystem.local')->end() |
||
| 377 | ->scalarNode('cdn')->defaultValue('sonata.media.cdn.server')->end() |
||
| 378 | ->scalarNode('generator')->defaultValue('sonata.media.generator.default')->end() |
||
| 379 | ->scalarNode('thumbnail')->defaultValue('sonata.media.thumbnail.format')->end() |
||
| 380 | ->scalarNode('html5')->defaultValue(false)->end() |
||
| 381 | ->end() |
||
| 382 | ->end() |
||
| 383 | |||
| 384 | ->arrayNode('dailymotion') |
||
| 385 | ->addDefaultsIfNotSet() |
||
| 386 | ->children() |
||
| 387 | ->scalarNode('service')->defaultValue('sonata.media.provider.dailymotion')->end() |
||
| 388 | ->scalarNode('resizer')->defaultValue('sonata.media.resizer.default')->end() |
||
| 389 | ->scalarNode('filesystem')->defaultValue('sonata.media.filesystem.local')->end() |
||
| 390 | ->scalarNode('cdn')->defaultValue('sonata.media.cdn.server')->end() |
||
| 391 | ->scalarNode('generator')->defaultValue('sonata.media.generator.default')->end() |
||
| 392 | ->scalarNode('thumbnail')->defaultValue('sonata.media.thumbnail.format')->end() |
||
| 393 | ->end() |
||
| 394 | ->end() |
||
| 395 | |||
| 396 | ->arrayNode('vimeo') |
||
| 397 | ->addDefaultsIfNotSet() |
||
| 398 | ->children() |
||
| 399 | ->scalarNode('service')->defaultValue('sonata.media.provider.vimeo')->end() |
||
| 400 | ->scalarNode('resizer')->defaultValue('sonata.media.resizer.default')->end() |
||
| 401 | ->scalarNode('filesystem')->defaultValue('sonata.media.filesystem.local')->end() |
||
| 402 | ->scalarNode('cdn')->defaultValue('sonata.media.cdn.server')->end() |
||
| 403 | ->scalarNode('generator')->defaultValue('sonata.media.generator.default')->end() |
||
| 404 | ->scalarNode('thumbnail')->defaultValue('sonata.media.thumbnail.format')->end() |
||
| 405 | ->end() |
||
| 406 | ->end() |
||
| 407 | ->end() |
||
| 408 | ->end() |
||
| 409 | ->end() |
||
| 410 | ; |
||
| 411 | } |
||
| 412 | |||
| 516 |
This check looks for parameters that are defined as one type in their type hint or doc comment but seem to be used as a narrower type, i.e an implementation of an interface or a subclass.
Consider changing the type of the parameter or doing an instanceof check before assuming your parameter is of the expected type.