Sonata\MediaBundle\Thumbnail\LiipImagineThumbnail

Complexity

Total Complexity

12

Size/Duplication

Total Lines	73
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	4

Importance

Changes

0

5 Methods

Rating	Name	Duplication	Size	Complexity
B	generatePublicUrl()	0	21	6
A	__construct()	0	12	2
A	generatePrivateUrl()	0	10	2
A	generate()	0	4	1
A	delete()	0	4	1

<?php

declare(strict_types=1);

/*
 * This file is part of the Sonata Project package.
 *
 * (c) Thomas Rabaix <thomas.rabaix@sonata-project.org>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Sonata\MediaBundle\Thumbnail;

use Liip\ImagineBundle\Imagine\Cache\CacheManager;
use Sonata\MediaBundle\Model\MediaInterface;
use Sonata\MediaBundle\Provider\MediaProviderInterface;
use Symfony\Component\Routing\RouterInterface;

/**
 * @final since sonata-project/media-bundle 3.21.0
 */
class LiipImagineThumbnail implements ThumbnailInterface
{
    /**
     * @deprecated since sonata-project/media-bundle 3.3, will be removed in 4.0.
     *
     * @var RouterInterface
     */
    protected $router;

    /**
     * @var CacheManager
     */
    private $cacheManager;

    /**
     * @param RouterInterface|CacheManager $cacheManager
     */
    public function __construct($cacheManager)
    {
        if ($cacheManager instanceof RouterInterface) {
            @trigger_error(sprintf(

It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended.

                'Using an instance of %s is deprecated since version 3.3 and will be removed in 4.0. Use %s.',
                RouterInterface::class,
                CacheManager::class
            ), E_USER_DEPRECATED);
            $this->router = $cacheManager;

The property Sonata\MediaBundle\Thumbnail\LiipImagineThumbnail::$router has been deprecated with message: since sonata-project/media-bundle 3.3, will be removed in 4.0.

        }
        $this->cacheManager = $cacheManager;

It seems like $cacheManager can also be of type object<Symfony\Component\Routing\RouterInterface>. However, the property $cacheManager is declared as type object<Liip\ImagineBundle\Imagine\Cache\CacheManager>. Maybe add an additional type check?

    }

    public function generatePublicUrl(MediaProviderInterface $provider, MediaInterface $media, $format)
    {
        $path = $provider->getReferenceImage($media);

        if (MediaProviderInterface::FORMAT_ADMIN === $format || MediaProviderInterface::FORMAT_REFERENCE === $format) {
            return $path;
        }
        if ($this->router instanceof RouterInterface && !($this->cacheManager instanceof CacheManager)) {

The property Sonata\MediaBundle\Thumbnail\LiipImagineThumbnail::$router has been deprecated with message: since sonata-project/media-bundle 3.3, will be removed in 4.0.

            $path = $this->router->generate(

The property Sonata\MediaBundle\Thumbnail\LiipImagineThumbnail::$router has been deprecated with message: since sonata-project/media-bundle 3.3, will be removed in 4.0.

                sprintf('_imagine_%s', $format),
                ['path' => sprintf('%s/%s_%s.jpg', $provider->generatePath($media), $media->getId(), $format)]
            );
        }

        $path = $provider->getCdnPath($path, $media->getCdnIsFlushable());
        if ($this->cacheManager instanceof CacheManager) {
            $path = $this->cacheManager->getBrowserPath($path, $format);
        }

        return $path;
    }

    public function generatePrivateUrl(MediaProviderInterface $provider, MediaInterface $media, $format)
    {
        if (MediaProviderInterface::FORMAT_REFERENCE !== $format) {
            throw new \RuntimeException('No private url for LiipImagineThumbnail');
        }

        $path = $provider->getReferenceImage($media);

        return $path;
    }

    public function generate(MediaProviderInterface $provider, MediaInterface $media): void
    {
        // nothing to generate, as generated on demand
    }

    public function delete(MediaProviderInterface $provider, MediaInterface $media, $formats = null): void
    {
        // feature not available
    }
}