ShowBuilder::fixFieldDescription() - Code Metrics - Inspection of "Webtests" - sonata-project/SonataDoctrinePhpcrAdminBundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#485)

by Maximilian

created 2017-08-16 06:04 UTC

ShowBuilder::fixFieldDescription() C

↳ Parent: ShowBuilder

Complexity

Conditions	11
Paths	55

Size

Total Lines	52
Code Lines	28

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	52
rs	5.9999
c	0
b	0
f	0
cc	11
eloc	28
nc	55
nop	2

How to fix Long Method Complexity

<?php

/*
 * This file is part of the Sonata Project package.
 *
 * (c) Thomas Rabaix <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Sonata\DoctrinePHPCRAdminBundle\Builder;

use Doctrine\ODM\PHPCR\Mapping\ClassMetadata;
use Sonata\AdminBundle\Admin\AdminInterface;
use Sonata\AdminBundle\Admin\FieldDescriptionCollection;
use Sonata\AdminBundle\Admin\FieldDescriptionInterface;
use Sonata\AdminBundle\Builder\ShowBuilderInterface;
use Sonata\AdminBundle\Guesser\TypeGuesserInterface;

class ShowBuilder implements ShowBuilderInterface
{
    /**
     * @var TypeGuesserInterface
     */
    protected $guesser;

    /**
     * @var array
     */
    protected $templates;

    /**
     * @param TypeGuesserInterface $guesser
     * @param array                $templates Indexed by field type
     */
    public function __construct(TypeGuesserInterface $guesser, array $templates)
    {
        $this->guesser = $guesser;
        $this->templates = $templates;
    }

    /**
     * {@inheritdoc}
     */
    public function getBaseList(array $options = array())
    {
        return new FieldDescriptionCollection();
    }

    /**
     * {@inheritdoc}
     */
    public function addField(FieldDescriptionCollection $list, $type, FieldDescriptionInterface $fieldDescription, AdminInterface $admin)
    {
        if ($type == null) {

            $guessType = $this->guesser->guessType($admin->getClass(), $fieldDescription->getName(), $admin->getModelManager());
            $fieldDescription->setType($guessType->getType());
        } else {
            $fieldDescription->setType($type);
        }

        $this->fixFieldDescription($admin, $fieldDescription);
        $admin->addShowFieldDescription($fieldDescription->getName(), $fieldDescription);

        $list->add($fieldDescription);
    }

    /**
     * The method defines the correct default settings for the provided FieldDescription.
     *
     * {@inheritdoc}
     *
     * @throws \RuntimeException if the $fieldDescription does not have a type
     */
    public function fixFieldDescription(AdminInterface $admin, FieldDescriptionInterface $fieldDescription)
    {
        $fieldDescription->setAdmin($admin);

        $metadata = null;
        if ($admin->getModelManager()->hasMetadata($admin->getClass())) {
            /** @var ClassMetadata $metadata */
            $metadata = $admin->getModelManager()->getMetadata($admin->getClass());

            // set the default field mapping
            if (isset($metadata->mappings[$fieldDescription->getName()])) {
                $fieldDescription->setFieldMapping($metadata->mappings[$fieldDescription->getName()]);
            }

            // set the default association mapping
            if ($metadata->hasAssociation($fieldDescription->getName())) {
                $fieldDescription->setAssociationMapping($metadata->getAssociation($fieldDescription->getName()));
            }
        }

        if (!$fieldDescription->getType()) {
            throw new \RuntimeException(sprintf('Please define a type for field `%s` in `%s`', $fieldDescription->getName(), get_class($admin)));
        }

        $fieldDescription->setOption('code', $fieldDescription->getOption('code', $fieldDescription->getName()));
        $fieldDescription->setOption('label', $fieldDescription->getOption('label', $fieldDescription->getName()));

        if (!$fieldDescription->getTemplate()) {
            $fieldDescription->setTemplate($this->getTemplate($fieldDescription->getType()));

            if ($fieldDescription->getMappingType() == ClassMetadata::MANY_TO_ONE) {
                $fieldDescription->setTemplate('SonataAdminBundle:CRUD/Association:show_many_to_one.html.twig');
            }

            if ($fieldDescription->getMappingType() == ClassMetadata::MANY_TO_MANY) {
                $fieldDescription->setTemplate('SonataAdminBundle:CRUD/Association:show_many_to_many.html.twig');
            }
        }

        $mappingTypes = array(
            ClassMetadata::MANY_TO_ONE,
            ClassMetadata::MANY_TO_MANY,
            'children',
            'child',
            'parent',
            'referrers',
        );

        if ($metadata && $metadata->hasAssociation($fieldDescription->getName()) && in_array($fieldDescription->getMappingType(), $mappingTypes)) {
            $admin->attachAdminClass($fieldDescription);
        }
    }

    /**
     * @param string $type
     *
     * @return string|null The template if found
     */
    private function getTemplate($type)
    {
        if (!isset($this->templates[$type])) {
            return;
        }

        return $this->templates[$type];
    }
}


1			<?php
2
3			/*
4			* This file is part of the Sonata Project package.
5			*
6			* (c) Thomas Rabaix <[email protected]>
7			*
8			* For the full copyright and license information, please view the LICENSE
9			* file that was distributed with this source code.
10			*/
11
12			namespace Sonata\DoctrinePHPCRAdminBundle\Builder;
13
14			use Doctrine\ODM\PHPCR\Mapping\ClassMetadata;
15			use Sonata\AdminBundle\Admin\AdminInterface;
16			use Sonata\AdminBundle\Admin\FieldDescriptionCollection;
17			use Sonata\AdminBundle\Admin\FieldDescriptionInterface;
18			use Sonata\AdminBundle\Builder\ShowBuilderInterface;
19			use Sonata\AdminBundle\Guesser\TypeGuesserInterface;
20
21			class ShowBuilder implements ShowBuilderInterface
22			{
23			/**
24			* @var TypeGuesserInterface
25			*/
26			protected $guesser;
27
28			/**
29			* @var array
30			*/
31			protected $templates;
32
33			/**
34			* @param TypeGuesserInterface $guesser
35			* @param array $templates Indexed by field type
36			*/
37			public function __construct(TypeGuesserInterface $guesser, array $templates)
38			{
39			$this->guesser = $guesser;
40			$this->templates = $templates;
41			}
42
43			/**
44			* {@inheritdoc}
45			*/
46			public function getBaseList(array $options = array())
47			{
48			return new FieldDescriptionCollection();
49			}
50
51			/**
52			* {@inheritdoc}
53			*/
54			public function addField(FieldDescriptionCollection $list, $type, FieldDescriptionInterface $fieldDescription, AdminInterface $admin)
55			{
56			if ($type == null) {
			0 ignored issues – show Bug introduced 2015-12-06 00:13 UTC by Report Bug Copy Issue Report It seems like you are loosely comparing `$type` of type `string\|null` against `null`; this is ambiguous if the string can be empty. Consider using a strict comparison `===` instead. Loading history...
57			$guessType = $this->guesser->guessType($admin->getClass(), $fieldDescription->getName(), $admin->getModelManager());
58			$fieldDescription->setType($guessType->getType());
59			} else {
60			$fieldDescription->setType($type);
61			}
62
63			$this->fixFieldDescription($admin, $fieldDescription);
64			$admin->addShowFieldDescription($fieldDescription->getName(), $fieldDescription);
65
66			$list->add($fieldDescription);
67			}
68
69			/**
70			* The method defines the correct default settings for the provided FieldDescription.
71			*
72			* {@inheritdoc}
73			*
74			* @throws \RuntimeException if the $fieldDescription does not have a type
75			*/
76			public function fixFieldDescription(AdminInterface $admin, FieldDescriptionInterface $fieldDescription)
77			{
78			$fieldDescription->setAdmin($admin);
79
80			$metadata = null;
81			if ($admin->getModelManager()->hasMetadata($admin->getClass())) {
82			/** @var ClassMetadata $metadata */
83			$metadata = $admin->getModelManager()->getMetadata($admin->getClass());
84
85			// set the default field mapping
86			if (isset($metadata->mappings[$fieldDescription->getName()])) {
87			$fieldDescription->setFieldMapping($metadata->mappings[$fieldDescription->getName()]);
88			}
89
90			// set the default association mapping
91			if ($metadata->hasAssociation($fieldDescription->getName())) {
92			$fieldDescription->setAssociationMapping($metadata->getAssociation($fieldDescription->getName()));
93			}
94			}
95
96			if (!$fieldDescription->getType()) {
97			throw new \RuntimeException(sprintf('Please define a type for field `%s` in `%s`', $fieldDescription->getName(), get_class($admin)));
98			}
99
100			$fieldDescription->setOption('code', $fieldDescription->getOption('code', $fieldDescription->getName()));
101			$fieldDescription->setOption('label', $fieldDescription->getOption('label', $fieldDescription->getName()));
102
103			if (!$fieldDescription->getTemplate()) {
104			$fieldDescription->setTemplate($this->getTemplate($fieldDescription->getType()));
105
106			if ($fieldDescription->getMappingType() == ClassMetadata::MANY_TO_ONE) {
107			$fieldDescription->setTemplate('SonataAdminBundle:CRUD/Association:show_many_to_one.html.twig');
108			}
109
110			if ($fieldDescription->getMappingType() == ClassMetadata::MANY_TO_MANY) {
111			$fieldDescription->setTemplate('SonataAdminBundle:CRUD/Association:show_many_to_many.html.twig');
112			}
113			}
114
115			$mappingTypes = array(
116			ClassMetadata::MANY_TO_ONE,
117			ClassMetadata::MANY_TO_MANY,
118			'children',
119			'child',
120			'parent',
121			'referrers',
122			);
123
124			if ($metadata && $metadata->hasAssociation($fieldDescription->getName()) && in_array($fieldDescription->getMappingType(), $mappingTypes)) {
125			$admin->attachAdminClass($fieldDescription);
126			}
127			}
128
129			/**
130			* @param string $type
131			*
132			* @return string\|null The template if found
133			*/
134			private function getTemplate($type)
135			{
136			if (!isset($this->templates[$type])) {
137			return;
138			}
139
140			return $this->templates[$type];
141			}
142			}
143

sonata-project / SonataDoctrinePhpcrAdminBundle

Pull Request — master (#485)

ShowBuilder::fixFieldDescription() C

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

Duplication Side-by-Side

Filter issues like