ContentAdmin::configureFormFields() - Code Metrics - Inspection of "Manual merge" - sonata-project/SonataDoctrinePhpcrAdminBundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#548)

by Grégoire

created 2019-02-02 12:12 UTC

ContentAdmin::configureFormFields() B

↳ Parent: ContentAdmin

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	66
rs	8.7418
c	0
b	0
f	0
cc	1
nc	1
nop	1

How to fix Long Method

<?php

declare(strict_types=1);

/*
 * This file is part of the Sonata Project package.
 *
 * (c) Thomas Rabaix <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Sonata\DoctrinePHPCRAdminBundle\Tests\Fixtures\App\Admin;

use Doctrine\Bundle\PHPCRBundle\Form\DataTransformer\DocumentToPathTransformer;
use Doctrine\Common\Persistence\ManagerRegistry;
use Sonata\AdminBundle\Datagrid\DatagridMapper;
use Sonata\AdminBundle\Datagrid\ListMapper;
use Sonata\AdminBundle\Form\FormMapper;
use Sonata\AdminBundle\Form\Type\ModelType;
use Sonata\AdminBundle\Show\ShowMapper;
use Sonata\DoctrinePHPCRAdminBundle\Filter\NodeNameFilter;
use Sonata\DoctrinePHPCRAdminBundle\Filter\StringFilter;
use Symfony\Component\Form\Extension\Core\Type\CheckboxType;
use Sonata\CoreBundle\Form\Type\CollectionType;
use Sonata\DoctrinePHPCRAdminBundle\Admin\Admin;
use Sonata\DoctrinePHPCRAdminBundle\Tests\Fixtures\App\Document\Content;
use Symfony\Component\Form\Extension\Core\Type\TextType;
use Symfony\Cmf\Bundle\TreeBrowserBundle\Form\Type\TreeSelectType;

/**
 * @author Maximilian Berghoff <[email protected]>
 */
class ContentAdmin extends Admin
{
    /**
     * @var ManagerRegistry
     */
    private $managerRegistry;

    public function setManagerRegistry(ManagerRegistry $managerRegistry)
    {
        $this->managerRegistry = $managerRegistry;
    }

    public function getExportFormats()
    {
        return [];
    }

    public function toString($object)
    {
        return $object instanceof Content && $object->getTitle()
            ? $object->getTitle()
            : $this->trans('link_add', [], 'SonataAdminBundle');
    }

    public function configureShowFields(ShowMapper $showMapper)
    {
        $showMapper
            ->tab('General')// the tab call is optional
            ->with(
                'Content',
                [
                    'class' => 'col-md-8',
                    'box_class' => 'box box-solid box-danger',
                    'description' => 'Main Content',
                ]
            )
            ->add('title')
            ->add('name')
            ->end()
            ->with('References')
            ->add(
                'children',
                null,
                [
                    'route' => ['name' => 'edit', 'parameters' => []],
                    'associated_property' => 'id',
                    'admin_code' => 'sonata_admin_doctrine_phpcr.test.admin',
                ]
            )
            ->add(
                'child',
                null,
                [
                    'route' => ['name' => 'edit', 'parameters' => []],
                    'associated_property' => 'id',
                    'admin_code' => 'sonata_admin_doctrine_phpcr.test.admin',
                ]
            )
            ->add(
                'singleRoute',
                null,
                ['route' => ['name' => 'edit', 'parameters' => []], 'associated_property' => 'id']
            )
            ->add(
                'routes',
                null,
                ['route' => ['name' => 'edit', 'parameters' => []], 'associated_property' => 'id']
            )
            ->end()
            ->end();
    }

    protected function configureListFields(ListMapper $listMapper)
    {
        $listMapper
            ->addIdentifier('id')
            ->add('title');
    }

    protected function configureFormFields(FormMapper $formMapper)
    {
        $formMapper
            ->with('form.group_general')
            ->add('name', TextType::class)
            ->add('title', TextType::class)
            ->add(
                'children',
                CollectionType::class,
                [
                    'label' => false, 'type_options' => [
                    'delete' => true,
                    'delete_options' => [
                        'type' => CheckboxType::class,
                        'type_options' => ['required' => false, 'mapped' => false],
                    ],
                ],
                ],
                ['edit' => 'inline', 'inline' => 'table', 'admin_code' => 'sonata_admin_doctrine_phpcr.test.admin']
            )
            ->add(
                'routes',
                ModelType::class,
                ['property' => 'title', 'multiple' => true, 'expanded' => false]
            )
            ->add(
                'parentDocument',
                TreeSelectType::class,
                [
                    'widget' => 'browser',
                    'root_node' => $this->getRootPath(),
                ]
            )
            ->add(
                'child',
                ModelType::class,
                [
                    'property' => 'title',
                    'class' => Content::class,
                    'btn_catalogue' => 'List',
                    'required' => false,
                ],
                ['admin_code' => 'sonata_admin_doctrine_phpcr.test.admin']
            )
            ->add(
                'singleRoute',
                TreeSelectType::class,
                [
                    'widget' => 'browser',
                    'root_node' => $this->getRootPath(),
                ]
            )
            ->end();

        $formMapper->getFormBuilder()->get('parentDocument')->addModelTransformer(
            new DocumentToPathTransformer(
                $this->managerRegistry->getManagerForClass($this->getClass())
            )
        );

        $formMapper->getFormBuilder()->get('singleRoute')->addModelTransformer(
            new DocumentToPathTransformer(
                $this->managerRegistry->getManagerForClass($this->getClass())
            )
        );
    }

    protected function configureDatagridFilters(DatagridMapper $datagridMapper)
    {
        $datagridMapper
            ->add('title', StringFilter::class)
            ->add('name', NodeNameFilter::class);
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			/*
6			* This file is part of the Sonata Project package.
7			*
8			* (c) Thomas Rabaix <[email protected]>
9			*
10			* For the full copyright and license information, please view the LICENSE
11			* file that was distributed with this source code.
12			*/
13
14			namespace Sonata\DoctrinePHPCRAdminBundle\Tests\Fixtures\App\Admin;
15
16			use Doctrine\Bundle\PHPCRBundle\Form\DataTransformer\DocumentToPathTransformer;
17			use Doctrine\Common\Persistence\ManagerRegistry;
18			use Sonata\AdminBundle\Datagrid\DatagridMapper;
19			use Sonata\AdminBundle\Datagrid\ListMapper;
20			use Sonata\AdminBundle\Form\FormMapper;
21			use Sonata\AdminBundle\Form\Type\ModelType;
22			use Sonata\AdminBundle\Show\ShowMapper;
23			use Sonata\DoctrinePHPCRAdminBundle\Filter\NodeNameFilter;
24			use Sonata\DoctrinePHPCRAdminBundle\Filter\StringFilter;
25			use Symfony\Component\Form\Extension\Core\Type\CheckboxType;
26			use Sonata\CoreBundle\Form\Type\CollectionType;
27			use Sonata\DoctrinePHPCRAdminBundle\Admin\Admin;
28			use Sonata\DoctrinePHPCRAdminBundle\Tests\Fixtures\App\Document\Content;
29			use Symfony\Component\Form\Extension\Core\Type\TextType;
30			use Symfony\Cmf\Bundle\TreeBrowserBundle\Form\Type\TreeSelectType;
31
32			/**
33			* @author Maximilian Berghoff <[email protected]>
34			*/
35			class ContentAdmin extends Admin
36			{
37			/**
38			* @var ManagerRegistry
39			*/
40			private $managerRegistry;
41
42			public function setManagerRegistry(ManagerRegistry $managerRegistry)
43			{
44			$this->managerRegistry = $managerRegistry;
45			}
46
47			public function getExportFormats()
48			{
49			return [];
50			}
51
52			public function toString($object)
53			{
54			return $object instanceof Content && $object->getTitle()
55			? $object->getTitle()
56			: $this->trans('link_add', [], 'SonataAdminBundle');
57			}
58
59			public function configureShowFields(ShowMapper $showMapper)
60			{
61			$showMapper
62			->tab('General')// the tab call is optional
63			->with(
64			'Content',
65			[
66			'class' => 'col-md-8',
67			'box_class' => 'box box-solid box-danger',
68			'description' => 'Main Content',
69			]
70			)
71			->add('title')
72			->add('name')
73			->end()
74			->with('References')
75			->add(
76			'children',
77			null,
78			[
79			'route' => ['name' => 'edit', 'parameters' => []],
80			'associated_property' => 'id',
81			'admin_code' => 'sonata_admin_doctrine_phpcr.test.admin',
82			]
83			)
84			->add(
85			'child',
86			null,
87			[
88			'route' => ['name' => 'edit', 'parameters' => []],
89			'associated_property' => 'id',
90			'admin_code' => 'sonata_admin_doctrine_phpcr.test.admin',
91			]
92			)
93			->add(
94			'singleRoute',
95			null,
96			['route' => ['name' => 'edit', 'parameters' => []], 'associated_property' => 'id']
97			)
98			->add(
99			'routes',
100			null,
101			['route' => ['name' => 'edit', 'parameters' => []], 'associated_property' => 'id']
102			)
103			->end()
104			->end();
105			}
106
107			protected function configureListFields(ListMapper $listMapper)
108			{
109			$listMapper
110			->addIdentifier('id')
111			->add('title');
112			}
113
114			protected function configureFormFields(FormMapper $formMapper)
115			{
116			$formMapper
117			->with('form.group_general')
118			->add('name', TextType::class)
119			->add('title', TextType::class)
120			->add(
121			'children',
122			CollectionType::class,
123			[
124			'label' => false, 'type_options' => [
125			'delete' => true,
126			'delete_options' => [
127			'type' => CheckboxType::class,
128			'type_options' => ['required' => false, 'mapped' => false],
129			],
130			],
131			],
132			['edit' => 'inline', 'inline' => 'table', 'admin_code' => 'sonata_admin_doctrine_phpcr.test.admin']
133			)
134			->add(
135			'routes',
136			ModelType::class,
137			['property' => 'title', 'multiple' => true, 'expanded' => false]
138			)
139			->add(
140			'parentDocument',
141			TreeSelectType::class,
142			[
143			'widget' => 'browser',
144			'root_node' => $this->getRootPath(),
145			]
146			)
147			->add(
148			'child',
149			ModelType::class,
150			[
151			'property' => 'title',
152			'class' => Content::class,
153			'btn_catalogue' => 'List',
154			'required' => false,
155			],
156			['admin_code' => 'sonata_admin_doctrine_phpcr.test.admin']
157			)
158			->add(
159			'singleRoute',
160			TreeSelectType::class,
161			[
162			'widget' => 'browser',
163			'root_node' => $this->getRootPath(),
164			]
165			)
166			->end();
167
168			$formMapper->getFormBuilder()->get('parentDocument')->addModelTransformer(
169			new DocumentToPathTransformer(
170			$this->managerRegistry->getManagerForClass($this->getClass())
171			)
172			);
173
174			$formMapper->getFormBuilder()->get('singleRoute')->addModelTransformer(
175			new DocumentToPathTransformer(
176			$this->managerRegistry->getManagerForClass($this->getClass())
177			)
178			);
179			}
180
181			protected function configureDatagridFilters(DatagridMapper $datagridMapper)
182			{
183			$datagridMapper
184			->add('title', StringFilter::class)
185			->add('name', NodeNameFilter::class);
186			}
187			}
188

sonata-project / SonataDoctrinePhpcrAdminBundle

Pull Request — master (#548)

ContentAdmin::configureFormFields() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like