Issues in TreeController.php - All Issues - Inspection of "Merge pull request #473 from sonata-project/fix_te..." - sonata-project/SonataDoctrinePhpcrAdminBundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( a33308...36ba79 )

by Maximilian

created 2017-07-28 13:21 UTC

src/Controller/TreeController.php (1 issue)

Showing only issues like (Show All)

Check for loose comparison of strings.

Best Practice Bug Major

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

/*
 * This file is part of the Sonata Project package.
 *
 * (c) Thomas Rabaix <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Sonata\DoctrinePHPCRAdminBundle\Controller;

use Doctrine\Bundle\PHPCRBundle\ManagerRegistry;
use PHPCR\Util\PathHelper;
use Symfony\Bundle\FrameworkBundle\Controller\Controller;
use Symfony\Component\HttpFoundation\JsonResponse;
use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\HttpFoundation\Response;

/**
 * A controller to render the tree block.
 */
class TreeController extends Controller
{
    /**
     * @var string
     */
    private $template = 'SonataDoctrinePHPCRAdminBundle:Tree:tree.html.twig';

    /**
     * @var \PHPCR\SessionInterface
     */
    private $session;
    /**
     * @var array
     */
    private $treeConfiguration;

    /**
     * @param ManagerRegistry $manager
     * @param string          $sessionName
     * @param array           $treeConfiguration     same structure as defined in Configuration
     * @param string          $defaultRepositoryName The name of the default resource repository
     * @param string          $template
     */
    public function __construct(
        ManagerRegistry $manager,
        $sessionName,
        array $treeConfiguration,
        $defaultRepositoryName,
        $template = null
    ) {
        if ($template) {
''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
            $this->template = $template;
        }

        $this->session = $manager->getConnection($sessionName);
        if (null === $treeConfiguration['repository_name']) {
            $treeConfiguration['repository_name'] = $defaultRepositoryName;
        }
        $this->treeConfiguration = $treeConfiguration;
    }

    /**
     * Renders a tree, passing the routes for each of the admin types (document types)
     * to the view.
     *
     * @param Request $request
     *
     * @return Response
     */
    public function treeAction(Request $request)
    {
        $root = $request->attributes->get('root');

        return $this->render($this->template, array(
            'root_node' => $root,
            'routing_defaults' => $this->treeConfiguration['routing_defaults'],
            'repository_name' => $this->treeConfiguration['repository_name'],
            'reorder' => $this->treeConfiguration['reorder'],
            'move' => $this->treeConfiguration['move'],
            'sortable_by' => $this->treeConfiguration['sortable_by'],
        ));
    }

    /**
     * Reorder $moved (child of $parent) before or after $target.
     *
     * @param Request $request
     *
     * @return Response
     */
    public function reorderAction(Request $request)
    {
        $parentPath = $request->get('parent');
        $dropedAtPath = $request->get('dropped');
        $targetPath = $request->get('target');
        $position = $request->get('position');

        if (null === $parentPath || null === $dropedAtPath || null === $targetPath) {
            return new JsonResponse(array('Parameters parent, dropped and target has to be set to reorder.'), Response::HTTP_BAD_REQUEST);
        }

        $before = 'before' == $position;
        $parentNode = $this->session->getNode($parentPath);
        $targetName = PathHelper::getNodeName($targetPath);
        if (!$before) {
            $nodesIterator = $parentNode->getNodes();
            $nodesIterator->rewind();
            while ($nodesIterator->valid()) {
                if ($nodesIterator->key() == $targetName) {
                    break;
                }
                $nodesIterator->next();
            }
            $targetName = null;
            if ($nodesIterator->valid()) {
                $nodesIterator->next();
                if ($nodesIterator->valid()) {
                    $targetName = $nodesIterator->key();
                }
            }
        }
        $parentNode->orderBefore($targetName, PathHelper::getNodeName($dropedAtPath));
        $this->session->save();

        return new Response('', Response::HTTP_NO_CONTENT);
    }
}


1			<?php
2
3			/*
4			* This file is part of the Sonata Project package.
5			*
6			* (c) Thomas Rabaix <[email protected]>
7			*
8			* For the full copyright and license information, please view the LICENSE
9			* file that was distributed with this source code.
10			*/
11
12			namespace Sonata\DoctrinePHPCRAdminBundle\Controller;
13
14			use Doctrine\Bundle\PHPCRBundle\ManagerRegistry;
15			use PHPCR\Util\PathHelper;
16			use Symfony\Bundle\FrameworkBundle\Controller\Controller;
17			use Symfony\Component\HttpFoundation\JsonResponse;
18			use Symfony\Component\HttpFoundation\Request;
19			use Symfony\Component\HttpFoundation\Response;
20
21			/**
22			* A controller to render the tree block.
23			*/
24			class TreeController extends Controller
25			{
26			/**
27			* @var string
28			*/
29			private $template = 'SonataDoctrinePHPCRAdminBundle:Tree:tree.html.twig';
30
31			/**
32			* @var \PHPCR\SessionInterface
33			*/
34			private $session;
35			/**
36			* @var array
37			*/
38			private $treeConfiguration;
39
40			/**
41			* @param ManagerRegistry $manager
42			* @param string $sessionName
43			* @param array $treeConfiguration same structure as defined in Configuration
44			* @param string $defaultRepositoryName The name of the default resource repository
45			* @param string $template
46			*/
47			public function __construct(
48			ManagerRegistry $manager,
49			$sessionName,
50			array $treeConfiguration,
51			$defaultRepositoryName,
52			$template = null
53			) {
54			if ($template) {
			0 ignored issues – show Bug Best Practice introduced 2017-07-27 06:24 UTC by Report Bug Copy Issue Report Show Similar Issues like this The expression `$template` of type `string\|null` is loosely compared to `true`; this is ambiguous if the string can be empty. You might want to explicitly use `!== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `string` values, the empty string `''` is a special case, in particular the following results might be unexpected: '' == false // true '' == null // true 'ab' == false // false 'ab' == null // false // It is often better to use strict comparison '' === false // false '' === null // false Loading history...
55			$this->template = $template;
56			}
57
58			$this->session = $manager->getConnection($sessionName);
59			if (null === $treeConfiguration['repository_name']) {
60			$treeConfiguration['repository_name'] = $defaultRepositoryName;
61			}
62			$this->treeConfiguration = $treeConfiguration;
63			}
64
65			/**
66			* Renders a tree, passing the routes for each of the admin types (document types)
67			* to the view.
68			*
69			* @param Request $request
70			*
71			* @return Response
72			*/
73			public function treeAction(Request $request)
74			{
75			$root = $request->attributes->get('root');
76
77			return $this->render($this->template, array(
78			'root_node' => $root,
79			'routing_defaults' => $this->treeConfiguration['routing_defaults'],
80			'repository_name' => $this->treeConfiguration['repository_name'],
81			'reorder' => $this->treeConfiguration['reorder'],
82			'move' => $this->treeConfiguration['move'],
83			'sortable_by' => $this->treeConfiguration['sortable_by'],
84			));
85			}
86
87			/**
88			* Reorder $moved (child of $parent) before or after $target.
89			*
90			* @param Request $request
91			*
92			* @return Response
93			*/
94			public function reorderAction(Request $request)
95			{
96			$parentPath = $request->get('parent');
97			$dropedAtPath = $request->get('dropped');
98			$targetPath = $request->get('target');
99			$position = $request->get('position');
100
101			if (null === $parentPath \|\| null === $dropedAtPath \|\| null === $targetPath) {
102			return new JsonResponse(array('Parameters parent, dropped and target has to be set to reorder.'), Response::HTTP_BAD_REQUEST);
103			}
104
105			$before = 'before' == $position;
106			$parentNode = $this->session->getNode($parentPath);
107			$targetName = PathHelper::getNodeName($targetPath);
108			if (!$before) {
109			$nodesIterator = $parentNode->getNodes();
110			$nodesIterator->rewind();
111			while ($nodesIterator->valid()) {
112			if ($nodesIterator->key() == $targetName) {
113			break;
114			}
115			$nodesIterator->next();
116			}
117			$targetName = null;
118			if ($nodesIterator->valid()) {
119			$nodesIterator->next();
120			if ($nodesIterator->valid()) {
121			$targetName = $nodesIterator->key();
122			}
123			}
124			}
125			$parentNode->orderBefore($targetName, PathHelper::getNodeName($dropedAtPath));
126			$this->session->save();
127
128			return new Response('', Response::HTTP_NO_CONTENT);
129			}
130			}
131

sonata-project / SonataDoctrinePhpcrAdminBundle

Push — master ( a33308...36ba79 )

src/Controller/TreeController.php (1 issue)

Showing only issues like (Show All)

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like