TreeController::__construct() - Code Metrics - Inspection of "1.x-dev" - sonata-project/SonataDoctrinePhpcrAdminBundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — 1.x ( e997bd )

by Sullivan

created 2016-06-04 17:56 UTC

TreeController::__construct() A

↳ Parent: TreeController

Complexity

Conditions	2
Paths	2

Size

Total Lines	10
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	10
rs	9.4285
cc	2
eloc	6
nc	2
nop	4

<?php

/*
 * This file is part of the Sonata package.
 *
 * (c) Thomas Rabaix <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Sonata\DoctrinePHPCRAdminBundle\Controller;

use Symfony\Component\HttpFoundation\Response;
use Symfony\Component\HttpFoundation\Request;
use Symfony\Bundle\FrameworkBundle\Controller\Controller;
use Symfony\Cmf\Bundle\TreeBrowserBundle\Tree\TreeInterface;

/**
 * A controller to render the tree block
 */
class TreeController extends Controller
{
    /**
     * @var TreeInterface
     */
    private $tree;

    /**
     * @var string
     */
    private $template = 'SonataDoctrinePHPCRAdminBundle:Tree:tree.html.twig';

    /**
     * @var array
     */
    private $defaults;

    /**
     * @var boolean
     */
    private $confirmMove = false;

    /**
     * @param TreeInterface $tree
     * @param string $template
     * @param array $defaults
     * @param boolean $confirmMove
     */
    public function __construct(TreeInterface $tree, $template = null, array $defaults = array(), $confirmMove = false)
    {
        $this->tree = $tree;
        if ($template) {
''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
            $this->template = $template;
        }
        $this->defaults = $defaults;

        $this->confirmMove = $confirmMove;
    }

    /**
     * Renders a tree, passing the routes for each of the admin types (document types)
     * to the view
     *
     * @param Request $request
     *
     * @return Response
     */
    public function treeAction(Request $request)
    {
        $createInOverlay = $request->attributes->get('create_in_overlay');
        $editInOverlay = $request->attributes->get('edit_in_overlay');
        $deleteInOverlay = $request->attributes->get('delete_in_overlay');

        $root = $request->attributes->get('root');
        $selected = $request->attributes->get('selected') ?: $root;

        return $this->render($this->template, array(
            'tree' => $this->tree,
            'root_node' => $root,
            'selected_node' => $selected,
            'routing_defaults' => $this->defaults,
            'confirm_move' => $this->confirmMove,
            'create_in_overlay' => $createInOverlay ? $createInOverlay : false,
            'edit_in_overlay' => $editInOverlay ? $editInOverlay : false,
            'delete_in_overlay' => $deleteInOverlay ? $deleteInOverlay : false,
        ));
    }
}


1			<?php
2
3			/*
4			* This file is part of the Sonata package.
5			*
6			* (c) Thomas Rabaix <[email protected]>
7			*
8			* For the full copyright and license information, please view the LICENSE
9			* file that was distributed with this source code.
10			*/
11
12			namespace Sonata\DoctrinePHPCRAdminBundle\Controller;
13
14			use Symfony\Component\HttpFoundation\Response;
15			use Symfony\Component\HttpFoundation\Request;
16			use Symfony\Bundle\FrameworkBundle\Controller\Controller;
17			use Symfony\Cmf\Bundle\TreeBrowserBundle\Tree\TreeInterface;
18
19			/**
20			* A controller to render the tree block
21			*/
22			class TreeController extends Controller
23			{
24			/**
25			* @var TreeInterface
26			*/
27			private $tree;
28
29			/**
30			* @var string
31			*/
32			private $template = 'SonataDoctrinePHPCRAdminBundle:Tree:tree.html.twig';
33
34			/**
35			* @var array
36			*/
37			private $defaults;
38
39			/**
40			* @var boolean
41			*/
42			private $confirmMove = false;
43
44			/**
45			* @param TreeInterface $tree
46			* @param string $template
47			* @param array $defaults
48			* @param boolean $confirmMove
49			*/
50			public function __construct(TreeInterface $tree, $template = null, array $defaults = array(), $confirmMove = false)
51			{
52			$this->tree = $tree;
53			if ($template) {
			0 ignored issues – show Bug Best Practice introduced 2015-12-06 00:13 UTC by Report Bug Copy Issue Report The expression `$template` of type `string\|null` is loosely compared to `true`; this is ambiguous if the string can be empty. You might want to explicitly use `!== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `string` values, the empty string `''` is a special case, in particular the following results might be unexpected: '' == false // true '' == null // true 'ab' == false // false 'ab' == null // false // It is often better to use strict comparison '' === false // false '' === null // false Loading history...
54			$this->template = $template;
55			}
56			$this->defaults = $defaults;
57
58			$this->confirmMove = $confirmMove;
59			}
60
61			/**
62			* Renders a tree, passing the routes for each of the admin types (document types)
63			* to the view
64			*
65			* @param Request $request
66			*
67			* @return Response
68			*/
69			public function treeAction(Request $request)
70			{
71			$createInOverlay = $request->attributes->get('create_in_overlay');
72			$editInOverlay = $request->attributes->get('edit_in_overlay');
73			$deleteInOverlay = $request->attributes->get('delete_in_overlay');
74
75			$root = $request->attributes->get('root');
76			$selected = $request->attributes->get('selected') ?: $root;
77
78			return $this->render($this->template, array(
79			'tree' => $this->tree,
80			'root_node' => $root,
81			'selected_node' => $selected,
82			'routing_defaults' => $this->defaults,
83			'confirm_move' => $this->confirmMove,
84			'create_in_overlay' => $createInOverlay ? $createInOverlay : false,
85			'edit_in_overlay' => $editInOverlay ? $editInOverlay : false,
86			'delete_in_overlay' => $deleteInOverlay ? $deleteInOverlay : false,
87			));
88			}
89			}
90

sonata-project / SonataDoctrinePhpcrAdminBundle

Push — 1.x ( e997bd )

TreeController::__construct() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like