Sonata\DoctrinePHPCRAdminBundle\Filter\NodeNameFilter::filter()

Complexity

Conditions	8
Paths	9

Size

Total Lines

28

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
    public function filter(ProxyQueryInterface $proxyQuery, $alias, $field, $data)
    {
        if (!$data || !is_array($data) || !array_key_exists('value', $data)) {

The expression $data of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using empty($expr) instead to make it clear that you intend to check for an array without elements.

            return;
        }

        $data['value'] = trim($data['value']);
        $data['type'] = empty($data['type']) ? ChoiceType::TYPE_CONTAINS : $data['type'];

        if (0 == strlen($data['value'])) {
            return;
        }

        $where = $this->getWhere($proxyQuery);

$proxyQuery of type object<Sonata\AdminBundle\Datagrid\ProxyQueryInterface> is not a sub-type of object<Sonata\DoctrinePHPCRAdminBundle\Datagrid\ProxyQuery>. It seems like you assume a concrete implementation of the interface Sonata\AdminBundle\Datagrid\ProxyQueryInterface to be always present.

        switch ($data['type']) {
            case ChoiceType::TYPE_EQUAL:
                $where->eq()->localName($alias)->literal($data['value']);

                break;
            case ChoiceType::TYPE_CONTAINS:
            default:
                $where->like()->localName($alias)->literal('%'.$data['value'].'%');
        }

        // filter is active as we have now modified the query
        $this->active = true;
    }