LoadAssociationData::load() - Code Metrics - Inspection of "[WIP] Webtests" - sonata-project/SonataDoctrinePhpcrAdminBundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#485)

by Maximilian

created 2017-08-06 21:00 UTC

LoadAssociationData::load() A

↳ Parent: LoadAssociationData

Complexity

Conditions	1
Paths	1

Size

Total Lines	17
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	17
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	10
nc	1
nop	1

<?php

/*
 * This file is part of the Symfony CMF package.
 *
 * (c) 2011-2017 Symfony CMF
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Sonata\DoctrinePHPCRAdminBundle\Tests\Resources\DataFixtures\Phpcr;

use Doctrine\Common\DataFixtures\FixtureInterface;
use Doctrine\Common\Persistence\ObjectManager;
use PHPCR\Util\NodeHelper;
use Sonata\DoctrinePHPCRAdminBundle\Tests\Resources\Document\Content;

class LoadAssociationData implements FixtureInterface
{
    public function load(ObjectManager $manager)
    {
        NodeHelper::createPath($manager->getPhpcrSession(), '/test');
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}

        NodeHelper::createPath($manager->getPhpcrSession(), '/test/content');
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}

        $contentRoot = $manager->find(null, '/test/content');

        $content = new Content();
        $content->setName('content-1');
        $content->setTitle('Content 1');
        $content->setParentDocument($contentRoot);

        $manager->persist($content);

        $manager->flush();
    }
}


Pull Request — master (#485)

LoadAssociationData::load() A

Complexity

Size

Duplication

Importance

Available Fixes

Available Fixes

1			<?php
2
3			/*
4			* This file is part of the Symfony CMF package.
5			*
6			* (c) 2011-2017 Symfony CMF
7			*
8			* For the full copyright and license information, please view the LICENSE
9			* file that was distributed with this source code.
10			*/
11
12			namespace Sonata\DoctrinePHPCRAdminBundle\Tests\Resources\DataFixtures\Phpcr;
13
14			use Doctrine\Common\DataFixtures\FixtureInterface;
15			use Doctrine\Common\Persistence\ObjectManager;
16			use PHPCR\Util\NodeHelper;
17			use Sonata\DoctrinePHPCRAdminBundle\Tests\Resources\Document\Content;
18
19			class LoadAssociationData implements FixtureInterface
20			{
21			public function load(ObjectManager $manager)
22			{
23			NodeHelper::createPath($manager->getPhpcrSession(), '/test');
			0 ignored issues – show Bug introduced 2017-08-06 19:13 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Doctrine\Common\Persistence\ObjectManager` as the method `getPhpcrSession()` does only exist in the following implementations of said interface: `Doctrine\ODM\PHPCR\Decor...ocumentManagerDecorator`, `Doctrine\ODM\PHPCR\DocumentManager`, `Doctrine\Tests\ODM\PHPCR...ManagerGetClassMetadata`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
24
25			NodeHelper::createPath($manager->getPhpcrSession(), '/test/content');
			0 ignored issues – show Bug introduced 2017-08-06 19:13 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Doctrine\Common\Persistence\ObjectManager` as the method `getPhpcrSession()` does only exist in the following implementations of said interface: `Doctrine\ODM\PHPCR\Decor...ocumentManagerDecorator`, `Doctrine\ODM\PHPCR\DocumentManager`, `Doctrine\Tests\ODM\PHPCR...ManagerGetClassMetadata`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
26
27			$contentRoot = $manager->find(null, '/test/content');
28
29			$content = new Content();
30			$content->setName('content-1');
31			$content->setTitle('Content 1');
32			$content->setParentDocument($contentRoot);
33
34			$manager->persist($content);
35
36			$manager->flush();
37			}
38			}
39

sonata-project / SonataDoctrinePhpcrAdminBundle

Pull Request — master (#485)

LoadAssociationData::load() A

Complexity

Size

Duplication

Importance

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like