Sonata\DoctrinePHPCRAdminBundle\Filter\NumberFilter::filter()

Complexity

Conditions	11
Paths	13

Size

Total Lines

36

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
    public function filter(ProxyQueryInterface $proxyQuery, $alias, $field, $data)
    {
        if (!$data || !is_array($data) || !array_key_exists('value', $data) || !is_numeric($data['value'])) {

The expression $data of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using empty($expr) instead to make it clear that you intend to check for an array without elements.

            return;
        }

        $type = isset($data['type']) ? $data['type'] : false;
        $where = $this->getWhere($proxyQuery);

$proxyQuery of type object<Sonata\AdminBundle\Datagrid\ProxyQueryInterface> is not a sub-type of object<Sonata\DoctrinePHPCRAdminBundle\Datagrid\ProxyQuery>. It seems like you assume a concrete implementation of the interface Sonata\AdminBundle\Datagrid\ProxyQueryInterface to be always present.

        $value = $data['value'];

        switch ($type) {
            case NumberType::TYPE_GREATER_EQUAL:
                $where->gte()->field('a.'.$field)->literal($value);

                break;
            case NumberType::TYPE_GREATER_THAN:
                $where->gt()->field('a.'.$field)->literal($value);

                break;
            case NumberType::TYPE_LESS_EQUAL:
                $where->lte()->field('a.'.$field)->literal($value);

                break;
            case NumberType::TYPE_LESS_THAN:
                $where->lt()->field('a.'.$field)->literal($value);

                break;
            case NumberType::TYPE_EQUAL:
            default:
                $where->eq()->field('a.'.$field)->literal($value);
        }

        // filter is active as we have now modified the query
        $this->active = true;
    }