Issues in LoadTreeData.php - New Issues - Inspection of "Fix tests" - sonata-project/SonataDoctrinePhpcrAdminBundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 22f94e...b6697a )

by Jordi Sala

created 2018-01-20 10:37 UTC

Resources/DataFixtures/Phpcr/LoadTreeData.php (1 issue)

Labels

Bug 1

Severity

Minor 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

declare(strict_types=1);

/*
 * This file is part of the Sonata Project package.
 *
 * (c) Thomas Rabaix <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Sonata\DoctrinePHPCRAdminBundle\Tests\Resources\DataFixtures\Phpcr;

use Doctrine\Common\DataFixtures\FixtureInterface;
use Doctrine\Common\Persistence\ObjectManager;
use PHPCR\Util\NodeHelper;
use Sonata\DoctrinePHPCRAdminBundle\Tests\Resources\Document\Content;

class LoadTreeData implements FixtureInterface
{
    public function load(ObjectManager $manager): void
    {
        NodeHelper::createPath($manager->getPhpcrSession(), '/test');

        NodeHelper::createPath($manager->getPhpcrSession(), '/test/content');
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
        NodeHelper::createPath($manager->getPhpcrSession(), '/test/routes');

        $contentRoot = $manager->find(null, '/test/content');
        $routeRoot = $manager->find(null, '/test/routes');

        $singleRoute = new Content();
        $singleRoute->setName('route-1');
        $singleRoute->setTitle('Route 1');
        $singleRoute->setParentDocument($routeRoot);
        $manager->persist($singleRoute);

        $routeAlikeA = new Content();
        $routeAlikeA->setName('route-2');
        $routeAlikeA->setTitle('Route 2');
        $routeAlikeA->setParentDocument($routeRoot);
        $manager->persist($routeAlikeA);

        $routeAlikeB = new Content();
        $routeAlikeB->setName('route-3');
        $routeAlikeB->setTitle('Route 3');
        $routeAlikeB->setParentDocument($routeRoot);
        $manager->persist($routeAlikeB);

        $child = new Content();
        $child->setName('child');
        $child->setTitle('Content Child');

        $content = new Content();
        $content->setName('content-1');
        $content->setTitle('Content 1');
        $content->setSingleRoute($singleRoute);
        $content->addRoute($routeAlikeA);
        $content->addRoute($routeAlikeB);
        $content->setChild($child);
        $content->setParentDocument($contentRoot);
        $manager->persist($content);

        $childA = new Content();
        $childA->setName('content-3');
        $childA->setTitle('Content Child A');

        $childB = new Content();
        $childB->setName('content-3');
        $childB->setTitle('Content Child B');

        $content = new Content();
        $content->setName('content-2');
        $content->setParentDocument($contentRoot);
        $content->addChild($childA);
        $content->addChild($childB);
        $content->setTitle('Content 2');
        $manager->persist($content);

        $manager->flush();
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			/*
6			* This file is part of the Sonata Project package.
7			*
8			* (c) Thomas Rabaix <[email protected]>
9			*
10			* For the full copyright and license information, please view the LICENSE
11			* file that was distributed with this source code.
12			*/
13
14			namespace Sonata\DoctrinePHPCRAdminBundle\Tests\Resources\DataFixtures\Phpcr;
15
16			use Doctrine\Common\DataFixtures\FixtureInterface;
17			use Doctrine\Common\Persistence\ObjectManager;
18			use PHPCR\Util\NodeHelper;
19			use Sonata\DoctrinePHPCRAdminBundle\Tests\Resources\Document\Content;
20
21			class LoadTreeData implements FixtureInterface
22			{
23			public function load(ObjectManager $manager): void
24			{
25			NodeHelper::createPath($manager->getPhpcrSession(), '/test');
26
27			NodeHelper::createPath($manager->getPhpcrSession(), '/test/content');
			0 ignored issues – show Bug introduced 2017-08-06 19:13 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like you code against a concrete implementation and not the interface `Doctrine\Common\Persistence\ObjectManager` as the method `getPhpcrSession()` does only exist in the following implementations of said interface: `Doctrine\ODM\PHPCR\Decor...ocumentManagerDecorator`, `Doctrine\ODM\PHPCR\DocumentManager`, `Doctrine\Tests\ODM\PHPCR...ManagerGetClassMetadata`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
28			NodeHelper::createPath($manager->getPhpcrSession(), '/test/routes');
29
30			$contentRoot = $manager->find(null, '/test/content');
31			$routeRoot = $manager->find(null, '/test/routes');
32
33			$singleRoute = new Content();
34			$singleRoute->setName('route-1');
35			$singleRoute->setTitle('Route 1');
36			$singleRoute->setParentDocument($routeRoot);
37			$manager->persist($singleRoute);
38
39			$routeAlikeA = new Content();
40			$routeAlikeA->setName('route-2');
41			$routeAlikeA->setTitle('Route 2');
42			$routeAlikeA->setParentDocument($routeRoot);
43			$manager->persist($routeAlikeA);
44
45			$routeAlikeB = new Content();
46			$routeAlikeB->setName('route-3');
47			$routeAlikeB->setTitle('Route 3');
48			$routeAlikeB->setParentDocument($routeRoot);
49			$manager->persist($routeAlikeB);
50
51			$child = new Content();
52			$child->setName('child');
53			$child->setTitle('Content Child');
54
55			$content = new Content();
56			$content->setName('content-1');
57			$content->setTitle('Content 1');
58			$content->setSingleRoute($singleRoute);
59			$content->addRoute($routeAlikeA);
60			$content->addRoute($routeAlikeB);
61			$content->setChild($child);
62			$content->setParentDocument($contentRoot);
63			$manager->persist($content);
64
65			$childA = new Content();
66			$childA->setName('content-3');
67			$childA->setTitle('Content Child A');
68
69			$childB = new Content();
70			$childB->setName('content-3');
71			$childB->setTitle('Content Child B');
72
73			$content = new Content();
74			$content->setName('content-2');
75			$content->setParentDocument($contentRoot);
76			$content->addChild($childA);
77			$content->addChild($childB);
78			$content->setTitle('Content 2');
79			$manager->persist($content);
80
81			$manager->flush();
82			}
83			}
84

sonata-project / SonataDoctrinePhpcrAdminBundle

Push — master ( 22f94e...b6697a )

Resources/DataFixtures/Phpcr/LoadTreeData.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Available Fixes

Duplication Side-by-Side

Filter issues like