sonata-project /
SonataDoctrinePhpcrAdminBundle
| Conditions | 13 |
| Paths | 31 |
| Total Lines | 44 |
| Code Lines | 30 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 22 | public function filter(ProxyQueryInterface $proxyQuery, $alias, $field, $data) |
||
| 23 | { |
||
| 24 | if (!$data || !is_array($data) || !array_key_exists('value', $data)) { |
||
| 25 | return; |
||
| 26 | } |
||
| 27 | |||
| 28 | $value = trim($data['value']); |
||
| 29 | $data['type'] = empty($data['type']) ? ChoiceType::TYPE_CONTAINS : $data['type']; |
||
| 30 | |||
| 31 | if (strlen($value) == 0) { |
||
| 32 | return; |
||
| 33 | } |
||
| 34 | |||
| 35 | $where = $this->getWhere($proxyQuery); |
||
|
|
|||
| 36 | $isComparisonLowerCase = $this->getOption('compare_case_insensitive'); |
||
| 37 | $value = $isComparisonLowerCase ? strtolower($value) : $value; |
||
| 38 | switch ($data['type']) { |
||
| 39 | case ChoiceType::TYPE_EQUAL: |
||
| 40 | if ($isComparisonLowerCase) { |
||
| 41 | $where->eq()->lowerCase()->field('a.'.$field)->end()->literal($value); |
||
| 42 | } else { |
||
| 43 | $where->eq()->field('a.'.$field)->literal($value); |
||
| 44 | } |
||
| 45 | |||
| 46 | break; |
||
| 47 | case ChoiceType::TYPE_NOT_CONTAINS: |
||
| 48 | $where->fullTextSearch('a.'.$field, '* -'.$value); |
||
| 49 | break; |
||
| 50 | case ChoiceType::TYPE_CONTAINS: |
||
| 51 | if ($isComparisonLowerCase) { |
||
| 52 | $where->like()->lowerCase()->field('a.'.$field)->end()->literal('%'.$value.'%'); |
||
| 53 | } else { |
||
| 54 | $where->like()->field('a.'.$field)->literal('%'.$value.'%'); |
||
| 55 | } |
||
| 56 | |||
| 57 | break; |
||
| 58 | case ChoiceType::TYPE_CONTAINS_WORDS: |
||
| 59 | default: |
||
| 60 | $where->fullTextSearch('a.'.$field, $value); |
||
| 61 | } |
||
| 62 | |||
| 63 | // filter is active as we have now modified the query |
||
| 64 | $this->active = true; |
||
| 65 | } |
||
| 66 | |||
| 90 |
This check looks for parameters that are defined as one type in their type hint or doc comment but seem to be used as a narrower type, i.e an implementation of an interface or a subclass.
Consider changing the type of the parameter or doing an instanceof check before assuming your parameter is of the expected type.