Issues in ListBuilderTest.php - Fixed Issues - Inspection of "Merge pull request #485 from ElectricMaxxx/webtest..." - sonata-project/SonataDoctrinePhpcrAdminBundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( eb83f4...bb238e )

by Maximilian

created 2017-08-16 07:23 UTC

tests/Builder/ListBuilderTest.php (15 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

/*
 * This file is part of the Sonata Project package.
 *
 * (c) Thomas Rabaix <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Sonata\DoctrinePHPCRAdminBundle\Tests\Builder;

use Sonata\AdminBundle\Admin\FieldDescriptionCollection;
use Sonata\AdminBundle\Admin\FieldDescriptionInterface;
use Sonata\AdminBundle\Guesser\TypeGuesserInterface;
use Sonata\DoctrinePHPCRAdminBundle\Admin\Admin;
use Sonata\DoctrinePHPCRAdminBundle\Admin\FieldDescription;
use Sonata\DoctrinePHPCRAdminBundle\Builder\ListBuilder;
use Sonata\DoctrinePHPCRAdminBundle\Model\ModelManager;
use Symfony\Component\Form\Guess\Guess;
use Symfony\Component\Form\Guess\TypeGuess;

class ListBuilderTest extends \PHPUnit_Framework_TestCase
{
    /**
     * @var ListBuilder
     */
    private $lb;

    /**
     * @var Admin
     */
    private $admin;

    /**
     * @var ModelManager
     */
    private $modelManager;

    /**
     * @var FieldDescriptionInterface
     */
    private $fieldDescription;

    /**
     * @var FieldDescriptionCollection
     */
    private $fieldDescriptionCollection;

    /**
     * @var TypeGuesserInterface
     */
    private $guesser;

    public function setUp()
    {
        $this->guesser = $this->createMock('\Sonata\AdminBundle\Guesser\TypeGuesserInterface', array(), array());

        $this->templates = array();
class MyClass { }

$x = new MyClass();
$x->foo = true;
    }

    public function testGetBaseList()
    {
        $lb = new ListBuilder($this->guesser, $this->templates);
        $this->assertInstanceOf('Sonata\AdminBundle\Admin\FieldDescriptionCollection', $lb->getBaseList());
    }

    public function testAddField()
    {
        $this->setupAddField();
        $this->lb->addField($this->fieldDescriptionCollection, 'string', $this->fieldDescription, $this->admin);
    }

    public function testAddFieldNullType()
    {
        $typeguess = $this->createMock('Symfony\Component\Form\Guess\TypeGuess', array(), array(), '', false);

        $this->guesser->expects($this->once())
            ->method('guessType')
            ->with($this->anything())
            ->will($this->returnValue($typeguess));
        $this->setupAddField();
        $this->lb->addField($this->fieldDescriptionCollection, null, $this->fieldDescription, $this->admin);
    }

    public function testAddListActionField()
    {
        $this->setUpListActionTests();

        $fieldDescription = new FieldDescription();
        $fieldDescription->setName('foo');
        $list = $this->listBuilder->getBaseList();
class MyClass { }

$x = new MyClass();
$x->foo = true;
        $this->listBuilder
            ->addField($list, 'actions', $fieldDescription, $this->admin);

        $this->assertSame(
            'SonataAdminBundle:CRUD:list__action.html.twig',
            $list->get('foo')->getTemplate(),
            'Custom list action field has a default list action template assigned'
        );
    }

    public function testCorrectFixedActionsFieldType()
    {
        $this->setUpListActionTests();

        $this->guesser->expects($this->once())->method('guessType')
            ->willReturn(new TypeGuess(null, array(), Guess::LOW_CONFIDENCE));

        $fieldDescription = new FieldDescription();
        $fieldDescription->setName('_action');
        $list = $this->listBuilder->getBaseList();
        $this->listBuilder->addField($list, null, $fieldDescription, $this->admin);

        $this->assertSame(
            'actions',
            $list->get('_action')->getType(),
            'Standard list _action field has "actions" type'
        );
    }

    //public function testAddField()
    //{
    //    $fieldDescriptionCollection = $this->getMock('\Sonata\AdminBundle\Admin\FieldDescriptionCollection', array(), array());
    //    $fieldDescription = $this->getMock('\Sonata\AdminBundle\Admin\FieldDescriptionInterface', array(), array());
    //    $admin = $this->getMock('\Sonata\AdminBundle\Admin\AdminInterface', array(), array());
    //    $lb = new ListBuilder($this->guesser, $this->templates);

    //    $lb->addField($fieldDescriptionCollection, 'sometype', $fieldDescription, $admin);

    //}

    protected function setUpListActionTests()
    {
        $this->metaData = $this->createMock('\Doctrine\ODM\PHPCR\Mapping\ClassMetadata');
class MyClass { }

$x = new MyClass();
$x->foo = true;
        $this->modelManager = $this->createMock('Sonata\DoctrinePHPCRAdminBundle\Model\ModelManager');

        $this->modelManager->expects($this->any())
            ->method('getMetadata')
            ->will($this->returnValue($this->metaData));
        $this->modelManager->expects($this->any())
            ->method('hasMetadata')
            ->with($this->anything())
            ->will($this->returnValue(true));

        $this->admin = $this->createMock('\Sonata\AdminBundle\Admin\Admin', array(), array(), '', false);

        $this->admin->expects($this->atLeastOnce())->method('getModelManager')
            ->willReturn($this->modelManager);

        $this->listBuilder = new ListBuilder($this->guesser);
    }

    private function setupAddField()
    {
        $this->lb = new ListBuilder($this->guesser, $this->templates);
        $this->metaData = $this->createMock('\Doctrine\ODM\PHPCR\Mapping\ClassMetadata', array(), array(), '', false);

        $this->modelManager = $this->createMock('\Sonata\DoctrinePHPCRAdminBundle\Model\ModelManager');

        $this->modelManager->expects($this->any())
            ->method('getMetadata')
            ->will($this->returnValue($this->metaData));
        $this->modelManager->expects($this->any())
            ->method('hasMetadata')
            ->with($this->anything())
            ->will($this->returnValue(true));

        $this->fieldDescription = $this->createMock('\Sonata\AdminBundle\Admin\FieldDescriptionInterface');

        $this->fieldDescription->expects($this->any())
            ->method('getType')
            ->will($this->returnValue('string'));
        $this->fieldDescription->expects($this->once())
            ->method('setType')
            ->with($this->anything());

        //AdminInterface doesn't implement methods called in addField,
        //so we mock Admin
        $this->admin = $this->createMock('\Sonata\AdminBundle\Admin\AbstractAdmin', array(), array(), '', false);

        $this->admin->expects($this->any())
            ->method('getModelManager')
            ->will($this->returnValue($this->modelManager));
        $this->admin->expects($this->once())
            ->method('addListFieldDescription')
            ->with($this->anything(), $this->fieldDescription);

        $this->fieldDescriptionCollection = $this->createMock('\Sonata\AdminBundle\Admin\FieldDescriptionCollection');

        $this->fieldDescriptionCollection->expects($this->once())
            ->method('add')
            ->with($this->fieldDescription);
    }
}


1			<?php
2
3			/*
4			* This file is part of the Sonata Project package.
5			*
6			* (c) Thomas Rabaix <[email protected]>
7			*
8			* For the full copyright and license information, please view the LICENSE
9			* file that was distributed with this source code.
10			*/
11
12			namespace Sonata\DoctrinePHPCRAdminBundle\Tests\Builder;
13
14			use Sonata\AdminBundle\Admin\FieldDescriptionCollection;
15			use Sonata\AdminBundle\Admin\FieldDescriptionInterface;
16			use Sonata\AdminBundle\Guesser\TypeGuesserInterface;
17			use Sonata\DoctrinePHPCRAdminBundle\Admin\Admin;
18			use Sonata\DoctrinePHPCRAdminBundle\Admin\FieldDescription;
19			use Sonata\DoctrinePHPCRAdminBundle\Builder\ListBuilder;
20			use Sonata\DoctrinePHPCRAdminBundle\Model\ModelManager;
21			use Symfony\Component\Form\Guess\Guess;
22			use Symfony\Component\Form\Guess\TypeGuess;
23
24			class ListBuilderTest extends \PHPUnit_Framework_TestCase
25			{
26			/**
27			* @var ListBuilder
28			*/
29			private $lb;
30
31			/**
32			* @var Admin
33			*/
34			private $admin;
35
36			/**
37			* @var ModelManager
38			*/
39			private $modelManager;
40
41			/**
42			* @var FieldDescriptionInterface
43			*/
44			private $fieldDescription;
45
46			/**
47			* @var FieldDescriptionCollection
48			*/
49			private $fieldDescriptionCollection;
50
51			/**
52			* @var TypeGuesserInterface
53			*/
54			private $guesser;
55
56			public function setUp()
57			{
58			$this->guesser = $this->createMock('\Sonata\AdminBundle\Guesser\TypeGuesserInterface', array(), array());
			0 ignored issues – show Unused Code introduced 2017-07-27 14:24 UTC by Report Bug Copy Issue Report Show Similar Issues like this The call to `ListBuilderTest::createMock()` has too many arguments starting with `array()`. This check compares calls to functions or methods with their respective definitions. If the call has more arguments than are defined, it raises an issue. If a function is defined several times with a different number of parameters, the check may pick up the wrong definition and report false positives. One codebase where this has been known to happen is Wordpress. In this case you can add the `@ignore` PhpDoc annotation to the duplicate definition and it will be ignored. Loading history... Documentation Bug introduced 2017-07-27 14:24 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `$this->createMock('\\Son...ace', array(), array())` of type `object<PHPUnit_Framework_MockObject_MockObject>` is incompatible with the declared type `object<Sonata\AdminBundl...r\TypeGuesserInterface>` of property `$guesser`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
59			$this->templates = array();
			0 ignored issues – show Bug introduced 2015-12-19 17:51 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `templates` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
60			}
61
62			public function testGetBaseList()
63			{
64			$lb = new ListBuilder($this->guesser, $this->templates);
65			$this->assertInstanceOf('Sonata\AdminBundle\Admin\FieldDescriptionCollection', $lb->getBaseList());
66			}
67
68			public function testAddField()
69			{
70			$this->setupAddField();
71			$this->lb->addField($this->fieldDescriptionCollection, 'string', $this->fieldDescription, $this->admin);
72			}
73
74			public function testAddFieldNullType()
75			{
76			$typeguess = $this->createMock('Symfony\Component\Form\Guess\TypeGuess', array(), array(), '', false);
			0 ignored issues – show Unused Code introduced 2017-07-27 14:24 UTC by Report Bug Copy Issue Report Show Similar Issues like this The call to `ListBuilderTest::createMock()` has too many arguments starting with `array()`. This check compares calls to functions or methods with their respective definitions. If the call has more arguments than are defined, it raises an issue. If a function is defined several times with a different number of parameters, the check may pick up the wrong definition and report false positives. One codebase where this has been known to happen is Wordpress. In this case you can add the `@ignore` PhpDoc annotation to the duplicate definition and it will be ignored. Loading history...
77			$this->guesser->expects($this->once())
78			->method('guessType')
79			->with($this->anything())
80			->will($this->returnValue($typeguess));
81			$this->setupAddField();
82			$this->lb->addField($this->fieldDescriptionCollection, null, $this->fieldDescription, $this->admin);
83			}
84
85			public function testAddListActionField()
86			{
87			$this->setUpListActionTests();
88
89			$fieldDescription = new FieldDescription();
90			$fieldDescription->setName('foo');
91			$list = $this->listBuilder->getBaseList();
			0 ignored issues – show Bug introduced 2017-07-27 14:24 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `listBuilder` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
92			$this->listBuilder
93			->addField($list, 'actions', $fieldDescription, $this->admin);
94
95			$this->assertSame(
96			'SonataAdminBundle:CRUD:list__action.html.twig',
97			$list->get('foo')->getTemplate(),
98			'Custom list action field has a default list action template assigned'
99			);
100			}
101
102			public function testCorrectFixedActionsFieldType()
103			{
104			$this->setUpListActionTests();
105
106			$this->guesser->expects($this->once())->method('guessType')
107			->willReturn(new TypeGuess(null, array(), Guess::LOW_CONFIDENCE));
108
109			$fieldDescription = new FieldDescription();
110			$fieldDescription->setName('_action');
111			$list = $this->listBuilder->getBaseList();
112			$this->listBuilder->addField($list, null, $fieldDescription, $this->admin);
113
114			$this->assertSame(
115			'actions',
116			$list->get('_action')->getType(),
117			'Standard list _action field has "actions" type'
118			);
119			}
120
121			//public function testAddField()
122			//{
123			// $fieldDescriptionCollection = $this->getMock('\Sonata\AdminBundle\Admin\FieldDescriptionCollection', array(), array());
124			// $fieldDescription = $this->getMock('\Sonata\AdminBundle\Admin\FieldDescriptionInterface', array(), array());
125			// $admin = $this->getMock('\Sonata\AdminBundle\Admin\AdminInterface', array(), array());
126			// $lb = new ListBuilder($this->guesser, $this->templates);
127
128			// $lb->addField($fieldDescriptionCollection, 'sometype', $fieldDescription, $admin);
129
130			//}
131
132			protected function setUpListActionTests()
133			{
134			$this->metaData = $this->createMock('\Doctrine\ODM\PHPCR\Mapping\ClassMetadata');
			0 ignored issues – show Bug introduced 2017-07-27 14:24 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `metaData` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
135			$this->modelManager = $this->createMock('Sonata\DoctrinePHPCRAdminBundle\Model\ModelManager');
			0 ignored issues – show Documentation Bug introduced 2017-07-27 14:24 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `$this->createMock('Sonat...\\Model\\ModelManager')` of type `object<PHPUnit_Framework_MockObject_MockObject>` is incompatible with the declared type `object<Sonata\DoctrinePH...dle\Model\ModelManager>` of property `$modelManager`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
136			$this->modelManager->expects($this->any())
137			->method('getMetadata')
138			->will($this->returnValue($this->metaData));
139			$this->modelManager->expects($this->any())
140			->method('hasMetadata')
141			->with($this->anything())
142			->will($this->returnValue(true));
143
144			$this->admin = $this->createMock('\Sonata\AdminBundle\Admin\Admin', array(), array(), '', false);
			0 ignored issues – show Unused Code introduced 2017-07-27 14:24 UTC by Report Bug Copy Issue Report Show Similar Issues like this The call to `ListBuilderTest::createMock()` has too many arguments starting with `array()`. This check compares calls to functions or methods with their respective definitions. If the call has more arguments than are defined, it raises an issue. If a function is defined several times with a different number of parameters, the check may pick up the wrong definition and report false positives. One codebase where this has been known to happen is Wordpress. In this case you can add the `@ignore` PhpDoc annotation to the duplicate definition and it will be ignored. Loading history... Documentation Bug introduced 2017-07-27 14:24 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `$this->createMock('\\Son...(), array(), '', false)` of type `object<PHPUnit_Framework_MockObject_MockObject>` is incompatible with the declared type `object<Sonata\DoctrinePH...dminBundle\Admin\Admin>` of property `$admin`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
145			$this->admin->expects($this->atLeastOnce())->method('getModelManager')
146			->willReturn($this->modelManager);
147
148			$this->listBuilder = new ListBuilder($this->guesser);
149			}
150
151			private function setupAddField()
152			{
153			$this->lb = new ListBuilder($this->guesser, $this->templates);
154			$this->metaData = $this->createMock('\Doctrine\ODM\PHPCR\Mapping\ClassMetadata', array(), array(), '', false);
			0 ignored issues – show Unused Code introduced 2017-07-27 14:24 UTC by Report Bug Copy Issue Report Show Similar Issues like this The call to `ListBuilderTest::createMock()` has too many arguments starting with `array()`. This check compares calls to functions or methods with their respective definitions. If the call has more arguments than are defined, it raises an issue. If a function is defined several times with a different number of parameters, the check may pick up the wrong definition and report false positives. One codebase where this has been known to happen is Wordpress. In this case you can add the `@ignore` PhpDoc annotation to the duplicate definition and it will be ignored. Loading history...
155			$this->modelManager = $this->createMock('\Sonata\DoctrinePHPCRAdminBundle\Model\ModelManager');
			0 ignored issues – show Documentation Bug introduced 2017-07-27 14:24 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `$this->createMock('\\Son...\\Model\\ModelManager')` of type `object<PHPUnit_Framework_MockObject_MockObject>` is incompatible with the declared type `object<Sonata\DoctrinePH...dle\Model\ModelManager>` of property `$modelManager`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
156			$this->modelManager->expects($this->any())
157			->method('getMetadata')
158			->will($this->returnValue($this->metaData));
159			$this->modelManager->expects($this->any())
160			->method('hasMetadata')
161			->with($this->anything())
162			->will($this->returnValue(true));
163
164			$this->fieldDescription = $this->createMock('\Sonata\AdminBundle\Admin\FieldDescriptionInterface');
			0 ignored issues – show Documentation Bug introduced 2017-07-27 14:24 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `$this->createMock('\\Son...dDescriptionInterface')` of type `object<PHPUnit_Framework_MockObject_MockObject>` is incompatible with the declared type `object<Sonata\AdminBundl...ldDescriptionInterface>` of property `$fieldDescription`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
165			$this->fieldDescription->expects($this->any())
166			->method('getType')
167			->will($this->returnValue('string'));
168			$this->fieldDescription->expects($this->once())
169			->method('setType')
170			->with($this->anything());
171
172			//AdminInterface doesn't implement methods called in addField,
173			//so we mock Admin
174			$this->admin = $this->createMock('\Sonata\AdminBundle\Admin\AbstractAdmin', array(), array(), '', false);
			0 ignored issues – show Unused Code introduced 2017-07-27 14:24 UTC by Report Bug Copy Issue Report Show Similar Issues like this The call to `ListBuilderTest::createMock()` has too many arguments starting with `array()`. This check compares calls to functions or methods with their respective definitions. If the call has more arguments than are defined, it raises an issue. If a function is defined several times with a different number of parameters, the check may pick up the wrong definition and report false positives. One codebase where this has been known to happen is Wordpress. In this case you can add the `@ignore` PhpDoc annotation to the duplicate definition and it will be ignored. Loading history... Documentation Bug introduced 2017-07-27 14:24 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `$this->createMock('\\Son...(), array(), '', false)` of type `object<PHPUnit_Framework_MockObject_MockObject>` is incompatible with the declared type `object<Sonata\DoctrinePH...dminBundle\Admin\Admin>` of property `$admin`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
175			$this->admin->expects($this->any())
176			->method('getModelManager')
177			->will($this->returnValue($this->modelManager));
178			$this->admin->expects($this->once())
179			->method('addListFieldDescription')
180			->with($this->anything(), $this->fieldDescription);
181
182			$this->fieldDescriptionCollection = $this->createMock('\Sonata\AdminBundle\Admin\FieldDescriptionCollection');
			0 ignored issues – show Documentation Bug introduced 2017-07-27 14:24 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `$this->createMock('\\Son...DescriptionCollection')` of type `object<PHPUnit_Framework_MockObject_MockObject>` is incompatible with the declared type `object<Sonata\AdminBundl...dDescriptionCollection>` of property `$fieldDescriptionCollection`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
183			$this->fieldDescriptionCollection->expects($this->once())
184			->method('add')
185			->with($this->fieldDescription);
186			}
187			}
188

sonata-project / SonataDoctrinePhpcrAdminBundle

Push — master ( eb83f4...bb238e )

tests/Builder/ListBuilderTest.php (15 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like