sonata-project / SonataDoctrinePhpcrAdminBundle

src/Filter/ChoiceFilter.php

<?php

/*
 * This file is part of the Sonata Project package.
 *
 * (c) Thomas Rabaix <thomas.rabaix@sonata-project.org>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Sonata\DoctrinePHPCRAdminBundle\Filter;

use Sonata\AdminBundle\Datagrid\ProxyQueryInterface;
use Sonata\AdminBundle\Form\Type\Filter\ChoiceType;

class ChoiceFilter extends Filter
{
    /**
     * {@inheritdoc}
     */
    public function filter(ProxyQueryInterface $proxyQuery, $alias, $field, $data)
    {
        if (!$data || !is_array($data) || !array_key_exists('type', $data) || !array_key_exists('value', $data)) {
            return;
        }

        $values = (array) $data['value'];
        $type = $data['type'];

        // clean values
        foreach ($values as $key => $value) {
            $value = trim($value);
            if (!$value) {
                unset($values[$key]);
            } else {
                $values[$key] = $value;
            }
        }

        // if values not set or "all" specified, do not do this filter
        if (!$values || in_array('all', $values, true)) {

The expression $values of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using empty($expr) instead to make it clear that you intend to check for an array without elements.

            return;
        }

        $andX = $this->getWhere($proxyQuery)->andX();

$proxyQuery of type object<Sonata\AdminBundle\Datagrid\ProxyQueryInterface> is not a sub-type of object<Sonata\DoctrinePHPCRAdminBundle\Datagrid\ProxyQuery>. It seems like you assume a concrete implementation of the interface Sonata\AdminBundle\Datagrid\ProxyQueryInterface to be always present.

        foreach ($values as $value) {
            if ($type == ChoiceType::TYPE_NOT_CONTAINS) {
                $andX->not()->like()->field('a.'.$field)->literal('%'.$value.'%');
            } elseif ($type == ChoiceType::TYPE_CONTAINS) {
                $andX->like()->field('a.'.$field)->literal('%'.$value.'%');
            } elseif ($type == ChoiceType::TYPE_EQUAL) {
                $andX->like()->field('a.'.$field)->literal($value);
            }
        }

        // filter is active as we have now modified the query
        $this->active = true;
    }

    /**
     * {@inheritdoc}
     */
    public function getDefaultOptions()
    {
        return array();
    }

    /**
     * {@inheritdoc}
     */
    public function getRenderSettings()
    {
        return array('sonata_type_filter_default', array(
            'operator_type' => 'sonata_type_equal',
            'field_type' => $this->getFieldType(),
            'field_options' => $this->getFieldOptions(),
            'label' => $this->getLabel(),
        ));
    }
}