Issues in PagerTest.php - New Issues - Inspection of "Merge 2.x into master" - sonata-project/SonataDoctrinePhpcrAdminBundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 6b2632...1706e7 )

unknown

created 2019-10-01 00:00 UTC

tests/Unit/Datagrid/PagerTest.php (2 issues)

Labels

Bug 2

Severity

Major 2

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

declare(strict_types=1);

/*
 * This file is part of the Sonata Project package.
 *
 * (c) Thomas Rabaix <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Sonata\DoctrinePHPCRAdminBundle\Tests\Unit\Datagrid;

use Doctrine\ODM\PHPCR\Query\Query as PHPCRQuery;
use PHPUnit\Framework\TestCase;
use Sonata\DoctrinePHPCRAdminBundle\Datagrid\Pager;
use Sonata\DoctrinePHPCRAdminBundle\Datagrid\ProxyQuery;

class PagerTest extends TestCase
{
    public function setUp(): void
    {
        $this->pager = new Pager(10);
class MyClass { }

$x = new MyClass();
$x->foo = true;

        $this->proxyQuery = $this->createMock(ProxyQuery::class);
class MyClass { }

$x = new MyClass();
$x->foo = true;
    }

    public function testInitNumPages(): void
    {
        $this->proxyQuery->expects($this->once())
            ->method('execute')
            ->with([], PHPCRQuery::HYDRATE_PHPCR)
            ->willReturn(range(0, 12));

        $this->proxyQuery->expects($this->once())
            ->method('setMaxResults')
            ->with($this->equalTo(10));

        $this->proxyQuery->expects($this->once())
            ->method('setFirstResult')
            ->with($this->equalTo(0));

        $this->pager->setQuery($this->proxyQuery);
        $this->pager->init();

        $this->assertSame(2, $this->pager->getLastPage());
    }

    public function testInitOffset(): void
    {
        $this->proxyQuery->expects($this->once())
            ->method('execute')
            ->with([], PHPCRQuery::HYDRATE_PHPCR)
            ->willReturn(range(0, 12));

        $this->proxyQuery->expects($this->once())
            ->method('setMaxResults')
            ->with($this->equalTo(10));

        // Asserting that the offset will be set correctly
        $this->proxyQuery->expects($this->once())
            ->method('setFirstResult')
            ->with($this->equalTo(10));

        $this->pager->setQuery($this->proxyQuery);
        $this->pager->setPage(2);
        $this->pager->init();

        $this->assertSame(2, $this->pager->getLastPage());
    }

    public function testNoPagesPerConfig(): void
    {
        $this->proxyQuery->expects($this->once())
            ->method('execute')
            ->with([], PHPCRQuery::HYDRATE_PHPCR)
            ->willReturn([]);

        $this->proxyQuery->expects($this->once())
            ->method('setMaxResults')
            ->with($this->equalTo(0));

        $this->proxyQuery->expects($this->once())
            ->method('setFirstResult')
            ->with($this->equalTo(0));

        $this->pager->setQuery($this->proxyQuery);

        // Max per page 0 means no pagination
        $this->pager->setMaxPerPage(0);
        $this->pager->init();

        $this->assertSame(0, $this->pager->getLastPage());
    }

    public function testNoPagesForNoResults(): void
    {
        $this->proxyQuery->expects($this->once())
            ->method('execute')
            ->with([], PHPCRQuery::HYDRATE_PHPCR)
            ->willReturn([]);

        $this->proxyQuery->expects($this->once())
            ->method('setMaxResults')
            ->with($this->equalTo(0));
        $this->proxyQuery->expects($this->once())
            ->method('setFirstResult')
            ->with($this->equalTo(0));

        $this->pager->setQuery($this->proxyQuery);
        $this->pager->init();
        $this->AssertEquals(0, $this->pager->getLastPage());
    }

    public function testInitNoQuery(): void
    {
        $this->expectException(\RuntimeException::class);
        $this->pager->init();
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			/*
6			* This file is part of the Sonata Project package.
7			*
8			* (c) Thomas Rabaix <[email protected]>
9			*
10			* For the full copyright and license information, please view the LICENSE
11			* file that was distributed with this source code.
12			*/
13
14			namespace Sonata\DoctrinePHPCRAdminBundle\Tests\Unit\Datagrid;
15
16			use Doctrine\ODM\PHPCR\Query\Query as PHPCRQuery;
17			use PHPUnit\Framework\TestCase;
18			use Sonata\DoctrinePHPCRAdminBundle\Datagrid\Pager;
19			use Sonata\DoctrinePHPCRAdminBundle\Datagrid\ProxyQuery;
20
21			class PagerTest extends TestCase
22			{
23			public function setUp(): void
24			{
25			$this->pager = new Pager(10);
			0 ignored issues – show Bug introduced 2019-05-07 06:03 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `pager` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
26
27			$this->proxyQuery = $this->createMock(ProxyQuery::class);
			0 ignored issues – show Bug introduced 2019-05-07 06:03 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `proxyQuery` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
28			}
29
30			public function testInitNumPages(): void
31			{
32			$this->proxyQuery->expects($this->once())
33			->method('execute')
34			->with([], PHPCRQuery::HYDRATE_PHPCR)
35			->willReturn(range(0, 12));
36
37			$this->proxyQuery->expects($this->once())
38			->method('setMaxResults')
39			->with($this->equalTo(10));
40
41			$this->proxyQuery->expects($this->once())
42			->method('setFirstResult')
43			->with($this->equalTo(0));
44
45			$this->pager->setQuery($this->proxyQuery);
46			$this->pager->init();
47
48			$this->assertSame(2, $this->pager->getLastPage());
49			}
50
51			public function testInitOffset(): void
52			{
53			$this->proxyQuery->expects($this->once())
54			->method('execute')
55			->with([], PHPCRQuery::HYDRATE_PHPCR)
56			->willReturn(range(0, 12));
57
58			$this->proxyQuery->expects($this->once())
59			->method('setMaxResults')
60			->with($this->equalTo(10));
61
62			// Asserting that the offset will be set correctly
63			$this->proxyQuery->expects($this->once())
64			->method('setFirstResult')
65			->with($this->equalTo(10));
66
67			$this->pager->setQuery($this->proxyQuery);
68			$this->pager->setPage(2);
69			$this->pager->init();
70
71			$this->assertSame(2, $this->pager->getLastPage());
72			}
73
74			public function testNoPagesPerConfig(): void
75			{
76			$this->proxyQuery->expects($this->once())
77			->method('execute')
78			->with([], PHPCRQuery::HYDRATE_PHPCR)
79			->willReturn([]);
80
81			$this->proxyQuery->expects($this->once())
82			->method('setMaxResults')
83			->with($this->equalTo(0));
84
85			$this->proxyQuery->expects($this->once())
86			->method('setFirstResult')
87			->with($this->equalTo(0));
88
89			$this->pager->setQuery($this->proxyQuery);
90
91			// Max per page 0 means no pagination
92			$this->pager->setMaxPerPage(0);
93			$this->pager->init();
94
95			$this->assertSame(0, $this->pager->getLastPage());
96			}
97
98			public function testNoPagesForNoResults(): void
99			{
100			$this->proxyQuery->expects($this->once())
101			->method('execute')
102			->with([], PHPCRQuery::HYDRATE_PHPCR)
103			->willReturn([]);
104
105			$this->proxyQuery->expects($this->once())
106			->method('setMaxResults')
107			->with($this->equalTo(0));
108			$this->proxyQuery->expects($this->once())
109			->method('setFirstResult')
110			->with($this->equalTo(0));
111
112			$this->pager->setQuery($this->proxyQuery);
113			$this->pager->init();
114			$this->AssertEquals(0, $this->pager->getLastPage());
115			}
116
117			public function testInitNoQuery(): void
118			{
119			$this->expectException(\RuntimeException::class);
120			$this->pager->init();
121			}
122			}
123

sonata-project / SonataDoctrinePhpcrAdminBundle

Push — master ( 6b2632...1706e7 )

tests/Unit/Datagrid/PagerTest.php (2 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like