ProxyQueryTest::testGetFirstResult() - Code Metrics - Inspection of "Merge 2.x into master" - sonata-project/SonataDoctrinePhpcrAdminBundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 6b2632...1706e7 )

unknown

created 2019-10-01 00:00 UTC

ProxyQueryTest::testGetFirstResult() A

↳ Parent: ProxyQueryTest

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	7
rs	10
c	0
b	0
f	0
cc	1
nc	1
nop	0

<?php

declare(strict_types=1);

/*
 * This file is part of the Sonata Project package.
 *
 * (c) Thomas Rabaix <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Sonata\DoctrinePHPCRAdminBundle\Tests\Unit\Datagrid;

use Doctrine\ODM\PHPCR\DocumentManager;
use Doctrine\ODM\PHPCR\Query\Builder\QueryBuilder;
use Doctrine\ODM\PHPCR\Query\Query;
use PHPUnit\Framework\TestCase;
use Sonata\DoctrinePHPCRAdminBundle\Datagrid\ProxyQuery;

class ProxyQueryTest extends TestCase
{
    /**
     * @var QueryBuilder|\PHPUnit_Framework_MockObject_MockObject
     */
    private $qb;

    /**
     * @var ProxyQuery
     */
    private $pq;

    public function setUp(): void
    {
        $this->qb = $this->createMock(QueryBuilder::class);
        $this->query = $this->createMock(Query::class);
class MyClass { }

$x = new MyClass();
$x->foo = true;

        $this->pq = new ProxyQuery($this->qb, 'a');
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }

    public function testConstructor(): void
    {
        $this->assertInstanceOf(QueryBuilder::class, $this->pq->getQueryBuilder());
    }

    public function testSetSortBy(): void
    {
        $this->pq->setSortBy([], ['fieldName' => 'field']);
        $this->assertSame('field', $this->pq->getSortBy());
    }

    public function testSetSortOrder(): void
    {
        $this->pq->setSortOrder('ASC');
        $this->assertSame('ASC', $this->pq->getSortOrder());
    }

    public function testSetSortOrderInvalid(): void
    {
        $this->expectException(\InvalidArgumentException::class);

        $this->pq->setSortOrder('SOME_ORDER');
        $this->assertSame('SOME_ORDER', $this->pq->getSortOrder());
    }

    public function testSetFirstResult(): void
    {
        $this->qb->expects($this->once())
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
            ->method('setFirstResult')
            ->with($this->equalTo(19));

        $this->pq->setFirstResult(19);
    }

    public function testGetFirstResult(): void
    {
        $this->qb->expects($this->once())
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
            ->method('getFirstResult');

        $this->pq->getFirstResult();
class User
{
    private $email;

    public function getEmail()
    {
        return $this->email;
    }

    public function setEmail($email)
    {
        $this->email = $email;
    }
}
    }

    public function testSetMaxResults(): void
    {
        $this->qb->expects($this->once())
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
            ->method('setMaxResults')
            ->with($this->equalTo(29));

        $this->pq->setMaxResults(29);
    }

    public function testGetMaxResults(): void
    {
        $this->qb->expects($this->once())
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
            ->method('getMaxResults');

        $this->pq->getMaxResults();
class User
{
    private $email;

    public function getEmail()
    {
        return $this->email;
    }

    public function setEmail($email)
    {
        $this->email = $email;
    }
}
    }

    public function testExecute(): void
    {
        $this->qb->expects($this->once())
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
            ->method('getQuery')
            ->willReturn($this->query);
        $this->query->expects($this->once())
            ->method('execute')
            ->willReturn('test');

        $res = $this->pq->execute();
        $this->assertSame('test', $res);
    }

    public function testGetAndSetDocumentManager(): void
    {
        $dm = $this->createMock(DocumentManager::class);
        $this->pq->setDocumentManager($dm);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $this->assertSame($dm, $this->pq->getDocumentManager());
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			/*
6			* This file is part of the Sonata Project package.
7			*
8			* (c) Thomas Rabaix <[email protected]>
9			*
10			* For the full copyright and license information, please view the LICENSE
11			* file that was distributed with this source code.
12			*/
13
14			namespace Sonata\DoctrinePHPCRAdminBundle\Tests\Unit\Datagrid;
15
16			use Doctrine\ODM\PHPCR\DocumentManager;
17			use Doctrine\ODM\PHPCR\Query\Builder\QueryBuilder;
18			use Doctrine\ODM\PHPCR\Query\Query;
19			use PHPUnit\Framework\TestCase;
20			use Sonata\DoctrinePHPCRAdminBundle\Datagrid\ProxyQuery;
21
22			class ProxyQueryTest extends TestCase
23			{
24			/**
25			* @var QueryBuilder\|\PHPUnit_Framework_MockObject_MockObject
26			*/
27			private $qb;
28
29			/**
30			* @var ProxyQuery
31			*/
32			private $pq;
33
34			public function setUp(): void
35			{
36			$this->qb = $this->createMock(QueryBuilder::class);
37			$this->query = $this->createMock(Query::class);
			0 ignored issues – show Bug introduced 2019-05-07 06:03 UTC by Report Bug Copy Issue Report The property `query` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
38
39			$this->pq = new ProxyQuery($this->qb, 'a');
			0 ignored issues – show Documentation introduced 2018-06-19 00:19 UTC by Report Bug Copy Issue Report `$this->qb` is of type `object<PHPUnit\Framework\MockObject\MockObject>`, but the function expects a `object<Doctrine\ODM\PHPC...y\Builder\QueryBuilder>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
40			}
41
42			public function testConstructor(): void
43			{
44			$this->assertInstanceOf(QueryBuilder::class, $this->pq->getQueryBuilder());
45			}
46
47			public function testSetSortBy(): void
48			{
49			$this->pq->setSortBy([], ['fieldName' => 'field']);
50			$this->assertSame('field', $this->pq->getSortBy());
51			}
52
53			public function testSetSortOrder(): void
54			{
55			$this->pq->setSortOrder('ASC');
56			$this->assertSame('ASC', $this->pq->getSortOrder());
57			}
58
59			public function testSetSortOrderInvalid(): void
60			{
61			$this->expectException(\InvalidArgumentException::class);
62
63			$this->pq->setSortOrder('SOME_ORDER');
64			$this->assertSame('SOME_ORDER', $this->pq->getSortOrder());
65			}
66
67			public function testSetFirstResult(): void
68			{
69			$this->qb->expects($this->once())
			0 ignored issues – show Bug introduced 2015-12-19 17:51 UTC by Report Bug Copy Issue Report The method `expects` does only exist in `PHPUnit_Framework_MockObject_MockObject`, but not in `Doctrine\ODM\PHPCR\Query\Builder\QueryBuilder`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
70			->method('setFirstResult')
71			->with($this->equalTo(19));
72
73			$this->pq->setFirstResult(19);
74			}
75
76			public function testGetFirstResult(): void
77			{
78			$this->qb->expects($this->once())
			0 ignored issues – show Bug introduced 2015-12-19 17:51 UTC by Report Bug Copy Issue Report The method `expects` does only exist in `PHPUnit_Framework_MockObject_MockObject`, but not in `Doctrine\ODM\PHPCR\Query\Builder\QueryBuilder`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
79			->method('getFirstResult');
80
81			$this->pq->getFirstResult();
			0 ignored issues – show Unused Code introduced 2015-12-06 00:13 UTC by Report Bug Copy Issue Report The call to the method `Sonata\DoctrinePHPCRAdmi...Query::getFirstResult()` seems un-needed as the method has no side-effects. PHP Analyzer performs a side-effects analysis of your code. A side-effect is basically anything that might be visible after the scope of the method is left. Let’s take a look at an example: class User { private $email; public function getEmail() { return $this->email; } public function setEmail($email) { $this->email = $email; } } If we look at the `getEmail()` method, we can see that it has no side-effect. Whether you call this method or not, no future calls to other methods are affected by this. As such code as the following is useless: $user = new User(); $user->getEmail(); // This line could safely be removed as it has no effect. On the hand, if we look at the `setEmail()`, this method _has_ side-effects. In the following case, we could not remove the method call: $user = new User(); $user->setEmail('email@domain'); // This line has a side-effect (it changes an // instance variable). Loading history...
82			}
83
84			public function testSetMaxResults(): void
85			{
86			$this->qb->expects($this->once())
			0 ignored issues – show Bug introduced 2015-12-19 17:51 UTC by Report Bug Copy Issue Report The method `expects` does only exist in `PHPUnit_Framework_MockObject_MockObject`, but not in `Doctrine\ODM\PHPCR\Query\Builder\QueryBuilder`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
87			->method('setMaxResults')
88			->with($this->equalTo(29));
89
90			$this->pq->setMaxResults(29);
91			}
92
93			public function testGetMaxResults(): void
94			{
95			$this->qb->expects($this->once())
			0 ignored issues – show Bug introduced 2015-12-19 17:51 UTC by Report Bug Copy Issue Report The method `expects` does only exist in `PHPUnit_Framework_MockObject_MockObject`, but not in `Doctrine\ODM\PHPCR\Query\Builder\QueryBuilder`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
96			->method('getMaxResults');
97
98			$this->pq->getMaxResults();
			0 ignored issues – show Unused Code introduced 2015-12-06 00:13 UTC by Report Bug Copy Issue Report The call to the method `Sonata\DoctrinePHPCRAdmi...yQuery::getMaxResults()` seems un-needed as the method has no side-effects. PHP Analyzer performs a side-effects analysis of your code. A side-effect is basically anything that might be visible after the scope of the method is left. Let’s take a look at an example: class User { private $email; public function getEmail() { return $this->email; } public function setEmail($email) { $this->email = $email; } } If we look at the `getEmail()` method, we can see that it has no side-effect. Whether you call this method or not, no future calls to other methods are affected by this. As such code as the following is useless: $user = new User(); $user->getEmail(); // This line could safely be removed as it has no effect. On the hand, if we look at the `setEmail()`, this method _has_ side-effects. In the following case, we could not remove the method call: $user = new User(); $user->setEmail('email@domain'); // This line has a side-effect (it changes an // instance variable). Loading history...
99			}
100
101			public function testExecute(): void
102			{
103			$this->qb->expects($this->once())
			0 ignored issues – show Bug introduced 2015-12-19 17:51 UTC by Report Bug Copy Issue Report The method `expects` does only exist in `PHPUnit_Framework_MockObject_MockObject`, but not in `Doctrine\ODM\PHPCR\Query\Builder\QueryBuilder`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
104			->method('getQuery')
105			->willReturn($this->query);
106			$this->query->expects($this->once())
107			->method('execute')
108			->willReturn('test');
109
110			$res = $this->pq->execute();
111			$this->assertSame('test', $res);
112			}
113
114			public function testGetAndSetDocumentManager(): void
115			{
116			$dm = $this->createMock(DocumentManager::class);
117			$this->pq->setDocumentManager($dm);
			0 ignored issues – show Documentation introduced 2018-06-19 00:19 UTC by Report Bug Copy Issue Report `$dm` is of type `object<PHPUnit\Framework\MockObject\MockObject>`, but the function expects a `object<Doctrine\ODM\PHPCR\DocumentManager>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
118			$this->assertSame($dm, $this->pq->getDocumentManager());
119			}
120			}
121

sonata-project / SonataDoctrinePhpcrAdminBundle

Push — master ( 6b2632...1706e7 )

ProxyQueryTest::testGetFirstResult() A

Complexity

Size

Duplication

Importance

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like