Completed
Pull Request — 1.2 (#360)
by Wouter
16:28
created
Builder/FormContractor.php 1 patch
Unused Use Statements   -3 removed lines patch added patch discarded remove patch
@@ -14,10 +14,7 @@
 block discarded – undo
14 14
 use Sonata\AdminBundle\Admin\AdminInterface;
15 15
 use Sonata\AdminBundle\Admin\FieldDescriptionInterface;
16 16
 use Sonata\AdminBundle\Builder\FormContractorInterface;
17
-
18
-use Symfony\Component\Form\FormBuilder;
19 17
 use Symfony\Component\Form\FormFactoryInterface;
20
-
21 18
 use Doctrine\ODM\PHPCR\Mapping\ClassMetadata;
22 19
 
23 20
 class FormContractor implements FormContractorInterface
Please login to merge, or discard this patch.
Builder/ShowBuilder.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -16,7 +16,6 @@
 block discarded – undo
16 16
 use Sonata\AdminBundle\Admin\FieldDescriptionCollection;
17 17
 use Sonata\AdminBundle\Builder\ShowBuilderInterface;
18 18
 use Sonata\AdminBundle\Guesser\TypeGuesserInterface;
19
-
20 19
 use Doctrine\ODM\PHPCR\Mapping\ClassMetadata;
21 20
 
22 21
 class ShowBuilder implements ShowBuilderInterface
Please login to merge, or discard this patch.
Filter/NumberFilter.php 1 patch
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -11,8 +11,6 @@
 block discarded – undo
11 11
 
12 12
 namespace Sonata\DoctrinePHPCRAdminBundle\Filter;
13 13
 
14
-use Doctrine\ODM\PHPCR\Query\ExpressionBuilder;
15
-use Doctrine\ODM\PHPCR\Query\Expression\Comparison;
16 14
 use Sonata\AdminBundle\Form\Type\Filter\NumberType;
17 15
 use Sonata\AdminBundle\Datagrid\ProxyQueryInterface;
18 16
 
Please login to merge, or discard this patch.
Model/ModelManager.php 2 patches
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -18,12 +18,10 @@
 block discarded – undo
18 18
 use Sonata\AdminBundle\Datagrid\DatagridInterface;
19 19
 use Sonata\AdminBundle\Datagrid\ProxyQueryInterface;
20 20
 use Sonata\AdminBundle\Exception\ModelManagerException;
21
-
22 21
 use Doctrine\ODM\PHPCR\Mapping\ClassMetadata;
23 22
 use Doctrine\ODM\PHPCR\DocumentManager;
24 23
 use Doctrine\Common\Collections\ArrayCollection;
25 24
 use Doctrine\Common\Util\ClassUtils;
26
-
27 25
 use Symfony\Component\PropertyAccess\Exception\NoSuchPropertyException;
28 26
 
29 27
 class ModelManager implements ModelManagerInterface
Please login to merge, or discard this patch.
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -221,7 +221,7 @@
 block discarded – undo
221 221
     /**
222 222
      * @param ProxyQuery $query
223 223
      *
224
-     * @return mixed
224
+     * @return \PHPCR\Query\QueryResultInterface
225 225
      */
226 226
     public function executeQuery($query)
227 227
     {
Please login to merge, or discard this patch.
Tests/Datagrid/SimplePagerTest.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -12,7 +12,6 @@
 block discarded – undo
12 12
 namespace Sonata\DoctrinePHPCRAdminBundle\Tests\Datagrid;
13 13
 
14 14
 use Sonata\DoctrinePHPCRAdminBundle\Datagrid\SimplePager;
15
-use Doctrine\ODM\PHPCR\Query\Query as PHPCRQuery;
16 15
 use Doctrine\Common\Collections\ArrayCollection;
17 16
 
18 17
 class SimplePagerTest extends \PHPUnit_Framework_TestCase
Please login to merge, or discard this patch.
Tests/Route/PathInfoBuilderSlashesTest.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -12,7 +12,6 @@
 block discarded – undo
12 12
 namespace Sonata\DoctrinePHPCRAdminBundle\Tests\Route;
13 13
 
14 14
 use Sonata\DoctrinePHPCRAdminBundle\Route\PathInfoBuilderSlashes;
15
-use Sonata\AdminBundle\Translator\LabelTranslatorStrategyInterface;
16 15
 
17 16
 class PathInfoBuilderSlashesTest extends \PHPUnit_Framework_TestCase
18 17
 {
Please login to merge, or discard this patch.
Tree/PhpcrOdmTree.php 1 patch
Unused Use Statements   -3 removed lines patch added patch discarded remove patch
@@ -13,7 +13,6 @@  discard block
 block discarded – undo
13 13
 
14 14
 use Doctrine\ODM\PHPCR\Document\Generic;
15 15
 use PHPCR\Util\NodeHelper;
16
-
17 16
 use PHPCR\Util\PathHelper;
18 17
 use Symfony\Bundle\FrameworkBundle\Templating\Helper\AssetsHelper;
19 18
 use Symfony\Component\PropertyAccess\PropertyAccess;
@@ -21,10 +20,8 @@  discard block
 block discarded – undo
21 20
 use Symfony\Component\Translation\TranslatorInterface;
22 21
 use Symfony\Component\Templating\Helper\CoreAssetsHelper;
23 22
 use Symfony\Cmf\Bundle\TreeBrowserBundle\Tree\TreeInterface;
24
-
25 23
 use Doctrine\ODM\PHPCR\DocumentManager;
26 24
 use Doctrine\Common\Util\ClassUtils;
27
-
28 25
 use Sonata\AdminBundle\Admin\Pool;
29 26
 use Sonata\AdminBundle\Admin\AdminInterface;
30 27
 use Sonata\DoctrinePHPCRAdminBundle\Model\ModelManager;
Please login to merge, or discard this patch.
Builder/DatagridBuilder.php 1 patch
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -18,12 +18,10 @@
 block discarded – undo
18 18
 use Sonata\AdminBundle\Datagrid\DatagridInterface;
19 19
 use Sonata\AdminBundle\Datagrid\ProxyQueryInterface;
20 20
 use Sonata\AdminBundle\Exception\ModelManagerException;
21
-
22 21
 use Doctrine\ODM\PHPCR\Mapping\ClassMetadata;
23 22
 use Doctrine\ODM\PHPCR\DocumentManager;
24 23
 use Doctrine\Common\Collections\ArrayCollection;
25 24
 use Doctrine\Common\Util\ClassUtils;
26
-
27 25
 use Symfony\Component\PropertyAccess\Exception\NoSuchPropertyException;
28 26
 
29 27
 class ModelManager implements ModelManagerInterface
Please login to merge, or discard this patch.
Builder/ListBuilder.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -16,7 +16,6 @@
 block discarded – undo
16 16
 use Sonata\AdminBundle\Admin\FieldDescriptionCollection;
17 17
 use Sonata\AdminBundle\Builder\ShowBuilderInterface;
18 18
 use Sonata\AdminBundle\Guesser\TypeGuesserInterface;
19
-
20 19
 use Doctrine\ODM\PHPCR\Mapping\ClassMetadata;
21 20
 
22 21
 class ShowBuilder implements ShowBuilderInterface
Please login to merge, or discard this patch.