Sonata\DoctrinePHPCRAdminBundle\Filter\NumberFilter

Complexity

Total Complexity

12

Size/Duplication

Total Lines	62
Duplicated Lines	0 %

Coupling/Cohesion

Components	2
Dependencies	1

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
B	filter()	0	36	10
A	getDefaultOptions()	0	4	1
A	getRenderSettings()	0	8	1

<?php

declare(strict_types=1);

/*
 * This file is part of the Sonata Project package.
 *
 * (c) Thomas Rabaix <thomas.rabaix@sonata-project.org>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Sonata\DoctrinePHPCRAdminBundle\Filter;

use Sonata\AdminBundle\Datagrid\ProxyQueryInterface;
use Sonata\AdminBundle\Form\Type\Filter\NumberType;

class NumberFilter extends Filter
{
    /**
     * {@inheritdoc}
     */
    public function filter(ProxyQueryInterface $proxyQuery, $alias, $field, $data): void
    {
        if (!$data || !\is_array($data) || !\array_key_exists('value', $data) || !is_numeric($data['value'])) {

The expression $data of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using empty($expr) instead to make it clear that you intend to check for an array without elements.

            return;
        }

        $type = $data['type'] ?? false;
        $where = $this->getWhere($proxyQuery);

$proxyQuery of type object<Sonata\AdminBundle\Datagrid\ProxyQueryInterface> is not a sub-type of object<Sonata\DoctrinePHPCRAdminBundle\Datagrid\ProxyQuery>. It seems like you assume a concrete implementation of the interface Sonata\AdminBundle\Datagrid\ProxyQueryInterface to be always present.

        $value = $data['value'];

        switch ($type) {
            case NumberType::TYPE_GREATER_EQUAL:

The constant Sonata\AdminBundle\Form\Type\Filter\NumberType::TYPE_GREATER_EQUAL has been deprecated with message: since sonata-project/admin-bundle 3.57, to be removed with 4.0: Use NumberOperatorType::TYPE_GREATER_EQUAL instead

                $where->gte()->field('a.'.$field)->literal($value);

                break;
            case NumberType::TYPE_GREATER_THAN:

The constant Sonata\AdminBundle\Form\Type\Filter\NumberType::TYPE_GREATER_THAN has been deprecated with message: since sonata-project/admin-bundle 3.57, to be removed with 4.0: Use NumberOperatorType::TYPE_GREATER_THAN instead

                $where->gt()->field('a.'.$field)->literal($value);

                break;
            case NumberType::TYPE_LESS_EQUAL:

The constant Sonata\AdminBundle\Form\Type\Filter\NumberType::TYPE_LESS_EQUAL has been deprecated with message: since sonata-project/admin-bundle 3.57, to be removed with 4.0: Use NumberOperatorType::TYPE_LESS_EQUAL instead

                $where->lte()->field('a.'.$field)->literal($value);

                break;
            case NumberType::TYPE_LESS_THAN:

The constant Sonata\AdminBundle\Form\Type\Filter\NumberType::TYPE_LESS_THAN has been deprecated with message: since sonata-project/admin-bundle 3.57, to be removed with 4.0: Use NumberOperatorType::TYPE_LESS_THAN instead

                $where->lt()->field('a.'.$field)->literal($value);

                break;
            case NumberType::TYPE_EQUAL:

The constant Sonata\AdminBundle\Form\Type\Filter\NumberType::TYPE_EQUAL has been deprecated with message: since sonata-project/admin-bundle 3.57, to be removed with 4.0: Use NumberOperatorType::TYPE_EQUAL instead

            default:
                $where->eq()->field('a.'.$field)->literal($value);
        }

        // filter is active as we have now modified the query
        $this->active = true;
    }

    /**
     * {@inheritdoc}
     */
    public function getDefaultOptions()
    {
        return [];
    }

    /**
     * {@inheritdoc}
     */
    public function getRenderSettings()
    {
        return ['sonata_type_filter_number', [
            'field_type' => $this->getFieldType(),
            'field_options' => $this->getFieldOptions(),
            'label' => $this->getLabel(),
        ]];
    }
}