AbstractDateFilter::filter() - Code Metrics - Inspection of "Improved support for symfony3 (#614)" - sonata-project/SonataDoctrineORMAdminBundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — 3.x ( 9d3d46...b6d9a6 )

unknown

created 2016-08-16 07:37 UTC

AbstractDateFilter::filter() F

↳ Parent: AbstractDateFilter

Complexity

Conditions	31
Paths	2052

Size

Total Lines	105
Code Lines	55

Duplication

Lines	0
Ratio	0 %

Importance

Changes	5
Bugs	3	Features	0

Metric	Value
c	5
b	3
f	0
dl	0
loc	105
rs	2
cc	31
eloc	55
nc	2052
nop	4

How to fix Long Method Complexity

<?php

/*
 * This file is part of the Sonata Project package.
 *
 * (c) Thomas Rabaix <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Sonata\DoctrineORMAdminBundle\Filter;

use Sonata\AdminBundle\Datagrid\ProxyQueryInterface;
use Sonata\AdminBundle\Form\Type\Filter\DateRangeType;
use Sonata\AdminBundle\Form\Type\Filter\DateType;

abstract class AbstractDateFilter extends Filter
{
    /**
     * Flag indicating that filter will have range.
     *
     * @var bool
     */
    protected $range = false;

    /**
     * Flag indicating that filter will filter by datetime instead by date.
     *
     * @var bool
     */
    protected $time = false;

    /**
     * {@inheritdoc}
     */
    public function filter(ProxyQueryInterface $queryBuilder, $alias, $field, $data)
    {
        // check data sanity
        if (!$data || !is_array($data) || !array_key_exists('value', $data)) {
            return;
        }

        if ($this->range) {
            // additional data check for ranged items
            if (!array_key_exists('start', $data['value']) || !array_key_exists('end', $data['value'])) {
                return;
            }

            if (!$data['value']['start'] && !$data['value']['end']) {
                return;
            }

            // date filter should filter records for the whole days
            if ($this->time === false) {
                if ($data['value']['start'] instanceof \DateTime) {
                    $data['value']['start']->setTime(0, 0, 0);
                }
                if ($data['value']['end'] instanceof \DateTime) {
                    $data['value']['end']->setTime(23, 59, 59);
                }
            }

            // transform types
            if ($this->getOption('input_type') === 'timestamp') {
                $data['value']['start'] = $data['value']['start'] instanceof \DateTime ? $data['value']['start']->getTimestamp() : 0;
                $data['value']['end'] = $data['value']['end'] instanceof \DateTime ? $data['value']['end']->getTimestamp() : 0;
            }

            // default type for range filter
            $data['type'] = !isset($data['type']) || !is_numeric($data['type']) ? DateRangeType::TYPE_BETWEEN : $data['type'];

            $startDateParameterName = $this->getNewParameterName($queryBuilder);
            $endDateParameterName = $this->getNewParameterName($queryBuilder);

            if ($data['type'] == DateRangeType::TYPE_NOT_BETWEEN) {
                $this->applyWhere($queryBuilder, sprintf('%s.%s < :%s OR %s.%s > :%s', $alias, $field, $startDateParameterName, $alias, $field, $endDateParameterName));
            } else {
                if ($data['value']['start']) {
                    $this->applyWhere($queryBuilder, sprintf('%s.%s %s :%s', $alias, $field, '>=', $startDateParameterName));
                }

                if ($data['value']['end']) {
                    $this->applyWhere($queryBuilder, sprintf('%s.%s %s :%s', $alias, $field, '<=', $endDateParameterName));
                }
            }

            if ($data['value']['start']) {
                $queryBuilder->setParameter($startDateParameterName, $data['value']['start']);
            }

            if ($data['value']['end']) {
                $queryBuilder->setParameter($endDateParameterName, $data['value']['end']);
            }
        } else {
            if (!$data['value']) {
                return;
            }

            // default type for simple filter
            $data['type'] = !isset($data['type']) || !is_numeric($data['type']) ? DateType::TYPE_EQUAL : $data['type'];

            // just find an operator and apply query
            $operator = $this->getOperator($data['type']);

            // transform types
            if ($this->getOption('input_type') === 'timestamp') {
                $data['value'] = $data['value'] instanceof \DateTime ? $data['value']->getTimestamp() : 0;
            }

            // null / not null only check for col
            if (in_array($operator, array('NULL', 'NOT NULL'))) {
                $this->applyWhere($queryBuilder, sprintf('%s.%s IS %s ', $alias, $field, $operator));

                return;
            }

            $parameterName = $this->getNewParameterName($queryBuilder);

            // date filter should filter records for the whole day
            if ($this->time === false && $data['type'] == DateType::TYPE_EQUAL) {
                $this->applyWhere($queryBuilder, sprintf('%s.%s %s :%s', $alias, $field, '>=', $parameterName));
                $queryBuilder->setParameter($parameterName, $data['value']);

                $endDateParameterName = $this->getNewParameterName($queryBuilder);
                $this->applyWhere($queryBuilder, sprintf('%s.%s %s :%s', $alias, $field, '<', $endDateParameterName));
                if ($this->getOption('input_type') === 'timestamp') {
                    $endValue = strtotime('+1 day', $data['value']);
                } else {
                    $endValue = clone $data['value'];
                    $endValue->add(new \DateInterval('P1D'));
                }
                $queryBuilder->setParameter($endDateParameterName, $endValue);

                return;
            }

            $this->applyWhere($queryBuilder, sprintf('%s.%s %s :%s', $alias, $field, $operator, $parameterName));
            $queryBuilder->setParameter($parameterName, $data['value']);
        }
    }

    /**
     * {@inheritdoc}
     */
    public function getDefaultOptions()
    {
        return array(
            'input_type' => 'datetime',
        );
    }

    /**
     * {@inheritdoc}
     */
    public function getRenderSettings()
    {
        $name = 'sonata_type_filter_date';

        if ($this->time) {
            $name .= 'time';
        }

        if ($this->range) {
            $name .= '_range';
        }

        // NEXT_MAJOR: Remove this line when drop Symfony <2.8 support
        if (method_exists('Symfony\Component\Form\AbstractType', 'getBlockPrefix')) {
            $classnames = array(
                'sonata_type_filter_date' => 'Sonata\AdminBundle\Form\Type\Filter\DateType',
                'sonata_type_filter_date_range' => 'Sonata\AdminBundle\Form\Type\Filter\DateRangeType',
                'sonata_type_filter_datetime' => 'Sonata\AdminBundle\Form\Type\Filter\DateTimeType',
                'sonata_type_filter_datetime_range' => 'Sonata\AdminBundle\Form\Type\Filter\DateTimeRangeType',
            );
            $name = $classnames[$name];
        }

        return array($name, array(
            'field_type' => $this->getFieldType(),
            'field_options' => $this->getFieldOptions(),
            'label' => $this->getLabel(),
        ));
    }

    /**
     * Resolves DataType:: constants to SQL operators.
     *
     * @param int $type
     *
     * @return string
     */
    protected function getOperator($type)
    {
        $type = intval($type);

        $choices = array(
            DateType::TYPE_EQUAL => '=',
            DateType::TYPE_GREATER_EQUAL => '>=',
            DateType::TYPE_GREATER_THAN => '>',
            DateType::TYPE_LESS_EQUAL => '<=',
            DateType::TYPE_LESS_THAN => '<',
            DateType::TYPE_NULL => 'NULL',
            DateType::TYPE_NOT_NULL => 'NOT NULL',
        );

        return isset($choices[$type]) ? $choices[$type] : '=';
    }
}


1			<?php
2
3			/*
4			* This file is part of the Sonata Project package.
5			*
6			* (c) Thomas Rabaix <[email protected]>
7			*
8			* For the full copyright and license information, please view the LICENSE
9			* file that was distributed with this source code.
10			*/
11
12			namespace Sonata\DoctrineORMAdminBundle\Filter;
13
14			use Sonata\AdminBundle\Datagrid\ProxyQueryInterface;
15			use Sonata\AdminBundle\Form\Type\Filter\DateRangeType;
16			use Sonata\AdminBundle\Form\Type\Filter\DateType;
17
18			abstract class AbstractDateFilter extends Filter
19			{
20			/**
21			* Flag indicating that filter will have range.
22			*
23			* @var bool
24			*/
25			protected $range = false;
26
27			/**
28			* Flag indicating that filter will filter by datetime instead by date.
29			*
30			* @var bool
31			*/
32			protected $time = false;
33
34			/**
35			* {@inheritdoc}
36			*/
37			public function filter(ProxyQueryInterface $queryBuilder, $alias, $field, $data)
38			{
39			// check data sanity
40			if (!$data \|\| !is_array($data) \|\| !array_key_exists('value', $data)) {
41			return;
42			}
43
44			if ($this->range) {
45			// additional data check for ranged items
46			if (!array_key_exists('start', $data['value']) \|\| !array_key_exists('end', $data['value'])) {
47			return;
48			}
49
50			if (!$data['value']['start'] && !$data['value']['end']) {
51			return;
52			}
53
54			// date filter should filter records for the whole days
55			if ($this->time === false) {
56			if ($data['value']['start'] instanceof \DateTime) {
57			$data['value']['start']->setTime(0, 0, 0);
58			}
59			if ($data['value']['end'] instanceof \DateTime) {
60			$data['value']['end']->setTime(23, 59, 59);
61			}
62			}
63
64			// transform types
65			if ($this->getOption('input_type') === 'timestamp') {
66			$data['value']['start'] = $data['value']['start'] instanceof \DateTime ? $data['value']['start']->getTimestamp() : 0;
67			$data['value']['end'] = $data['value']['end'] instanceof \DateTime ? $data['value']['end']->getTimestamp() : 0;
68			}
69
70			// default type for range filter
71			$data['type'] = !isset($data['type']) \|\| !is_numeric($data['type']) ? DateRangeType::TYPE_BETWEEN : $data['type'];
72
73			$startDateParameterName = $this->getNewParameterName($queryBuilder);
74			$endDateParameterName = $this->getNewParameterName($queryBuilder);
75
76			if ($data['type'] == DateRangeType::TYPE_NOT_BETWEEN) {
77			$this->applyWhere($queryBuilder, sprintf('%s.%s < :%s OR %s.%s > :%s', $alias, $field, $startDateParameterName, $alias, $field, $endDateParameterName));
78			} else {
79			if ($data['value']['start']) {
80			$this->applyWhere($queryBuilder, sprintf('%s.%s %s :%s', $alias, $field, '>=', $startDateParameterName));
81			}
82
83			if ($data['value']['end']) {
84			$this->applyWhere($queryBuilder, sprintf('%s.%s %s :%s', $alias, $field, '<=', $endDateParameterName));
85			}
86			}
87
88			if ($data['value']['start']) {
89			$queryBuilder->setParameter($startDateParameterName, $data['value']['start']);
90			}
91
92			if ($data['value']['end']) {
93			$queryBuilder->setParameter($endDateParameterName, $data['value']['end']);
94			}
95			} else {
96			if (!$data['value']) {
97			return;
98			}
99
100			// default type for simple filter
101			$data['type'] = !isset($data['type']) \|\| !is_numeric($data['type']) ? DateType::TYPE_EQUAL : $data['type'];
102
103			// just find an operator and apply query
104			$operator = $this->getOperator($data['type']);
105
106			// transform types
107			if ($this->getOption('input_type') === 'timestamp') {
108			$data['value'] = $data['value'] instanceof \DateTime ? $data['value']->getTimestamp() : 0;
109			}
110
111			// null / not null only check for col
112			if (in_array($operator, array('NULL', 'NOT NULL'))) {
113			$this->applyWhere($queryBuilder, sprintf('%s.%s IS %s ', $alias, $field, $operator));
114
115			return;
116			}
117
118			$parameterName = $this->getNewParameterName($queryBuilder);
119
120			// date filter should filter records for the whole day
121			if ($this->time === false && $data['type'] == DateType::TYPE_EQUAL) {
122			$this->applyWhere($queryBuilder, sprintf('%s.%s %s :%s', $alias, $field, '>=', $parameterName));
123			$queryBuilder->setParameter($parameterName, $data['value']);
124
125			$endDateParameterName = $this->getNewParameterName($queryBuilder);
126			$this->applyWhere($queryBuilder, sprintf('%s.%s %s :%s', $alias, $field, '<', $endDateParameterName));
127			if ($this->getOption('input_type') === 'timestamp') {
128			$endValue = strtotime('+1 day', $data['value']);
129			} else {
130			$endValue = clone $data['value'];
131			$endValue->add(new \DateInterval('P1D'));
132			}
133			$queryBuilder->setParameter($endDateParameterName, $endValue);
134
135			return;
136			}
137
138			$this->applyWhere($queryBuilder, sprintf('%s.%s %s :%s', $alias, $field, $operator, $parameterName));
139			$queryBuilder->setParameter($parameterName, $data['value']);
140			}
141			}
142
143			/**
144			* {@inheritdoc}
145			*/
146			public function getDefaultOptions()
147			{
148			return array(
149			'input_type' => 'datetime',
150			);
151			}
152
153			/**
154			* {@inheritdoc}
155			*/
156			public function getRenderSettings()
157			{
158			$name = 'sonata_type_filter_date';
159
160			if ($this->time) {
161			$name .= 'time';
162			}
163
164			if ($this->range) {
165			$name .= '_range';
166			}
167
168			// NEXT_MAJOR: Remove this line when drop Symfony <2.8 support
169			if (method_exists('Symfony\Component\Form\AbstractType', 'getBlockPrefix')) {
170			$classnames = array(
171			'sonata_type_filter_date' => 'Sonata\AdminBundle\Form\Type\Filter\DateType',
172			'sonata_type_filter_date_range' => 'Sonata\AdminBundle\Form\Type\Filter\DateRangeType',
173			'sonata_type_filter_datetime' => 'Sonata\AdminBundle\Form\Type\Filter\DateTimeType',
174			'sonata_type_filter_datetime_range' => 'Sonata\AdminBundle\Form\Type\Filter\DateTimeRangeType',
175			);
176			$name = $classnames[$name];
177			}
178
179			return array($name, array(
180			'field_type' => $this->getFieldType(),
181			'field_options' => $this->getFieldOptions(),
182			'label' => $this->getLabel(),
183			));
184			}
185
186			/**
187			* Resolves DataType:: constants to SQL operators.
188			*
189			* @param int $type
190			*
191			* @return string
192			*/
193			protected function getOperator($type)
194			{
195			$type = intval($type);
196
197			$choices = array(
198			DateType::TYPE_EQUAL => '=',
199			DateType::TYPE_GREATER_EQUAL => '>=',
200			DateType::TYPE_GREATER_THAN => '>',
201			DateType::TYPE_LESS_EQUAL => '<=',
202			DateType::TYPE_LESS_THAN => '<',
203			DateType::TYPE_NULL => 'NULL',
204			DateType::TYPE_NOT_NULL => 'NOT NULL',
205			);
206
207			return isset($choices[$type]) ? $choices[$type] : '=';
208			}
209			}
210

sonata-project / SonataDoctrineORMAdminBundle

Push — 3.x ( 9d3d46...b6d9a6 )

AbstractDateFilter::filter() F

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

Duplication Side-by-Side

Filter issues like