ShowBuilderTest::testAddFieldWithType() - Code Metrics - Inspection of "[WIP] Add missing tests" - sonata-project/SonataDoctrineORMAdminBundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — 3.x (#807)

unknown

created 2018-02-07 21:28 UTC

ShowBuilderTest::testAddFieldWithType() B

↳ Parent: ShowBuilderTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	32
Code Lines	20

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	32
rs	8.8571
cc	1
eloc	20
nc	1
nop	0

<?php

/*
 * This file is part of the Sonata Project package.
 *
 * (c) Thomas Rabaix <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Sonata\DoctrineORMAdminBundle\Tests\Builder;

use Doctrine\ORM\Mapping\ClassMetadata;
use PHPUnit\Framework\TestCase;
use Sonata\AdminBundle\Admin\AdminInterface;
use Sonata\AdminBundle\Admin\FieldDescriptionCollection;
use Sonata\AdminBundle\Admin\FieldDescriptionInterface;
use Sonata\AdminBundle\Guesser\TypeGuesserInterface;
use Sonata\DoctrineORMAdminBundle\Builder\ShowBuilder;
use Sonata\DoctrineORMAdminBundle\Model\ModelManager;
use Symfony\Component\Form\Guess\TypeGuess;

/**
 * @author Marko Kunic <[email protected]>
 */
class ShowBuilderTest extends TestCase
{
    private $guesser;
    private $showBuilder;

    public function setUp()
    {
        $this->guesser = $this->prophesize(TypeGuesserInterface::class);

        $this->showBuilder = new ShowBuilder(
            $this->guesser->reveal(),
            ['fakeTemplate' => 'fake']
        );
    }

    public function testGetBaseList()
    {
        $this->assertInstanceOf(FieldDescriptionCollection::class, $this->showBuilder->getBaseList());
    }

    public function testAddFieldNoType()
    {
        $fieldDescriptionCollection = $this->prophesize(FieldDescriptionCollection::class);
        $fieldDescription = $this->prophesize(FieldDescriptionInterface::class);
        $admin = $this->prophesize(AdminInterface::class);
        $modelManager = $this->prophesize(ModelManager::class);
        $typeGuess = $this->prophesize(TypeGuess::class);

        $admin->getClass()->willReturn($adminClassReturn = 'FakeClass')->shouldBeCalledTimes(2);

        $fieldDescription->getName()->willReturn($fieldDescriptionNameReturn = 'FakeName')
            ->shouldBeCalledTimes(4);

        $admin->getModelManager()->willReturn($modelManager->reveal())->shouldBeCalledTimes(2);

        $typeGuess->getType()->willReturn($typeGuessReturn = 'fakeType')->shouldBeCalledTimes(1);

        $this->guesser->guessType($adminClassReturn, $fieldDescriptionNameReturn, $modelManager)
            ->willReturn($typeGuess)
            ->shouldBeCalledTimes(1);

        $fieldDescription->setType($typeGuessReturn)->shouldBeCalledTimes(1);

        $fieldDescription->setAdmin($admin)->shouldBeCalledTimes(1);

        $modelManager->hasMetadata($adminClassReturn)->willReturn(false)->shouldBeCalledTimes(1);

        $fieldDescription->getType()->willReturn(true)->shouldBeCalledTimes(1);

        $fieldDescription->setOption('code', $fieldDescriptionNameReturn)->shouldBeCalledTimes(1);
        $fieldDescription->setOption('label', $fieldDescriptionNameReturn)->shouldBeCalledTimes(1);

        $fieldDescription->getOption('code', $fieldDescriptionNameReturn)
            ->willReturn($fieldDescriptionNameReturn)
            ->shouldBeCalledTimes(1);

        $fieldDescription->getOption('label', $fieldDescriptionNameReturn)
            ->willReturn($fieldDescriptionNameReturn)
            ->shouldBeCalledTimes(1);

        $fieldDescription->getTemplate()->willReturn(true)->shouldBeCalledTimes(1);

        $fieldDescription->getMappingType()->willReturn(ClassMetadata::MANY_TO_ONE)->shouldBeCalledTimes(1);

        $admin->attachAdminClass($fieldDescription)->shouldBeCalledTimes(1);

        $admin->addShowFieldDescription($fieldDescriptionNameReturn, $fieldDescription)
            ->shouldBeCalledTimes(1);

        $fieldDescriptionCollection->add($fieldDescription)->shouldBeCalledTimes(1);

        $this->showBuilder->addField(
            $fieldDescriptionCollection->reveal(),
            null,
            $fieldDescription->reveal(),
            $admin->reveal()
        );
    }

    public function testAddFieldWithType()
    {
        $fieldDescriptionCollection = $this->prophesize(FieldDescriptionCollection::class);
        $fieldDescription = $this->prophesize(FieldDescriptionInterface::class);
        $admin = $this->prophesize(AdminInterface::class);
        $modelManager = $this->prophesize(ModelManager::class);

        $admin->getClass()->willReturn($adminClassReturn = 'FakeClass')->shouldBeCalledTimes(1);

        $fieldDescription->getName()->willReturn($fieldDescriptionNameReturn = 'FakeName')
            ->shouldBeCalledTimes(1);

        $admin->getModelManager()->willReturn($modelManager->reveal())->shouldBeCalledTimes(1);

        $fieldDescription->setType($type = 'someType')->shouldBeCalledTimes(1);
        $fieldDescription->setAdmin($admin)->shouldBeCalledTimes(1);

        $fieldDescription->setAdmin($admin)->shouldBeCalledTimes(1);

        $modelManager->hasMetadata($adminClassReturn)->willReturn(false)->shouldBeCalledTimes(1);

        $fieldDescription->getType()->willReturn(false)->shouldBeCalledTimes(1);

        $this->expectException(\RuntimeException::class);

        $this->showBuilder->addField(
            $fieldDescriptionCollection->reveal(),
            $type,
            $fieldDescription->reveal(),
            $admin->reveal()
        );
    }

    /**
     * @dataProvider testFixFieldDescriptionData
     */
    public function testFixFieldDescription($mappingType, $template)
    {
        $fieldDescription = $this->prophesize(FieldDescriptionInterface::class);
        $admin = $this->prophesize(AdminInterface::class);
        $modelManager = $this->prophesize(ModelManager::class);
        $classMetadata = $this->prophesize(ClassMetadata::class);

        $fieldDescription->setAdmin($admin)->shouldBeCalledTimes(1);

        $admin->getClass()->willReturn($adminClassReturn = 'FakeClass')->shouldBeCalledTimes(2);
        $modelManager->hasMetadata($adminClassReturn)->willReturn(true)->shouldBeCalledTimes(1);
        $admin->getModelManager()->willReturn($modelManager->reveal())->shouldBeCalledTimes(2);

        $fieldDescription->getName()->willReturn($fieldDescriptionNameReturn = 'FakeName')
            ->shouldBeCalledTimes(3);
        $modelManager->getParentMetadataForProperty($adminClassReturn, $fieldDescriptionNameReturn)
            ->willReturn([$classMetadata, 2, $parentAssociationMapping = []])
            ->shouldBeCalledTimes(1);

        $fieldDescription->setParentAssociationMappings($parentAssociationMapping)->shouldBeCalledTimes(1);

        $classMetadata->fieldMappings = [2 => $fieldMapping = 'test'];
        $fieldDescription->setFieldMapping($fieldMapping)->shouldBeCalledTimes(1);

        $classMetadata->associationMappings = [2 => $associationMapping = 'test'];
        $fieldDescription->setAssociationMapping($associationMapping)->shouldBeCalledTimes(1);

        $fieldDescription->getType()->willReturn('test')->shouldBeCalledTimes(2);

        $fieldDescription->setOption('code', $fieldDescriptionNameReturn)->shouldBeCalledTimes(1);
        $fieldDescription->setOption('label', $fieldDescriptionNameReturn)->shouldBeCalledTimes(1);
        $fieldDescription->getOption('code', $fieldDescriptionNameReturn)
            ->willReturn($fieldDescriptionNameReturn)->shouldBeCalledTimes(1);
        $fieldDescription->getOption('label', $fieldDescriptionNameReturn)
            ->willReturn($fieldDescriptionNameReturn)->shouldBeCalledTimes(1);

        $fieldDescription->getTemplate()->willReturn(false)->shouldBeCalledTimes(2);
        $fieldDescription->setTemplate(null)->shouldBeCalledTimes(1);

        $fieldDescription->getMappingType()->willReturn($mappingType)->shouldBeCalledTimes(2);

        $fieldDescription->setTemplate($template)
            ->shouldBeCalledTimes(1);

        $admin->attachAdminClass($fieldDescription)->shouldBeCalledTimes(1);

        $this->showBuilder->fixFieldDescription($admin->reveal(), $fieldDescription->reveal());
    }

    public function testFixFieldDescriptionData()
    {
        return [
            [
                ClassMetadata::ONE_TO_ONE,
                '@SonataAdmin/CRUD/Association/show_one_to_one.html.twig',
            ],
            [
                ClassMetadata::MANY_TO_ONE,
                '@SonataAdmin/CRUD/Association/show_many_to_one.html.twig',
            ],
            [
                ClassMetadata::ONE_TO_MANY,
                '@SonataAdmin/CRUD/Association/show_one_to_many.html.twig',
            ],
            [
                ClassMetadata::MANY_TO_MANY,
                '@SonataAdmin/CRUD/Association/show_many_to_many.html.twig',
            ],
        ];
    }
}


1			<?php
2
3			/*
4			* This file is part of the Sonata Project package.
5			*
6			* (c) Thomas Rabaix <[email protected]>
7			*
8			* For the full copyright and license information, please view the LICENSE
9			* file that was distributed with this source code.
10			*/
11
12			namespace Sonata\DoctrineORMAdminBundle\Tests\Builder;
13
14			use Doctrine\ORM\Mapping\ClassMetadata;
15			use PHPUnit\Framework\TestCase;
16			use Sonata\AdminBundle\Admin\AdminInterface;
17			use Sonata\AdminBundle\Admin\FieldDescriptionCollection;
18			use Sonata\AdminBundle\Admin\FieldDescriptionInterface;
19			use Sonata\AdminBundle\Guesser\TypeGuesserInterface;
20			use Sonata\DoctrineORMAdminBundle\Builder\ShowBuilder;
21			use Sonata\DoctrineORMAdminBundle\Model\ModelManager;
22			use Symfony\Component\Form\Guess\TypeGuess;
23
24			/**
25			* @author Marko Kunic <[email protected]>
26			*/
27			class ShowBuilderTest extends TestCase
28			{
29			private $guesser;
30			private $showBuilder;
31
32			public function setUp()
33			{
34			$this->guesser = $this->prophesize(TypeGuesserInterface::class);
35
36			$this->showBuilder = new ShowBuilder(
37			$this->guesser->reveal(),
38			['fakeTemplate' => 'fake']
39			);
40			}
41
42			public function testGetBaseList()
43			{
44			$this->assertInstanceOf(FieldDescriptionCollection::class, $this->showBuilder->getBaseList());
45			}
46
47			public function testAddFieldNoType()
48			{
49			$fieldDescriptionCollection = $this->prophesize(FieldDescriptionCollection::class);
50			$fieldDescription = $this->prophesize(FieldDescriptionInterface::class);
51			$admin = $this->prophesize(AdminInterface::class);
52			$modelManager = $this->prophesize(ModelManager::class);
53			$typeGuess = $this->prophesize(TypeGuess::class);
54
55			$admin->getClass()->willReturn($adminClassReturn = 'FakeClass')->shouldBeCalledTimes(2);
56
57			$fieldDescription->getName()->willReturn($fieldDescriptionNameReturn = 'FakeName')
58			->shouldBeCalledTimes(4);
59
60			$admin->getModelManager()->willReturn($modelManager->reveal())->shouldBeCalledTimes(2);
61
62			$typeGuess->getType()->willReturn($typeGuessReturn = 'fakeType')->shouldBeCalledTimes(1);
63
64			$this->guesser->guessType($adminClassReturn, $fieldDescriptionNameReturn, $modelManager)
65			->willReturn($typeGuess)
66			->shouldBeCalledTimes(1);
67
68			$fieldDescription->setType($typeGuessReturn)->shouldBeCalledTimes(1);
69
70			$fieldDescription->setAdmin($admin)->shouldBeCalledTimes(1);
71
72			$modelManager->hasMetadata($adminClassReturn)->willReturn(false)->shouldBeCalledTimes(1);
73
74			$fieldDescription->getType()->willReturn(true)->shouldBeCalledTimes(1);
75
76			$fieldDescription->setOption('code', $fieldDescriptionNameReturn)->shouldBeCalledTimes(1);
77			$fieldDescription->setOption('label', $fieldDescriptionNameReturn)->shouldBeCalledTimes(1);
78
79			$fieldDescription->getOption('code', $fieldDescriptionNameReturn)
80			->willReturn($fieldDescriptionNameReturn)
81			->shouldBeCalledTimes(1);
82
83			$fieldDescription->getOption('label', $fieldDescriptionNameReturn)
84			->willReturn($fieldDescriptionNameReturn)
85			->shouldBeCalledTimes(1);
86
87			$fieldDescription->getTemplate()->willReturn(true)->shouldBeCalledTimes(1);
88
89			$fieldDescription->getMappingType()->willReturn(ClassMetadata::MANY_TO_ONE)->shouldBeCalledTimes(1);
90
91			$admin->attachAdminClass($fieldDescription)->shouldBeCalledTimes(1);
92
93			$admin->addShowFieldDescription($fieldDescriptionNameReturn, $fieldDescription)
94			->shouldBeCalledTimes(1);
95
96			$fieldDescriptionCollection->add($fieldDescription)->shouldBeCalledTimes(1);
97
98			$this->showBuilder->addField(
99			$fieldDescriptionCollection->reveal(),
100			null,
101			$fieldDescription->reveal(),
102			$admin->reveal()
103			);
104			}
105
106			public function testAddFieldWithType()
107			{
108			$fieldDescriptionCollection = $this->prophesize(FieldDescriptionCollection::class);
109			$fieldDescription = $this->prophesize(FieldDescriptionInterface::class);
110			$admin = $this->prophesize(AdminInterface::class);
111			$modelManager = $this->prophesize(ModelManager::class);
112
113			$admin->getClass()->willReturn($adminClassReturn = 'FakeClass')->shouldBeCalledTimes(1);
114
115			$fieldDescription->getName()->willReturn($fieldDescriptionNameReturn = 'FakeName')
116			->shouldBeCalledTimes(1);
117
118			$admin->getModelManager()->willReturn($modelManager->reveal())->shouldBeCalledTimes(1);
119
120			$fieldDescription->setType($type = 'someType')->shouldBeCalledTimes(1);
121			$fieldDescription->setAdmin($admin)->shouldBeCalledTimes(1);
122
123			$fieldDescription->setAdmin($admin)->shouldBeCalledTimes(1);
124
125			$modelManager->hasMetadata($adminClassReturn)->willReturn(false)->shouldBeCalledTimes(1);
126
127			$fieldDescription->getType()->willReturn(false)->shouldBeCalledTimes(1);
128
129			$this->expectException(\RuntimeException::class);
130
131			$this->showBuilder->addField(
132			$fieldDescriptionCollection->reveal(),
133			$type,
134			$fieldDescription->reveal(),
135			$admin->reveal()
136			);
137			}
138
139			/**
140			* @dataProvider testFixFieldDescriptionData
141			*/
142			public function testFixFieldDescription($mappingType, $template)
143			{
144			$fieldDescription = $this->prophesize(FieldDescriptionInterface::class);
145			$admin = $this->prophesize(AdminInterface::class);
146			$modelManager = $this->prophesize(ModelManager::class);
147			$classMetadata = $this->prophesize(ClassMetadata::class);
148
149			$fieldDescription->setAdmin($admin)->shouldBeCalledTimes(1);
150
151			$admin->getClass()->willReturn($adminClassReturn = 'FakeClass')->shouldBeCalledTimes(2);
152			$modelManager->hasMetadata($adminClassReturn)->willReturn(true)->shouldBeCalledTimes(1);
153			$admin->getModelManager()->willReturn($modelManager->reveal())->shouldBeCalledTimes(2);
154
155			$fieldDescription->getName()->willReturn($fieldDescriptionNameReturn = 'FakeName')
156			->shouldBeCalledTimes(3);
157			$modelManager->getParentMetadataForProperty($adminClassReturn, $fieldDescriptionNameReturn)
158			->willReturn([$classMetadata, 2, $parentAssociationMapping = []])
159			->shouldBeCalledTimes(1);
160
161			$fieldDescription->setParentAssociationMappings($parentAssociationMapping)->shouldBeCalledTimes(1);
162
163			$classMetadata->fieldMappings = [2 => $fieldMapping = 'test'];
164			$fieldDescription->setFieldMapping($fieldMapping)->shouldBeCalledTimes(1);
165
166			$classMetadata->associationMappings = [2 => $associationMapping = 'test'];
167			$fieldDescription->setAssociationMapping($associationMapping)->shouldBeCalledTimes(1);
168
169			$fieldDescription->getType()->willReturn('test')->shouldBeCalledTimes(2);
170
171			$fieldDescription->setOption('code', $fieldDescriptionNameReturn)->shouldBeCalledTimes(1);
172			$fieldDescription->setOption('label', $fieldDescriptionNameReturn)->shouldBeCalledTimes(1);
173			$fieldDescription->getOption('code', $fieldDescriptionNameReturn)
174			->willReturn($fieldDescriptionNameReturn)->shouldBeCalledTimes(1);
175			$fieldDescription->getOption('label', $fieldDescriptionNameReturn)
176			->willReturn($fieldDescriptionNameReturn)->shouldBeCalledTimes(1);
177
178			$fieldDescription->getTemplate()->willReturn(false)->shouldBeCalledTimes(2);
179			$fieldDescription->setTemplate(null)->shouldBeCalledTimes(1);
180
181			$fieldDescription->getMappingType()->willReturn($mappingType)->shouldBeCalledTimes(2);
182
183			$fieldDescription->setTemplate($template)
184			->shouldBeCalledTimes(1);
185
186			$admin->attachAdminClass($fieldDescription)->shouldBeCalledTimes(1);
187
188			$this->showBuilder->fixFieldDescription($admin->reveal(), $fieldDescription->reveal());
189			}
190
191			public function testFixFieldDescriptionData()
192			{
193			return [
194			[
195			ClassMetadata::ONE_TO_ONE,
196			'@SonataAdmin/CRUD/Association/show_one_to_one.html.twig',
197			],
198			[
199			ClassMetadata::MANY_TO_ONE,
200			'@SonataAdmin/CRUD/Association/show_many_to_one.html.twig',
201			],
202			[
203			ClassMetadata::ONE_TO_MANY,
204			'@SonataAdmin/CRUD/Association/show_one_to_many.html.twig',
205			],
206			[
207			ClassMetadata::MANY_TO_MANY,
208			'@SonataAdmin/CRUD/Association/show_many_to_many.html.twig',
209			],
210			];
211			}
212			}
213

sonata-project / SonataDoctrineORMAdminBundle

Pull Request — 3.x (#807)

ShowBuilderTest::testAddFieldWithType() B

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like