StringFilter::filter() - Code Metrics - Inspection of "Manual merge" - sonata-project/SonataDoctrineORMAdminBundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#906)

by Grégoire

created 2019-02-26 06:41 UTC

StringFilter::filter() C

↳ Parent: StringFilter

Complexity

Conditions	12
Paths	34

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	12
nc	34
nop	4
dl	0
loc	48
rs	6.9666
c	0
b	0
f	0

How to fix Complexity

<?php

declare(strict_types=1);

/*
 * This file is part of the Sonata Project package.
 *
 * (c) Thomas Rabaix <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Sonata\DoctrineORMAdminBundle\Filter;

use Sonata\AdminBundle\Datagrid\ProxyQueryInterface;
use Sonata\AdminBundle\Form\Type\Filter\ChoiceType;

class StringFilter extends Filter
{
    public function filter(ProxyQueryInterface $queryBuilder, $alias, $field, $data): void
    {
        if (!$data || !\is_array($data) || !\array_key_exists('value', $data) || null === $data['value']) {

            return;
        }

        $data['value'] = trim($data['value']);

        if (0 === \strlen($data['value'])) {
            return;
        }

        $data['type'] = !isset($data['type']) ? ChoiceType::TYPE_CONTAINS : $data['type'];

        $operator = $this->getOperator((int) $data['type']);

        if (!$operator) {
''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
            $operator = 'LIKE';
        }

        // c.name > '1' => c.name OPERATOR :FIELDNAME
        $parameterName = $this->getNewParameterName($queryBuilder);

        $or = $queryBuilder->expr()->orX();

        if ($this->getOption('case_sensitive')) {
            $or->add(sprintf('%s.%s %s :%s', $alias, $field, $operator, $parameterName));
        } else {
            $or->add(sprintf('LOWER(%s.%s) %s :%s', $alias, $field, $operator, $parameterName));
        }

        if (ChoiceType::TYPE_NOT_CONTAINS === $data['type']) {
            $or->add($queryBuilder->expr()->isNull(sprintf('%s.%s', $alias, $field)));
        }

        $this->applyWhere($queryBuilder, $or);

        if (ChoiceType::TYPE_EQUAL === $data['type']) {
            $queryBuilder->setParameter($parameterName, $data['value']);
        } else {
            $queryBuilder->setParameter($parameterName,
                sprintf(
                    $this->getOption('format'),
                    $this->getOption('case_sensitive') ? $data['value'] : mb_strtolower($data['value'])
                )
            );
        }
    }

    public function getDefaultOptions()
    {
        return [
            'format' => '%%%s%%',
            'case_sensitive' => true,
        ];
    }

    public function getRenderSettings()
    {
        return [ChoiceType::class, [
            'field_type' => $this->getFieldType(),
            'field_options' => $this->getFieldOptions(),
            'label' => $this->getLabel(),
        ]];
    }

    /**
     * @param string $type
     *
     * @return bool
     */
    private function getOperator($type)
    {
        $choices = [
            ChoiceType::TYPE_CONTAINS => 'LIKE',
            ChoiceType::TYPE_NOT_CONTAINS => 'NOT LIKE',
            ChoiceType::TYPE_EQUAL => '=',
        ];

        return $choices[$type] ?? false;
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			/*
6			* This file is part of the Sonata Project package.
7			*
8			* (c) Thomas Rabaix <[email protected]>
9			*
10			* For the full copyright and license information, please view the LICENSE
11			* file that was distributed with this source code.
12			*/
13
14			namespace Sonata\DoctrineORMAdminBundle\Filter;
15
16			use Sonata\AdminBundle\Datagrid\ProxyQueryInterface;
17			use Sonata\AdminBundle\Form\Type\Filter\ChoiceType;
18
19			class StringFilter extends Filter
20			{
21			public function filter(ProxyQueryInterface $queryBuilder, $alias, $field, $data): void
22			{
23			if (!$data \|\| !\is_array($data) \|\| !\array_key_exists('value', $data) \|\| null === $data['value']) {
			0 ignored issues – show Bug Best Practice introduced 2019-02-22 14:56 UTC by Report Bug Copy Issue Report The expression `$data` of type `array` is implicitly converted to a boolean; are you sure this is intended? If so, consider using `empty($expr)` instead to make it clear that you intend to check for an array without elements. This check marks implicit conversions of arrays to boolean values in a comparison. While in PHP an empty array is considered to be equal (but not identical) to false, this is not always apparent. Consider making the comparison explicit by using `empty(..)` or `! empty(...)` instead. Loading history...
24			return;
25			}
26
27			$data['value'] = trim($data['value']);
28
29			if (0 === \strlen($data['value'])) {
30			return;
31			}
32
33			$data['type'] = !isset($data['type']) ? ChoiceType::TYPE_CONTAINS : $data['type'];
34
35			$operator = $this->getOperator((int) $data['type']);
36
37			if (!$operator) {
			0 ignored issues – show Bug Best Practice introduced 2015-11-23 21:03 UTC by Report Bug Copy Issue Report The expression `$operator` of type `string\|false` is loosely compared to `false`; this is ambiguous if the string can be empty. You might want to explicitly use `=== false` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `string` values, the empty string `''` is a special case, in particular the following results might be unexpected: '' == false // true '' == null // true 'ab' == false // false 'ab' == null // false // It is often better to use strict comparison '' === false // false '' === null // false Loading history...
38			$operator = 'LIKE';
39			}
40
41			// c.name > '1' => c.name OPERATOR :FIELDNAME
42			$parameterName = $this->getNewParameterName($queryBuilder);
43
44			$or = $queryBuilder->expr()->orX();
45
46			if ($this->getOption('case_sensitive')) {
47			$or->add(sprintf('%s.%s %s :%s', $alias, $field, $operator, $parameterName));
48			} else {
49			$or->add(sprintf('LOWER(%s.%s) %s :%s', $alias, $field, $operator, $parameterName));
50			}
51
52			if (ChoiceType::TYPE_NOT_CONTAINS === $data['type']) {
53			$or->add($queryBuilder->expr()->isNull(sprintf('%s.%s', $alias, $field)));
54			}
55
56			$this->applyWhere($queryBuilder, $or);
57
58			if (ChoiceType::TYPE_EQUAL === $data['type']) {
59			$queryBuilder->setParameter($parameterName, $data['value']);
60			} else {
61			$queryBuilder->setParameter($parameterName,
62			sprintf(
63			$this->getOption('format'),
64			$this->getOption('case_sensitive') ? $data['value'] : mb_strtolower($data['value'])
65			)
66			);
67			}
68			}
69
70			public function getDefaultOptions()
71			{
72			return [
73			'format' => '%%%s%%',
74			'case_sensitive' => true,
75			];
76			}
77
78			public function getRenderSettings()
79			{
80			return [ChoiceType::class, [
81			'field_type' => $this->getFieldType(),
82			'field_options' => $this->getFieldOptions(),
83			'label' => $this->getLabel(),
84			]];
85			}
86
87			/**
88			* @param string $type
89			*
90			* @return bool
91			*/
92			private function getOperator($type)
93			{
94			$choices = [
95			ChoiceType::TYPE_CONTAINS => 'LIKE',
96			ChoiceType::TYPE_NOT_CONTAINS => 'NOT LIKE',
97			ChoiceType::TYPE_EQUAL => '=',
98			];
99
100			return $choices[$type] ?? false;
101			}
102			}
103

sonata-project / SonataDoctrineORMAdminBundle

Pull Request — master (#906)

StringFilter::filter() C

Complexity

Size

Duplication

Importance

How to fix Complexity

Long Method

Duplication Side-by-Side

Filter issues like