TypeGuesserTest::noAssociationData() - Code Metrics - Inspection of "Manual Merge" - sonata-project/SonataDoctrineORMAdminBundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#812)

unknown

created 2018-02-13 18:04 UTC

TypeGuesserTest::noAssociationData() B

↳ Parent: TypeGuesserTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	85
Code Lines	66

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
c	1
b	0
f	1
dl	0
loc	85
rs	8.6875
cc	1
eloc	66
nc	1
nop	0

How to fix Long Method

<?php

declare(strict_types=1);

/*
 * This file is part of the Sonata Project package.
 *
 * (c) Thomas Rabaix <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Sonata\DoctrineORMAdminBundle\Tests\Guesser;

use Doctrine\ORM\Mapping\ClassMetadata;
use Doctrine\ORM\Mapping\MappingException;
use PHPUnit\Framework\TestCase;
use Sonata\DoctrineORMAdminBundle\Guesser\TypeGuesser;
use Sonata\DoctrineORMAdminBundle\Model\ModelManager;
use Symfony\Component\Form\Guess\Guess;

/**
 * @author Marko Kunic <[email protected]>
 */
class TypeGuesserTest extends TestCase
{
    private $modelManager;
    private $guesser;

    public function setUp(): void
    {
        $this->modelManager = $this->prophesize(ModelManager::class);
        $this->guesser = new TypeGuesser();
    }

    public function testGuessTypeNoMetadata(): void
    {
        $this->modelManager->getParentMetadataForProperty(
            $class = 'FakeClass',
            $property = 'fakeProperty'
        )->willThrow(MappingException::class);

        $result = $this->guesser->guessType($class, $property, $this->modelManager->reveal());

        $this->assertSame('text', $result->getType());
        $this->assertSame(Guess::LOW_CONFIDENCE, $result->getConfidence());
    }

    /**
     * @dataProvider associationData
     */
    public function testGuessTypeWithAssociation($mappingType, $type): void
    {
        $classMetadata = $this->prophesize(ClassMetadata::class);

        $classMetadata->hasAssociation($property = 'fakeProperty')->willReturn(true);
        $classMetadata->getAssociationMapping($property)
            ->willReturn(['type' => $mappingType]);

        $this->modelManager->getParentMetadataForProperty(
            $class = 'FakeClass',
            $property
        )->willReturn([$classMetadata, $property, 'notUsed']);

        $result = $this->guesser->guessType($class, $property, $this->modelManager->reveal());

        $this->assertSame($type, $result->getType());
        $this->assertSame(Guess::HIGH_CONFIDENCE, $result->getConfidence());
    }

    public function associationData(): array
    {
        return [
            'many-to-one' => [
                ClassMetadata::MANY_TO_ONE,
                'orm_many_to_one',
            ],
            'one-to-many' => [
                ClassMetadata::ONE_TO_MANY,
                'orm_one_to_many',
            ],
            'one-to-one' => [
                ClassMetadata::ONE_TO_ONE,
                'orm_one_to_one',
            ],
            'many-to-many' => [
                ClassMetadata::MANY_TO_MANY,
                'orm_many_to_many',
            ],
        ];
    }

    /**
     * @dataProvider noAssociationData
     */
    public function testGuessTypeNoAssociation($type, $resultType, $confidence): void
    {
        $classMetadata = $this->prophesize(ClassMetadata::class);

        $classMetadata->hasAssociation($property = 'fakeProperty')->willReturn(false);
        $classMetadata->getTypeOfField($property)->willReturn($type);

        $this->modelManager->getParentMetadataForProperty(
            $class = 'FakeClass',
            $property
        )->willReturn([$classMetadata, $property, 'notUsed']);

        $result = $this->guesser->guessType($class, $property, $this->modelManager->reveal());

        $this->assertSame($resultType, $result->getType());
        $this->assertSame($confidence, $result->getConfidence());
    }

    public function noAssociationData(): array
    {
        return [
            'array' => [
                $array = 'array',
                $array,
                Guess::HIGH_CONFIDENCE,
            ],
            'json' => [
                'json',
                $array,
                Guess::HIGH_CONFIDENCE,
            ],
            'boolean' => [
                $boolean = 'boolean',
                $boolean,
                Guess::HIGH_CONFIDENCE,
            ],
            'datetime' => [
                $datetime = 'datetime',
                $datetime,
                Guess::HIGH_CONFIDENCE,
            ],
            'vardatetime' => [
                'vardatetime',
                $datetime,
                Guess::HIGH_CONFIDENCE,
            ],
            'datetimetz' => [
                'datetimetz',
                $datetime,
                Guess::HIGH_CONFIDENCE,
            ],
            'date' => [
                $date = 'date',
                $date,
                Guess::HIGH_CONFIDENCE,
            ],
            'decimal' => [
                'decimal',
                $number = 'number',
                Guess::MEDIUM_CONFIDENCE,
            ],
            'float' => [
                'float',
                $number,
                Guess::MEDIUM_CONFIDENCE,
            ],
            'integer' => [
                $integer = 'integer',
                $integer,
                Guess::MEDIUM_CONFIDENCE,
            ],
            'bigint' => [
                'bigint',
                $integer,
                Guess::MEDIUM_CONFIDENCE,
            ],
            'smallint' => [
                'smallint',
                $integer,
                Guess::MEDIUM_CONFIDENCE,
            ],
            'string' => [
                'string',
                $text = 'text',
                Guess::MEDIUM_CONFIDENCE,
            ],
            'text' => [
                'text',
                'textarea',
                Guess::MEDIUM_CONFIDENCE,
            ],
            'time' => [
                $time = 'time',
                $time,
                Guess::HIGH_CONFIDENCE,
            ],
            'somefake' => [
                'somefake',
                $text,
                Guess::LOW_CONFIDENCE,
            ],
        ];
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			/*
6			* This file is part of the Sonata Project package.
7			*
8			* (c) Thomas Rabaix <[email protected]>
9			*
10			* For the full copyright and license information, please view the LICENSE
11			* file that was distributed with this source code.
12			*/
13
14			namespace Sonata\DoctrineORMAdminBundle\Tests\Guesser;
15
16			use Doctrine\ORM\Mapping\ClassMetadata;
17			use Doctrine\ORM\Mapping\MappingException;
18			use PHPUnit\Framework\TestCase;
19			use Sonata\DoctrineORMAdminBundle\Guesser\TypeGuesser;
20			use Sonata\DoctrineORMAdminBundle\Model\ModelManager;
21			use Symfony\Component\Form\Guess\Guess;
22
23			/**
24			* @author Marko Kunic <[email protected]>
25			*/
26			class TypeGuesserTest extends TestCase
27			{
28			private $modelManager;
29			private $guesser;
30
31			public function setUp(): void
32			{
33			$this->modelManager = $this->prophesize(ModelManager::class);
34			$this->guesser = new TypeGuesser();
35			}
36
37			public function testGuessTypeNoMetadata(): void
38			{
39			$this->modelManager->getParentMetadataForProperty(
40			$class = 'FakeClass',
41			$property = 'fakeProperty'
42			)->willThrow(MappingException::class);
43
44			$result = $this->guesser->guessType($class, $property, $this->modelManager->reveal());
45
46			$this->assertSame('text', $result->getType());
47			$this->assertSame(Guess::LOW_CONFIDENCE, $result->getConfidence());
48			}
49
50			/**
51			* @dataProvider associationData
52			*/
53			public function testGuessTypeWithAssociation($mappingType, $type): void
54			{
55			$classMetadata = $this->prophesize(ClassMetadata::class);
56
57			$classMetadata->hasAssociation($property = 'fakeProperty')->willReturn(true);
58			$classMetadata->getAssociationMapping($property)
59			->willReturn(['type' => $mappingType]);
60
61			$this->modelManager->getParentMetadataForProperty(
62			$class = 'FakeClass',
63			$property
64			)->willReturn([$classMetadata, $property, 'notUsed']);
65
66			$result = $this->guesser->guessType($class, $property, $this->modelManager->reveal());
67
68			$this->assertSame($type, $result->getType());
69			$this->assertSame(Guess::HIGH_CONFIDENCE, $result->getConfidence());
70			}
71
72			public function associationData(): array
73			{
74			return [
75			'many-to-one' => [
76			ClassMetadata::MANY_TO_ONE,
77			'orm_many_to_one',
78			],
79			'one-to-many' => [
80			ClassMetadata::ONE_TO_MANY,
81			'orm_one_to_many',
82			],
83			'one-to-one' => [
84			ClassMetadata::ONE_TO_ONE,
85			'orm_one_to_one',
86			],
87			'many-to-many' => [
88			ClassMetadata::MANY_TO_MANY,
89			'orm_many_to_many',
90			],
91			];
92			}
93
94			/**
95			* @dataProvider noAssociationData
96			*/
97			public function testGuessTypeNoAssociation($type, $resultType, $confidence): void
98			{
99			$classMetadata = $this->prophesize(ClassMetadata::class);
100
101			$classMetadata->hasAssociation($property = 'fakeProperty')->willReturn(false);
102			$classMetadata->getTypeOfField($property)->willReturn($type);
103
104			$this->modelManager->getParentMetadataForProperty(
105			$class = 'FakeClass',
106			$property
107			)->willReturn([$classMetadata, $property, 'notUsed']);
108
109			$result = $this->guesser->guessType($class, $property, $this->modelManager->reveal());
110
111			$this->assertSame($resultType, $result->getType());
112			$this->assertSame($confidence, $result->getConfidence());
113			}
114
115			public function noAssociationData(): array
116			{
117			return [
118			'array' => [
119			$array = 'array',
120			$array,
121			Guess::HIGH_CONFIDENCE,
122			],
123			'json' => [
124			'json',
125			$array,
126			Guess::HIGH_CONFIDENCE,
127			],
128			'boolean' => [
129			$boolean = 'boolean',
130			$boolean,
131			Guess::HIGH_CONFIDENCE,
132			],
133			'datetime' => [
134			$datetime = 'datetime',
135			$datetime,
136			Guess::HIGH_CONFIDENCE,
137			],
138			'vardatetime' => [
139			'vardatetime',
140			$datetime,
141			Guess::HIGH_CONFIDENCE,
142			],
143			'datetimetz' => [
144			'datetimetz',
145			$datetime,
146			Guess::HIGH_CONFIDENCE,
147			],
148			'date' => [
149			$date = 'date',
150			$date,
151			Guess::HIGH_CONFIDENCE,
152			],
153			'decimal' => [
154			'decimal',
155			$number = 'number',
156			Guess::MEDIUM_CONFIDENCE,
157			],
158			'float' => [
159			'float',
160			$number,
161			Guess::MEDIUM_CONFIDENCE,
162			],
163			'integer' => [
164			$integer = 'integer',
165			$integer,
166			Guess::MEDIUM_CONFIDENCE,
167			],
168			'bigint' => [
169			'bigint',
170			$integer,
171			Guess::MEDIUM_CONFIDENCE,
172			],
173			'smallint' => [
174			'smallint',
175			$integer,
176			Guess::MEDIUM_CONFIDENCE,
177			],
178			'string' => [
179			'string',
180			$text = 'text',
181			Guess::MEDIUM_CONFIDENCE,
182			],
183			'text' => [
184			'text',
185			'textarea',
186			Guess::MEDIUM_CONFIDENCE,
187			],
188			'time' => [
189			$time = 'time',
190			$time,
191			Guess::HIGH_CONFIDENCE,
192			],
193			'somefake' => [
194			'somefake',
195			$text,
196			Guess::LOW_CONFIDENCE,
197			],
198			];
199			}
200			}
201

sonata-project / SonataDoctrineORMAdminBundle

Pull Request — master (#812)

TypeGuesserTest::noAssociationData() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like