Conditions | 27 |
Paths | 252 |
Total Lines | 95 |
Code Lines | 51 |
Lines | 0 |
Ratio | 0 % |
Changes | 4 | ||
Bugs | 3 | Features | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
1 | <?php |
||
37 | public function filter(ProxyQueryInterface $queryBuilder, $alias, $field, $data) |
||
38 | { |
||
39 | // check data sanity |
||
40 | if (!$data || !is_array($data) || !array_key_exists('value', $data)) { |
||
41 | return; |
||
42 | } |
||
43 | |||
44 | if ($this->range) { |
||
45 | // additional data check for ranged items |
||
46 | if (!array_key_exists('start', $data['value']) || !array_key_exists('end', $data['value'])) { |
||
47 | return; |
||
48 | } |
||
49 | |||
50 | if (!$data['value']['start'] || !$data['value']['end']) { |
||
51 | return; |
||
52 | } |
||
53 | |||
54 | // date filter should filter records for the whole days |
||
55 | if ($this->time === false) { |
||
56 | if ($data['value']['start'] instanceof \DateTime) { |
||
57 | $data['value']['start']->setTime(0, 0, 0); |
||
58 | } |
||
59 | if ($data['value']['end'] instanceof \DateTime) { |
||
60 | $data['value']['end']->setTime(23, 59, 59); |
||
61 | } |
||
62 | } |
||
63 | |||
64 | // transform types |
||
65 | if ($this->getOption('input_type') === 'timestamp') { |
||
66 | $data['value']['start'] = $data['value']['start'] instanceof \DateTime ? $data['value']['start']->getTimestamp() : 0; |
||
67 | $data['value']['end'] = $data['value']['end'] instanceof \DateTime ? $data['value']['end']->getTimestamp() : 0; |
||
68 | } |
||
69 | |||
70 | // default type for range filter |
||
71 | $data['type'] = !isset($data['type']) || !is_numeric($data['type']) ? DateRangeType::TYPE_BETWEEN : $data['type']; |
||
72 | |||
73 | $startDateParameterName = $this->getNewParameterName($queryBuilder); |
||
74 | $endDateParameterName = $this->getNewParameterName($queryBuilder); |
||
75 | |||
76 | if ($data['type'] == DateRangeType::TYPE_NOT_BETWEEN) { |
||
77 | $this->applyWhere($queryBuilder, sprintf('%s.%s < :%s OR %s.%s > :%s', $alias, $field, $startDateParameterName, $alias, $field, $endDateParameterName)); |
||
78 | } else { |
||
79 | $this->applyWhere($queryBuilder, sprintf('%s.%s %s :%s', $alias, $field, '>=', $startDateParameterName)); |
||
80 | $this->applyWhere($queryBuilder, sprintf('%s.%s %s :%s', $alias, $field, '<=', $endDateParameterName)); |
||
81 | } |
||
82 | |||
83 | $queryBuilder->setParameter($startDateParameterName, $data['value']['start']); |
||
84 | $queryBuilder->setParameter($endDateParameterName, $data['value']['end']); |
||
85 | } else { |
||
86 | if (!$data['value']) { |
||
87 | return; |
||
88 | } |
||
89 | |||
90 | // default type for simple filter |
||
91 | $data['type'] = !isset($data['type']) || !is_numeric($data['type']) ? DateType::TYPE_EQUAL : $data['type']; |
||
92 | |||
93 | // just find an operator and apply query |
||
94 | $operator = $this->getOperator($data['type']); |
||
95 | |||
96 | // transform types |
||
97 | if ($this->getOption('input_type') === 'timestamp') { |
||
98 | $data['value'] = $data['value'] instanceof \DateTime ? $data['value']->getTimestamp() : 0; |
||
99 | } |
||
100 | |||
101 | // null / not null only check for col |
||
102 | if (in_array($operator, array('NULL', 'NOT NULL'))) { |
||
103 | $this->applyWhere($queryBuilder, sprintf('%s.%s IS %s ', $alias, $field, $operator)); |
||
104 | |||
105 | return; |
||
106 | } |
||
107 | |||
108 | $parameterName = $this->getNewParameterName($queryBuilder); |
||
109 | |||
110 | // date filter should filter records for the whole day |
||
111 | if ($this->time === false && $data['type'] == DateType::TYPE_EQUAL) { |
||
112 | $this->applyWhere($queryBuilder, sprintf('%s.%s %s :%s', $alias, $field, '>=', $parameterName)); |
||
113 | $queryBuilder->setParameter($parameterName, $data['value']); |
||
114 | |||
115 | $endDateParameterName = $this->getNewParameterName($queryBuilder); |
||
116 | $this->applyWhere($queryBuilder, sprintf('%s.%s %s :%s', $alias, $field, '<', $endDateParameterName)); |
||
117 | if ($this->getOption('input_type') === 'timestamp') { |
||
118 | $endValue = strtotime('+1 day', $data['value']); |
||
119 | } else { |
||
120 | $endValue = clone $data['value']; |
||
121 | $endValue->add(new \DateInterval('P1D')); |
||
122 | } |
||
123 | $queryBuilder->setParameter($endDateParameterName, $endValue); |
||
124 | |||
125 | return; |
||
126 | } |
||
127 | |||
128 | $this->applyWhere($queryBuilder, sprintf('%s.%s %s :%s', $alias, $field, $operator, $parameterName)); |
||
129 | $queryBuilder->setParameter($parameterName, $data['value']); |
||
130 | } |
||
131 | } |
||
132 | |||
189 |