DateRangeFilterTest::testFilterEndDate() - Code Metrics - Inspection of "Ability to use the date range filter with an open..." - sonata-project/SonataDoctrineORMAdminBundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — 3.x (#610)

by Patrick

created 2016-08-05 11:55 UTC

DateRangeFilterTest::testFilterEndDate() A

↳ Parent: DateRangeFilterTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	21
Code Lines	13

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	21
rs	9.3142
cc	1
eloc	13
nc	1
nop	0

<?php

/*
 * This file is part of the Sonata Project package.
 *
 * (c) Patrick Landolt <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Sonata\DoctrineORMAdminBundle\Tests\Filter;

use Sonata\DoctrineORMAdminBundle\Datagrid\ProxyQuery;
use Sonata\DoctrineORMAdminBundle\Filter\DateRangeFilter;

class DateRangeFilterTest extends \PHPUnit_Framework_TestCase
{
    public function testFilterEmpty()
    {
        $filter = new DateRangeFilter();
        $filter->initialize('field_name', array('field_options' => array('class' => 'FooBar')));

        $builder = new ProxyQuery(new QueryBuilder());
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

        $filter->filter($builder, 'alias', 'field', null);
        $filter->filter($builder, 'alias', 'field', '');
        $filter->filter($builder, 'alias', 'field', 'test');
        $filter->filter($builder, 'alias', 'field', false);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

        $filter->filter($builder, 'alias', 'field', array());
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $filter->filter($builder, 'alias', 'field', array(null, 'test'));
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $filter->filter($builder, 'alias', 'field', array('type' => null, 'value' => array()));
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $filter->filter($builder, 'alias', 'field', array(
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            'type' => null,
            'value' => array('start' => null, 'end' => null),
        ));
        $filter->filter($builder, 'alias', 'field', array(
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            'type' => null,
            'value' => array('start' => '', 'end' => ''),
        ));

        $this->assertSame(array(), $builder->query);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $this->assertFalse($filter->isActive());
    }

    public function testFilterStartDateAndEndDate()
    {
        $filter = new DateRangeFilter();
        $filter->initialize('field_name', array('field_options' => array('class' => 'FooBar')));

        $builder = new ProxyQuery(new QueryBuilder());
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

        $startDateTime = new \DateTime('2016-08-01');
        $endDateTime = new \DateTime('2016-08-31');

        $filter->filter($builder, 'alias', 'field', array(
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            'type' => null,
            'value' => array(
                'start' => $startDateTime,
                'end' => $endDateTime,
            ),
        ));

        $this->assertSame(array('alias.field >= :field_name_0', 'alias.field <= :field_name_1'), $builder->query);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $this->assertSame(array(
            'field_name_0' => $startDateTime,
            'field_name_1' => $endDateTime,
        ), $builder->parameters);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $this->assertTrue($filter->isActive());
    }

    public function testFilterStartDate()
    {
        $filter = new DateRangeFilter();
        $filter->initialize('field_name', array('field_options' => array('class' => 'FooBar')));

        $builder = new ProxyQuery(new QueryBuilder());
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

        $startDateTime = new \DateTime('2016-08-01');

        $filter->filter($builder, 'alias', 'field', array(
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            'type' => null,
            'value' => array(
                'start' => $startDateTime,
                'end' => '',
            ),
        ));

        $this->assertSame(array('alias.field >= :field_name_0'), $builder->query);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $this->assertSame(array('field_name_0' => $startDateTime), $builder->parameters);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $this->assertTrue($filter->isActive());
    }

    public function testFilterEndDate()
    {
        $filter = new DateRangeFilter();
        $filter->initialize('field_name', array('field_options' => array('class' => 'FooBar')));

        $builder = new ProxyQuery(new QueryBuilder());
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

        $endDateTime = new \DateTime('2016-08-31');

        $filter->filter($builder, 'alias', 'field', array(
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            'type' => null,
            'value' => array(
                'start' => '',
                'end' => $endDateTime,
            ),
        ));

        $this->assertSame(array('alias.field <= :field_name_1'), $builder->query);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $this->assertSame(array('field_name_1' => $endDateTime), $builder->parameters);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $this->assertTrue($filter->isActive());
    }
}


1			<?php
2
3			/*
4			* This file is part of the Sonata Project package.
5			*
6			* (c) Patrick Landolt <[email protected]>
7			*
8			* For the full copyright and license information, please view the LICENSE
9			* file that was distributed with this source code.
10			*/
11
12			namespace Sonata\DoctrineORMAdminBundle\Tests\Filter;
13
14			use Sonata\DoctrineORMAdminBundle\Datagrid\ProxyQuery;
15			use Sonata\DoctrineORMAdminBundle\Filter\DateRangeFilter;
16
17			class DateRangeFilterTest extends \PHPUnit_Framework_TestCase
18			{
19			public function testFilterEmpty()
20			{
21			$filter = new DateRangeFilter();
22			$filter->initialize('field_name', array('field_options' => array('class' => 'FooBar')));
23
24			$builder = new ProxyQuery(new QueryBuilder());
			0 ignored issues – show Documentation introduced 2016-08-05 11:35 UTC by Report Bug Copy Issue Report `new \Sonata\DoctrineORMA...s\Filter\QueryBuilder()` is of type `object<Sonata\DoctrineOR...ts\Filter\QueryBuilder>`, but the function expects a `object<Doctrine\ORM\QueryBuilder>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
25
26			$filter->filter($builder, 'alias', 'field', null);
27			$filter->filter($builder, 'alias', 'field', '');
28			$filter->filter($builder, 'alias', 'field', 'test');
29			$filter->filter($builder, 'alias', 'field', false);
			0 ignored issues – show Documentation introduced 2016-08-05 11:35 UTC by Report Bug Copy Issue Report `false` is of type `boolean`, but the function expects a `string`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
30
31			$filter->filter($builder, 'alias', 'field', array());
			0 ignored issues – show Documentation introduced 2016-08-05 11:35 UTC by Report Bug Copy Issue Report `array()` is of type `array`, but the function expects a `string`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
32			$filter->filter($builder, 'alias', 'field', array(null, 'test'));
			0 ignored issues – show Documentation introduced 2016-08-05 11:35 UTC by Report Bug Copy Issue Report `array(null, 'test')` is of type `array<integer,null\|strin...":"null","1":"string"}>`, but the function expects a `string`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
33			$filter->filter($builder, 'alias', 'field', array('type' => null, 'value' => array()));
			0 ignored issues – show Documentation introduced 2016-08-05 11:35 UTC by Report Bug Copy Issue Report `array('type' => null, 'value' => array())` is of type `array<string,null\|array,...null","value":"array"}>`, but the function expects a `string`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
34			$filter->filter($builder, 'alias', 'field', array(
			0 ignored issues – show Documentation introduced 2016-08-05 11:35 UTC by Report Bug Copy Issue Report `array('type' => null, 'v...> null, 'end' => null))` is of type `array<string,null\|array<...",\"end\":\"null\"}>"}>`, but the function expects a `string`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
35			'type' => null,
36			'value' => array('start' => null, 'end' => null),
37			));
38			$filter->filter($builder, 'alias', 'field', array(
			0 ignored issues – show Documentation introduced 2016-08-05 11:55 UTC by Report Bug Copy Issue Report `array('type' => null, 'v...t' => '', 'end' => ''))` is of type `array<string,null\|array<...\"end\":\"string\"}>"}>`, but the function expects a `string`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
39			'type' => null,
40			'value' => array('start' => '', 'end' => ''),
41			));
42
43			$this->assertSame(array(), $builder->query);
			0 ignored issues – show Documentation introduced 2016-08-05 11:55 UTC by Report Bug Copy Issue Report The property `query` does not exist on `object<Sonata\DoctrineOR...le\Datagrid\ProxyQuery>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
44			$this->assertFalse($filter->isActive());
45			}
46
47			public function testFilterStartDateAndEndDate()
48			{
49			$filter = new DateRangeFilter();
50			$filter->initialize('field_name', array('field_options' => array('class' => 'FooBar')));
51
52			$builder = new ProxyQuery(new QueryBuilder());
			0 ignored issues – show Documentation introduced 2016-08-05 11:55 UTC by Report Bug Copy Issue Report `new \Sonata\DoctrineORMA...s\Filter\QueryBuilder()` is of type `object<Sonata\DoctrineOR...ts\Filter\QueryBuilder>`, but the function expects a `object<Doctrine\ORM\QueryBuilder>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
53
54			$startDateTime = new \DateTime('2016-08-01');
55			$endDateTime = new \DateTime('2016-08-31');
56
57			$filter->filter($builder, 'alias', 'field', array(
			0 ignored issues – show Documentation introduced 2016-08-05 11:55 UTC by Report Bug Copy Issue Report `array('type' => null, 'v...'end' => $endDateTime))` is of type `array<string,null\|array<...object<DateTime>\"}>"}>`, but the function expects a `string`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
58			'type' => null,
59			'value' => array(
60			'start' => $startDateTime,
61			'end' => $endDateTime,
62			),
63			));
64
65			$this->assertSame(array('alias.field >= :field_name_0', 'alias.field <= :field_name_1'), $builder->query);
			0 ignored issues – show Documentation introduced 2016-08-05 11:55 UTC by Report Bug Copy Issue Report The property `query` does not exist on `object<Sonata\DoctrineOR...le\Datagrid\ProxyQuery>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
66			$this->assertSame(array(
67			'field_name_0' => $startDateTime,
68			'field_name_1' => $endDateTime,
69			), $builder->parameters);
			0 ignored issues – show Documentation introduced 2016-08-05 11:55 UTC by Report Bug Copy Issue Report The property `parameters` does not exist on `object<Sonata\DoctrineOR...le\Datagrid\ProxyQuery>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
70			$this->assertTrue($filter->isActive());
71			}
72
73			public function testFilterStartDate()
74			{
75			$filter = new DateRangeFilter();
76			$filter->initialize('field_name', array('field_options' => array('class' => 'FooBar')));
77
78			$builder = new ProxyQuery(new QueryBuilder());
			0 ignored issues – show Documentation introduced 2016-08-05 11:55 UTC by Report Bug Copy Issue Report `new \Sonata\DoctrineORMA...s\Filter\QueryBuilder()` is of type `object<Sonata\DoctrineOR...ts\Filter\QueryBuilder>`, but the function expects a `object<Doctrine\ORM\QueryBuilder>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
79
80			$startDateTime = new \DateTime('2016-08-01');
81
82			$filter->filter($builder, 'alias', 'field', array(
			0 ignored issues – show Documentation introduced 2016-08-05 11:55 UTC by Report Bug Copy Issue Report `array('type' => null, 'v...DateTime, 'end' => ''))` is of type `array<string,null\|array<...\"end\":\"string\"}>"}>`, but the function expects a `string`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
83			'type' => null,
84			'value' => array(
85			'start' => $startDateTime,
86			'end' => '',
87			),
88			));
89
90			$this->assertSame(array('alias.field >= :field_name_0'), $builder->query);
			0 ignored issues – show Documentation introduced 2016-08-05 11:55 UTC by Report Bug Copy Issue Report The property `query` does not exist on `object<Sonata\DoctrineOR...le\Datagrid\ProxyQuery>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
91			$this->assertSame(array('field_name_0' => $startDateTime), $builder->parameters);
			0 ignored issues – show Documentation introduced 2016-08-05 11:55 UTC by Report Bug Copy Issue Report The property `parameters` does not exist on `object<Sonata\DoctrineOR...le\Datagrid\ProxyQuery>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
92			$this->assertTrue($filter->isActive());
93			}
94
95			public function testFilterEndDate()
96			{
97			$filter = new DateRangeFilter();
98			$filter->initialize('field_name', array('field_options' => array('class' => 'FooBar')));
99
100			$builder = new ProxyQuery(new QueryBuilder());
			0 ignored issues – show Documentation introduced 2016-08-05 11:55 UTC by Report Bug Copy Issue Report `new \Sonata\DoctrineORMA...s\Filter\QueryBuilder()` is of type `object<Sonata\DoctrineOR...ts\Filter\QueryBuilder>`, but the function expects a `object<Doctrine\ORM\QueryBuilder>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
101
102			$endDateTime = new \DateTime('2016-08-31');
103
104			$filter->filter($builder, 'alias', 'field', array(
			0 ignored issues – show Documentation introduced 2016-08-05 11:55 UTC by Report Bug Copy Issue Report `array('type' => null, 'v...'end' => $endDateTime))` is of type `array<string,null\|array<...object<DateTime>\"}>"}>`, but the function expects a `string`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
105			'type' => null,
106			'value' => array(
107			'start' => '',
108			'end' => $endDateTime,
109			),
110			));
111
112			$this->assertSame(array('alias.field <= :field_name_1'), $builder->query);
			0 ignored issues – show Documentation introduced 2016-08-05 11:55 UTC by Report Bug Copy Issue Report The property `query` does not exist on `object<Sonata\DoctrineOR...le\Datagrid\ProxyQuery>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
113			$this->assertSame(array('field_name_1' => $endDateTime), $builder->parameters);
			0 ignored issues – show Documentation introduced 2016-08-05 11:55 UTC by Report Bug Copy Issue Report The property `parameters` does not exist on `object<Sonata\DoctrineOR...le\Datagrid\ProxyQuery>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
114			$this->assertTrue($filter->isActive());
115			}
116			}
117

sonata-project / SonataDoctrineORMAdminBundle

Pull Request — 3.x (#610)

DateRangeFilterTest::testFilterEndDate() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like