sonata-project /
SonataDoctrineORMAdminBundle
| Conditions | 31 |
| Paths | 2052 |
| Total Lines | 105 |
| Code Lines | 55 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 39 | public function filter(ProxyQueryInterface $queryBuilder, $alias, $field, $data) |
||
| 40 | { |
||
| 41 | // check data sanity |
||
| 42 | if (!$data || !is_array($data) || !array_key_exists('value', $data)) { |
||
|
|
|||
| 43 | return; |
||
| 44 | } |
||
| 45 | |||
| 46 | if ($this->range) { |
||
| 47 | // additional data check for ranged items |
||
| 48 | if (!array_key_exists('start', $data['value']) || !array_key_exists('end', $data['value'])) { |
||
| 49 | return; |
||
| 50 | } |
||
| 51 | |||
| 52 | if (!$data['value']['start'] && !$data['value']['end']) { |
||
| 53 | return; |
||
| 54 | } |
||
| 55 | |||
| 56 | // date filter should filter records for the whole days |
||
| 57 | if (false === $this->time) { |
||
| 58 | if ($data['value']['start'] instanceof \DateTime) { |
||
| 59 | $data['value']['start']->setTime(0, 0, 0); |
||
| 60 | } |
||
| 61 | if ($data['value']['end'] instanceof \DateTime) { |
||
| 62 | $data['value']['end']->setTime(23, 59, 59); |
||
| 63 | } |
||
| 64 | } |
||
| 65 | |||
| 66 | // transform types |
||
| 67 | if ('timestamp' === $this->getOption('input_type')) { |
||
| 68 | $data['value']['start'] = $data['value']['start'] instanceof \DateTime ? $data['value']['start']->getTimestamp() : 0; |
||
| 69 | $data['value']['end'] = $data['value']['end'] instanceof \DateTime ? $data['value']['end']->getTimestamp() : 0; |
||
| 70 | } |
||
| 71 | |||
| 72 | // default type for range filter |
||
| 73 | $data['type'] = !isset($data['type']) || !is_numeric($data['type']) ? DateRangeType::TYPE_BETWEEN : $data['type']; |
||
| 74 | |||
| 75 | $startDateParameterName = $this->getNewParameterName($queryBuilder); |
||
| 76 | $endDateParameterName = $this->getNewParameterName($queryBuilder); |
||
| 77 | |||
| 78 | if (DateRangeType::TYPE_NOT_BETWEEN == $data['type']) { |
||
| 79 | $this->applyWhere($queryBuilder, sprintf('%s.%s < :%s OR %s.%s > :%s', $alias, $field, $startDateParameterName, $alias, $field, $endDateParameterName)); |
||
| 80 | } else { |
||
| 81 | if ($data['value']['start']) { |
||
| 82 | $this->applyWhere($queryBuilder, sprintf('%s.%s %s :%s', $alias, $field, '>=', $startDateParameterName)); |
||
| 83 | } |
||
| 84 | |||
| 85 | if ($data['value']['end']) { |
||
| 86 | $this->applyWhere($queryBuilder, sprintf('%s.%s %s :%s', $alias, $field, '<=', $endDateParameterName)); |
||
| 87 | } |
||
| 88 | } |
||
| 89 | |||
| 90 | if ($data['value']['start']) { |
||
| 91 | $queryBuilder->setParameter($startDateParameterName, $data['value']['start']); |
||
| 92 | } |
||
| 93 | |||
| 94 | if ($data['value']['end']) { |
||
| 95 | $queryBuilder->setParameter($endDateParameterName, $data['value']['end']); |
||
| 96 | } |
||
| 97 | } else { |
||
| 98 | if (!$data['value']) { |
||
| 99 | return; |
||
| 100 | } |
||
| 101 | |||
| 102 | // default type for simple filter |
||
| 103 | $data['type'] = !isset($data['type']) || !is_numeric($data['type']) ? DateType::TYPE_EQUAL : $data['type']; |
||
| 104 | |||
| 105 | // just find an operator and apply query |
||
| 106 | $operator = $this->getOperator($data['type']); |
||
| 107 | |||
| 108 | // transform types |
||
| 109 | if ('timestamp' === $this->getOption('input_type')) { |
||
| 110 | $data['value'] = $data['value'] instanceof \DateTime ? $data['value']->getTimestamp() : 0; |
||
| 111 | } |
||
| 112 | |||
| 113 | // null / not null only check for col |
||
| 114 | if (in_array($operator, ['NULL', 'NOT NULL'])) { |
||
| 115 | $this->applyWhere($queryBuilder, sprintf('%s.%s IS %s ', $alias, $field, $operator)); |
||
| 116 | |||
| 117 | return; |
||
| 118 | } |
||
| 119 | |||
| 120 | $parameterName = $this->getNewParameterName($queryBuilder); |
||
| 121 | |||
| 122 | // date filter should filter records for the whole day |
||
| 123 | if (false === $this->time && DateType::TYPE_EQUAL == $data['type']) { |
||
| 124 | $this->applyWhere($queryBuilder, sprintf('%s.%s %s :%s', $alias, $field, '>=', $parameterName)); |
||
| 125 | $queryBuilder->setParameter($parameterName, $data['value']); |
||
| 126 | |||
| 127 | $endDateParameterName = $this->getNewParameterName($queryBuilder); |
||
| 128 | $this->applyWhere($queryBuilder, sprintf('%s.%s %s :%s', $alias, $field, '<', $endDateParameterName)); |
||
| 129 | if ('timestamp' === $this->getOption('input_type')) { |
||
| 130 | $endValue = strtotime('+1 day', $data['value']); |
||
| 131 | } else { |
||
| 132 | $endValue = clone $data['value']; |
||
| 133 | $endValue->add(new \DateInterval('P1D')); |
||
| 134 | } |
||
| 135 | $queryBuilder->setParameter($endDateParameterName, $endValue); |
||
| 136 | |||
| 137 | return; |
||
| 138 | } |
||
| 139 | |||
| 140 | $this->applyWhere($queryBuilder, sprintf('%s.%s %s :%s', $alias, $field, $operator, $parameterName)); |
||
| 141 | $queryBuilder->setParameter($parameterName, $data['value']); |
||
| 142 | } |
||
| 143 | } |
||
| 144 | |||
| 201 |
This check marks implicit conversions of arrays to boolean values in a comparison. While in PHP an empty array is considered to be equal (but not identical) to false, this is not always apparent.
Consider making the comparison explicit by using
empty(..)or! empty(...)instead.