DateTimeRangeFilterTest::testEmpty() - Code Metrics - Inspection of "add some missing tests" - sonata-project/SonataDoctrineORMAdminBundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — 3.x ( b582dd...8b3829 )

by Jordi Sala

created 2018-02-11 10:23 UTC

DateTimeRangeFilterTest::testEmpty() A

↳ Parent: DateTimeRangeFilterTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	13
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
dl	0
loc	13
rs	9.4285
c	1
b	0
f	1
cc	1
eloc	8
nc	1
nop	0

<?php

/*
 * This file is part of the Sonata Project package.
 *
 * (c) Thomas Rabaix <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Sonata\DoctrineORMAdminBundle\Tests\Filter;

use PHPUnit\Framework\TestCase;
use Sonata\CoreBundle\Form\Type\DateTimeRangeType;
use Sonata\DoctrineORMAdminBundle\Datagrid\ProxyQuery;
use Sonata\DoctrineORMAdminBundle\Filter\DateTimeRangeFilter;

/**
 * @author Marko Kunic <[email protected]>
 */
class DateTimeRangeFilterTest extends TestCase
{
    public function testEmpty()
    {
        $filter = new DateTimeRangeFilter();
        $filter->initialize('field_name', ['field_options' => ['class' => 'FooBar']]);

        $builder = new ProxyQuery(new QueryBuilder());
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

        $filter->filter($builder, 'alias', 'field', null);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $filter->filter($builder, 'alias', 'field', '');
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

        $this->assertEquals([], $builder->query);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $this->assertFalse($filter->isActive());
    }

    public function testGetType()
    {
        $this->assertSame(DateTimeRangeType::class, (new DateTimeRangeFilter())->getFieldType());
    }
}


1			<?php
2
3			/*
4			* This file is part of the Sonata Project package.
5			*
6			* (c) Thomas Rabaix <[email protected]>
7			*
8			* For the full copyright and license information, please view the LICENSE
9			* file that was distributed with this source code.
10			*/
11
12			namespace Sonata\DoctrineORMAdminBundle\Tests\Filter;
13
14			use PHPUnit\Framework\TestCase;
15			use Sonata\CoreBundle\Form\Type\DateTimeRangeType;
16			use Sonata\DoctrineORMAdminBundle\Datagrid\ProxyQuery;
17			use Sonata\DoctrineORMAdminBundle\Filter\DateTimeRangeFilter;
18
19			/**
20			* @author Marko Kunic <[email protected]>
21			*/
22			class DateTimeRangeFilterTest extends TestCase
23			{
24			public function testEmpty()
25			{
26			$filter = new DateTimeRangeFilter();
27			$filter->initialize('field_name', ['field_options' => ['class' => 'FooBar']]);
28
29			$builder = new ProxyQuery(new QueryBuilder());
			0 ignored issues – show Documentation introduced 2016-08-05 11:35 UTC by Report Bug Copy Issue Report `new \Sonata\DoctrineORMA...s\Filter\QueryBuilder()` is of type `object<Sonata\DoctrineOR...ts\Filter\QueryBuilder>`, but the function expects a `object<Doctrine\ORM\QueryBuilder>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
30
31			$filter->filter($builder, 'alias', 'field', null);
			0 ignored issues – show Documentation introduced 2018-02-09 21:02 UTC by Report Bug Copy Issue Report `null` is of type `null`, but the function expects a `array`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
32			$filter->filter($builder, 'alias', 'field', '');
			0 ignored issues – show Documentation introduced 2018-02-09 21:02 UTC by Report Bug Copy Issue Report `''` is of type `string`, but the function expects a `array`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
33
34			$this->assertEquals([], $builder->query);
			0 ignored issues – show Documentation introduced 2018-02-09 21:02 UTC by Report Bug Copy Issue Report The property `query` does not exist on `object<Sonata\DoctrineOR...le\Datagrid\ProxyQuery>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
35			$this->assertFalse($filter->isActive());
36			}
37
38			public function testGetType()
39			{
40			$this->assertSame(DateTimeRangeType::class, (new DateTimeRangeFilter())->getFieldType());
41			}
42			}
43

sonata-project / SonataDoctrineORMAdminBundle

Push — 3.x ( b582dd...8b3829 )

DateTimeRangeFilterTest::testEmpty() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like