ObjectAclManipulator::batchConfigureAcls() - Code Metrics - Inspection of "Small clanup" - sonata-project/SonataDoctrineORMAdminBundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — 3.x (#662)

unknown

created 2017-01-31 09:03 UTC

ObjectAclManipulator::batchConfigureAcls() C

↳ Parent: ObjectAclManipulator

Complexity

Conditions	8
Paths	63

Size

Total Lines	63
Code Lines	41

Duplication

Lines	0
Ratio	0 %

Importance

Changes	3
Bugs	2	Features	0

Metric	Value
dl	0
loc	63
rs	6.8825
c	3
b	2
f	0
cc	8
eloc	41
nc	63
nop	3

How to fix Long Method

<?php

/*
 * This file is part of the Sonata Project package.
 *
 * (c) Thomas Rabaix <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Sonata\DoctrineORMAdminBundle\Util;

use Sonata\AdminBundle\Admin\AdminInterface;
use Sonata\AdminBundle\Exception\ModelManagerException;
use Sonata\AdminBundle\Security\Handler\AclSecurityHandlerInterface;
use Sonata\AdminBundle\Util\ObjectAclManipulator as BaseObjectAclManipulator;
use Symfony\Component\Console\Output\OutputInterface;
use Symfony\Component\Security\Acl\Domain\ObjectIdentity;
use Symfony\Component\Security\Acl\Domain\UserSecurityIdentity;

class ObjectAclManipulator extends BaseObjectAclManipulator
{
    /**
     * {@inheritdoc}
     */
    public function batchConfigureAcls(OutputInterface $output, AdminInterface $admin, UserSecurityIdentity $securityIdentity = null)
    {
        $securityHandler = $admin->getSecurityHandler();
        if (!$securityHandler instanceof AclSecurityHandlerInterface) {
            $output->writeln('Admin class is not configured to use ACL : <info>ignoring</info>');

            return;
        }

        $output->writeln(sprintf(' > generate ACLs for %s', $admin->getCode()));
        $objectOwnersMsg = is_null($securityIdentity) ? '' : ' and set the object owner';

        $em = $admin->getModelManager()->getEntityManager($admin->getClass());
        $qb = $em->createQueryBuilder();
        $qb->select('o')->from($admin->getClass(), 'o');

        $count = 0;
        $countUpdated = 0;
        $countAdded = 0;

        try {
            $batchSize = 20;
            $batchSizeOutput = 200;
            $objectIds = array();

            foreach ($qb->getQuery()->iterate() as $row) {
                $objectIds[] = ObjectIdentity::fromDomainObject($row[0]);
                $objectIdIterator = new \ArrayIterator($objectIds);

                // detach from Doctrine, so that it can be Garbage-Collected immediately
                $em->detach($row[0]);

                ++$count;

                if (($count % $batchSize) == 0) {
                    list($batchAdded, $batchUpdated) = $this->configureAcls($output, $admin, $objectIdIterator, $securityIdentity);
                    $countAdded += $batchAdded;
                    $countUpdated += $batchUpdated;
                    $objectIds = array();
                }

                if (($count % $batchSizeOutput) == 0) {
                    $output->writeln(sprintf('   - generated class ACEs%s for %s objects (added %s, updated %s)', $objectOwnersMsg, $count, $countAdded, $countUpdated));
                }
            }

            if (count($objectIds) > 0) {
                list($batchAdded, $batchUpdated) = $this->configureAcls($output, $admin, $objectIdIterator, $securityIdentity);
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
                $countAdded += $batchAdded;
                $countUpdated += $batchUpdated;
            }
        } catch (\PDOException $e) {
            throw new ModelManagerException('', 0, $e);
        }

        $output->writeln(sprintf(
            '   - [TOTAL] generated class ACEs%s for %s objects (added %s, updated %s)',
            $objectOwnersMsg,
            $count,
            $countAdded,
            $countUpdated
        ));
    }
}


1			<?php
2
3			/*
4			* This file is part of the Sonata Project package.
5			*
6			* (c) Thomas Rabaix <[email protected]>
7			*
8			* For the full copyright and license information, please view the LICENSE
9			* file that was distributed with this source code.
10			*/
11
12			namespace Sonata\DoctrineORMAdminBundle\Util;
13
14			use Sonata\AdminBundle\Admin\AdminInterface;
15			use Sonata\AdminBundle\Exception\ModelManagerException;
16			use Sonata\AdminBundle\Security\Handler\AclSecurityHandlerInterface;
17			use Sonata\AdminBundle\Util\ObjectAclManipulator as BaseObjectAclManipulator;
18			use Symfony\Component\Console\Output\OutputInterface;
19			use Symfony\Component\Security\Acl\Domain\ObjectIdentity;
20			use Symfony\Component\Security\Acl\Domain\UserSecurityIdentity;
21
22			class ObjectAclManipulator extends BaseObjectAclManipulator
23			{
24			/**
25			* {@inheritdoc}
26			*/
27			public function batchConfigureAcls(OutputInterface $output, AdminInterface $admin, UserSecurityIdentity $securityIdentity = null)
28			{
29			$securityHandler = $admin->getSecurityHandler();
30			if (!$securityHandler instanceof AclSecurityHandlerInterface) {
31			$output->writeln('Admin class is not configured to use ACL : <info>ignoring</info>');
32
33			return;
34			}
35
36			$output->writeln(sprintf(' > generate ACLs for %s', $admin->getCode()));
37			$objectOwnersMsg = is_null($securityIdentity) ? '' : ' and set the object owner';
38
39			$em = $admin->getModelManager()->getEntityManager($admin->getClass());
40			$qb = $em->createQueryBuilder();
41			$qb->select('o')->from($admin->getClass(), 'o');
42
43			$count = 0;
44			$countUpdated = 0;
45			$countAdded = 0;
46
47			try {
48			$batchSize = 20;
49			$batchSizeOutput = 200;
50			$objectIds = array();
51
52			foreach ($qb->getQuery()->iterate() as $row) {
53			$objectIds[] = ObjectIdentity::fromDomainObject($row[0]);
54			$objectIdIterator = new \ArrayIterator($objectIds);
55
56			// detach from Doctrine, so that it can be Garbage-Collected immediately
57			$em->detach($row[0]);
58
59			++$count;
60
61			if (($count % $batchSize) == 0) {
62			list($batchAdded, $batchUpdated) = $this->configureAcls($output, $admin, $objectIdIterator, $securityIdentity);
63			$countAdded += $batchAdded;
64			$countUpdated += $batchUpdated;
65			$objectIds = array();
66			}
67
68			if (($count % $batchSizeOutput) == 0) {
69			$output->writeln(sprintf(' - generated class ACEs%s for %s objects (added %s, updated %s)', $objectOwnersMsg, $count, $countAdded, $countUpdated));
70			}
71			}
72
73			if (count($objectIds) > 0) {
74			list($batchAdded, $batchUpdated) = $this->configureAcls($output, $admin, $objectIdIterator, $securityIdentity);
			0 ignored issues – show Bug introduced 2015-11-23 21:03 UTC by Report Bug Copy Issue Report The variable `$objectIdIterator` does not seem to be defined for all execution paths leading up to this point. If you define a variable conditionally, it can happen that it is not defined for all execution paths. Let’s take a look at an example: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } // $x is potentially undefined here. echo $x; } In the above example, the variable `$x` is defined if you pass “foo” or “bar” as argument for `$a`. However, since the `switch` statement has no default case statement, if you pass any other value, the variable `$x` would be undefined. Available Fixes Check for existence of the variable explicitly: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } if (isset($x)) { // Make sure it's always set. echo $x; } } Define a default value for the variable: function myFunction($a) { $x = ''; // Set a default which gets overridden for certain paths. switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } echo $x; } Add a value for the missing path: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; // We add support for the missing case. default: $x = ''; break; } echo $x; } Loading history...
75			$countAdded += $batchAdded;
76			$countUpdated += $batchUpdated;
77			}
78			} catch (\PDOException $e) {
79			throw new ModelManagerException('', 0, $e);
80			}
81
82			$output->writeln(sprintf(
83			' - [TOTAL] generated class ACEs%s for %s objects (added %s, updated %s)',
84			$objectOwnersMsg,
85			$count,
86			$countAdded,
87			$countUpdated
88			));
89			}
90			}
91

sonata-project / SonataDoctrineORMAdminBundle

Pull Request — 3.x (#662)

ObjectAclManipulator::batchConfigureAcls() C

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Available Fixes

Duplication Side-by-Side

Filter issues like