| Conditions | 12 |
| Paths | 66 |
| Total Lines | 33 |
| Code Lines | 19 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 2 | ||
| Bugs | 0 | Features | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 27 | public function filter(ProxyQueryInterface $queryBuilder, $name, $field, $data) |
||
| 28 | { |
||
| 29 | if (!$data || !is_array($data) || !array_key_exists('value', $data)) { |
||
| 30 | return; |
||
| 31 | } |
||
| 32 | |||
| 33 | $data['value'] = trim($data['value']); |
||
| 34 | |||
| 35 | if (strlen($data['value']) == 0) { |
||
| 36 | return; |
||
| 37 | } |
||
| 38 | |||
| 39 | $data['type'] = isset($data['type']) && !empty($data['type']) ? $data['type'] : ChoiceType::TYPE_CONTAINS; |
||
| 40 | |||
| 41 | $obj = $queryBuilder; |
||
| 42 | if ($this->condition == self::CONDITION_OR) { |
||
| 43 | $obj = $queryBuilder->expr(); |
||
| 44 | } |
||
| 45 | |||
| 46 | if ($data['type'] == ChoiceType::TYPE_EQUAL) { |
||
| 47 | $obj->field($field)->equals($data['value']); |
||
| 48 | } elseif ($data['type'] == ChoiceType::TYPE_CONTAINS) { |
||
| 49 | $obj->field($field)->equals(new \MongoRegex(sprintf('/%s/i', $data['value']))); |
||
| 50 | } elseif ($data['type'] == ChoiceType::TYPE_NOT_CONTAINS) { |
||
| 51 | $obj->field($field)->not(new \MongoRegex(sprintf('/%s/i', $data['value']))); |
||
| 52 | } |
||
| 53 | |||
| 54 | if ($this->condition == self::CONDITION_OR) { |
||
| 55 | $queryBuilder->addOr($obj); |
||
| 56 | } |
||
| 57 | |||
| 58 | $this->active = true; |
||
| 59 | } |
||
| 60 | |||
| 78 |
This check looks for PHPDoc comments describing methods or function parameters that do not exist on the corresponding method or function.
Consider the following example. The parameter
$italyis not defined by the methodfinale(...).The most likely cause is that the parameter was removed, but the annotation was not.