ObjectAclManipulator::batchConfigureAcls() - Code Metrics - Inspection of "Some small changes" - sonata-project/SonataDoctrineMongoDBAdminBundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — 3.x (#204)

unknown

created 2017-02-10 08:19 UTC

ObjectAclManipulator::batchConfigureAcls() C

↳ Parent: ObjectAclManipulator

Complexity

Conditions	8
Paths	63

Size

Total Lines	69
Code Lines	45

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
dl	0
loc	69
rs	6.5437
c	1
b	0
f	0
cc	8
eloc	45
nc	63
nop	3

How to fix Long Method

<?php

/*
 * This file is part of the Sonata Project package.
 *
 * (c) Thomas Rabaix <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Sonata\DoctrineMongoDBAdminBundle\Util;

use Doctrine\ODM\MongoDB\DocumentManager;
use Sonata\AdminBundle\Admin\AdminInterface;
use Sonata\AdminBundle\Exception\ModelManagerException;
use Sonata\AdminBundle\Security\Handler\AclSecurityHandlerInterface;
use Sonata\AdminBundle\Util\ObjectAclManipulator as BaseObjectAclManipulator;
use Symfony\Component\Console\Output\OutputInterface;
use Symfony\Component\Security\Acl\Domain\ObjectIdentity;
use Symfony\Component\Security\Acl\Domain\UserSecurityIdentity;

class ObjectAclManipulator extends BaseObjectAclManipulator
{
    /**
     * {@inheritdoc}
     */
    public function batchConfigureAcls(OutputInterface $output, AdminInterface $admin, UserSecurityIdentity $securityIdentity = null)
    {
        $securityHandler = $admin->getSecurityHandler();
        if (!$securityHandler instanceof AclSecurityHandlerInterface) {
            $output->writeln('Admin class is not configured to use ACL : <info>ignoring</info>');

            return;
        }

        $output->writeln(sprintf(' > generate ACLs for %s', $admin->getCode()));
        $objectOwnersMsg = is_null($securityIdentity) ? '' : ' and set the object owner';

        /** @var DocumentManager $om */
        $om = $admin->getModelManager()->getDocumentManager();
        $qb = $om->createQueryBuilder($admin->getClass());

        $count = 0;
        $countUpdated = 0;
        $countAdded = 0;

        try {
            $batchSize = 20;
            $batchSizeOutput = 200;
            $objectIds = array();

            foreach ($qb->getQuery()->iterate() as $row) {
                $objectIds[] = ObjectIdentity::fromDomainObject($row);
                $objectIdIterator = new \ArrayIterator($objectIds);

                // detach from Doctrine, so that it can be Garbage-Collected immediately
                $om->detach($row);

                ++$count;

                if (($count % $batchSize) == 0) {
                    list($batchAdded, $batchUpdated) = $this->configureAcls($output, $admin, $objectIdIterator, $securityIdentity);
                    $countAdded += $batchAdded;
                    $countUpdated += $batchUpdated;
                    $objectIds = array();
                }

                if (($count % $batchSizeOutput) == 0) {
                    $output->writeln(sprintf(
                        '   - generated class ACEs%s for %s objects (added %s, updated %s)',
                        $objectOwnersMsg,
                        $count,
                        $countAdded,
                        $countUpdated
                    ));
                }
            }

            if (count($objectIds) > 0) {
                list($batchAdded, $batchUpdated) = $this->configureAcls($output, $admin, $objectIdIterator, $securityIdentity);
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
                $countAdded += $batchAdded;
                $countUpdated += $batchUpdated;
            }
        } catch (\BadMethodCallException $e) {
            throw new ModelManagerException('', 0, $e);
        }

        $output->writeln(sprintf(
            '   - [TOTAL] generated class ACEs%s for %s objects (added %s, updated %s)',
            $objectOwnersMsg,
            $count,
            $countAdded,
            $countUpdated
        ));
    }
}


1			<?php
2
3			/*
4			* This file is part of the Sonata Project package.
5			*
6			* (c) Thomas Rabaix <[email protected]>
7			*
8			* For the full copyright and license information, please view the LICENSE
9			* file that was distributed with this source code.
10			*/
11
12			namespace Sonata\DoctrineMongoDBAdminBundle\Util;
13
14			use Doctrine\ODM\MongoDB\DocumentManager;
15			use Sonata\AdminBundle\Admin\AdminInterface;
16			use Sonata\AdminBundle\Exception\ModelManagerException;
17			use Sonata\AdminBundle\Security\Handler\AclSecurityHandlerInterface;
18			use Sonata\AdminBundle\Util\ObjectAclManipulator as BaseObjectAclManipulator;
19			use Symfony\Component\Console\Output\OutputInterface;
20			use Symfony\Component\Security\Acl\Domain\ObjectIdentity;
21			use Symfony\Component\Security\Acl\Domain\UserSecurityIdentity;
22
23			class ObjectAclManipulator extends BaseObjectAclManipulator
24			{
25			/**
26			* {@inheritdoc}
27			*/
28			public function batchConfigureAcls(OutputInterface $output, AdminInterface $admin, UserSecurityIdentity $securityIdentity = null)
29			{
30			$securityHandler = $admin->getSecurityHandler();
31			if (!$securityHandler instanceof AclSecurityHandlerInterface) {
32			$output->writeln('Admin class is not configured to use ACL : <info>ignoring</info>');
33
34			return;
35			}
36
37			$output->writeln(sprintf(' > generate ACLs for %s', $admin->getCode()));
38			$objectOwnersMsg = is_null($securityIdentity) ? '' : ' and set the object owner';
39
40			/** @var DocumentManager $om */
41			$om = $admin->getModelManager()->getDocumentManager();
42			$qb = $om->createQueryBuilder($admin->getClass());
43
44			$count = 0;
45			$countUpdated = 0;
46			$countAdded = 0;
47
48			try {
49			$batchSize = 20;
50			$batchSizeOutput = 200;
51			$objectIds = array();
52
53			foreach ($qb->getQuery()->iterate() as $row) {
54			$objectIds[] = ObjectIdentity::fromDomainObject($row);
55			$objectIdIterator = new \ArrayIterator($objectIds);
56
57			// detach from Doctrine, so that it can be Garbage-Collected immediately
58			$om->detach($row);
59
60			++$count;
61
62			if (($count % $batchSize) == 0) {
63			list($batchAdded, $batchUpdated) = $this->configureAcls($output, $admin, $objectIdIterator, $securityIdentity);
64			$countAdded += $batchAdded;
65			$countUpdated += $batchUpdated;
66			$objectIds = array();
67			}
68
69			if (($count % $batchSizeOutput) == 0) {
70			$output->writeln(sprintf(
71			' - generated class ACEs%s for %s objects (added %s, updated %s)',
72			$objectOwnersMsg,
73			$count,
74			$countAdded,
75			$countUpdated
76			));
77			}
78			}
79
80			if (count($objectIds) > 0) {
81			list($batchAdded, $batchUpdated) = $this->configureAcls($output, $admin, $objectIdIterator, $securityIdentity);
			0 ignored issues – show Bug introduced 2015-12-14 09:14 UTC by Report Bug Copy Issue Report The variable `$objectIdIterator` does not seem to be defined for all execution paths leading up to this point. If you define a variable conditionally, it can happen that it is not defined for all execution paths. Let’s take a look at an example: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } // $x is potentially undefined here. echo $x; } In the above example, the variable `$x` is defined if you pass “foo” or “bar” as argument for `$a`. However, since the `switch` statement has no default case statement, if you pass any other value, the variable `$x` would be undefined. Available Fixes Check for existence of the variable explicitly: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } if (isset($x)) { // Make sure it's always set. echo $x; } } Define a default value for the variable: function myFunction($a) { $x = ''; // Set a default which gets overridden for certain paths. switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } echo $x; } Add a value for the missing path: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; // We add support for the missing case. default: $x = ''; break; } echo $x; } Loading history...
82			$countAdded += $batchAdded;
83			$countUpdated += $batchUpdated;
84			}
85			} catch (\BadMethodCallException $e) {
86			throw new ModelManagerException('', 0, $e);
87			}
88
89			$output->writeln(sprintf(
90			' - [TOTAL] generated class ACEs%s for %s objects (added %s, updated %s)',
91			$objectOwnersMsg,
92			$count,
93			$countAdded,
94			$countUpdated
95			));
96			}
97			}
98

sonata-project / SonataDoctrineMongoDBAdminBundle

Pull Request — 3.x (#204)

ObjectAclManipulator::batchConfigureAcls() C

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Available Fixes

Duplication Side-by-Side

Filter issues like