Completed
Push — master ( 4a2acb...1a7b0d )
by Grégoire
12s queued 10s
created

NumberFilterTest   A

Complexity

Total Complexity 4

Size/Duplication

Total Lines 70
Duplicated Lines 0 %

Coupling/Cohesion

Components 1
Dependencies 3

Importance

Changes 0
Metric Value
wmc 4
lcom 1
cbo 3
dl 0
loc 70
rs 10
c 0
b 0
f 0

4 Methods

Rating   Name   Duplication   Size   Complexity  
A testFilterEmpty() 0 17 1
A testFilterInvalidOperator() 0 16 1
A testFilter() 0 17 1
A getNumberExamples() 0 11 1
1
<?php
2
3
declare(strict_types=1);
4
5
/*
6
 * This file is part of the Sonata Project package.
7
 *
8
 * (c) Thomas Rabaix <[email protected]>
9
 *
10
 * For the full copyright and license information, please view the LICENSE
11
 * file that was distributed with this source code.
12
 */
13
14
namespace Sonata\DoctrineMongoDBAdminBundle\Tests\Filter;
15
16
use Sonata\AdminBundle\Form\Type\Filter\NumberType;
17
use Sonata\DoctrineMongoDBAdminBundle\Datagrid\ProxyQuery;
18
use Sonata\DoctrineMongoDBAdminBundle\Filter\NumberFilter;
19
20
class NumberFilterTest extends FilterWithQueryBuilderTest
21
{
22
    public function testFilterEmpty(): void
23
    {
24
        $filter = new NumberFilter();
25
        $filter->initialize('field_name', ['field_options' => ['class' => 'FooBar']]);
26
27
        $builder = new ProxyQuery($this->getQueryBuilder());
28
29
        $builder->getQueryBuilder()
0 ignored issues
show
Bug introduced by
The method expects() does not seem to exist on object<Doctrine\ODM\MongoDB\Query\Builder>.

This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces.

This is most likely a typographical error or the method has been renamed.

Loading history...
30
            ->expects($this->never())
31
            ->method('field')
32
        ;
33
34
        $filter->filter($builder, 'alias', 'field', null);
35
        $filter->filter($builder, 'alias', 'field', 'asds');
36
37
        $this->assertFalse($filter->isActive());
38
    }
39
40
    public function testFilterInvalidOperator(): void
41
    {
42
        $filter = new NumberFilter();
43
        $filter->initialize('field_name', ['field_options' => ['class' => 'FooBar']]);
44
45
        $builder = new ProxyQuery($this->getQueryBuilder());
46
47
        $builder->getQueryBuilder()
0 ignored issues
show
Bug introduced by
The method expects() does not seem to exist on object<Doctrine\ODM\MongoDB\Query\Builder>.

This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces.

This is most likely a typographical error or the method has been renamed.

Loading history...
48
            ->expects($this->never())
49
            ->method('field')
50
        ;
51
52
        $filter->filter($builder, 'alias', 'field', ['type' => 'foo']);
0 ignored issues
show
Documentation introduced by
array('type' => 'foo') is of type array<string,string,{"type":"string"}>, but the function expects a string.

It seems like the type of the argument is not accepted by the function/method which you are calling.

In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug.

We suggest to add an explicit type cast like in the following example:

function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
Loading history...
53
54
        $this->assertFalse($filter->isActive());
55
    }
56
57
    /**
58
     * @dataProvider getNumberExamples
59
     */
60
    public function testFilter(array $data, string $method): void
61
    {
62
        $filter = new NumberFilter();
63
        $filter->initialize('field_name', ['field_options' => ['class' => 'FooBar']]);
64
65
        $builder = new ProxyQuery($this->getQueryBuilder());
66
67
        $builder->getQueryBuilder()
0 ignored issues
show
Bug introduced by
The method expects() does not seem to exist on object<Doctrine\ODM\MongoDB\Query\Builder>.

This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces.

This is most likely a typographical error or the method has been renamed.

Loading history...
68
            ->expects($this->once())
69
            ->method($method)
70
            ->with($data['value'])
71
        ;
72
73
        $filter->filter($builder, 'alias', 'field', $data);
0 ignored issues
show
Documentation introduced by
$data is of type array, but the function expects a string.

It seems like the type of the argument is not accepted by the function/method which you are calling.

In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug.

We suggest to add an explicit type cast like in the following example:

function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
Loading history...
74
75
        $this->assertTrue($filter->isActive());
76
    }
77
78
    public function getNumberExamples(): array
79
    {
80
        return [
81
            [['type' => NumberType::TYPE_EQUAL, 'value' => 42], 'equals'],
82
            [['type' => NumberType::TYPE_GREATER_EQUAL, 'value' => 42], 'gte'],
83
            [['type' => NumberType::TYPE_GREATER_THAN, 'value' => 42], 'gt'],
84
            [['type' => NumberType::TYPE_LESS_EQUAL, 'value' => 42], 'lte'],
85
            [['type' => NumberType::TYPE_LESS_THAN, 'value' => 42], 'lt'],
86
            [['value' => 42], 'equals'],
87
        ];
88
    }
89
}
90