sonata-project /
SonataDoctrineMongoDBAdminBundle
| Conditions | 12 |
| Paths | 12 |
| Total Lines | 33 |
| Code Lines | 19 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 1 | ||
| Bugs | 0 | Features | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 27 | public function filter(ProxyQueryInterface $queryBuilder, $alias, $field, $data) |
||
| 28 | { |
||
| 29 | if (!$data || !is_array($data) || !array_key_exists('type', $data) || !array_key_exists('value', $data)) { |
||
| 30 | return; |
||
| 31 | } |
||
| 32 | |||
| 33 | if (is_array($data['value'])) { |
||
| 34 | $values = array(); |
||
| 35 | foreach ($data['value'] as $v) { |
||
| 36 | if (!in_array($v, array(BooleanType::TYPE_NO, BooleanType::TYPE_YES))) { |
||
| 37 | continue; |
||
| 38 | } |
||
| 39 | |||
| 40 | $values[] = ($v == BooleanType::TYPE_YES) ? true : false; |
||
| 41 | } |
||
| 42 | |||
| 43 | if (count($values) == 0) { |
||
| 44 | return; |
||
| 45 | } |
||
| 46 | |||
| 47 | $queryBuilder->field($field)->in($values); |
||
| 48 | $this->active = true; |
||
| 49 | } else { |
||
| 50 | if (!in_array($data['value'], array(BooleanType::TYPE_NO, BooleanType::TYPE_YES))) { |
||
| 51 | return; |
||
| 52 | } |
||
| 53 | |||
| 54 | $value = BooleanType::TYPE_YES == $data['value'] ? true : false; |
||
| 55 | |||
| 56 | $queryBuilder->field($field)->equals($value); |
||
| 57 | $this->active = true; |
||
| 58 | } |
||
| 59 | } |
||
| 60 | |||
| 80 |
