ShowBuilder::fixFieldDescription() - Code Metrics - Inspection of "adds php-cs-fixer-styleci-bridge to dev dependenci..." - sonata-project/SonataDoctrineMongoDBAdminBundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — 3.x ( 839353...0c5d0b )

by Grégoire

created 2016-06-24 07:11 UTC

ShowBuilder::fixFieldDescription() C

↳ Parent: ShowBuilder

Complexity

Conditions	12
Paths	175

Size

Total Lines	52
Code Lines	27

Duplication

Lines	0
Ratio	0 %

Importance

Changes	3
Bugs	1	Features	0

Metric	Value
c	3
b	1
f	0
dl	0
loc	52
rs	5.4871
cc	12
eloc	27
nc	175
nop	2

How to fix Long Method Complexity

<?php

/*
 * This file is part of the Sonata Project package.
 *
 * (c) Thomas Rabaix <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Sonata\DoctrineMongoDBAdminBundle\Builder;

use Doctrine\ODM\MongoDB\Mapping\ClassMetadataInfo;
use Sonata\AdminBundle\Admin\AdminInterface;
use Sonata\AdminBundle\Admin\FieldDescriptionCollection;
use Sonata\AdminBundle\Admin\FieldDescriptionInterface;
use Sonata\AdminBundle\Builder\ShowBuilderInterface;
use Sonata\AdminBundle\Guesser\TypeGuesserInterface;

class ShowBuilder implements ShowBuilderInterface
{
    protected $guesser;

    protected $templates;

    /**
     * @param \Sonata\AdminBundle\Guesser\TypeGuesserInterface $guesser
     * @param array                                            $templates
     */
    public function __construct(TypeGuesserInterface $guesser, array $templates)
    {
        $this->guesser = $guesser;
        $this->templates = $templates;
    }

    /**
     * @param array $options
     *
     * @return \Sonata\AdminBundle\Admin\FieldDescriptionCollection
     */
    public function getBaseList(array $options = array())
    {
        return new FieldDescriptionCollection();
    }

    /**
     * @param \Sonata\AdminBundle\Admin\FieldDescriptionCollection $list
     * @param string|null                                          $type
     * @param \Sonata\AdminBundle\Admin\FieldDescriptionInterface  $fieldDescription
     * @param \Sonata\AdminBundle\Admin\AdminInterface             $admin
     *
     * @return mixed
     */
    public function addField(FieldDescriptionCollection $list, $type, FieldDescriptionInterface $fieldDescription, AdminInterface $admin)
    {
        if ($type == null) {

            $guessType = $this->guesser->guessType($admin->getClass(), $fieldDescription->getName(), $admin->getModelManager());
            $fieldDescription->setType($guessType->getType());
        } else {
            $fieldDescription->setType($type);
        }

        $this->fixFieldDescription($admin, $fieldDescription);
        $admin->addShowFieldDescription($fieldDescription->getName(), $fieldDescription);

        $list->add($fieldDescription);
    }

    /**
     * The method defines the correct default settings for the provided FieldDescription.
     *
     * @param \Sonata\AdminBundle\Admin\AdminInterface            $admin
     * @param \Sonata\AdminBundle\Admin\FieldDescriptionInterface $fieldDescription
     */
    public function fixFieldDescription(AdminInterface $admin, FieldDescriptionInterface $fieldDescription)
    {
        $fieldDescription->setAdmin($admin);

        if ($admin->getModelManager()->hasMetadata($admin->getClass())) {
            list($metadata, $lastPropertyName, $parentAssociationMappings) = $admin->getModelManager()->getParentMetadataForProperty($admin->getClass(), $fieldDescription->getName());
            $fieldDescription->setParentAssociationMappings($parentAssociationMappings);

            // set the default field mapping
            if (isset($metadata->fieldMappings[$lastPropertyName])) {
                $fieldDescription->setFieldMapping($metadata->fieldMappings[$lastPropertyName]);
            }

                // set the default association mapping
            if (isset($metadata->associationMappings[$lastPropertyName])) {
                $fieldDescription->setAssociationMapping($metadata->associationMappings[$lastPropertyName]);
            }
        }

        if (!$fieldDescription->getType()) {
            throw new \RuntimeException(sprintf('Please define a type for field `%s` in `%s`', $fieldDescription->getName(), get_class($admin)));
        }

        $fieldDescription->setOption('code', $fieldDescription->getOption('code', $fieldDescription->getName()));
        $fieldDescription->setOption('label', $fieldDescription->getOption('label', $fieldDescription->getName()));

        if (!$fieldDescription->getTemplate()) {
            if ($fieldDescription->getType() == 'id') {
                $fieldDescription->setType('string');
            }

            if ($fieldDescription->getType() == 'int') {
                $fieldDescription->setType('integer');
            }

            $template = $this->getTemplate($fieldDescription->getType());

            if ($template === null) {
                if ($fieldDescription->getMappingType() == ClassMetadataInfo::ONE) {
                    $template = 'SonataDoctrineMongoDBAdminBundle:CRUD:show_mongo_one.html.twig';
                } elseif ($fieldDescription->getMappingType() == ClassMetadataInfo::MANY) {
                    $template = 'SonataDoctrineMongoDBAdminBundle:CRUD:show_mongo_many.html.twig';
                }
            }

            $fieldDescription->setTemplate($template);
        }

        if (in_array($fieldDescription->getMappingType(), array(ClassMetadataInfo::ONE, ClassMetadataInfo::MANY))) {
            $admin->attachAdminClass($fieldDescription);
        }
    }

    /**
     * @param string $type
     *
     * @return string
     */
    private function getTemplate($type)
    {
        if (!isset($this->templates[$type])) {
            return;
        }

        return $this->templates[$type];
    }
}


1			<?php
2
3			/*
4			* This file is part of the Sonata Project package.
5			*
6			* (c) Thomas Rabaix <[email protected]>
7			*
8			* For the full copyright and license information, please view the LICENSE
9			* file that was distributed with this source code.
10			*/
11
12			namespace Sonata\DoctrineMongoDBAdminBundle\Builder;
13
14			use Doctrine\ODM\MongoDB\Mapping\ClassMetadataInfo;
15			use Sonata\AdminBundle\Admin\AdminInterface;
16			use Sonata\AdminBundle\Admin\FieldDescriptionCollection;
17			use Sonata\AdminBundle\Admin\FieldDescriptionInterface;
18			use Sonata\AdminBundle\Builder\ShowBuilderInterface;
19			use Sonata\AdminBundle\Guesser\TypeGuesserInterface;
20
21			class ShowBuilder implements ShowBuilderInterface
22			{
23			protected $guesser;
24
25			protected $templates;
26
27			/**
28			* @param \Sonata\AdminBundle\Guesser\TypeGuesserInterface $guesser
29			* @param array $templates
30			*/
31			public function __construct(TypeGuesserInterface $guesser, array $templates)
32			{
33			$this->guesser = $guesser;
34			$this->templates = $templates;
35			}
36
37			/**
38			* @param array $options
39			*
40			* @return \Sonata\AdminBundle\Admin\FieldDescriptionCollection
41			*/
42			public function getBaseList(array $options = array())
43			{
44			return new FieldDescriptionCollection();
45			}
46
47			/**
48			* @param \Sonata\AdminBundle\Admin\FieldDescriptionCollection $list
49			* @param string\|null $type
50			* @param \Sonata\AdminBundle\Admin\FieldDescriptionInterface $fieldDescription
51			* @param \Sonata\AdminBundle\Admin\AdminInterface $admin
52			*
53			* @return mixed
54			*/
55			public function addField(FieldDescriptionCollection $list, $type, FieldDescriptionInterface $fieldDescription, AdminInterface $admin)
56			{
57			if ($type == null) {
			0 ignored issues – show Bug introduced 2015-12-14 09:14 UTC by Report Bug Copy Issue Report It seems like you are loosely comparing `$type` of type `string\|null` against `null`; this is ambiguous if the string can be empty. Consider using a strict comparison `===` instead. Loading history...
58			$guessType = $this->guesser->guessType($admin->getClass(), $fieldDescription->getName(), $admin->getModelManager());
59			$fieldDescription->setType($guessType->getType());
60			} else {
61			$fieldDescription->setType($type);
62			}
63
64			$this->fixFieldDescription($admin, $fieldDescription);
65			$admin->addShowFieldDescription($fieldDescription->getName(), $fieldDescription);
66
67			$list->add($fieldDescription);
68			}
69
70			/**
71			* The method defines the correct default settings for the provided FieldDescription.
72			*
73			* @param \Sonata\AdminBundle\Admin\AdminInterface $admin
74			* @param \Sonata\AdminBundle\Admin\FieldDescriptionInterface $fieldDescription
75			*/
76			public function fixFieldDescription(AdminInterface $admin, FieldDescriptionInterface $fieldDescription)
77			{
78			$fieldDescription->setAdmin($admin);
79
80			if ($admin->getModelManager()->hasMetadata($admin->getClass())) {
81			list($metadata, $lastPropertyName, $parentAssociationMappings) = $admin->getModelManager()->getParentMetadataForProperty($admin->getClass(), $fieldDescription->getName());
82			$fieldDescription->setParentAssociationMappings($parentAssociationMappings);
83
84			// set the default field mapping
85			if (isset($metadata->fieldMappings[$lastPropertyName])) {
86			$fieldDescription->setFieldMapping($metadata->fieldMappings[$lastPropertyName]);
87			}
88
89			// set the default association mapping
90			if (isset($metadata->associationMappings[$lastPropertyName])) {
91			$fieldDescription->setAssociationMapping($metadata->associationMappings[$lastPropertyName]);
92			}
93			}
94
95			if (!$fieldDescription->getType()) {
96			throw new \RuntimeException(sprintf('Please define a type for field `%s` in `%s`', $fieldDescription->getName(), get_class($admin)));
97			}
98
99			$fieldDescription->setOption('code', $fieldDescription->getOption('code', $fieldDescription->getName()));
100			$fieldDescription->setOption('label', $fieldDescription->getOption('label', $fieldDescription->getName()));
101
102			if (!$fieldDescription->getTemplate()) {
103			if ($fieldDescription->getType() == 'id') {
104			$fieldDescription->setType('string');
105			}
106
107			if ($fieldDescription->getType() == 'int') {
108			$fieldDescription->setType('integer');
109			}
110
111			$template = $this->getTemplate($fieldDescription->getType());
112
113			if ($template === null) {
114			if ($fieldDescription->getMappingType() == ClassMetadataInfo::ONE) {
115			$template = 'SonataDoctrineMongoDBAdminBundle:CRUD:show_mongo_one.html.twig';
116			} elseif ($fieldDescription->getMappingType() == ClassMetadataInfo::MANY) {
117			$template = 'SonataDoctrineMongoDBAdminBundle:CRUD:show_mongo_many.html.twig';
118			}
119			}
120
121			$fieldDescription->setTemplate($template);
122			}
123
124			if (in_array($fieldDescription->getMappingType(), array(ClassMetadataInfo::ONE, ClassMetadataInfo::MANY))) {
125			$admin->attachAdminClass($fieldDescription);
126			}
127			}
128
129			/**
130			* @param string $type
131			*
132			* @return string
133			*/
134			private function getTemplate($type)
135			{
136			if (!isset($this->templates[$type])) {
137			return;
138			}
139
140			return $this->templates[$type];
141			}
142			}
143

sonata-project / SonataDoctrineMongoDBAdminBundle

Push — 3.x ( 839353...0c5d0b )

ShowBuilder::fixFieldDescription() C

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

Duplication Side-by-Side

Filter issues like