ModelFilterTest::getFieldDescription() - Code Metrics - Inspection of "Merge 3.x into master" - sonata-project/SonataDoctrineMongoDBAdminBundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 4ae855...8f18c8 )

unknown

created 2019-11-21 01:00 UTC

ModelFilterTest::getFieldDescription() A

↳ Parent: ModelFilterTest

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	8
rs	10
c	0
b	0
f	0
cc	1
nc	1
nop	1

<?php

declare(strict_types=1);

/*
 * This file is part of the Sonata Project package.
 *
 * (c) Thomas Rabaix <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Sonata\DoctrineMongoDBAdminBundle\Tests\Filter;

use Doctrine\ODM\MongoDB\Mapping\ClassMetadata;
use Doctrine\ODM\MongoDB\Query\Builder;
use PHPUnit\Framework\TestCase;
use Sonata\AdminBundle\Admin\FieldDescriptionInterface;
use Sonata\DoctrineMongoDBAdminBundle\Datagrid\ProxyQuery;
use Sonata\DoctrineMongoDBAdminBundle\Filter\ModelFilter;
use Sonata\Form\Type\EqualType;

class DocumentStub
{
    private $id;

    public function __construct()
    {
        $this->id = new \MongoId();
    }

    public function getId()
    {
        return (string) ($this->id);
    }
}

class ModelFilterTest extends TestCase
{
    private $queryBuilder;

    protected function setUp()
    {
        $this->queryBuilder = $this->createMock(Builder::class);
    }

    /**
     * @return \Sonata\AdminBundle\Admin\FieldDescriptionInterface
     */
    public function getFieldDescription(array $options)
    {
        $fieldDescription = $this->createMock(FieldDescriptionInterface::class);
        $fieldDescription->expects($this->once())->method('getOptions')->willReturn($options);
        $fieldDescription->expects($this->once())->method('getName')->willReturn('field_name');

        return $fieldDescription;
    }

    public function testFilterEmpty(): void
    {
        $filter = new ModelFilter();
        $filter->initialize('field_name', ['field_options' => ['class' => 'FooBar']]);

        $builder = new ProxyQuery($this->queryBuilder);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

        $builder->getQueryBuilder()

            ->expects($this->never())
            ->method('field')
        ;

        $filter->filter($builder, 'alias', 'field', null);
        $filter->filter($builder, 'alias', 'field', []);

        $this->assertFalse($filter->isActive());
    }

    public function testFilterArray(): void
    {
        $filter = new ModelFilter();
        $filter->initialize('field_name', ['field_options' => ['class' => 'FooBar'], 'field_mapping' => true]);

        $builder = new ProxyQuery($this->queryBuilder);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

        $builder->getQueryBuilder()

            ->expects($this->once())
            ->method('field')
            ->with('field.$id')
            ->willReturnSelf()
        ;

        $oneDocument = new DocumentStub();
        $otherDocument = new DocumentStub();

        $builder->getQueryBuilder()

            ->expects($this->once())
            ->method('in')
            ->with([new \MongoId($oneDocument->getId()), new \MongoId($otherDocument->getId())])
        ;

        $filter->filter($builder, 'alias', 'field', [
            'type' => EqualType::TYPE_IS_EQUAL,
            'value' => [$oneDocument, $otherDocument],
        ]);

        $this->assertTrue($filter->isActive());
    }

    public function testFilterScalar(): void
    {
        $filter = new ModelFilter();
        $filter->initialize('field_name', ['field_options' => ['class' => 'FooBar'], 'field_mapping' => true]);

        $builder = new ProxyQuery($this->queryBuilder);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

        $builder->getQueryBuilder()

            ->expects($this->once())
            ->method('field')
            ->with('field.$id')
            ->willReturnSelf()
        ;

        $document1 = new DocumentStub();

        $builder->getQueryBuilder()

            ->expects($this->once())
            ->method('equals')
            ->with(new \MongoId($document1->getId()))
        ;

        $filter->filter($builder, 'alias', 'field', ['type' => EqualType::TYPE_IS_EQUAL, 'value' => $document1]);

        $this->assertTrue($filter->isActive());
    }

    public function testAssociationWithInvalidMapping(): void
    {
        $this->expectException(\RuntimeException::class);

        $filter = new ModelFilter();
        $filter->initialize('field_name', ['mapping_type' => 'foo', 'field_mapping' => true]);

        $builder = new ProxyQuery($this->queryBuilder);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

        $filter->apply($builder, 'asd');
    }

    public function testAssociationWithValidMappingAndEmptyFieldName(): void
    {
        $this->expectException(\RuntimeException::class);

        $filter = new ModelFilter();
        $filter->initialize('field_name', ['mapping_type' => ClassMetadata::ONE, 'field_mapping' => true]);

        $builder = new ProxyQuery($this->queryBuilder);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

        $filter->apply($builder, 'asd');
        $this->assertTrue($filter->isActive());
    }

    public function testAssociationWithValidMapping(): void
    {
        $filter = new ModelFilter();
        $filter->initialize('field_name', [
            'mapping_type' => ClassMetadata::ONE,
            'field_name' => 'field_name',
            'association_mapping' => [
                'fieldName' => 'association_mapping',
            ], 'field_mapping' => true,
        ]);

        $builder = new ProxyQuery($this->queryBuilder);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

        $builder->getQueryBuilder()

            ->method('field')
            ->with('field_name.$id')
            ->willReturnSelf()
        ;

        $filter->apply($builder, ['type' => EqualType::TYPE_IS_EQUAL, 'value' => new DocumentStub()]);

        $this->assertTrue($filter->isActive());
    }

    public function testAssociationWithValidParentAssociationMappings(): void
    {
        $filter = new ModelFilter();
        $filter->initialize('field_name', [
            'mapping_type' => ClassMetadata::ONE,
            'field_name' => 'field_name',
            'parent_association_mappings' => [
                [
                    'fieldName' => 'association_mapping',
                ],
                [
                    'fieldName' => 'sub_association_mapping',
                ],
            ],
            'association_mapping' => [
                'fieldName' => 'sub_sub_association_mapping',
            ], 'field_mapping' => true,
        ]);

        $builder = new ProxyQuery($this->queryBuilder);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

        $builder->getQueryBuilder()

            ->method('field')
            ->with('field_name.$id')
            ->willReturnSelf()
        ;

        $filter->apply($builder, ['type' => EqualType::TYPE_IS_EQUAL, 'value' => new DocumentStub()]);

        $this->assertTrue($filter->isActive());
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			/*
6			* This file is part of the Sonata Project package.
7			*
8			* (c) Thomas Rabaix <[email protected]>
9			*
10			* For the full copyright and license information, please view the LICENSE
11			* file that was distributed with this source code.
12			*/
13
14			namespace Sonata\DoctrineMongoDBAdminBundle\Tests\Filter;
15
16			use Doctrine\ODM\MongoDB\Mapping\ClassMetadata;
17			use Doctrine\ODM\MongoDB\Query\Builder;
18			use PHPUnit\Framework\TestCase;
19			use Sonata\AdminBundle\Admin\FieldDescriptionInterface;
20			use Sonata\DoctrineMongoDBAdminBundle\Datagrid\ProxyQuery;
21			use Sonata\DoctrineMongoDBAdminBundle\Filter\ModelFilter;
22			use Sonata\Form\Type\EqualType;
23
24			class DocumentStub
25			{
26			private $id;
27
28			public function __construct()
29			{
30			$this->id = new \MongoId();
31			}
32
33			public function getId()
34			{
35			return (string) ($this->id);
36			}
37			}
38
39			class ModelFilterTest extends TestCase
40			{
41			private $queryBuilder;
42
43			protected function setUp()
44			{
45			$this->queryBuilder = $this->createMock(Builder::class);
46			}
47
48			/**
49			* @return \Sonata\AdminBundle\Admin\FieldDescriptionInterface
50			*/
51			public function getFieldDescription(array $options)
52			{
53			$fieldDescription = $this->createMock(FieldDescriptionInterface::class);
54			$fieldDescription->expects($this->once())->method('getOptions')->willReturn($options);
55			$fieldDescription->expects($this->once())->method('getName')->willReturn('field_name');
56
57			return $fieldDescription;
58			}
59
60			public function testFilterEmpty(): void
61			{
62			$filter = new ModelFilter();
63			$filter->initialize('field_name', ['field_options' => ['class' => 'FooBar']]);
64
65			$builder = new ProxyQuery($this->queryBuilder);
			0 ignored issues – show Documentation introduced 2019-11-20 18:34 UTC by Report Bug Copy Issue Report `$this->queryBuilder` is of type `object<PHPUnit\Framework\MockObject\MockObject>`, but the function expects a `object<Doctrine\ODM\MongoDB\Query\Builder>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
66
67			$builder->getQueryBuilder()
			0 ignored issues – show Bug introduced 2019-11-20 11:37 UTC by Report Bug Copy Issue Report The method `expects()` does not seem to exist on `object<Doctrine\ODM\MongoDB\Query\Builder>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
68			->expects($this->never())
69			->method('field')
70			;
71
72			$filter->filter($builder, 'alias', 'field', null);
73			$filter->filter($builder, 'alias', 'field', []);
74
75			$this->assertFalse($filter->isActive());
76			}
77
78			public function testFilterArray(): void
79			{
80			$filter = new ModelFilter();
81			$filter->initialize('field_name', ['field_options' => ['class' => 'FooBar'], 'field_mapping' => true]);
82
83			$builder = new ProxyQuery($this->queryBuilder);
			0 ignored issues – show Documentation introduced 2019-11-20 18:34 UTC by Report Bug Copy Issue Report `$this->queryBuilder` is of type `object<PHPUnit\Framework\MockObject\MockObject>`, but the function expects a `object<Doctrine\ODM\MongoDB\Query\Builder>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
84
85			$builder->getQueryBuilder()
			0 ignored issues – show Bug introduced 2019-11-20 11:37 UTC by Report Bug Copy Issue Report The method `expects()` does not seem to exist on `object<Doctrine\ODM\MongoDB\Query\Builder>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
86			->expects($this->once())
87			->method('field')
88			->with('field.$id')
89			->willReturnSelf()
90			;
91
92			$oneDocument = new DocumentStub();
93			$otherDocument = new DocumentStub();
94
95			$builder->getQueryBuilder()
			0 ignored issues – show Bug introduced 2019-11-20 11:37 UTC by Report Bug Copy Issue Report The method `expects()` does not seem to exist on `object<Doctrine\ODM\MongoDB\Query\Builder>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
96			->expects($this->once())
97			->method('in')
98			->with([new \MongoId($oneDocument->getId()), new \MongoId($otherDocument->getId())])
99			;
100
101			$filter->filter($builder, 'alias', 'field', [
102			'type' => EqualType::TYPE_IS_EQUAL,
103			'value' => [$oneDocument, $otherDocument],
104			]);
105
106			$this->assertTrue($filter->isActive());
107			}
108
109			public function testFilterScalar(): void
110			{
111			$filter = new ModelFilter();
112			$filter->initialize('field_name', ['field_options' => ['class' => 'FooBar'], 'field_mapping' => true]);
113
114			$builder = new ProxyQuery($this->queryBuilder);
			0 ignored issues – show Documentation introduced 2019-11-20 18:34 UTC by Report Bug Copy Issue Report `$this->queryBuilder` is of type `object<PHPUnit\Framework\MockObject\MockObject>`, but the function expects a `object<Doctrine\ODM\MongoDB\Query\Builder>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
115
116			$builder->getQueryBuilder()
			0 ignored issues – show Bug introduced 2019-11-20 11:37 UTC by Report Bug Copy Issue Report The method `expects()` does not seem to exist on `object<Doctrine\ODM\MongoDB\Query\Builder>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
117			->expects($this->once())
118			->method('field')
119			->with('field.$id')
120			->willReturnSelf()
121			;
122
123			$document1 = new DocumentStub();
124
125			$builder->getQueryBuilder()
			0 ignored issues – show Bug introduced 2019-11-20 12:17 UTC by Report Bug Copy Issue Report The method `expects()` does not seem to exist on `object<Doctrine\ODM\MongoDB\Query\Builder>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
126			->expects($this->once())
127			->method('equals')
128			->with(new \MongoId($document1->getId()))
129			;
130
131			$filter->filter($builder, 'alias', 'field', ['type' => EqualType::TYPE_IS_EQUAL, 'value' => $document1]);
132
133			$this->assertTrue($filter->isActive());
134			}
135
136			public function testAssociationWithInvalidMapping(): void
137			{
138			$this->expectException(\RuntimeException::class);
139
140			$filter = new ModelFilter();
141			$filter->initialize('field_name', ['mapping_type' => 'foo', 'field_mapping' => true]);
142
143			$builder = new ProxyQuery($this->queryBuilder);
			0 ignored issues – show Documentation introduced 2019-11-20 18:34 UTC by Report Bug Copy Issue Report `$this->queryBuilder` is of type `object<PHPUnit\Framework\MockObject\MockObject>`, but the function expects a `object<Doctrine\ODM\MongoDB\Query\Builder>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
144
145			$filter->apply($builder, 'asd');
146			}
147
148			public function testAssociationWithValidMappingAndEmptyFieldName(): void
149			{
150			$this->expectException(\RuntimeException::class);
151
152			$filter = new ModelFilter();
153			$filter->initialize('field_name', ['mapping_type' => ClassMetadata::ONE, 'field_mapping' => true]);
154
155			$builder = new ProxyQuery($this->queryBuilder);
			0 ignored issues – show Documentation introduced 2019-11-20 18:34 UTC by Report Bug Copy Issue Report `$this->queryBuilder` is of type `object<PHPUnit\Framework\MockObject\MockObject>`, but the function expects a `object<Doctrine\ODM\MongoDB\Query\Builder>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
156
157			$filter->apply($builder, 'asd');
158			$this->assertTrue($filter->isActive());
159			}
160
161			public function testAssociationWithValidMapping(): void
162			{
163			$filter = new ModelFilter();
164			$filter->initialize('field_name', [
165			'mapping_type' => ClassMetadata::ONE,
166			'field_name' => 'field_name',
167			'association_mapping' => [
168			'fieldName' => 'association_mapping',
169			], 'field_mapping' => true,
170			]);
171
172			$builder = new ProxyQuery($this->queryBuilder);
			0 ignored issues – show Documentation introduced 2019-11-20 18:34 UTC by Report Bug Copy Issue Report `$this->queryBuilder` is of type `object<PHPUnit\Framework\MockObject\MockObject>`, but the function expects a `object<Doctrine\ODM\MongoDB\Query\Builder>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
173
174			$builder->getQueryBuilder()
			0 ignored issues – show Bug introduced 2019-11-20 11:37 UTC by Report Bug Copy Issue Report The method `method()` does not seem to exist on `object<Doctrine\ODM\MongoDB\Query\Builder>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
175			->method('field')
176			->with('field_name.$id')
177			->willReturnSelf()
178			;
179
180			$filter->apply($builder, ['type' => EqualType::TYPE_IS_EQUAL, 'value' => new DocumentStub()]);
181
182			$this->assertTrue($filter->isActive());
183			}
184
185			public function testAssociationWithValidParentAssociationMappings(): void
186			{
187			$filter = new ModelFilter();
188			$filter->initialize('field_name', [
189			'mapping_type' => ClassMetadata::ONE,
190			'field_name' => 'field_name',
191			'parent_association_mappings' => [
192			[
193			'fieldName' => 'association_mapping',
194			],
195			[
196			'fieldName' => 'sub_association_mapping',
197			],
198			],
199			'association_mapping' => [
200			'fieldName' => 'sub_sub_association_mapping',
201			], 'field_mapping' => true,
202			]);
203
204			$builder = new ProxyQuery($this->queryBuilder);
			0 ignored issues – show Documentation introduced 2019-11-20 18:34 UTC by Report Bug Copy Issue Report `$this->queryBuilder` is of type `object<PHPUnit\Framework\MockObject\MockObject>`, but the function expects a `object<Doctrine\ODM\MongoDB\Query\Builder>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
205
206			$builder->getQueryBuilder()
			0 ignored issues – show Bug introduced 2019-11-20 12:17 UTC by Report Bug Copy Issue Report The method `method()` does not seem to exist on `object<Doctrine\ODM\MongoDB\Query\Builder>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
207			->method('field')
208			->with('field_name.$id')
209			->willReturnSelf()
210			;
211
212			$filter->apply($builder, ['type' => EqualType::TYPE_IS_EQUAL, 'value' => new DocumentStub()]);
213
214			$this->assertTrue($filter->isActive());
215			}
216			}
217

sonata-project / SonataDoctrineMongoDBAdminBundle

Push — master ( 4ae855...8f18c8 )

ModelFilterTest::getFieldDescription() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like