NumberFilterTest::testFilter() - Code Metrics - sonata-project/SonataDoctrineMongoDBAdminBundle - Measure and Improve Code Quality continuously with Scrutinizer

NumberFilterTest::testFilter() A
last analyzed 2020-08-28 02:03 UTC

↳ Parent: NumberFilterTest

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	17
rs	9.7
c	0
b	0
f	0
cc	1
nc	1
nop	2

<?php

declare(strict_types=1);

/*
 * This file is part of the Sonata Project package.
 *
 * (c) Thomas Rabaix <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Sonata\DoctrineMongoDBAdminBundle\Tests\Filter;

use Sonata\AdminBundle\Form\Type\Operator\NumberOperatorType;
use Sonata\DoctrineMongoDBAdminBundle\Datagrid\ProxyQuery;
use Sonata\DoctrineMongoDBAdminBundle\Filter\NumberFilter;

class NumberFilterTest extends FilterWithQueryBuilderTest
{
    public function testFilterEmpty(): void
    {
        $filter = new NumberFilter();
        $filter->initialize('field_name', ['field_options' => ['class' => 'FooBar']]);

        $builder = new ProxyQuery($this->getQueryBuilder());

        $builder->getQueryBuilder()

            ->expects($this->never())
            ->method('field')
        ;

        $filter->filter($builder, 'alias', 'field', null);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $filter->filter($builder, 'alias', 'field', 'asds');
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

        $this->assertFalse($filter->isActive());
    }

    public function testFilterInvalidOperator(): void
    {
        $filter = new NumberFilter();
        $filter->initialize('field_name', ['field_options' => ['class' => 'FooBar']]);

        $builder = new ProxyQuery($this->getQueryBuilder());

        $builder->getQueryBuilder()

            ->expects($this->never())
            ->method('field')
        ;

        $filter->filter($builder, 'alias', 'field', ['type' => 'foo']);

        $this->assertFalse($filter->isActive());
    }

    /**
     * @dataProvider getNumberExamples
     */
    public function testFilter(array $data, string $method): void
    {
        $filter = new NumberFilter();
        $filter->initialize('field_name', ['field_options' => ['class' => 'FooBar']]);

        $builder = new ProxyQuery($this->getQueryBuilder());

        $builder->getQueryBuilder()

            ->expects($this->once())
            ->method($method)
            ->with($data['value'])
        ;

        $filter->filter($builder, 'alias', 'field', $data);

        $this->assertTrue($filter->isActive());
    }

    public function getNumberExamples(): array
    {
        return [
            [['type' => NumberOperatorType::TYPE_EQUAL, 'value' => 42], 'equals'],
            [['type' => NumberOperatorType::TYPE_GREATER_EQUAL, 'value' => 42], 'gte'],
            [['type' => NumberOperatorType::TYPE_GREATER_THAN, 'value' => 42], 'gt'],
            [['type' => NumberOperatorType::TYPE_LESS_EQUAL, 'value' => 42], 'lte'],
            [['type' => NumberOperatorType::TYPE_LESS_THAN, 'value' => 42], 'lt'],
            [['value' => 42], 'equals'],
        ];
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			/*
6			* This file is part of the Sonata Project package.
7			*
8			* (c) Thomas Rabaix <[email protected]>
9			*
10			* For the full copyright and license information, please view the LICENSE
11			* file that was distributed with this source code.
12			*/
13
14			namespace Sonata\DoctrineMongoDBAdminBundle\Tests\Filter;
15
16			use Sonata\AdminBundle\Form\Type\Operator\NumberOperatorType;
17			use Sonata\DoctrineMongoDBAdminBundle\Datagrid\ProxyQuery;
18			use Sonata\DoctrineMongoDBAdminBundle\Filter\NumberFilter;
19
20			class NumberFilterTest extends FilterWithQueryBuilderTest
21			{
22			public function testFilterEmpty(): void
23			{
24			$filter = new NumberFilter();
25			$filter->initialize('field_name', ['field_options' => ['class' => 'FooBar']]);
26
27			$builder = new ProxyQuery($this->getQueryBuilder());
28
29			$builder->getQueryBuilder()
			0 ignored issues – show Bug introduced 2019-11-20 11:37 UTC by Report Bug Copy Issue Report The method `expects()` does not seem to exist on `object<Doctrine\ODM\MongoDB\Query\Builder>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
30			->expects($this->never())
31			->method('field')
32			;
33
34			$filter->filter($builder, 'alias', 'field', null);
			0 ignored issues – show Documentation introduced 2020-07-29 13:57 UTC by Report Bug Copy Issue Report `null` is of type `null`, but the function expects a `array`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
35			$filter->filter($builder, 'alias', 'field', 'asds');
			0 ignored issues – show Documentation introduced 2020-07-29 13:57 UTC by Report Bug Copy Issue Report `'asds'` is of type `string`, but the function expects a `array`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
36
37			$this->assertFalse($filter->isActive());
38			}
39
40			public function testFilterInvalidOperator(): void
41			{
42			$filter = new NumberFilter();
43			$filter->initialize('field_name', ['field_options' => ['class' => 'FooBar']]);
44
45			$builder = new ProxyQuery($this->getQueryBuilder());
46
47			$builder->getQueryBuilder()
			0 ignored issues – show Bug introduced 2019-11-20 11:37 UTC by Report Bug Copy Issue Report The method `expects()` does not seem to exist on `object<Doctrine\ODM\MongoDB\Query\Builder>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
48			->expects($this->never())
49			->method('field')
50			;
51
52			$filter->filter($builder, 'alias', 'field', ['type' => 'foo']);
53
54			$this->assertFalse($filter->isActive());
55			}
56
57			/**
58			* @dataProvider getNumberExamples
59			*/
60			public function testFilter(array $data, string $method): void
61			{
62			$filter = new NumberFilter();
63			$filter->initialize('field_name', ['field_options' => ['class' => 'FooBar']]);
64
65			$builder = new ProxyQuery($this->getQueryBuilder());
66
67			$builder->getQueryBuilder()
			0 ignored issues – show Bug introduced 2019-11-20 11:37 UTC by Report Bug Copy Issue Report The method `expects()` does not seem to exist on `object<Doctrine\ODM\MongoDB\Query\Builder>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
68			->expects($this->once())
69			->method($method)
70			->with($data['value'])
71			;
72
73			$filter->filter($builder, 'alias', 'field', $data);
74
75			$this->assertTrue($filter->isActive());
76			}
77
78			public function getNumberExamples(): array
79			{
80			return [
81			[['type' => NumberOperatorType::TYPE_EQUAL, 'value' => 42], 'equals'],
82			[['type' => NumberOperatorType::TYPE_GREATER_EQUAL, 'value' => 42], 'gte'],
83			[['type' => NumberOperatorType::TYPE_GREATER_THAN, 'value' => 42], 'gt'],
84			[['type' => NumberOperatorType::TYPE_LESS_EQUAL, 'value' => 42], 'lte'],
85			[['type' => NumberOperatorType::TYPE_LESS_THAN, 'value' => 42], 'lt'],
86			[['value' => 42], 'equals'],
87			];
88			}
89			}
90

sonata-project / SonataDoctrineMongoDBAdminBundle

NumberFilterTest::testFilter() A last analyzed 2020-08-28 02:03 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

NumberFilterTest::testFilter() A
last analyzed 2020-08-28 02:03 UTC