BaseCacheCommand::__construct() - Code Metrics - sonata-project/SonataCacheBundle - Measure and Improve Code Quality continuously with Scrutinizer

BaseCacheCommand::__construct() A
last analyzed 2020-03-15 02:05 UTC

↳ Parent: BaseCacheCommand

Complexity

Conditions	2
Paths	2

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	13
rs	9.8333
c	0
b	0
f	0
cc	2
nc	2
nop	2

<?php

declare(strict_types=1);

/*
 * This file is part of the Sonata Project package.
 *
 * (c) Thomas Rabaix <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Sonata\CacheBundle\Command;

use Sonata\Cache\CacheManagerInterface;
use Symfony\Bundle\FrameworkBundle\Command\ContainerAwareCommand;

/**
 * NEXT_MAJOR: stop extending ContainerAwareCommand.
 */
abstract class BaseCacheCommand extends ContainerAwareCommand
{
    /**
     * @var ?CacheManagerInterface
     */
    private $cacheManager;

    public function __construct(
        string $name = null,
        CacheManagerInterface $cacheManager = null
    ) {
        parent::__construct($name);
        if (null === $cacheManager) {
            @trigger_error(sprintf(
// For example instead of
@mkdir($dir);

// Better use
if (@mkdir($dir) === false) {
    throw new \RuntimeException('The directory '.$dir.' could not be created.');
}
                'Not providing a cache manager to "%s" is deprecated since 3.x and will no longer be possible in 4.0',
                \get_class($this)
            ), E_USER_DEPRECATED);
        }
        $this->cacheManager = $cacheManager;
    }

    public function getManager(): CacheManagerInterface
    {
        if (null === $this->cacheManager) {
            return $this->getContainer()->get(CacheManagerInterface::class);
        }

        return $this->cacheManager;
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			/*
6			* This file is part of the Sonata Project package.
7			*
8			* (c) Thomas Rabaix <[email protected]>
9			*
10			* For the full copyright and license information, please view the LICENSE
11			* file that was distributed with this source code.
12			*/
13
14			namespace Sonata\CacheBundle\Command;
15
16			use Sonata\Cache\CacheManagerInterface;
17			use Symfony\Bundle\FrameworkBundle\Command\ContainerAwareCommand;
18
19			/**
20			* NEXT_MAJOR: stop extending ContainerAwareCommand.
21			*/
22			abstract class BaseCacheCommand extends ContainerAwareCommand
23			{
24			/**
25			* @var ?CacheManagerInterface
26			*/
27			private $cacheManager;
28
29			public function __construct(
30			string $name = null,
31			CacheManagerInterface $cacheManager = null
32			) {
33			parent::__construct($name);
34			if (null === $cacheManager) {
35			@trigger_error(sprintf(
			0 ignored issues – show Security Best Practice introduced 2019-01-28 18:43 UTC by Report Bug Copy Issue Report It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended. If you suppress an error, we recommend checking for the error condition explicitly: // For example instead of @mkdir($dir); // Better use if (@mkdir($dir) === false) { throw new \RuntimeException('The directory '.$dir.' could not be created.'); } Loading history...
36			'Not providing a cache manager to "%s" is deprecated since 3.x and will no longer be possible in 4.0',
37			\get_class($this)
38			), E_USER_DEPRECATED);
39			}
40			$this->cacheManager = $cacheManager;
41			}
42
43			public function getManager(): CacheManagerInterface
44			{
45			if (null === $this->cacheManager) {
46			return $this->getContainer()->get(CacheManagerInterface::class);
47			}
48
49			return $this->cacheManager;
50			}
51			}
52

sonata-project / SonataCacheBundle

BaseCacheCommand::__construct() A last analyzed 2020-03-15 02:05 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

BaseCacheCommand::__construct() A
last analyzed 2020-03-15 02:05 UTC