Issues in RoleSecurityHandlerTest.php (master) - Issues in master - sonata-project/SonataAdminBundle - Measure and Improve Code Quality continuously with Scrutinizer

Issues (655)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

tests/Security/Handler/RoleSecurityHandlerTest.php (5 issues)

Labels

Bug 5

Severity

Major 5

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

declare(strict_types=1);

/*
 * This file is part of the Sonata Project package.
 *
 * (c) Thomas Rabaix <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Sonata\AdminBundle\Tests\Security\Handler;

use PHPUnit\Framework\TestCase;
use Sonata\AdminBundle\Admin\AdminInterface;
use Sonata\AdminBundle\Security\Handler\RoleSecurityHandler;
use Symfony\Component\Security\Core\Authorization\AuthorizationCheckerInterface;
use Symfony\Component\Security\Core\Exception\AuthenticationCredentialsNotFoundException;

/**
 * Test for RoleSecurityHandler.
 *
 * @author Andrej Hudec <[email protected]>
 */
class RoleSecurityHandlerTest extends TestCase
{
    /**
     * @var AdminInterface
     */
    private $admin;

    /**
     * @var AuthorizationCheckerInterface
     */
    private $authorizationChecker;

    protected function setUp(): void
    {
        $this->authorizationChecker = $this->createMock(AuthorizationCheckerInterface::class);
        $this->admin = $this->createMock(AdminInterface::class);
    }

    /**
     * @dataProvider getBaseRoleTests
     */
    public function testGetBaseRole(string $expected, string $code): void
    {
        $handler = new RoleSecurityHandler($this->authorizationChecker, ['ROLE_BATMAN', 'ROLE_IRONMAN']);

        $this->admin->expects($this->once())

            ->method('getCode')
            ->willReturn($code);

        $this->assertSame($expected, $handler->getBaseRole($this->admin));
    }

    public function getBaseRoleTests(): array
    {
        return [
            ['ROLE_FOO_BAR_%s', 'foo.bar'],
            ['ROLE_FOO_BAR_%s', 'Foo.Bar'],
            ['ROLE_FOO_BAR_BAZ_%s', 'foo.bar_baz'],
            ['ROLE_FOO_BAR_%s', 'FOO.BAR'],
        ];
    }

    /**
     * @dataProvider getIsGrantedTests
     */
    public function testIsGranted(bool $expected, array $superAdminRoles, string $adminCode, $operation, $object = null): void
    {
        $handler = $this->getRoleSecurityHandler($superAdminRoles);

        $this->admin

            ->method('getCode')
            ->willReturn($adminCode);

        $this->authorizationChecker

            ->method('isGranted')
            ->willReturnCallback(static function (string $attribute, $object) {
                switch ($attribute) {
                    case 'ROLE_BATMAN':
                    case 'ROLE_IRONMAN':
                    case 'ROLE_FOO_BAR_ABC':
                    case 'ROLE_FOO_BAR_BAZ_ALL':
                        return true;
                    case 'ROLE_AUTH_EXCEPTION':
                        throw new AuthenticationCredentialsNotFoundException();
                    case 'ROLE_FOO_BAR_DEF':
                        return $object instanceof \stdClass;
                    default:
                        return false;
                }
            });

        $this->assertSame($expected, $handler->isGranted($this->admin, $operation, $object));
    }

    public function getIsGrantedTests(): array
    {
        return [
            //empty
            [false, [''], 'foo.bar', ''],
            [false, [''], 'foo.bar', ['']],
            [false, [''], 'foo.bar.abc', ['']],
            [false, [''], 'foo.bar.def', ['']],
            [false, [''], 'foo.bar.baz.xyz', ''],
            [false, [''], 'foo.bar.baz.xyz', ['']],

            //superadmins
            [true, ['ROLE_BATMAN', 'ROLE_IRONMAN'], 'foo.bar', 'BAZ'],
            [true, ['ROLE_BATMAN', 'ROLE_IRONMAN'], 'foo.bar', 'ANYTHING'],
            [true, ['ROLE_BATMAN', 'ROLE_IRONMAN'], 'foo.bar', ['BAZ', 'ANYTHING']],
            [true, ['ROLE_IRONMAN'], 'foo.bar', 'BAZ'],
            [true, ['ROLE_IRONMAN'], 'foo.bar', 'ANYTHING'],
            [true, ['ROLE_IRONMAN'], 'foo.bar.baz.xyz', 'ANYTHING'],
            [true, ['ROLE_IRONMAN'], 'foo.bar', ''],
            [true, ['ROLE_IRONMAN'], 'foo.bar', ['']],

            //operations
            [true, ['ROLE_SPIDERMAN'], 'foo.bar', 'ABC'],
            [true, ['ROLE_SPIDERMAN'], 'foo.bar', ['ABC']],
            [true, ['ROLE_SPIDERMAN'], 'foo.bar', ['ABC', 'DEF']],
            [true, ['ROLE_SPIDERMAN'], 'foo.bar', ['BAZ', 'ABC']],
            [false, ['ROLE_SPIDERMAN'], 'foo.bar', 'DEF'],
            [false, ['ROLE_SPIDERMAN'], 'foo.bar', ['DEF']],
            [false, ['ROLE_SPIDERMAN'], 'foo.bar', 'BAZ'],
            [false, ['ROLE_SPIDERMAN'], 'foo.bar', ['BAZ']],
            [true, [], 'foo.bar', 'ABC'],
            [true, [], 'foo.bar', ['ABC']],
            [false, [], 'foo.bar', 'DEF'],
            [false, [], 'foo.bar', ['DEF']],
            [false, [], 'foo.bar', 'BAZ'],
            [false, [], 'foo.bar', ['BAZ']],
            [false, [], 'foo.bar.baz.xyz', 'ABC'],
            [false, [], 'foo.bar.baz.xyz', ['ABC']],
            [false, [], 'foo.bar.baz.xyz', ['ABC', 'DEF']],
            [false, [], 'foo.bar.baz.xyz', 'DEF'],
            [false, [], 'foo.bar.baz.xyz', ['DEF']],
            [false, [], 'foo.bar.baz.xyz', 'BAZ'],
            [false, [], 'foo.bar.baz.xyz', ['BAZ']],

            //objects
            [true, ['ROLE_SPIDERMAN'], 'foo.bar', ['DEF'], new \stdClass()],
            [true, ['ROLE_SPIDERMAN'], 'foo.bar', ['ABC'], new \stdClass()],
            [true, ['ROLE_SPIDERMAN'], 'foo.bar', ['ABC', 'DEF'], new \stdClass()],
            [true, ['ROLE_SPIDERMAN'], 'foo.bar', ['BAZ', 'DEF'], new \stdClass()],
            [true, ['ROLE_SPIDERMAN'], 'foo.bar', 'DEF', new \stdClass()],
            [true, ['ROLE_SPIDERMAN'], 'foo.bar', 'ABC', new \stdClass()],
            [false, ['ROLE_SPIDERMAN'], 'foo.bar', 'BAZ', new \stdClass()],
            [false, ['ROLE_SPIDERMAN'], 'foo.bar.baz.xyz', 'DEF', new \stdClass()],
            [false, ['ROLE_SPIDERMAN'], 'foo.bar.baz.xyz', 'ABC', new \stdClass()],
            [true, [], 'foo.bar', ['ABC'], new \stdClass()],
            [true, [], 'foo.bar', 'ABC', new \stdClass()],
            [true, [], 'foo.bar', ['DEF'], new \stdClass()],
            [true, [], 'foo.bar', 'DEF', new \stdClass()],
            [false, [], 'foo.bar', ['BAZ'], new \stdClass()],
            [false, [], 'foo.bar', 'BAZ', new \stdClass()],
            [false, [], 'foo.bar.baz.xyz', 'BAZ', new \stdClass()],
            [false, [], 'foo.bar.baz.xyz', ['BAZ'], new \stdClass()],
            [false, ['ROLE_AUTH_EXCEPTION'], 'foo.bar.baz.xyz', ['BAZ'], new \stdClass()],

            // ALL role
            [true, [], 'foo.bar.baz', 'LIST'],
            [true, [], 'foo.bar.baz', ['LIST', 'EDIT']],
        ];
    }

    public function testIsGrantedWithException(): void
    {
        $this->expectException(\RuntimeException::class);
        $this->expectExceptionMessage('Something is wrong');

        $this->admin

            ->method('getCode')
            ->willReturn('foo.bar');

        $this->authorizationChecker

            ->method('isGranted')
            ->willReturnCallback(static function (): void {
                throw new \RuntimeException('Something is wrong');
            });

        $handler = $this->getRoleSecurityHandler(['ROLE_BATMAN']);
        $handler->isGranted($this->admin, 'BAZ');
    }

    /**
     * @doesNotPerformAssertions
     */
    public function testCreateObjectSecurity(): void
    {
        $handler = $this->getRoleSecurityHandler(['ROLE_FOO']);
        $handler->createObjectSecurity($this->getSonataAdminObject(), new \stdClass());
    }

    /**
     * @doesNotPerformAssertions
     */
    public function testDeleteObjectSecurity(): void
    {
        $handler = $this->getRoleSecurityHandler(['ROLE_FOO']);
        $handler->deleteObjectSecurity($this->getSonataAdminObject(), new \stdClass());
    }

    public function testBuildSecurityInformation(): void
    {
        $handler = $this->getRoleSecurityHandler(['ROLE_FOO']);
        $this->assertSame([], $handler->buildSecurityInformation($this->getSonataAdminObject()));
    }

    private function getRoleSecurityHandler(array $superAdminRoles): RoleSecurityHandler
    {
        return new RoleSecurityHandler($this->authorizationChecker, $superAdminRoles);
    }

    private function getSonataAdminObject(): AdminInterface
    {
        return $this->getMockForAbstractClass(AdminInterface::class);
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			/*
6			* This file is part of the Sonata Project package.
7			*
8			* (c) Thomas Rabaix <[email protected]>
9			*
10			* For the full copyright and license information, please view the LICENSE
11			* file that was distributed with this source code.
12			*/
13
14			namespace Sonata\AdminBundle\Tests\Security\Handler;
15
16			use PHPUnit\Framework\TestCase;
17			use Sonata\AdminBundle\Admin\AdminInterface;
18			use Sonata\AdminBundle\Security\Handler\RoleSecurityHandler;
19			use Symfony\Component\Security\Core\Authorization\AuthorizationCheckerInterface;
20			use Symfony\Component\Security\Core\Exception\AuthenticationCredentialsNotFoundException;
21
22			/**
23			* Test for RoleSecurityHandler.
24			*
25			* @author Andrej Hudec <[email protected]>
26			*/
27			class RoleSecurityHandlerTest extends TestCase
28			{
29			/**
30			* @var AdminInterface
31			*/
32			private $admin;
33
34			/**
35			* @var AuthorizationCheckerInterface
36			*/
37			private $authorizationChecker;
38
39			protected function setUp(): void
40			{
41			$this->authorizationChecker = $this->createMock(AuthorizationCheckerInterface::class);
42			$this->admin = $this->createMock(AdminInterface::class);
43			}
44
45			/**
46			* @dataProvider getBaseRoleTests
47			*/
48			public function testGetBaseRole(string $expected, string $code): void
49			{
50			$handler = new RoleSecurityHandler($this->authorizationChecker, ['ROLE_BATMAN', 'ROLE_IRONMAN']);
51
52			$this->admin->expects($this->once())
			0 ignored issues – show Bug introduced 2017-12-07 16:48 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `expects()` does not seem to exist on `object<Sonata\AdminBundle\Admin\AdminInterface>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
53			->method('getCode')
54			->willReturn($code);
55
56			$this->assertSame($expected, $handler->getBaseRole($this->admin));
57			}
58
59			public function getBaseRoleTests(): array
60			{
61			return [
62			['ROLE_FOO_BAR_%s', 'foo.bar'],
63			['ROLE_FOO_BAR_%s', 'Foo.Bar'],
64			['ROLE_FOO_BAR_BAZ_%s', 'foo.bar_baz'],
65			['ROLE_FOO_BAR_%s', 'FOO.BAR'],
66			];
67			}
68
69			/**
70			* @dataProvider getIsGrantedTests
71			*/
72			public function testIsGranted(bool $expected, array $superAdminRoles, string $adminCode, $operation, $object = null): void
73			{
74			$handler = $this->getRoleSecurityHandler($superAdminRoles);
75
76			$this->admin
			0 ignored issues – show Bug introduced 2019-12-07 19:25 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `method()` does not seem to exist on `object<Sonata\AdminBundle\Admin\AdminInterface>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
77			->method('getCode')
78			->willReturn($adminCode);
79
80			$this->authorizationChecker
			0 ignored issues – show Bug introduced 2019-12-07 19:25 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `method()` does not seem to exist on `object<Symfony\Component...zationCheckerInterface>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
81			->method('isGranted')
82			->willReturnCallback(static function (string $attribute, $object) {
83			switch ($attribute) {
84			case 'ROLE_BATMAN':
85			case 'ROLE_IRONMAN':
86			case 'ROLE_FOO_BAR_ABC':
87			case 'ROLE_FOO_BAR_BAZ_ALL':
88			return true;
89			case 'ROLE_AUTH_EXCEPTION':
90			throw new AuthenticationCredentialsNotFoundException();
91			case 'ROLE_FOO_BAR_DEF':
92			return $object instanceof \stdClass;
93			default:
94			return false;
95			}
96			});
97
98			$this->assertSame($expected, $handler->isGranted($this->admin, $operation, $object));
99			}
100
101			public function getIsGrantedTests(): array
102			{
103			return [
104			//empty
105			[false, [''], 'foo.bar', ''],
106			[false, [''], 'foo.bar', ['']],
107			[false, [''], 'foo.bar.abc', ['']],
108			[false, [''], 'foo.bar.def', ['']],
109			[false, [''], 'foo.bar.baz.xyz', ''],
110			[false, [''], 'foo.bar.baz.xyz', ['']],
111
112			//superadmins
113			[true, ['ROLE_BATMAN', 'ROLE_IRONMAN'], 'foo.bar', 'BAZ'],
114			[true, ['ROLE_BATMAN', 'ROLE_IRONMAN'], 'foo.bar', 'ANYTHING'],
115			[true, ['ROLE_BATMAN', 'ROLE_IRONMAN'], 'foo.bar', ['BAZ', 'ANYTHING']],
116			[true, ['ROLE_IRONMAN'], 'foo.bar', 'BAZ'],
117			[true, ['ROLE_IRONMAN'], 'foo.bar', 'ANYTHING'],
118			[true, ['ROLE_IRONMAN'], 'foo.bar.baz.xyz', 'ANYTHING'],
119			[true, ['ROLE_IRONMAN'], 'foo.bar', ''],
120			[true, ['ROLE_IRONMAN'], 'foo.bar', ['']],
121
122			//operations
123			[true, ['ROLE_SPIDERMAN'], 'foo.bar', 'ABC'],
124			[true, ['ROLE_SPIDERMAN'], 'foo.bar', ['ABC']],
125			[true, ['ROLE_SPIDERMAN'], 'foo.bar', ['ABC', 'DEF']],
126			[true, ['ROLE_SPIDERMAN'], 'foo.bar', ['BAZ', 'ABC']],
127			[false, ['ROLE_SPIDERMAN'], 'foo.bar', 'DEF'],
128			[false, ['ROLE_SPIDERMAN'], 'foo.bar', ['DEF']],
129			[false, ['ROLE_SPIDERMAN'], 'foo.bar', 'BAZ'],
130			[false, ['ROLE_SPIDERMAN'], 'foo.bar', ['BAZ']],
131			[true, [], 'foo.bar', 'ABC'],
132			[true, [], 'foo.bar', ['ABC']],
133			[false, [], 'foo.bar', 'DEF'],
134			[false, [], 'foo.bar', ['DEF']],
135			[false, [], 'foo.bar', 'BAZ'],
136			[false, [], 'foo.bar', ['BAZ']],
137			[false, [], 'foo.bar.baz.xyz', 'ABC'],
138			[false, [], 'foo.bar.baz.xyz', ['ABC']],
139			[false, [], 'foo.bar.baz.xyz', ['ABC', 'DEF']],
140			[false, [], 'foo.bar.baz.xyz', 'DEF'],
141			[false, [], 'foo.bar.baz.xyz', ['DEF']],
142			[false, [], 'foo.bar.baz.xyz', 'BAZ'],
143			[false, [], 'foo.bar.baz.xyz', ['BAZ']],
144
145			//objects
146			[true, ['ROLE_SPIDERMAN'], 'foo.bar', ['DEF'], new \stdClass()],
147			[true, ['ROLE_SPIDERMAN'], 'foo.bar', ['ABC'], new \stdClass()],
148			[true, ['ROLE_SPIDERMAN'], 'foo.bar', ['ABC', 'DEF'], new \stdClass()],
149			[true, ['ROLE_SPIDERMAN'], 'foo.bar', ['BAZ', 'DEF'], new \stdClass()],
150			[true, ['ROLE_SPIDERMAN'], 'foo.bar', 'DEF', new \stdClass()],
151			[true, ['ROLE_SPIDERMAN'], 'foo.bar', 'ABC', new \stdClass()],
152			[false, ['ROLE_SPIDERMAN'], 'foo.bar', 'BAZ', new \stdClass()],
153			[false, ['ROLE_SPIDERMAN'], 'foo.bar.baz.xyz', 'DEF', new \stdClass()],
154			[false, ['ROLE_SPIDERMAN'], 'foo.bar.baz.xyz', 'ABC', new \stdClass()],
155			[true, [], 'foo.bar', ['ABC'], new \stdClass()],
156			[true, [], 'foo.bar', 'ABC', new \stdClass()],
157			[true, [], 'foo.bar', ['DEF'], new \stdClass()],
158			[true, [], 'foo.bar', 'DEF', new \stdClass()],
159			[false, [], 'foo.bar', ['BAZ'], new \stdClass()],
160			[false, [], 'foo.bar', 'BAZ', new \stdClass()],
161			[false, [], 'foo.bar.baz.xyz', 'BAZ', new \stdClass()],
162			[false, [], 'foo.bar.baz.xyz', ['BAZ'], new \stdClass()],
163			[false, ['ROLE_AUTH_EXCEPTION'], 'foo.bar.baz.xyz', ['BAZ'], new \stdClass()],
164
165			// ALL role
166			[true, [], 'foo.bar.baz', 'LIST'],
167			[true, [], 'foo.bar.baz', ['LIST', 'EDIT']],
168			];
169			}
170
171			public function testIsGrantedWithException(): void
172			{
173			$this->expectException(\RuntimeException::class);
174			$this->expectExceptionMessage('Something is wrong');
175
176			$this->admin
			0 ignored issues – show Bug introduced 2019-12-07 19:25 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `method()` does not seem to exist on `object<Sonata\AdminBundle\Admin\AdminInterface>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
177			->method('getCode')
178			->willReturn('foo.bar');
179
180			$this->authorizationChecker
			0 ignored issues – show Bug introduced 2019-12-07 19:25 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `method()` does not seem to exist on `object<Symfony\Component...zationCheckerInterface>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
181			->method('isGranted')
182			->willReturnCallback(static function (): void {
183			throw new \RuntimeException('Something is wrong');
184			});
185
186			$handler = $this->getRoleSecurityHandler(['ROLE_BATMAN']);
187			$handler->isGranted($this->admin, 'BAZ');
188			}
189
190			/**
191			* @doesNotPerformAssertions
192			*/
193			public function testCreateObjectSecurity(): void
194			{
195			$handler = $this->getRoleSecurityHandler(['ROLE_FOO']);
196			$handler->createObjectSecurity($this->getSonataAdminObject(), new \stdClass());
197			}
198
199			/**
200			* @doesNotPerformAssertions
201			*/
202			public function testDeleteObjectSecurity(): void
203			{
204			$handler = $this->getRoleSecurityHandler(['ROLE_FOO']);
205			$handler->deleteObjectSecurity($this->getSonataAdminObject(), new \stdClass());
206			}
207
208			public function testBuildSecurityInformation(): void
209			{
210			$handler = $this->getRoleSecurityHandler(['ROLE_FOO']);
211			$this->assertSame([], $handler->buildSecurityInformation($this->getSonataAdminObject()));
212			}
213
214			private function getRoleSecurityHandler(array $superAdminRoles): RoleSecurityHandler
215			{
216			return new RoleSecurityHandler($this->authorizationChecker, $superAdminRoles);
217			}
218
219			private function getSonataAdminObject(): AdminInterface
220			{
221			return $this->getMockForAbstractClass(AdminInterface::class);
222			}
223			}
224

sonata-project / SonataAdminBundle

Issues (655)

Security Analysis not enabled

tests/Security/Handler/RoleSecurityHandlerTest.php (5 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like