Completed
Pull Request — 3.x (#6244)
by Grégoire
02:55
created
src/Security/Handler/SecurityHandlerInterface.php 1 patch
Doc Comments   +3 added lines, -1 removed lines patch added patch discarded remove patch
@@ -21,7 +21,7 @@  discard block
 block discarded – undo
21 21
 interface SecurityHandlerInterface
22 22
 {
23 23
     /**
24
-     * @param string|array $attributes
24
+     * @param string $attributes
25 25
      * @param mixed|null   $object
26 26
      *
27 27
      * @return bool
@@ -44,6 +44,7 @@  discard block
 block discarded – undo
44 44
      * Create object security, fe. make the current user owner of the object.
45 45
      *
46 46
      * @param object $object
47
+     * @return void
47 48
      */
48 49
     public function createObjectSecurity(AdminInterface $admin, $object);
49 50
 
@@ -51,6 +52,7 @@  discard block
 block discarded – undo
51 52
      * Remove object security.
52 53
      *
53 54
      * @param object $object
55
+     * @return void
54 56
      */
55 57
     public function deleteObjectSecurity(AdminInterface $admin, $object);
56 58
 }
Please login to merge, or discard this patch.
tests/Datagrid/PagerTest.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -647,6 +647,9 @@
 block discarded – undo
647 647
         $this->assertNull($this->pager->getQuery());
648 648
     }
649 649
 
650
+    /**
651
+     * @param Pager $obj
652
+     */
650 653
     protected function callMethod($obj, string $name, array $args = [])
651 654
     {
652 655
         $class = new \ReflectionClass($obj);
Please login to merge, or discard this patch.
src/Command/QuestionableCommand.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -24,7 +24,7 @@
 block discarded – undo
24 24
 {
25 25
     /**
26 26
      * @param string   $questionText
27
-     * @param mixed    $default
27
+     * @param string    $default
28 28
      * @param callable $validator
29 29
      *
30 30
      * @return mixed
Please login to merge, or discard this patch.
src/Filter/FilterInterface.php 1 patch
Doc Comments   +7 added lines, -2 removed lines patch added patch discarded remove patch
@@ -62,6 +62,7 @@  discard block
 block discarded – undo
62 62
 
63 63
     /**
64 64
      * @param string $label
65
+     * @return void
65 66
      */
66 67
     public function setLabel($label);
67 68
 
@@ -72,7 +73,7 @@  discard block
 block discarded – undo
72 73
 
73 74
     /**
74 75
      * @param string     $name
75
-     * @param mixed|null $default
76
+     * @param boolean $default
76 77
      *
77 78
      * @return mixed
78 79
      */
@@ -80,12 +81,14 @@  discard block
 block discarded – undo
80 81
 
81 82
     /**
82 83
      * @param string $name
83
-     * @param mixed  $value
84
+     * @param boolean  $value
85
+     * @return void
84 86
      */
85 87
     public function setOption($name, $value);
86 88
 
87 89
     /**
88 90
      * @param string $name
91
+     * @return void
89 92
      */
90 93
     public function initialize($name, array $options = []);
91 94
 
@@ -129,6 +132,7 @@  discard block
 block discarded – undo
129 132
      *
130 133
      * @param string $name
131 134
      * @param mixed  $value
135
+     * @return void
132 136
      */
133 137
     public function setFieldOption($name, $value);
134 138
 
@@ -155,6 +159,7 @@  discard block
 block discarded – undo
155 159
      * Set the condition to use with the left side of the query : OR or AND.
156 160
      *
157 161
      * @param string $condition
162
+     * @return void
158 163
      */
159 164
     public function setCondition($condition);
160 165
 
Please login to merge, or discard this patch.
src/Twig/GlobalVariables.php 1 patch
Doc Comments   +4 added lines, -3 removed lines patch added patch discarded remove patch
@@ -44,6 +44,7 @@  discard block
 block discarded – undo
44 44
 
45 45
     /**
46 46
      * @param ContainerInterface|Pool $adminPool
47
+     * @param string $mosaicBackground
47 48
      */
48 49
     public function __construct($adminPool, ?string $mosaicBackground = null)
49 50
     {
@@ -80,7 +81,7 @@  discard block
 block discarded – undo
80 81
     /**
81 82
      * @param string $code
82 83
      * @param string $action
83
-     * @param array  $parameters
84
+     * @param string[]  $parameters
84 85
      * @param int    $referenceType
85 86
      *
86 87
      * @return string
@@ -95,8 +96,8 @@  discard block
 block discarded – undo
95 96
     /**
96 97
      * @param string $code
97 98
      * @param string $action
98
-     * @param object $object
99
-     * @param array  $parameters
99
+     * @param string $object
100
+     * @param string[]  $parameters
100 101
      * @param int    $referenceType
101 102
      *
102 103
      * @return string
Please login to merge, or discard this patch.
src/Admin/AbstractAdmin.php 1 patch
Doc Comments   +3 added lines, -1 removed lines patch added patch discarded remove patch
@@ -1040,6 +1040,7 @@  discard block
 block discarded – undo
1040 1040
 
1041 1041
     /**
1042 1042
      * NEXT_MAJOR: remove this method.
1043
+     * @param string $subClass
1043 1044
      */
1044 1045
     public function addSubClass($subClass)
1045 1046
     {
@@ -2378,7 +2379,7 @@  discard block
 block discarded – undo
2378 2379
      *
2379 2380
      * @param string $context
2380 2381
      *
2381
-     * @return array
2382
+     * @return string[]
2382 2383
      */
2383 2384
     public function getPermissionsShow($context)
2384 2385
     {
@@ -2949,6 +2950,7 @@  discard block
 block discarded – undo
2949 2950
      * NEXT_MAJOR: remove this method.
2950 2951
      *
2951 2952
      * @deprecated Use configureTabMenu instead
2953
+     * @param string $action
2952 2954
      */
2953 2955
     protected function configureSideMenu(ItemInterface $menu, $action, ?AdminInterface $childAdmin = null)
2954 2956
     {
Please login to merge, or discard this patch.
src/Admin/Pool.php 1 patch
Doc Comments   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -87,6 +87,7 @@  discard block
 block discarded – undo
87 87
      * @param string $title
88 88
      * @param string $logoTitle
89 89
      * @param array  $options
90
+     * @param PropertyAccessorInterface $propertyAccessor
90 91
      */
91 92
     public function __construct(
92 93
         ContainerInterface $container,
@@ -386,7 +387,7 @@  discard block
 block discarded – undo
386 387
     }
387 388
 
388 389
     /**
389
-     * @return array
390
+     * @return string[]
390 391
      */
391 392
     public function getAdminServiceIds()
392 393
     {
Please login to merge, or discard this patch.
src/Controller/CRUDController.php 1 patch
Doc Comments   +9 added lines, -5 removed lines patch added patch discarded remove patch
@@ -66,6 +66,9 @@  discard block
 block discarded – undo
66 66
      */
67 67
     private $templateRegistry;
68 68
 
69
+    /**
70
+     * @param ContainerInterface $container
71
+     */
69 72
     public function setContainer(?ContainerInterface $container = null)
70 73
     {
71 74
         $this->container = $container;
@@ -195,7 +198,7 @@  discard block
 block discarded – undo
195 198
     /**
196 199
      * Delete action.
197 200
      *
198
-     * @param int|string|null $id
201
+     * @param integer|null $id
199 202
      *
200 203
      * @throws NotFoundHttpException If the object does not exist
201 204
      * @throws AccessDeniedException If access is not granted
@@ -791,7 +794,7 @@  discard block
 block discarded – undo
791 794
     /**
792 795
      * View history revision of object.
793 796
      *
794
-     * @param int|string|null $id
797
+     * @param null|integer $id
795 798
      * @param string|null     $revision
796 799
      *
797 800
      * @throws AccessDeniedException If access is not granted
@@ -854,9 +857,9 @@  discard block
 block discarded – undo
854 857
     /**
855 858
      * Compare history revisions of object.
856 859
      *
857
-     * @param int|string|null $id
858
-     * @param int|string|null $base_revision
859
-     * @param int|string|null $compare_revision
860
+     * @param null|integer $id
861
+     * @param null|integer $base_revision
862
+     * @param null|integer $compare_revision
860 863
      *
861 864
      * @throws AccessDeniedException If access is not granted
862 865
      * @throws NotFoundHttpException If the object or revision does not exist or the audit reader is not available
@@ -1580,6 +1583,7 @@  discard block
 block discarded – undo
1580 1583
 
1581 1584
     /**
1582 1585
      * Sets the admin form theme to form view. Used for compatibility between Symfony versions.
1586
+     * @param string[] $theme
1583 1587
      */
1584 1588
     private function setFormTheme(FormView $formView, ?array $theme = null): void
1585 1589
     {
Please login to merge, or discard this patch.
src/Form/ChoiceList/ModelChoiceLoader.php 1 patch
Doc Comments   +1 added lines patch added patch discarded remove patch
@@ -65,6 +65,7 @@
 block discarded – undo
65 65
      * @param string|null $property
66 66
      * @param mixed|null  $query
67 67
      * @param array       $choices
68
+     * @param PropertyAccessorInterface $propertyAccessor
68 69
      */
69 70
     public function __construct(
70 71
         ModelManagerInterface $modelManager,
Please login to merge, or discard this patch.