Completed
Pull Request — master (#6005)
by Javier
03:47
created
src/Security/Handler/SecurityHandlerInterface.php 1 patch
Doc Comments   +3 added lines, -1 removed lines patch added patch discarded remove patch
@@ -21,7 +21,7 @@  discard block
 block discarded – undo
21 21
 interface SecurityHandlerInterface
22 22
 {
23 23
     /**
24
-     * @param string|array $attributes
24
+     * @param string $attributes
25 25
      * @param mixed|null   $object
26 26
      *
27 27
      * @return bool
@@ -44,6 +44,7 @@  discard block
 block discarded – undo
44 44
      * Create object security, fe. make the current user owner of the object.
45 45
      *
46 46
      * @param object $object
47
+     * @return void
47 48
      */
48 49
     public function createObjectSecurity(AdminInterface $admin, $object);
49 50
 
@@ -51,6 +52,7 @@  discard block
 block discarded – undo
51 52
      * Remove object security.
52 53
      *
53 54
      * @param object $object
55
+     * @return void
54 56
      */
55 57
     public function deleteObjectSecurity(AdminInterface $admin, $object);
56 58
 }
Please login to merge, or discard this patch.
tests/Datagrid/PagerTest.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -647,6 +647,9 @@
 block discarded – undo
647 647
         $this->assertNull($this->pager->getQuery());
648 648
     }
649 649
 
650
+    /**
651
+     * @param Pager $obj
652
+     */
650 653
     protected function callMethod($obj, string $name, array $args = [])
651 654
     {
652 655
         $class = new \ReflectionClass($obj);
Please login to merge, or discard this patch.
src/Command/QuestionableCommand.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -24,7 +24,7 @@
 block discarded – undo
24 24
 {
25 25
     /**
26 26
      * @param string   $questionText
27
-     * @param mixed    $default
27
+     * @param string    $default
28 28
      * @param callable $validator
29 29
      *
30 30
      * @return mixed
Please login to merge, or discard this patch.
tests/Form/Widget/FormSonataFilterChoiceWidgetTest.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -56,6 +56,9 @@
 block discarded – undo
56 56
         );
57 57
     }
58 58
 
59
+    /**
60
+     * @return string
61
+     */
59 62
     protected function getChoiceClass()
60 63
     {
61 64
         return ChoiceType::class;
Please login to merge, or discard this patch.
src/Twig/Extension/SonataAdminExtension.php 1 patch
Doc Comments   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -182,7 +182,7 @@  discard block
 block discarded – undo
182 182
     /**
183 183
      * render a view element.
184 184
      *
185
-     * @param object $object
185
+     * @param \stdClass $object
186 186
      *
187 187
      * @return string
188 188
      */
@@ -319,7 +319,7 @@  discard block
 block discarded – undo
319 319
     /**
320 320
      * Get the identifiers as a string that is safe to use in a url.
321 321
      *
322
-     * @param object $model
322
+     * @param \stdClass $model
323 323
      *
324 324
      * @return string string representation of the id that is safe to use in a url
325 325
      */
@@ -341,7 +341,7 @@  discard block
 block discarded – undo
341 341
     }
342 342
 
343 343
     /**
344
-     * @return string|bool
344
+     * @return string|false
345 345
      */
346 346
     public function getXEditableType($type)
347 347
     {
Please login to merge, or discard this patch.
src/Controller/CRUDController.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -743,8 +743,8 @@
 block discarded – undo
743 743
     /**
744 744
      * Compare history revisions of object.
745 745
      *
746
-     * @param int|string|null $baseRevision
747
-     * @param int|string|null $compareRevision
746
+     * @param null|integer $baseRevision
747
+     * @param null|integer $compareRevision
748 748
      *
749 749
      * @throws AccessDeniedException If access is not granted
750 750
      * @throws NotFoundHttpException If the object or revision does not exist or the audit reader is not available
Please login to merge, or discard this patch.
src/Model/ModelManagerInterface.php 1 patch
Doc Comments   +11 added lines, -2 removed lines patch added patch discarded remove patch
@@ -37,6 +37,7 @@  discard block
 block discarded – undo
37 37
      * @param object $object
38 38
      *
39 39
      * @throws ModelManagerException
40
+     * @return void
40 41
      */
41 42
     public function create($object);
42 43
 
@@ -44,6 +45,7 @@  discard block
 block discarded – undo
44 45
      * @param object $object
45 46
      *
46 47
      * @throws ModelManagerException
48
+     * @return void
47 49
      */
48 50
     public function update($object);
49 51
 
@@ -51,6 +53,7 @@  discard block
 block discarded – undo
51 53
      * @param object $object
52 54
      *
53 55
      * @throws ModelManagerException
56
+     * @return void
54 57
      */
55 58
     public function delete($object);
56 59
 
@@ -72,7 +75,7 @@  discard block
 block discarded – undo
72 75
      * @param string $class
73 76
      * @param mixed  $id
74 77
      *
75
-     * @return object|null the object with id or null if not found
78
+     * @return \Sonata\AdminBundle\Tests\App\Model\Foo|null the object with id or null if not found
76 79
      */
77 80
     public function find($class, $id);
78 81
 
@@ -80,6 +83,7 @@  discard block
 block discarded – undo
80 83
      * @param string $class
81 84
      *
82 85
      * @throws ModelManagerException
86
+     * @return void
83 87
      */
84 88
     public function batchDelete($class, ProxyQueryInterface $queryProxy);
85 89
 
@@ -156,7 +160,7 @@  discard block
 block discarded – undo
156 160
      *
157 161
      * @param string $class
158 162
      *
159
-     * @return object
163
+     * @return \Sonata\AdminBundle\Tests\App\Model\Foo
160 164
      */
161 165
     public function getModelInstance($class);
162 166
 
@@ -172,6 +176,7 @@  discard block
 block discarded – undo
172 176
      *
173 177
      * @param array  $collection
174 178
      * @param object $element
179
+     * @return void
175 180
      */
176 181
     public function collectionRemoveElement(&$collection, &$element);
177 182
 
@@ -180,6 +185,7 @@  discard block
 block discarded – undo
180 185
      *
181 186
      * @param array  $collection
182 187
      * @param object $element
188
+     * @return void
183 189
      */
184 190
     public function collectionAddElement(&$collection, &$element);
185 191
 
@@ -197,6 +203,7 @@  discard block
 block discarded – undo
197 203
      * Clear the collection.
198 204
      *
199 205
      * @param array $collection
206
+     * @return void
200 207
      */
201 208
     public function collectionClear(&$collection);
202 209
 
@@ -229,6 +236,7 @@  discard block
 block discarded – undo
229 236
 
230 237
     /**
231 238
      * @param mixed $query
239
+     * @return void
232 240
      */
233 241
     public function executeQuery($query);
234 242
 
@@ -261,6 +269,7 @@  discard block
 block discarded – undo
261 269
 
262 270
     /**
263 271
      * @param string $class
272
+     * @return void
264 273
      */
265 274
     public function addIdentifiersToQuery($class, ProxyQueryInterface $query, array $idx);
266 275
 }
Please login to merge, or discard this patch.
src/Filter/FilterInterface.php 1 patch
Doc Comments   +7 added lines, -2 removed lines patch added patch discarded remove patch
@@ -62,6 +62,7 @@  discard block
 block discarded – undo
62 62
 
63 63
     /**
64 64
      * @param string $label
65
+     * @return void
65 66
      */
66 67
     public function setLabel($label);
67 68
 
@@ -72,7 +73,7 @@  discard block
 block discarded – undo
72 73
 
73 74
     /**
74 75
      * @param string     $name
75
-     * @param mixed|null $default
76
+     * @param boolean $default
76 77
      *
77 78
      * @return mixed
78 79
      */
@@ -80,12 +81,14 @@  discard block
 block discarded – undo
80 81
 
81 82
     /**
82 83
      * @param string $name
83
-     * @param mixed  $value
84
+     * @param boolean  $value
85
+     * @return void
84 86
      */
85 87
     public function setOption($name, $value);
86 88
 
87 89
     /**
88 90
      * @param string $name
91
+     * @return void
89 92
      */
90 93
     public function initialize($name, array $options = []);
91 94
 
@@ -129,6 +132,7 @@  discard block
 block discarded – undo
129 132
      *
130 133
      * @param string $name
131 134
      * @param mixed  $value
135
+     * @return void
132 136
      */
133 137
     public function setFieldOption($name, $value);
134 138
 
@@ -155,6 +159,7 @@  discard block
 block discarded – undo
155 159
      * Set the condition to use with the left side of the query : OR or AND.
156 160
      *
157 161
      * @param string $condition
162
+     * @return void
158 163
      */
159 164
     public function setCondition($condition);
160 165
 
Please login to merge, or discard this patch.
src/Admin/AdminInterface.php 1 patch
Doc Comments   +117 added lines, -1 removed lines patch added patch discarded remove patch
@@ -37,26 +37,59 @@  discard block
 block discarded – undo
37 37
  */
38 38
 interface AdminInterface extends AccessRegistryInterface, FieldDescriptionRegistryInterface, LifecycleHookProviderInterface, MenuBuilderInterface, ParentAdminInterface, UrlGeneratorInterface
39 39
 {
40
+    /**
41
+     * @return void
42
+     */
40 43
     public function setMenuFactory(MenuFactoryInterface $menuFactory): void;
41 44
 
45
+    /**
46
+     * @return MenuFactoryInterface
47
+     */
42 48
     public function getMenuFactory(): ?MenuFactoryInterface;
43 49
 
50
+    /**
51
+     * @return void
52
+     */
44 53
     public function setFormContractor(FormContractorInterface $formContractor): void;
45 54
 
55
+    /**
56
+     * @return void
57
+     */
46 58
     public function setListBuilder(ListBuilderInterface $listBuilder): void;
47 59
 
60
+    /**
61
+     * @return ListBuilderInterface
62
+     */
48 63
     public function getListBuilder(): ?ListBuilderInterface;
49 64
 
65
+    /**
66
+     * @return void
67
+     */
50 68
     public function setDatagridBuilder(DatagridBuilderInterface $datagridBuilder): void;
51 69
 
70
+    /**
71
+     * @return DatagridBuilderInterface
72
+     */
52 73
     public function getDatagridBuilder(): ?DatagridBuilderInterface;
53 74
 
75
+    /**
76
+     * @return void
77
+     */
54 78
     public function setTranslator(TranslatorInterface $translator): void;
55 79
 
80
+    /**
81
+     * @return TranslatorInterface
82
+     */
56 83
     public function getTranslator(): ?TranslatorInterface;
57 84
 
85
+    /**
86
+     * @return void
87
+     */
58 88
     public function setRequest(Request $request): void;
59 89
 
90
+    /**
91
+     * @return void
92
+     */
60 93
     public function setConfigurationPool(Pool $pool): void;
61 94
 
62 95
     /**
@@ -67,14 +100,21 @@  discard block
 block discarded – undo
67 100
      */
68 101
     public function getClass(): string;
69 102
 
103
+    /**
104
+     * @return void
105
+     */
70 106
     public function attachAdminClass(FieldDescriptionInterface $fieldDescription): void;
71 107
 
108
+    /**
109
+     * @return DatagridInterface|null
110
+     */
72 111
     public function getDatagrid(): ?DatagridInterface;
73 112
 
74 113
     /**
75 114
      * Set base controller name.
76 115
      *
77 116
      * @param string $baseControllerName
117
+     * @return void
78 118
      */
79 119
     public function setBaseControllerName($baseControllerName): void;
80 120
 
@@ -85,6 +125,7 @@  discard block
 block discarded – undo
85 125
 
86 126
     /**
87 127
      * Sets a list of templates.
128
+     * @return void
88 129
      */
89 130
     public function setTemplates(array $templates): void;
90 131
 
@@ -93,9 +134,13 @@  discard block
 block discarded – undo
93 134
      *
94 135
      * @param string $name
95 136
      * @param string $template
137
+     * @return void
96 138
      */
97 139
     public function setTemplate($name, $template): void;
98 140
 
141
+    /**
142
+     * @return ModelManagerInterface
143
+     */
99 144
     public function getModelManager(): ?ModelManagerInterface;
100 145
 
101 146
     /**
@@ -115,6 +160,7 @@  discard block
 block discarded – undo
115 160
 
116 161
     /**
117 162
      * Returns a form depend on the given $object.
163
+     * @return \Symfony\Component\Form\Form|null
118 164
      */
119 165
     public function getForm(): ?FormInterface;
120 166
 
@@ -145,6 +191,9 @@  discard block
 block discarded – undo
145 191
      */
146 192
     public function getSecurityInformation(): array;
147 193
 
194
+    /**
195
+     * @return void
196
+     */
148 197
     public function setParentFieldDescription(FieldDescriptionInterface $parentFieldDescription): void;
149 198
 
150 199
     /**
@@ -188,8 +237,14 @@  discard block
 block discarded – undo
188 237
      */
189 238
     public function hasRoute($name): bool;
190 239
 
240
+    /**
241
+     * @return void
242
+     */
191 243
     public function setSecurityHandler(SecurityHandlerInterface $securityHandler): void;
192 244
 
245
+    /**
246
+     * @return SecurityHandlerInterface
247
+     */
193 248
     public function getSecurityHandler(): ?SecurityHandlerInterface;
194 249
 
195 250
     /**
@@ -210,16 +265,28 @@  discard block
 block discarded – undo
210 265
      *
211 266
      * @param object $entity
212 267
      *
213
-     * @return mixed
268
+     * @return string
214 269
      */
215 270
     public function id($entity);
216 271
 
272
+    /**
273
+     * @return void
274
+     */
217 275
     public function setValidator(ValidatorInterface $validator): void;
218 276
 
277
+    /**
278
+     * @return ValidatorInterface
279
+     */
219 280
     public function getValidator(): ?ValidatorInterface;
220 281
 
282
+    /**
283
+     * @return FieldDescriptionCollection|null
284
+     */
221 285
     public function getShow(): ?FieldDescriptionCollection;
222 286
 
287
+    /**
288
+     * @return void
289
+     */
223 290
     public function setFormTheme(array $formTheme): void;
224 291
 
225 292
     /**
@@ -227,6 +294,9 @@  discard block
 block discarded – undo
227 294
      */
228 295
     public function getFormTheme(): array;
229 296
 
297
+    /**
298
+     * @return void
299
+     */
230 300
     public function setFilterTheme(array $filterTheme): void;
231 301
 
232 302
     /**
@@ -234,6 +304,9 @@  discard block
 block discarded – undo
234 304
      */
235 305
     public function getFilterTheme(): array;
236 306
 
307
+    /**
308
+     * @return void
309
+     */
237 310
     public function addExtension(AdminExtensionInterface $extension): void;
238 311
 
239 312
     /**
@@ -243,8 +316,14 @@  discard block
 block discarded – undo
243 316
      */
244 317
     public function getExtensions(): array;
245 318
 
319
+    /**
320
+     * @return void
321
+     */
246 322
     public function setRouteBuilder(RouteBuilderInterface $routeBuilder): void;
247 323
 
324
+    /**
325
+     * @return RouteBuilderInterface
326
+     */
248 327
     public function getRouteBuilder(): ?RouteBuilderInterface;
249 328
 
250 329
     /**
@@ -252,8 +331,14 @@  discard block
 block discarded – undo
252 331
      */
253 332
     public function toString($object): string;
254 333
 
334
+    /**
335
+     * @return void
336
+     */
255 337
     public function setLabelTranslatorStrategy(LabelTranslatorStrategyInterface $labelTranslatorStrategy): void;
256 338
 
339
+    /**
340
+     * @return LabelTranslatorStrategyInterface
341
+     */
257 342
     public function getLabelTranslatorStrategy(): ?LabelTranslatorStrategyInterface;
258 343
 
259 344
     /**
@@ -270,6 +355,7 @@  discard block
 block discarded – undo
270 355
 
271 356
     /**
272 357
      * @param string $uniqId
358
+     * @return void
273 359
      */
274 360
     public function setUniqid($uniqId): void;
275 361
 
@@ -292,6 +378,7 @@  discard block
 block discarded – undo
292 378
 
293 379
     /**
294 380
      * @param object|null $subject
381
+     * @return void
295 382
      */
296 383
     public function setSubject($subject): void;
297 384
 
@@ -338,6 +425,7 @@  discard block
 block discarded – undo
338 425
      *
339 426
      * @param string $actionName
340 427
      * @param bool   $allElements
428
+     * @return void
341 429
      */
342 430
     public function preBatchAction($actionName, ProxyQueryInterface $query, array &$idx, $allElements): void;
343 431
 
@@ -360,6 +448,7 @@  discard block
 block discarded – undo
360 448
      *
361 449
      * @deprecated this feature cannot be stable, use a custom validator,
362 450
      *             the feature will be removed with Symfony 2.2
451
+     * @return void
363 452
      */
364 453
     public function validate(ErrorElement $errorElement, $object): void;
365 454
 
@@ -372,11 +461,18 @@  discard block
 block discarded – undo
372 461
      * Add object security, fe. make the current user owner of the object.
373 462
      *
374 463
      * @param object $object
464
+     * @return void
375 465
      */
376 466
     public function createObjectSecurity($object): void;
377 467
 
468
+    /**
469
+     * @return AdminInterface|null
470
+     */
378 471
     public function getParent(): ?self;
379 472
 
473
+    /**
474
+     * @return void
475
+     */
380 476
     public function setParent(self $admin): void;
381 477
 
382 478
     /**
@@ -388,6 +484,7 @@  discard block
 block discarded – undo
388 484
      * Set the translation domain.
389 485
      *
390 486
      * @param string $translationDomain the translation domain
487
+     * @return void
391 488
      */
392 489
     public function setTranslationDomain($translationDomain): void;
393 490
 
@@ -407,21 +504,29 @@  discard block
 block discarded – undo
407 504
 
408 505
     /**
409 506
      * Set the form groups.
507
+     * @return void
410 508
      */
411 509
     public function setFormGroups(array $formGroups): void;
412 510
 
413 511
     public function getFormTabs();
414 512
 
513
+    /**
514
+     * @return void
515
+     */
415 516
     public function setFormTabs(array $formTabs): void;
416 517
 
417 518
     public function getShowTabs();
418 519
 
520
+    /**
521
+     * @return void
522
+     */
419 523
     public function setShowTabs(array $showTabs): void;
420 524
 
421 525
     /**
422 526
      * Remove a form group field.
423 527
      *
424 528
      * @param string $key
529
+     * @return void
425 530
      */
426 531
     public function removeFieldFromFormGroup($key): void;
427 532
 
@@ -434,6 +539,7 @@  discard block
 block discarded – undo
434 539
 
435 540
     /**
436 541
      * Set the show groups.
542
+     * @return void
437 543
      */
438 544
     public function setShowGroups(array $showGroups): void;
439 545
 
@@ -441,6 +547,7 @@  discard block
 block discarded – undo
441 547
      * Reorder items in showGroup.
442 548
      *
443 549
      * @param string $group
550
+     * @return void
444 551
      */
445 552
     public function reorderShowGroup($group, array $keys): void;
446 553
 
@@ -448,6 +555,7 @@  discard block
 block discarded – undo
448 555
      * add a FieldDescription.
449 556
      *
450 557
      * @param string $name
558
+     * @return void
451 559
      */
452 560
     public function addFormFieldDescription($name, FieldDescriptionInterface $fieldDescription): void;
453 561
 
@@ -455,6 +563,7 @@  discard block
 block discarded – undo
455 563
      * Remove a FieldDescription.
456 564
      *
457 565
      * @param string $name
566
+     * @return void
458 567
      */
459 568
     public function removeFormFieldDescription($name): void;
460 569
 
@@ -472,11 +581,13 @@  discard block
 block discarded – undo
472 581
      * Adds a new class to a list of supported sub classes.
473 582
      *
474 583
      * @param $subClass
584
+     * @return void
475 585
      */
476 586
     public function addSubClass($subClass): void;
477 587
 
478 588
     /**
479 589
      * Sets the list of supported sub classes.
590
+     * @return void
480 591
      */
481 592
     public function setSubClasses(array $subClasses): void;
482 593
 
@@ -515,6 +626,7 @@  discard block
 block discarded – undo
515 626
 
516 627
     /**
517 628
      * Returns Admin`s label.
629
+     * @return string
518 630
      */
519 631
     public function getLabel(): ?string;
520 632
 
@@ -529,6 +641,7 @@  discard block
 block discarded – undo
529 641
 
530 642
     /**
531 643
      * Set the current child status.
644
+     * @return void
532 645
      */
533 646
     public function setCurrentChild(bool $currentChild): void;
534 647
 
@@ -558,6 +671,7 @@  discard block
 block discarded – undo
558 671
 
559 672
     /**
560 673
      * @param string $mode
674
+     * @return void
561 675
      */
562 676
     public function setListMode($mode): void;
563 677
 
@@ -587,12 +701,14 @@  discard block
 block discarded – undo
587 701
      * Returns the result link for an object.
588 702
      *
589 703
      * @param object $object
704
+     * @return string|null
590 705
      */
591 706
     public function getSearchResultLink($object): ?string;
592 707
 
593 708
     /**
594 709
      * Setting to true will enable mosaic button for the admin screen.
595 710
      * Setting to false will hide mosaic button for the admin screen.
711
+     * @return void
596 712
      */
597 713
     public function showMosaicButton(bool $isShown): void;
598 714
 
Please login to merge, or discard this patch.