Completed
Pull Request — 3.x (#6069)
by Vincent
04:46 queued 01:50
created
src/Form/ChoiceList/ModelChoiceLoader.php 1 patch
Doc Comments   +1 added lines patch added patch discarded remove patch
@@ -65,6 +65,7 @@
 block discarded – undo
65 65
      * @param string|null $property
66 66
      * @param mixed|null  $query
67 67
      * @param array       $choices
68
+     * @param PropertyAccessorInterface $propertyAccessor
68 69
      */
69 70
     public function __construct(
70 71
         ModelManagerInterface $modelManager,
Please login to merge, or discard this patch.
src/Security/Handler/AclSecurityHandler.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -184,6 +184,9 @@
 block discarded – undo
184 184
         return $acls;
185 185
     }
186 186
 
187
+    /**
188
+     * @param UserSecurityIdentity $securityIdentity
189
+     */
187 190
     public function addObjectOwner(AclInterface $acl, ?UserSecurityIdentity $securityIdentity = null)
188 191
     {
189 192
         if (false === $this->findClassAceIndexByUsername($acl, $securityIdentity->getUsername())) {
Please login to merge, or discard this patch.
src/Twig/Extension/SonataAdminExtension.php 1 patch
Doc Comments   +5 added lines, -4 removed lines patch added patch discarded remove patch
@@ -184,7 +184,7 @@  discard block
 block discarded – undo
184 184
     /**
185 185
      * render a list element from the FieldDescription.
186 186
      *
187
-     * @param object $object
187
+     * @param \stdClass $object
188 188
      * @param array  $params
189 189
      *
190 190
      * @return string
@@ -265,7 +265,7 @@  discard block
 block discarded – undo
265 265
     /**
266 266
      * render a view element.
267 267
      *
268
-     * @param object $object
268
+     * @param \stdClass $object
269 269
      *
270 270
      * @return string
271 271
      */
@@ -402,7 +402,8 @@  discard block
 block discarded – undo
402 402
     /**
403 403
      * Get the identifiers as a string that is safe to use in a url.
404 404
      *
405
-     * @param object $model
405
+     * @param \stdClass $model
406
+     * @param AdminInterface $admin
406 407
      *
407 408
      * @return string string representation of the id that is safe to use in a url
408 409
      */
@@ -424,7 +425,7 @@  discard block
 block discarded – undo
424 425
     }
425 426
 
426 427
     /**
427
-     * @return string|bool
428
+     * @return string|false
428 429
      */
429 430
     public function getXEditableType($type)
430 431
     {
Please login to merge, or discard this patch.
src/Util/AdminObjectAclData.php 1 patch
Doc Comments   +1 added lines patch added patch discarded remove patch
@@ -80,6 +80,7 @@
 block discarded – undo
80 80
     /**
81 81
      * @param object $object
82 82
      * @param string $maskBuilderClass
83
+     * @param \Traversable $aclRoles
83 84
      */
84 85
     public function __construct(
85 86
         AdminInterface $admin,
Please login to merge, or discard this patch.
src/Menu/Matcher/Voter/AdminVoter.php 1 patch
Doc Comments   +4 added lines patch added patch discarded remove patch
@@ -38,6 +38,9 @@  discard block
 block discarded – undo
38 38
      */
39 39
     private $request;
40 40
 
41
+    /**
42
+     * @param RequestStack $requestStack
43
+     */
41 44
     public function __construct(?RequestStack $requestStack = null)
42 45
     {
43 46
         $this->requestStack = $requestStack;
@@ -46,6 +49,7 @@  discard block
 block discarded – undo
46 49
     /**
47 50
      * @deprecated since sonata-project/admin-bundle 3.31. Pass a RequestStack to the constructor instead.
48 51
      *
52
+     * @param Request $request
49 53
      * @return $this
50 54
      */
51 55
     public function setRequest($request)
Please login to merge, or discard this patch.
src/Action/RetrieveAutocompleteItemsAction.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -17,7 +17,6 @@
 block discarded – undo
17 17
 use Sonata\AdminBundle\Admin\FieldDescriptionInterface;
18 18
 use Sonata\AdminBundle\Admin\Pool;
19 19
 use Sonata\AdminBundle\Filter\FilterInterface;
20
-use Symfony\Component\Form\Form;
21 20
 use Symfony\Component\HttpFoundation\JsonResponse;
22 21
 use Symfony\Component\HttpFoundation\Request;
23 22
 use Symfony\Component\HttpFoundation\Response;
Please login to merge, or discard this patch.
src/Security/Handler/SecurityHandlerInterface.php 1 patch
Doc Comments   +2 added lines patch added patch discarded remove patch
@@ -44,6 +44,7 @@  discard block
 block discarded – undo
44 44
      * Create object security, fe. make the current user owner of the object.
45 45
      *
46 46
      * @param object $object
47
+     * @return void
47 48
      */
48 49
     public function createObjectSecurity(AdminInterface $admin, $object);
49 50
 
@@ -51,6 +52,7 @@  discard block
 block discarded – undo
51 52
      * Remove object security.
52 53
      *
53 54
      * @param object $object
55
+     * @return void
54 56
      */
55 57
     public function deleteObjectSecurity(AdminInterface $admin, $object);
56 58
 }
Please login to merge, or discard this patch.