AdminSearchBlockService::__construct() - Code Metrics - Inspection of "Add Support for BlockBundle 4" - sonata-project/SonataAdminBundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — 3.x (#6212)

by Jordi Sala

created 2020-07-20 16:49 UTC

AdminSearchBlockService::__construct() B

↳ Parent: AdminSearchBlockService

Complexity

Conditions	5
Paths	5

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	43
rs	8.9208
c	0
b	0
f	0
cc	5
nc	5
nop	4

<?php

declare(strict_types=1);

/*
 * This file is part of the Sonata Project package.
 *
 * (c) Thomas Rabaix <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Sonata\AdminBundle\Block;

use Sonata\AdminBundle\Admin\AdminInterface;
use Sonata\AdminBundle\Admin\Pool;
use Sonata\AdminBundle\Search\SearchHandler;
use Sonata\BlockBundle\Block\BlockContextInterface;
use Sonata\BlockBundle\Block\Service\AbstractBlockService;
use Symfony\Bundle\FrameworkBundle\Templating\EngineInterface;
use Symfony\Component\DependencyInjection\Exception\ServiceNotFoundException;
use Symfony\Component\HttpFoundation\Response;
use Symfony\Component\OptionsResolver\OptionsResolver;
use Twig\Environment;

/**
 * @final since sonata-project/admin-bundle 3.52
 *
 * @author Thomas Rabaix <[email protected]>
 */
class AdminSearchBlockService extends AbstractBlockService
{
    /**
     * @var Pool
     */
    protected $pool;

    /**
     * @var SearchHandler
     */
    protected $searchHandler;

    /**
     * NEXT_MAJOR: Remove `$templating` argument.
     *
     * @param Environment|string $twigOrName
     */
    public function __construct($twigOrName, ?EngineInterface $templating, Pool $pool, SearchHandler $searchHandler)
    {
        // NEXT_MAJOR: Remove conditions, only pass the Environment
        if ($templating instanceof EngineInterface) {
            @trigger_error(sprintf(
// For example instead of
@mkdir($dir);

// Better use
if (@mkdir($dir) === false) {
    throw new \RuntimeException('The directory '.$dir.' could not be created.');
}
                'Passing %s as argument 2 to %s() is deprecated since sonata-project/doctrine-orm-admin-bundle 3.x'
                . ' and will throw a \TypeError in version 4.0. You must pass null instead.',
                EngineInterface::class,
                __METHOD__
            ), E_USER_DEPRECATED);

            if (!\is_string($twigOrName)) {
                throw new \TypeError(sprintf(

                    'Passing other than string as argument 1 to %s() is not allowed when %s is passed as argument 2.'
                    . ' You must pass an string instead.',
                    __METHOD__,
                    EngineInterface::class
                ));
            }

            parent::__construct($twigOrName, $templating);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        } elseif ($twigOrName instanceof Environment) {
            if (!\is_null($templating)) {
                throw new \TypeError(sprintf(

                    'Argument 2 passed to %s() must be null if you passing %s as first argument, %s given.',
                    __METHOD__,
                    Environment::class,
                    EngineInterface::class
                ));
            }

            parent::__construct($twigOrName);
        } else {
            throw new \TypeError(sprintf(

                'Argument 1 passed to %s() should be an instance of %s, and you should leave argument 2 as null.',
                __METHOD__,
                Environment::class
            ));
        }

        $this->pool = $pool;
        $this->searchHandler = $searchHandler;
    }

    public function execute(BlockContextInterface $blockContext, ?Response $response = null): Response
    {
        try {
            $admin = $this->pool->getAdminByAdminCode($blockContext->getSetting('admin_code'));
        } catch (ServiceNotFoundException $e) {
            throw new \RuntimeException('Unable to find the Admin instance', $e->getCode(), $e);
        }

        if (!$admin instanceof AdminInterface) {
            throw new \RuntimeException('The requested service is not an Admin instance');
        }

        $admin->checkAccess('list');

        $pager = $this->searchHandler->search(
            $admin,
            $blockContext->getSetting('query'),
            $blockContext->getSetting('page'),
            $blockContext->getSetting('per_page')
        );

        if (false === $pager) {
            $response = $response ?: new Response();

            return $response->setContent('')->setStatusCode(204);
        }

        return $this->renderPrivateResponse($admin->getTemplate('search_result_block'), [

            'block' => $blockContext->getBlock(),
            'settings' => $blockContext->getSettings(),
            'admin_pool' => $this->pool,
            'pager' => $pager,
            'admin' => $admin,
        ], $response);
    }

    public function getName()
    {
        return 'Admin Search Result';
    }

    public function configureSettings(OptionsResolver $resolver): void
    {
        $resolver
            ->setDefaults([
                'admin_code' => '',
                'query' => '',
                'page' => 0,
                'per_page' => 10,
                'icon' => '<i class="fa fa-list"></i>',
            ])
            ->setRequired('admin_code')
            ->setAllowedTypes('admin_code', ['string']);
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			/*
6			* This file is part of the Sonata Project package.
7			*
8			* (c) Thomas Rabaix <[email protected]>
9			*
10			* For the full copyright and license information, please view the LICENSE
11			* file that was distributed with this source code.
12			*/
13
14			namespace Sonata\AdminBundle\Block;
15
16			use Sonata\AdminBundle\Admin\AdminInterface;
17			use Sonata\AdminBundle\Admin\Pool;
18			use Sonata\AdminBundle\Search\SearchHandler;
19			use Sonata\BlockBundle\Block\BlockContextInterface;
20			use Sonata\BlockBundle\Block\Service\AbstractBlockService;
21			use Symfony\Bundle\FrameworkBundle\Templating\EngineInterface;
22			use Symfony\Component\DependencyInjection\Exception\ServiceNotFoundException;
23			use Symfony\Component\HttpFoundation\Response;
24			use Symfony\Component\OptionsResolver\OptionsResolver;
25			use Twig\Environment;
26
27			/**
28			* @final since sonata-project/admin-bundle 3.52
29			*
30			* @author Thomas Rabaix <[email protected]>
31			*/
32			class AdminSearchBlockService extends AbstractBlockService
33			{
34			/**
35			* @var Pool
36			*/
37			protected $pool;
38
39			/**
40			* @var SearchHandler
41			*/
42			protected $searchHandler;
43
44			/**
45			* NEXT_MAJOR: Remove `$templating` argument.
46			*
47			* @param Environment\|string $twigOrName
48			*/
49			public function __construct($twigOrName, ?EngineInterface $templating, Pool $pool, SearchHandler $searchHandler)
50			{
51			// NEXT_MAJOR: Remove conditions, only pass the Environment
52			if ($templating instanceof EngineInterface) {
53			@trigger_error(sprintf(
			0 ignored issues – show Security Best Practice introduced 2020-07-20 16:45 UTC by Report Bug Copy Issue Report It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended. If you suppress an error, we recommend checking for the error condition explicitly: // For example instead of @mkdir($dir); // Better use if (@mkdir($dir) === false) { throw new \RuntimeException('The directory '.$dir.' could not be created.'); } Loading history...
54			'Passing %s as argument 2 to %s() is deprecated since sonata-project/doctrine-orm-admin-bundle 3.x'
55			. ' and will throw a \TypeError in version 4.0. You must pass null instead.',
56			EngineInterface::class,
57			__METHOD__
58			), E_USER_DEPRECATED);
59
60			if (!\is_string($twigOrName)) {
61			throw new \TypeError(sprintf(
			0 ignored issues – show Unused Code introduced 2020-07-20 16:45 UTC by Report Bug Copy Issue Report The call to `TypeError::__construct()` has too many arguments starting with `sprintf('Passing other t...EngineInterface::class)`. This check compares calls to functions or methods with their respective definitions. If the call has more arguments than are defined, it raises an issue. If a function is defined several times with a different number of parameters, the check may pick up the wrong definition and report false positives. One codebase where this has been known to happen is Wordpress. In this case you can add the `@ignore` PhpDoc annotation to the duplicate definition and it will be ignored. Loading history...
62			'Passing other than string as argument 1 to %s() is not allowed when %s is passed as argument 2.'
63			. ' You must pass an string instead.',
64			__METHOD__,
65			EngineInterface::class
66			));
67			}
68
69			parent::__construct($twigOrName, $templating);
			0 ignored issues – show Documentation introduced 2020-07-20 09:25 UTC by Report Bug Copy Issue Report `$twigOrName` is of type `string`, but the function expects a `object<Twig\Environment>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history... Unused Code introduced 2020-07-19 16:33 UTC by Report Bug Copy Issue Report The call to `AbstractBlockService::__construct()` has too many arguments starting with `$templating`. This check compares calls to functions or methods with their respective definitions. If the call has more arguments than are defined, it raises an issue. If a function is defined several times with a different number of parameters, the check may pick up the wrong definition and report false positives. One codebase where this has been known to happen is Wordpress. In this case you can add the `@ignore` PhpDoc annotation to the duplicate definition and it will be ignored. Loading history...
70			} elseif ($twigOrName instanceof Environment) {
71			if (!\is_null($templating)) {
72			throw new \TypeError(sprintf(
			0 ignored issues – show Unused Code introduced 2020-07-20 16:45 UTC by Report Bug Copy Issue Report The call to `TypeError::__construct()` has too many arguments starting with `sprintf('Argument 2 pass...EngineInterface::class)`. This check compares calls to functions or methods with their respective definitions. If the call has more arguments than are defined, it raises an issue. If a function is defined several times with a different number of parameters, the check may pick up the wrong definition and report false positives. One codebase where this has been known to happen is Wordpress. In this case you can add the `@ignore` PhpDoc annotation to the duplicate definition and it will be ignored. Loading history...
73			'Argument 2 passed to %s() must be null if you passing %s as first argument, %s given.',
74			__METHOD__,
75			Environment::class,
76			EngineInterface::class
77			));
78			}
79
80			parent::__construct($twigOrName);
81			} else {
82			throw new \TypeError(sprintf(
			0 ignored issues – show Unused Code introduced 2020-07-20 16:45 UTC by Report Bug Copy Issue Report The call to `TypeError::__construct()` has too many arguments starting with `sprintf('Argument 1 pass...wig\Environment::class)`. This check compares calls to functions or methods with their respective definitions. If the call has more arguments than are defined, it raises an issue. If a function is defined several times with a different number of parameters, the check may pick up the wrong definition and report false positives. One codebase where this has been known to happen is Wordpress. In this case you can add the `@ignore` PhpDoc annotation to the duplicate definition and it will be ignored. Loading history...
83			'Argument 1 passed to %s() should be an instance of %s, and you should leave argument 2 as null.',
84			__METHOD__,
85			Environment::class
86			));
87			}
88
89			$this->pool = $pool;
90			$this->searchHandler = $searchHandler;
91			}
92
93			public function execute(BlockContextInterface $blockContext, ?Response $response = null): Response
94			{
95			try {
96			$admin = $this->pool->getAdminByAdminCode($blockContext->getSetting('admin_code'));
97			} catch (ServiceNotFoundException $e) {
98			throw new \RuntimeException('Unable to find the Admin instance', $e->getCode(), $e);
99			}
100
101			if (!$admin instanceof AdminInterface) {
102			throw new \RuntimeException('The requested service is not an Admin instance');
103			}
104
105			$admin->checkAccess('list');
106
107			$pager = $this->searchHandler->search(
108			$admin,
109			$blockContext->getSetting('query'),
110			$blockContext->getSetting('page'),
111			$blockContext->getSetting('per_page')
112			);
113
114			if (false === $pager) {
115			$response = $response ?: new Response();
116
117			return $response->setContent('')->setStatusCode(204);
118			}
119
120			return $this->renderPrivateResponse($admin->getTemplate('search_result_block'), [
			0 ignored issues – show Deprecated Code introduced 2020-01-09 07:32 UTC by Report Bug Copy Issue Report The method `Sonata\AdminBundle\Admin...nterface::getTemplate()` has been deprecated with message: since sonata-project/admin-bundle 3.35. To be removed in 4.0. Use TemplateRegistry services instead This method has been deprecated. The supplier of the class has supplied an explanatory message. The explanatory message should give you some clue as to whether and when the method will be removed from the class and what other method or class to use instead. Loading history...
121			'block' => $blockContext->getBlock(),
122			'settings' => $blockContext->getSettings(),
123			'admin_pool' => $this->pool,
124			'pager' => $pager,
125			'admin' => $admin,
126			], $response);
127			}
128
129			public function getName()
130			{
131			return 'Admin Search Result';
132			}
133
134			public function configureSettings(OptionsResolver $resolver): void
135			{
136			$resolver
137			->setDefaults([
138			'admin_code' => '',
139			'query' => '',
140			'page' => 0,
141			'per_page' => 10,
142			'icon' => '<i class="fa fa-list"></i>',
143			])
144			->setRequired('admin_code')
145			->setAllowedTypes('admin_code', ['string']);
146			}
147			}
148

sonata-project / SonataAdminBundle

Pull Request — 3.x (#6212)

AdminSearchBlockService::__construct() B

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like